< tryphe_> kallewoof, i think the avoid_reuse wallet flag should have more obvious documentation somewhere (unless i'm missing something) as i've been recently chatting with people who want this feature but i've been forgetting to tell them about it until i recently realized your commit #13756 exists in the codebase. the question is, where to put it? maybe an extended description of the complete functionality of "setwalletflag" flags would do better,
< tryphe_> as there's only a very terse example of the usage, but no extended description anywhere in any "help" commands/arguments.
< gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
< tryphe_> i feel like "finding" this feature should be much more obvious/intuitive
< tryphe_> it looks like the description in the release notes would do the job (and tell the user they need to -rescan also), just not sure of the correct place for it
< tryphe_> also slightly related, when users look to enable features, they do ./bitcoind -help, ./bitcoin-cli -help, but not necessarily ./bitcoin-cli help, so they might not even stumble on setwalletflag. but not sure how to effectively get people to do this :(
< luke-jr> tryphe_: note the "avoid_reuse" flag does not in fact avoid reuse :x
< tryphe_> luke-jr, ah, how so?
< luke-jr> would have to review the code to explain accurately
< tryphe_> i've never really used the flag, fwiw, but the idea is nice
< tryphe_> luke-jr, it looks like it doesn't avoid reuse, but avoids spending outputs from keys that were already "spent from"?
< luke-jr> something along those lines
< tryphe_> not sure if that's what you meant
< luke-jr> IIRC the main thing is that if multiple such outputs exist, it tries to spend them all at once
< tryphe_> ahh okay, yeah the functionality is not really explicit to the definition
< luke-jr> although that may be default behaviour now too\
< tryphe_> ahh yeah i saw that as well also, in another PR
< tryphe_> -avoidpartialspends is always enabled when avoid_reuse is enabled
< tryphe_> i think it would also be useful to note that in some documentation as well (avoidpartialspends documentation links to avoid_reuse but there's not really any documenation of avoid_reuse to explain that it enables avoidpartialspends)
< tryphe_> so you wouldn't know about it unless | grepping some help output
< tryphe_> also, i guess the implication of a "dusting" attack here is that you would only avoid the dusting attack completely if the address was already marked dirty before the dusting happens
< luke-jr> eh?
< tryphe_> luke-jr, you might sweep up the dust the first time an address is marked dirty, but never after that, right?
< luke-jr> tryphe_: what's the problem?
< luke-jr> sweeping up the dust is the right thing to do there
< tryphe_> ah nm, you're right
< tryphe_> confusing myself :p
< fanquake> sipa: probably time to block tnawanna
< fanquake> grubles: there’s no particularly easy way
< sipa> fanquake: just did
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/652c45fdbbd5...967be53aeec9
< bitcoin-git> bitcoin/master a5f5374 Sjors Provoost: test: create default wallet in extended tests
< bitcoin-git> bitcoin/master 967be53 fanquake: Merge #19971: test: create default wallet in extended tests
< bitcoin-git> [bitcoin] fanquake merged pull request #19971: test: create default wallet in extended tests (master...2020/09/fix_no_default_wallet_extended_tests) https://github.com/bitcoin/bitcoin/pull/19971
< kallewoof> tryphe_: i'm all for making it more known, but not sure where to do so. perhaps add an entry about it to the bitcoin wiki might be a good idea
< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/967be53aeec9...c30f79d418e2
< bitcoin-git> bitcoin/master 2233a93 codeShark149: [rpc] Return fee and vsize from testmempoolaccept
< bitcoin-git> bitcoin/master 23c35bf gzhao408: [test] add get_vsize util for more programmatic testing
< bitcoin-git> bitcoin/master c30f79d fanquake: Merge #19940: rpc: Return fee and vsize from testmempoolaccept
< bitcoin-git> [bitcoin] fanquake merged pull request #19940: rpc: Return fee and vsize from testmempoolaccept (master...rpc-testmempoolaccept-fee) https://github.com/bitcoin/bitcoin/pull/19940
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/c30f79d418e2...83b23848f730
< bitcoin-git> bitcoin/master 27dcc37 Hennadii Stepanov: qt: Name RPCConsole executor QThread
< bitcoin-git> bitcoin/master 2c7f5d8 Hennadii Stepanov: qt: Name WalletController worker QThread
< bitcoin-git> bitcoin/master ad5f614 Hennadii Stepanov: qt: Name ClientModel timer QThread
< bitcoin-git> [bitcoin] fanquake merged pull request #18790: gui: Improve thread naming (master...200427-name-qthread) https://github.com/bitcoin/bitcoin/pull/18790
< jonasschnelli> ryanofsky: cap’n proto connects over TCP, right? Should be easy to tunnel with WireGuard or so?
< bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/83b23848f730...831b0ecea915
< bitcoin-git> bitcoin/master e15b1cf Daniel Kraft: Various cleanups in zmqnotificationinterface.
< bitcoin-git> bitcoin/master b93b9d5 Daniel Kraft: Simplify and fix notifier removal on error.
< bitcoin-git> bitcoin/master 7f2ad1b Daniel Kraft: Use std::unique_ptr for CZMQNotifierFactory.
< bitcoin-git> [bitcoin] fanquake merged pull request #13686: ZMQ: Small cleanups in the ZMQ code (master...zmq-cleanup) https://github.com/bitcoin/bitcoin/pull/13686
< bitcoin-git> [bitcoin] hebasto opened pull request #19979: Use proper TSA attributes (attempt two) (master...200919-tsa) https://github.com/bitcoin/bitcoin/pull/19979
< fanquake> Is this the first time we've ever had 4 different PRs open, all for the same change
< hebasto> one PR per a developer :)
< fanquake> My current understanding is that 19979, 19918, 19970 & 19865 are all alternatives to each other
< hebasto> fanquake: almost
< wumpus> we've had "competing PRs" before but dunno if it was at this scale
< wumpus> thinking of the various wayt to do writable settings here, for example
< wumpus> it's not bad to have competing approaches and have a discussion about what is the best one, but it does make me wonder what makes this particular thing so interesting/important to work on :)
< wumpus> and "why does everyone want it differently"
< wumpus> fanquake: yes that's a great overview
< wumpus> I don't have a strong opinion on this besides, please don't add "WeakAssert"
< hebasto> wumpus: the recent 19979 removes the need to choose the name at all
< yanmaani> what's the process of suggesting a change to the protocol?
< yanmaani> Do I just describe it informally on the mailing list and ask something like "Would you consider a BIP to this effect to be potentially suitable for inclusion in the Bitcoin protocol?"
< yanmaani> Or do I write up a BIP directly?
< bitcoin-git> [bitcoin] fanquake closed pull request #15115: GUI: Replace send-to-self with dual send+receive entries (master...rm_send2self) https://github.com/bitcoin/bitcoin/pull/15115
< bitcoin-git> [bitcoin] fanquake closed pull request #17463: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...gui_custom_sendyes) https://github.com/bitcoin/bitcoin/pull/17463
< ryanofsky> jonasschnelli: it just reads and writes bytes to anything. the current PRs open a unix socket not a TCP socket, but is easy to change
< ryanofsky> ssh and socat commands are also happy to forward traffic between tcp sockets and unix sockets (maybe netcat too, not sure)
< jnewbery> Perhaps ryanofsky, aj and hebasto could get together and figure out which is the best way? They seem to care about this more than other people and I think other reviewers are probably going to be disinclined to weigh in or review 4 different PRs.
< bitcoin-git> [bitcoin] prayank23 closed pull request #19945: Remove connect_nodes global and Replace connect_nodes(self.nodes[a], b) with self.connect_nodes(a, b) (master...master) https://github.com/bitcoin/bitcoin/pull/19945
< bitcoin-git> [bitcoin] promag opened pull request #19980: 2020 09 wallet cleanups (master...2020-09-wallet-cleanups) https://github.com/bitcoin/bitcoin/pull/19980