< bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/be3af4f31089...652c45fdbbd5
< bitcoin-git> bitcoin/master 1bee1e6 Andrew Chow: Do not create default wallet
< bitcoin-git> bitcoin/master d26f064 Andrew Chow: Tell users how to load or create a wallet when no wallet is loaded
< bitcoin-git> bitcoin/master 652c45f Samuel Dobson: Merge #15454: Remove the automatic creation and loading of the default wal...
< bitcoin-git> [bitcoin] meshcollider merged pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454
< yanmaani> aj: A bit of overengineering, but couldn't you have acceptable "spacing positions" for each arg
< yanmaani> so you specify something like ("sig" SEP "net" SEP "challenge"), and all 4 combinations are valid
< yanmaani> signetchallenge, signet-challenge, sig-net-challenge, sig-netchallenge
< aj> yanmaani: code could specify "signet-challenge" and bitcoind could allow you to drop the "-"s i guess
< yanmaani> that might be the smart way, yeah. Take "sig-net-challenge", clean both strings of hyphens, check map membership, then ensure hyphenation is valid
< kallewoof> I switched to squeezecase and pushed change, FWIW. (Re-)review would be glorious. https://github.com/bitcoin/bitcoin/pull/18267
< bitcoin-git> [bitcoin] ajtowns opened pull request #19970: sync.h: fix LockAssertion error reporting (master...202009-lockassertion) https://github.com/bitcoin/bitcoin/pull/19970
< vasild> "Method not found (wallet method is disabled because no wallet is loaded)"
< vasild> this seems to have propagated into #19970 (and I guess any other PR which is based on master after the #15454 merge)
< gribble> https://github.com/bitcoin/bitcoin/issues/19970 | sync.h: fix LockAssertion error reporting by ajtowns · Pull Request #19970 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/15454 | Remove the automatic creation and loading of the default wallet by achow101 · Pull Request #15454 · bitcoin/bitcoin · GitHub
< vasild> achow101: ^
< jonasschnelli> for the GUI, does it make sense to estimate the fees before IBD is finished?
< jonasschnelli> I would say no but interested to hear other opinions
< sipa> jonasschnelli: no, it can't give any useful estimates
< jonasschnelli> sipa: Agree. Currently, we call estimateSmartFee on each block during IBD. Leading to unlimited freezes.
< jonasschnelli> (in the GUI only)
< jonasschnelli> sipa: the only concern I saw is that OLDEST_ESTIMATE_HISTORY is 6 * 1008 where IBD is latched to false once we have tip-144 reached
< sipa> jonasschnelli: the whole thing is pointless
< sipa> it watches how long transactions were in the mempool before confirming
< sipa> while in IBD you have no functional mempool
< jonasschnelli> Agree. I just hope there is no edge case I break when disabling fee calculation during IBD
< wumpus> re: endomorphism "technology advances one expired patent at a time"
< wumpus> I'm going to enable it from now on in all my nodes
< fanquake> 🚀
< aj> might want to revert #15454, it's breaking travis (though only on the c++17 job for some reason?)
< gribble> https://github.com/bitcoin/bitcoin/issues/15454 | Remove the automatic creation and loading of the default wallet by achow101 · Pull Request #15454 · bitcoin/bitcoin · GitHub
< provoostenator> aj: feature_pruning.py breaks with "(wallet method is disabled because no wallet is loaded"
< aj> provoostenator: yeah, it was doing so in the travis run in that PR too
< provoostenator> And I saw it in a followup PR too, weird
< aj> what's weird? the tests now need a -wallet= argument or something, and don't have it, as far as i can see?
< provoostenator> It's weird that it only fails on that machine
< provoostenator> I'll try to reproduce locally
< aj> seems to reproduce locally fine for me on that test case fwiw
< aj> trying to see if anything else breaks too
< provoostenator> If so, I should be able to push a fix, which I would prever over a rever.t
< provoostenator> But it's not the only machine that runs the functional test suite
< provoostenator> Oh it's part of EXTENDED_SCRIPTS
< aj> guess that'd do it
< aj> dbcrash fails too fwiw, though the c++17 test excludes it
< * provoostenator> making sure the tests pass before making a PR
< bitcoin-git> [bitcoin] Sjors opened pull request #19971: test: create default wallet in extended tests (master...2020/09/fix_no_default_wallet_extended_tests) https://github.com/bitcoin/bitcoin/pull/19971
< emzy> just have activated DNSSEC on dnsseed.emzy.de
< jonasschnelli> emzy: nice! I have never configured bind (always used djbdns),... do you mind share the configuration/steps-to-setup?
< emzy> jonasschnelli: maybe it also works woth djbdns. I use dynamic updates on bind with "nsupdate". But yes I will write it up next week. I like to have it running a few days first.
< jonasschnelli> emzy: sure. No hurry.
< jonatack> "with endomorphism = yes" is the new hotness
< wumpus> yess
< vasild> endowhat?
< vasild> :-D
< bitcoin-git> [bitcoin] practicalswift opened pull request #19972: tests: Add fuzzing harness for node eviction logic (master...fuzzers-eviction-logic) https://github.com/bitcoin/bitcoin/pull/19972
< wumpus> 'inner shapeism' i guess if you'd translate it literally
< wumpus> I'm not sure if the "Initializing chainstate Chainstate [ibd] @ height -1 (null)" log message is very useful
< wumpus> does it ever get logged with different arguments?
< grubles> is there a way to package bitcoind and -cli using the macdeploy script?
< grubles> instead of just -qt
< Lightsword> is setting regtest rpcport or rpcbind parameters via the command line broken?