< bitcoin-git>
[bitcoin] luke-jr closed pull request #18479: RPC: Show fee in results for signrawtransaction* for segwit inputs (master...rpc_sign_show_fees) https://github.com/bitcoin/bitcoin/pull/18479
< ZEFRON>
I hate to be annoying but does anyone know how, if at all possible, I can access node.chainman globally? like COM, singleton, whatever.
< _aj_>
ZEFRON: not really; where do you want to access it from?
< ZEFRON>
damn, inside of CheckProofOfWork()
< ZEFRON>
which is problematic because that function is called within a variety of places, all of which I would need to feed the node.chainmain via function parameters >.<
< ZEFRON>
like a little game of function parameter snake
< _aj_>
achow101: it seems much harder than i would have expected to go from a wallet that has a descriptor "wpkh([XXX/84'/1'/0']tpubYYY/0/*)" and add a "tr([XXX/86'/1'/0']tpubZZZ/0/*)" descriptor -- have to extract the private key and do lots of decoding and encoding even to work out what tpubZZZ is meant to be. wouldn't it make sense to just be able to say "add a descriptor for 'tr([XXX/86'/1'/0']/0/*)'
< _aj_>
and have bitcoind look up the master private key based on the fingerprint being shared with some other descriptor in the wallet, and work the rest out itself?
< achow101>
_aj_: the keys are stored separately for each descriptor, but we could have a function that just adds a newly generated descriptor of a certain type
< prayank>
Hi everyone 👋 I wanted to get some feedback on few things related to testing in Bitcoin Core. So, created this form with 5 simple questions. Will be helpful if you could answer them:
< sipa>
prayank: i don't understand the first question, or the goal overall
< prayank>
sipa: First question rephrased: Do you think we are missing something in tests or testing options for new reviewers that can improve things? Or you are satisfied with the way things are setup
< prayank>
Overall goal: Get feedback for my project which is related to testing bitcoin core in a different way from people who are involved in testing core regularly
< sipa>
yes, i see that, but i don't understand the goal
< sipa>
do you want to get tests written in powershell? that seems very hard to integrate
< sipa>
it also doesn't seem to have any advantages over writing them in python
< prayank>
1. Yes I want to write fee tests in Powershell scripts and I have already done this in past for other things so easy for me. Maybe something new and interesting comes out of it.
< prayank>
2. Yes not many advantages
< sipa>
of course, some people might already know powershell and not know python, but even then, the effort of needing to learn python for very simple sequence of commands, vs. needing to reimplement all of the testing framework seems like a very hard sell
< luke-jr>
isn't PowerShell a Windows-specific language? O.o
< luke-jr>
prayank: I agree the poll is very confusing. Even with the rephrasing, I don't know how to answer it
< prayank>
It works on Linux as well now but less commands supported
< sipa>
it does appear to be open-source, and supporting linux
< prayank>
Sorry for the confusion. I wanted to make it easier. Maybe missed adding some context.
< sipa>
still - i see no benefit
< luke-jr>
seems like it'd make more sense to do BASH if anything
< prayank>
Yeah bash will be cool but I am not good at it
< sipa>
you can learn :)
< luke-jr>
prayank: keep in mind if tests are written in PowerShell, everyone suddenly needs PS to run tests :/
< luke-jr>
it's not even available in Gentoo
< luke-jr>
looks like it's .NET too :/
< prayank>
luke-jr: Tests will run in the application which I am going to develop. It will work on Linux and Windows.
< prayank>
It's like if someone creates a desktop application that can be used to run all python tests with nice GUI and few more options
< sipa>
i think you're much better off spending your time on learning python and the existing test framework
< luke-jr>
prayank: without .NET or PowerShell?
< prayank>
luke-jr: A similar project can be made which works better and does not use .NET and PowerShell. I understand why you don't like them but I have to create one intern project with the skills I have right now. It will not affect anything either. If a group of users find it useful may use it else testing core continues the way we do it now.
< prayank>
I also had two other proposals for this internship but they are not related to Core directly
< prayank>
Finally decided to work on this and thought it will help in improving something
< luke-jr>
if someone can't write Python code in a day, I'm not sure they have the skills needed to write usable tests in the first place to be frank
< prayank>
Thanks for your feedback. Will share tests and application once it's complete.