ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
sipsorcery has joined #bitcoin-core-dev
da39a3ee5e6b4b0d has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
Evel-Knievel has quit [Ping timeout: 256 seconds]
Evel-Knievel has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
ghost43 has quit [Remote host closed the connection]
shesek__ has joined #bitcoin-core-dev
da39a3ee5e6b4b0d has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
ghost43 has joined #bitcoin-core-dev
Guest76 has joined #bitcoin-core-dev
shesek_ has quit [Ping timeout: 240 seconds]
Guest76 has quit [Client Quit]
shesek_ has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 252 seconds]
Evel-Knievel has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
shesek__ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 240 seconds]
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
shesek__ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 272 seconds]
shesek__ has quit [Remote host closed the connection]
shesek__ has joined #bitcoin-core-dev
shesek_ has joined #bitcoin-core-dev
Evel-Knievel has quit [Remote host closed the connection]
Evel-Knievel has joined #bitcoin-core-dev
shesek__ has quit [Ping timeout: 256 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 240 seconds]
Evel-Knievel has quit [Ping timeout: 256 seconds]
Evel-Knievel has joined #bitcoin-core-dev
synch has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
shesek_ is now known as shesek
ebaySatoshi has joined #bitcoin-core-dev
da39a3ee5e6b4b0d has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
<ebaySatoshi>
Where can I see the lines of code of Satoshi that were removed, possibly related to the implementation of a shopping feature in Bitcoin a bit like ebay shopping system?
zeropoint has quit [Ping timeout: 260 seconds]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
synch has quit [Quit: Client closed]
ghost43 has quit [Remote host closed the connection]
sudoforge has quit [Ping timeout: 240 seconds]
ghost43 has joined #bitcoin-core-dev
da39a3ee5e6b4b0_ has joined #bitcoin-core-dev
hashfunc569 has joined #bitcoin-core-dev
da39a3ee5e6b4b0d has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
Willtech has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
hashfunc569 has quit [Ping timeout: 240 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Willtech has quit [Quit: Willtech]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
da39a3ee5e6b4b0_ has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
TallTim has quit [Remote host closed the connection]
da39a3ee5e6b4b0d has joined #bitcoin-core-dev
TallTim has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
da39a3ee5e6b4b0d has quit [Ping timeout: 256 seconds]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
GoldmanSats has quit [Quit: Connection closed for inactivity]
Guest46 has joined #bitcoin-core-dev
Guest46 has quit [Client Quit]
mikehu44 has quit [Ping timeout: 272 seconds]
mikehu44 has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow opened pull request #24530: wallet: assert BnB's internally calculated waste is the same as GetSelectionWaste (master...2022-03-bnb-waste) https://github.com/bitcoin/bitcoin/pull/24530
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 252 seconds]
roconnor has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24453: Bugfix: doc: Correct change_address/changeAddress in wallet RPC help (master...fix_rpcdoc_changeaddr_STR) https://github.com/bitcoin/bitcoin/pull/24453
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #24533: test: use MiniWallet for feature_maxuploadtarget.py (master...202203-test-use_MiniWallet_for_feature_maxuploadtarget) https://github.com/bitcoin/bitcoin/pull/24533
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] prusnak opened pull request #24534: contrib: macdeploy: make gen-sdk deterministic (master...deterministic-macos-sdk) https://github.com/bitcoin/bitcoin/pull/24534
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
achow101 has quit [Quit: Bye]
achow101 has joined #bitcoin-core-dev
Willtech has quit [K-Lined]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24535: test: Fix generate calls and comments in feature_segwit (master...2203-test_fix_seg-🏌) https://github.com/bitcoin/bitcoin/pull/24535
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
sirdigby727 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master ec7d736 glozow: [wallet] assert BnB internally calculated waste is the same as GetSelectio...
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] achow101 merged pull request #24530: wallet: assert BnB's internally calculated waste is the same as GetSelectionWaste (master...2022-03-bnb-waste) https://github.com/bitcoin/bitcoin/pull/24530
sudoforge has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24537: rpc: Split mempool RPCs from blockchain.cpp (master...2203-mempoolRpc-🌛) https://github.com/bitcoin/bitcoin/pull/24537
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow opened pull request #24538: miner: bug fix? update for ancestor inclusion using modified fees, not base (master...2022-03-miner-prioritised) https://github.com/bitcoin/bitcoin/pull/24538
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
roconnor_ is now known as roconnor
Talkless has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
ifeanyi has joined #bitcoin-core-dev
sirdigby727 has quit [Quit: Connection closed for inactivity]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 250 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 256 seconds]
arythmetic has quit [Remote host closed the connection]
mudsip has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
<jeremyrubin>
basically, it's not really clear (at least *to me*) what is supposed to happen with the satisfaction of miniscript stuff w.r.t. HWWs
<jeremyrubin>
i.e., BIP-174 defines things that a signer must verify (like the parent txns of all outputs being spent AFAIU?)
<jeremyrubin>
but it's not really clear to me either if the signer is in HWW how that data is getting shuttled over to the singing 'enclave'
ghost43 has quit [Remote host closed the connection]
<jeremyrubin>
rust-miniscript has this thing called a Satisfier which is an API to "look up" a key out of the PSBT itself, which in theory could be used to "look up" a signature out of HWW (if it sent it all the right information?)
<achow101>
jeremyrubin: the psbt is supposed to contain all of the things the hww needs in order to sign
ghost43 has joined #bitcoin-core-dev
<sipa>
this seems more like rust-miniscript API question than a question about wallets (and even less about bitcoin core's wallet)
<jeremyrubin>
well in 174 it says "Before signing a non-witness input, the Signer must verify that the TXID of the non-witness UTXO matches the TXID specified in the unsigned transaction."
<sipa>
is that not clear?
<jeremyrubin>
but it's not really clear to me in the PSBT which data we've defined to allow that verification
brunoerg has joined #bitcoin-core-dev
<jeremyrubin>
how do we verify that? don't we need the entire parent TX to check that Outpoint(Txid(tx), i) == input.outpoint
<achow101>
jeremyrubin: that's provided in the psbt
<achow101>
as non_witness_utxo
<sipa>
the entire parent tx is "the non-witness UTXO", which is a field in the PSBT
<jeremyrubin>
ahh ok i see
<achow101>
anything else to discuss?
<michaelfolkson>
6 hour turnaround on #24530 from opening to merging? :)
<gribble>
https://github.com/bitcoin/bitcoin/issues/24530 | wallet: assert BnBs internally calculated waste is the same as GetSelectionWaste by glozow · Pull Request #24530 · bitcoin/bitcoin · GitHub
<michaelfolkson>
Very small change admittedly
<michaelfolkson>
But you seem like a quick merger achow101 :)
<jeremyrubin>
Well I guess the only other API oriented Q i have is that it seems like a lot of wallets don't support PSBT directly, and instead have some custom format and return signatures rather than updated PSBTs
<achow101>
jeremyrubin: that's partially because most hwws predate PSBT
<jeremyrubin>
fair
ghost43 has quit [Remote host closed the connection]
<jeremyrubin>
but e.g. jade seems to be this way
<achow101>
some are starting to add psbt though, e.g. ledger
<jeremyrubin>
yep
ghost43 has joined #bitcoin-core-dev
<jeremyrubin>
I guess the general question is API wise are we expecting PSBT supporting wallets to return a vector of signatures/witness data, or to directly modify and send back the PSBT
<sipa>
the bitcoin core signing logic also works like that
<jeremyrubin>
"that" =?
<achow101>
jeremyrubin: if they take a PSBT, then return a psbt with sigs
<achow101>
if they don't take a psbt, then whatever
<jeremyrubin>
gotcha.
<achow101>
for example, walletprocesspsbt takes a psbt, and returns a psbt with sigs
<jeremyrubin>
yes
<sipa>
I mean... I expect PSBTs to work with PSBTs, and they'll quite possibly be written with code that internally uses a satisfier-like interface to construct signatures and whatnot.
<sipa>
So my answer would be both, depending on what layer of the software you're looking at.
<achow101>
I guess ledger is an exception because they can take a psbt but return sigs
<achow101>
but that's a limitation of the hardware (not enough memory to store psbts)
<jeremyrubin>
well currently the satisfier iface is doing something where we look at the psbt and finalize miniscripts
<jeremyrubin>
v.s. look at psbt and create signatures
<achow101>
I don't know anything about rust-miniscript and related
<jeremyrubin>
i'm curious if it makes sense for signers to understand miniscript inherently
<sipa>
that = Bitcoin Core's PSBT RPC is internally implemented with calls to logic that "signs"
<sipa>
i mean... again API layer
<sipa>
a PSBT signer can sign whatever it understands/likes
<jeremyrubin>
well i guess my wondering is that if they don't have miniscript logic, then they can't know if a key they have is requested
<sipa>
if that includes miniscript, it can sign PSBTs that involve miniscript
<sipa>
@jeremyrubin That's not true, actually - you can sign without understanding
<jeremyrubin>
sure, it's valid to say anything can be in a different layer, i'm just trying to figure out really where the responsibility for these things should be. I could see a format where miniscript is not expected to be understood, but we'd need a "key extractor" that tells the signer which keys are in which input
<jeremyrubin>
and that would be "trusted"
<sipa>
You can infer from PSBT fields (if it contains the necessary values added by an Updater), with which keys a signature is expected with
<jeremyrubin>
PSBT_IN_TAP_BIP32_DERIVATION ?
<jeremyrubin>
it's not clear that those are hints v.s. required
<jeremyrubin>
e.g., if a key is within a gaplimit or something for the hww, i wouldn't need the derivation hint
<sipa>
you don't need to trust it - if you agree with the transaction (whatever that means for you), you can sign with it - at worst, your signature is just invalid if it happens a signature with that key doesn't participate in that script
<sipa>
sure?
<sipa>
psbt is just a container format that conveys all information a signer potentially needs
<jeremyrubin>
but that requires parsing miniscript to figure that out
<sipa>
they may not need/use all of it, if they don't care about it
<jeremyrubin>
"just a container" --> also a spec for roles to process it
<sipa>
for the updater, yes
<sipa>
for the signer, no
<jeremyrubin>
s/the/a/g
<sipa>
*updater
<sipa>
one of the participants in the process must be an updated that understands the thing being signed, and a finalizer that does
<sipa>
which means they can be relatively dumb
<sipa>
but the signer can just use the information provided by the updater
* jeremyrubin
(how apoas would work with this) OP_TOALTSTACK
<sipa>
i mean... it all depends on what you want to sign
<sipa>
signers can be restricted to only participating in scripts they understand/care about
<jeremyrubin>
yes
<jeremyrubin>
and if we want that, they would need to pull in miniscript?
<sipa>
there isn't a spec for "all psbt compliant software must support X" - it's just a spec for communicating how the things they need for that