bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #24600: doc: mention that BDB is for the legacy wallet in build-freebsd.md (master...freebsd_legacy_descriptor_switch) https://github.com/bitcoin/bitcoin/pull/24600
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sipsorcery has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master faadc60 MarcoFalke: refactor: Pass const reference instead of pointer to GetBlockScriptFlags
<bitcoin-git>
bitcoin/master fa42299 MarcoFalke: Remove nullptr check in GetBlockScriptFlags
<bitcoin-git>
bitcoin/master cccc1e7 MarcoFalke: Enforce Taproot script flags whenever WITNESS is set
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj merged pull request #23536: Enforce Taproot script flags whenever WITNESS is set (master...2111-taprootGenesis) https://github.com/bitcoin/bitcoin/pull/23536
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rex4539 has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 260 seconds]
rex4539 has quit [Ping timeout: 240 seconds]
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 272 seconds]
lukedashjr is now known as luke-jr
<luke-jr>
always nice to rebase just to have to rebase a day later >_<
<cfields_>
luke-jr: if you don't already have it enabled, git rerere is really helpful with that.
<cfields_>
maybe not so much for a 1day rebase though, those are probably fresh conflicts.
<MarcoFalke>
I think the issue is that both pulls were open for years with ~zero review. If they were reviewed and merged/closed within a month, there'd be no rebases necessary for either of them.
<luke-jr>
cfields_: not in this case
<luke-jr>
MarcoFalke: why was #19385 merged with 1 no-code-review ACK?
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] luke-jr closed pull request #16228: Bugfix: make check: Only run tests that were compiled (& print correct log on failure) (master...bugfix_raii_check_fail) https://github.com/bitcoin/bitcoin/pull/16228
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
<luke-jr>
oh well, too tired to re-fix that bug for now x.x
<MarcoFalke>
Yeah, I mean it is a bit ugly to fix it with C++ workaround code, but I think everyone prefers reviewing C++ over bash, so it seems fine
<luke-jr>
right, I mean the bug introduced in #19385 still needs fixing now
<bitcoin-git>
[bitcoin] fanquake opened pull request #24673: refactor: followup of remove -deprecatedrpc=addresses flag (master...22924_rebased) https://github.com/bitcoin/bitcoin/pull/24673
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mjdietzx closed pull request #22924: refactor: cleanup/followup of Remove -deprecatedrpc=addresses flag (master...refactor_ScriptToUniv) https://github.com/bitcoin/bitcoin/pull/22924
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master 575bbd0 John Newbery: [net processing] Move tx relay data to Peer
<bitcoin-git>
bitcoin/master 785f55f John Newbery: [net processing] Move m_wtxid_relay to Peer
<bitcoin-git>
bitcoin/master 0000ff0 MarcoFalke: test: move-only: Move all generate* tests to a single file
<bitcoin-git>
bitcoin/master 9745e18 MarcoFalke: Merge bitcoin/bitcoin#24670: test: move-only: Move all generate* tests to ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #24670: test: move-only: Move all generate* tests to a single file (master...2203-test-gen-🏻) https://github.com/bitcoin/bitcoin/pull/24670
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
knorrium[m] has quit [Quit: You have been kicked for being idle]
sipsorcery has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #24494: wallet: generate random change target for each tx for better privacy (master...2022-03-minchange) https://github.com/bitcoin/bitcoin/pull/24494
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] dongcarl opened pull request #24676: [WIP] [kernelheaders 1/n] Cleave LevelDB headers from our header tree (master...2022-03-kernelheaders-dbwrapper) https://github.com/bitcoin/bitcoin/pull/24676
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #24677: refactor: fix wallet and related named args (master...fix_wallet_and_co_named_args) https://github.com/bitcoin/bitcoin/pull/24677
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]