bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Cory has joined #bitcoin-core-dev
<michaelfolkson>
Anyone else find some of the feature_ functional tests flaky? feature_block.py, feature_dbcrash.py, feature_pruning.py, feature_utxo_set_hash.py failed for me locally. I ran them again individually and they passed.
<michaelfolkson>
On MacOS, I think they're being run on MacOS on the CI
jouke has joined #bitcoin-core-dev
geyaeb has quit [Remote host closed the connection]
geyaeb has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
keymeta has quit [Read error: Connection reset by peer]
geyaeb has quit [Remote host closed the connection]
geyaeb has joined #bitcoin-core-dev
jp__ has quit [Ping timeout: 256 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
roconnor has joined #bitcoin-core-dev
<_aj_>
michaelfolkson: i haven't found those tests unreliable locally; i'm not on macos though
mikehu44 has quit [Quit: No Ping reply in 180 seconds.]
mikehu44 has joined #bitcoin-core-dev
jp__ has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
jp__ has quit [Quit: Leaving]
AaronvanW has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
atharv_ has quit [Quit: Leaving]
AaronvanW has quit [Ping timeout: 256 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] josibake opened pull request #24584: [RFC] wallet: avoid mixing different `OutputTypes` during coin selection (master...josibake-coin-selection-v2) https://github.com/bitcoin/bitcoin/pull/24584
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<laanwj>
kalle: added
<michaelfolkson>
jp_: Not related to Core and not maintained anymore so wouldn't recommend using it https://pypi.org/project/bitcoin/
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<laanwj>
michaelfolkson: the functional tests require a fairly fast and unburdened system to run as-is; things to try would be: reduce parallelism, and/or increase the timeout scale (both are test runner arguments but i don't remember by heart)
sudoforge has joined #bitcoin-core-dev
<laanwj>
(assuming the tests fail due to timeouts, not actual wrong values, ofc)
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<laanwj>
if they fail due to *other* intermittent issues, please report an issue, but such widespread intermittent values tend to be due to timeouts
<laanwj>
failures*
brunoerg has quit [Remote host closed the connection]
<michaelfolkson>
laanwj: Ok thanks, yeah the problem was timeouts (at least on a couple of them). feature_dbcrash still ran for 1926 seconds though before failing
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 250 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<provoostenator>
michaelfolkson: I find it useful to run functional tests on a RAM disk, as follows:
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 250 seconds]
Guyver2_ is now known as Guyver2
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #24585: doc: mention that BDB is for the legacy wallet in build-osx.md (master...build_osx_descriptor_legacy_switch) https://github.com/bitcoin/bitcoin/pull/24585
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master bce9aaf Daniel Kraft: Unit tests for IsWitnessProgram and IsP2WSH.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #14752: tests: Unit tests for IsPayToWitnessScriptHash and IsWitnessProgram (master...script-segwit-tests) https://github.com/bitcoin/bitcoin/pull/14752
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rex4539 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
grettke has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] ayush933 opened pull request #24587: test: use MiniWallet for rpc_createmultisig.py (master...createmultisig-miniwallet) https://github.com/bitcoin/bitcoin/pull/24587
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
arythmet_ has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
arythmet_ has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 245 seconds]
arythmetic has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
arythmet_ has quit [Ping timeout: 240 seconds]
shesek has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
arythmet_ has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 256 seconds]
lucasdcf has quit [Ping timeout: 252 seconds]
arythmetic has joined #bitcoin-core-dev
arythmet_ has quit [Ping timeout: 252 seconds]
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
hashfuncf39 has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 240 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
fanquake has quit [Ping timeout: 268 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] michaelfolkson opened pull request #24592: doc: Delete old line of code that was commented out (master...2022-03-delete-comment) https://github.com/bitcoin/bitcoin/pull/24592
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
fanquake has joined #bitcoin-core-dev
Guest49 has joined #bitcoin-core-dev
Guest49 is now known as lkirkwood
lkirkwood has quit [Quit: Client closed]
sudoforge has quit [Ping timeout: 240 seconds]
shesek has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
bitcoin/master b8992f2 Andrew Chow: Merge bitcoin/bitcoin#24592: doc: Delete old line of code that was comment...
<bitcoin-git>
bitcoin/master 9a5b4d7 Michael Folkson: doc: Delete old line of code that was commented out
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 merged pull request #24592: doc: Delete old line of code that was commented out (master...2022-03-delete-comment) https://github.com/bitcoin/bitcoin/pull/24592
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]