bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<fanquake>
stickies-v: I've invited you
<fanquake>
and you should have wiki access
<jonatack>
fanquake: thanks; doing, lmk wrt the 2 rpc fixups by MarcoFalke
<stickies-v>
yep got it, thanks
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] johnoseni1 opened pull request #24694: Made the readme simplified and explanatory and also the code more understandable (master...master) https://github.com/bitcoin/bitcoin/pull/24694
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #24694: Made the readme simplified and explanatory and also the code more understandable (master...master) https://github.com/bitcoin/bitcoin/pull/24694
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<fanquake>
If something isn't currently marked for backport, it doesn't need to be backported
<fanquake>
I'm not sure how we've ended up with some many random, last-minute doc changes are other things that all now need backporting
<jonatack>
I don't think they are random but lmk if should close.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sudoforge has joined #bitcoin-core-dev
<jonatack>
The random docs can wait until the next release, I guess.
<fanquake>
?
ghost43 has quit [Remote host closed the connection]
<fanquake>
There are more than docs in that PR. We need to get the last of the backports in
ghost43 has joined #bitcoin-core-dev
<jonatack>
I've put a fair amount of time into adding/fixing docs for the release on the basis that docs could be backported. But indeed they don't have the backport label.
<hebasto>
some backports are just fixes of bugs detected during rc2 testing
<fanquake>
I don't understand why the PR was closed. It's not just docs, and it currently has everything that's been marked as needing backport
boxframes_ has joined #bitcoin-core-dev
Saloframes has quit [Read error: Connection reset by peer]
<jonatack>
I understand about bugs. I thought missing or incorrect docs were backportable too. It's probably best to leave it to people who have decision-making power.
<fanquake>
They are backportable. That's why some have been marked as needing backport
<fanquake>
I still don't understand why you've closed the PR
ghost43 has quit [Remote host closed the connection]
<jonatack>
I don't see which docs are marked as needing backport and this seems like my fault, so it's best to leave to someone who decides.
ghost43 has joined #bitcoin-core-dev
<MarcoFalke>
Usually we don't backport docs unless they fix bugs. Though that doesn't mean that doc backports are generally encouraged or forbidden.
<fanquake>
The Prs added to that PR had all been marked for backport, and there were non-doc fixes as well, as well as additional commits in the process of being added.
<fanquake>
So regardless of what doc changes were in there, I don't see why it was closed, because the non-doc things still needed backporting
<fanquake>
The PR should just be reopened, the remaining commits that were in the process of being added should still be added, and then the backports can be reviewed.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jonatack>
Done. My intentions were only to fill in missing docs (CJDNS) and fix up incorrect ones.
gnaf has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
<fanquake>
jonatack: that's fine, but in that case, i wouldn't have named the PR 23.x backports. As that kinda gives the impression that it's all the 23.x backports
<fanquake>
In general, I think doc backports for the binaries are more important than say, the /doc folder, as most people are going to look at those docs on master, regardless of what version they are running
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
<jonatack>
That could be, but with respect to what users will do, the principle of least surprise (e.g. the docs in the same release as the feature) seems a good guideline.
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
<glozow>
stickies-v nice!
hirish has quit [Remote host closed the connection]
mikehu44 has quit [Ping timeout: 260 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24697: refactor: Address relay time refactors (master...2203-refactor-addr-relay-time-🌦) https://github.com/bitcoin/bitcoin/pull/24697
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
hirish has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
eb66819 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 260 seconds]
eb66819 has quit [Quit: Connection closed]
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
AaronvanW has quit [Read error: Connection reset by peer]
cmirror has joined #bitcoin-core-dev
cmirror has quit [Client Quit]
ghost43 has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
vasild has quit [Ping timeout: 240 seconds]
vasild_ has joined #bitcoin-core-dev
shesek_ has joined #bitcoin-core-dev
gnaf has quit [Read error: Connection reset by peer]
ghost43_ has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43_ has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 240 seconds]
Talkless has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
ghost43_ has quit [Ping timeout: 240 seconds]
rex4539 has quit [Quit: No Ping reply in 180 seconds.]
rex4539 has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
gnaf has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24698: test: -peerblockfilters without -blockfilterindex raises an error (master...2022-03-peerblockfilters-init-error) https://github.com/bitcoin/bitcoin/pull/24698
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
Ademan has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 260 seconds]
gossie has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
<Ademan>
I've been lurking this channel for a while via the matrix bridge and just lost access last night or today with this message from the bridge "Could not join #bitcoin-core-dev on 'irc.libera.chat': err_needreggednick". I'm not expecting anybody to accomodate me wanting to lurk via the bridge if there was a reason it was closed off, but on the off chance it was closed off by accident...
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
realies7 has joined #bitcoin-core-dev
realies has quit [Ping timeout: 256 seconds]
realies7 is now known as realies
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek__ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
<stick>
Ademan: you can set up your bridge so it uses a registered nick
ghost43 has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] achow101 opened pull request #24699: wallet: Improve AvailableCoins performance by reducing duplicated operations (master...faster-available-coins) https://github.com/bitcoin/bitcoin/pull/24699
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
shesek__ has quit [Read error: Connection reset by peer]
<luke-jr>
I think laanwj only intended to make speaking require registered user tho?
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
shesek_ has quit [Remote host closed the connection]
shesek_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
indexarray has joined #bitcoin-core-dev
<indexarray>
Ademan: Its easy to get a registered nick in less than a minute. Get throwaway email, open https://web.libera.chat/, run command /msg NickServ REGISTER YourPassword youremail@example.com and /msg NickServ VERIFY REGISTER nick code
indexarray has left #bitcoin-core-dev [#bitcoin-core-dev]