real_or_random has quit [Quit: ZNC 1.8.2 - https://znc.in]
real_or_random has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
sipsorcery has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jessebarton closed pull request #24618: doc: Update OpenBSD build docs, added resources for pkg_add and doas (master...openbsd_install_doc_doas) https://github.com/bitcoin/bitcoin/pull/24618
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jessebarton opened pull request #24646: doc: remove unneeded documentation on basic package management on FreeBSD (master...freebsd_remove_basic_doc_info) https://github.com/bitcoin/bitcoin/pull/24646
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitdex has joined #bitcoin-core-dev
jessebarton has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
yanmaani1 has quit [Ping timeout: 240 seconds]
vysn has joined #bitcoin-core-dev
yanmaani1 has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
CoinForensics has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
* luke-jr
prods #24294 again
<gribble>
https://github.com/bitcoin/bitcoin/issues/24294 | RPC: Switch getblockfrompeer back to standard param names blockhash and nodeid by luke-jr · Pull Request #24294 · bitcoin/bitcoin · GitHub
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
mikehu44 has joined #bitcoin-core-dev
hashfunc569 has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
hashfunc569 has quit [Ping timeout: 240 seconds]
hashfunc569 has joined #bitcoin-core-dev
<_aj_>
luke-jr: where are you seeing: <luke-jr> weird, Assume() breaks the context for member calls
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43_ has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
kexkey_ has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 240 seconds]
kexkey has quit [Ping timeout: 240 seconds]
ronoaldo has quit [Quit: Konversation terminated!]
yanmaani1 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 240 seconds]
lukedashjr has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
lukedashjr is now known as luke-jr
vysn has quit [Ping timeout: 240 seconds]
kexkey_ has quit [Ping timeout: 252 seconds]
kexkey has joined #bitcoin-core-dev
yanmaani1 has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
ghost43_ has quit [Remote host closed the connection]
<luke-jr>
_aj_: when writing wallet code; pushed as bugfix_rpc_getbalance_hacky to my github - now has a "this->" added
lucasdcf_ has quit [Read error: Connection reset by peer]
luke-jr has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<_aj_>
luke-jr: interesting; seems to work with clang but not gcc for me
brunoerg has quit [Ping timeout: 256 seconds]
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 252 seconds]
ghost43 has quit [Remote host closed the connection]
lukedashjr is now known as luke-jr
ghost43 has joined #bitcoin-core-dev
CoinForensics has quit [Changing host]
CoinForensics has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 256 seconds]
lukedashjr is now known as luke-jr
franzo has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
hashfunc569 has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 252 seconds]
franzo has quit [Quit: Client closed]
jouke has quit [Ping timeout: 256 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #24648: Revert "net: do not advertise address where nobody is listening" (master...220323-listen) https://github.com/bitcoin/bitcoin/pull/24648
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
noonien has quit [Ping timeout: 240 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
Flow has quit [Ping timeout: 240 seconds]
dviola has quit [Changing host]
dviola has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
Flow has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] S3RK opened pull request #24649: wallet: do not count wallet utxos as external (master...wallet_correct_external_utxo) https://github.com/bitcoin/bitcoin/pull/24649
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 250 seconds]
kexkey has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
lukedashjr has quit [Read error: Connection reset by peer]
luke-jr has quit [Ping timeout: 256 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
ghost43_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 240 seconds]
sudoforge has quit [Ping timeout: 245 seconds]
jouke has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
lucasdcf_ has quit [Read error: Connection reset by peer]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<vasild>
michaelfolkson: I assume it is just utf8 symbols, did not create problems for me - can copy paste it if necessary, or autocomplete through it, but it is hard to type it :) if it ends up in the filesystem as a directory or file name it could create problems for non-utf8 filesystems, I guess (I do not know which ones would that be)
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24646: doc: remove unneeded documentation on basic package management on FreeBSD (master...freebsd_remove_basic_doc_info) https://github.com/bitcoin/bitcoin/pull/24646
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has joined #bitcoin-core-dev
<michaelfolkson>
vasild: Ok thanks. So just a minor typing irritant. The branch name shouldn't end up in the filesystem, just the Git history. So not a disaster for non-utf8 file systems?
ghost43 has quit [Remote host closed the connection]
<michaelfolkson>
Let's not include emoijs in directory or file names :)
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
franzo has quit [Quit: Client closed]
cold has quit [Ping timeout: 252 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto closed pull request #24648: Revert "net: do not advertise address where nobody is listening" (master...220323-listen) https://github.com/bitcoin/bitcoin/pull/24648
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 252 seconds]
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
noonien has joined #bitcoin-core-dev
luke-jr has quit [Client Quit]
luke-jr has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
luke-jr- has joined #bitcoin-core-dev
luke-jr- has quit [Read error: Connection reset by peer]
luke-jr has quit [Ping timeout: 250 seconds]
luke-jr- has joined #bitcoin-core-dev
luke-jr- has quit [Read error: Connection reset by peer]
shesek has quit [Remote host closed the connection]
noonien has joined #bitcoin-core-dev
shesek has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
<laanwj>
i don't think we particularly need to support checking out the repo on non-unicode file systems
<laanwj>
that said, i agree if there's no need to have utf-8 characters in filenames it's better not to
<laanwj>
fanquake: ACK on inviting 0xb10c, i'm surprised they weren't yet! btw, please invite people to bitcoincore org as well if you invite them for bitcoin to keep the lists in sync
vysn has quit [Ping timeout: 240 seconds]
ghost43 has quit [Remote host closed the connection]
mikehu44 has quit [Ping timeout: 256 seconds]
ghost43 has joined #bitcoin-core-dev
kexkey_ has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 250 seconds]
ghost43 has quit [Remote host closed the connection]
<jonatack>
a propos, I suggested S3RK some time ago on one of these membership PRs, and would re-recommend
<jonatack>
(based on activity, I don't have any other affiliation or connection)
<jonatack>
+1 wrt 0xb10c
ghost43 has joined #bitcoin-core-dev
<michaelfolkson>
#proposedmeetingtopic Current thinking on when to deprecate and the deprecation process when deprecation is considered appropriate
<michaelfolkson>
(Please do other proposed topics first, this may be more for my personal benefit)
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 260 seconds]
mikehu44 has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #24610: test, lint: check bash version before executing codespell (master...2022-03-bash-lint-spelling) https://github.com/bitcoin/bitcoin/pull/24610
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
cryptapus has quit [Quit: Konversation terminated!]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
morcos_ has joined #bitcoin-core-dev
morcos has quit [Ping timeout: 240 seconds]
morcos_ is now known as morcos
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
<josibake>
is there a way to simulate a bumpfee when using miniwallet? if not, is this worth adding to miniwallet?
<josibake>
context - i am trying to rewrite `test/functional/interface_zmq.py` to use MiniWallet and there are a few lines testing the RBF notifications, which use bumpfee
<MarcoFalke>
josibake: I think you can just do tx.vout[0].nValue -= 1000 to bumpfee
<josibake>
MarcoFalke: thanks! does it make sense to add this as a method to MiniWallet?
<laanwj>
jonasschnelli: thanks, invited S3RK to both orgs
<laanwj>
oops jonatack ^
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
mikehu44 has quit [Ping timeout: 260 seconds]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
morcos has quit [Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in]
morcos has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
lucasdcf_ has quit [Read error: Connection reset by peer]
lucasdcf_ has joined #bitcoin-core-dev
yanmaani1 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
monlovesmango has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
monlovesmango has quit [Client Quit]
ghost43 has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] fanquake opened pull request #24652: doc: rewrite OpenBSD build docs for 7.0 (master...openbsd_wallet_doc_cleanupp) https://github.com/bitcoin/bitcoin/pull/24652
rex4539 has quit [Ping timeout: 240 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] josibake opened pull request #24653: test, refactor: use `MiniWallet` in `test/functional/interface_zmg` (master...josibake-make-interfaces-zmq-test-use-miniwallet) https://github.com/bitcoin/bitcoin/pull/24653
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jouke has quit [Ping timeout: 252 seconds]
flooded is now known as _flood
cocoon has joined #bitcoin-core-dev
<cocoon>
1: adding to org for a project on github can be decided by the owners but this project is different from others. It is used by most of the nodes in bitcoin network claimed to be decentralized network for money and bip repo belongs to same organization.
<cocoon>
2: there should be a process for adding people to org else it will lead to controversies
<cocoon>
3: github needs org, bitcoin doesn't so these things can be separated
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rex4539 has joined #bitcoin-core-dev
<michaelfolkson>
cocoon: This is adding to the GitHub org, there is no org other than the GitHub org and merge permissions (maintainers)
shesek has quit [Remote host closed the connection]
AaronvanW has quit [Quit: Leaving...]
shesek has joined #bitcoin-core-dev
kouloumos_ has joined #bitcoin-core-dev
B_1o1 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 240 seconds]
<cocoon>
michaelfolkson: adding to github org has a meaning in bitcoin/bitcoin and bitcoin-core/gui. if you think there is no other github org maintaining implementations for bitcoin then its either a misunderstanding or centralization. I understand this does not involve merge permissions.
dunxen has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
zeropoint has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
<cocoon>
and I am not surprised by the last 2 people added or their employer or things they didn't want in bitcoin
<michaelfolkson>
cocoon: #bitcoin please
rex4539 has quit [Ping timeout: 240 seconds]
<cocoon>
michaelfolkson: lmao this was shared in this channel and they were added in bitcoin core github org
brunoerg has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
Guyver2 has left #bitcoin-core-dev [Closing Window]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
cocoon has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master 77773b0 MarcoFalke: wallet: Pass FastRandomContext& to DiscourageFeeSniping
<bitcoin-git>
bitcoin/master fa7deaa MarcoFalke: wallet: Pass FastRandomContext& to coin selection
<bitcoin-git>
bitcoin/master 3ab96f2 Andrew Chow: Merge bitcoin/bitcoin#24560: wallet: Use single FastRandomContext when cre...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 merged pull request #24560: wallet: Use single FastRandomContext when creating a wallet tx (master...2203-RandWallet-🗾) https://github.com/bitcoin/bitcoin/pull/24560
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
CoinForensics has quit [Ping timeout: 252 seconds]
rex4539 has joined #bitcoin-core-dev
gnaf has quit [Ping timeout: 252 seconds]
<luke-jr>
I agree with cocoon that it was on-topic here, though I don't really understand his concerns
CoinForensics has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 240 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
<michaelfolkson>
luke-jr: "I am not surprised" you think that (joke)
cocoon has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
<cocoon>
luke-jr: thanks for understanding and I like the recent feature that you can improve privacy by rejecting address reuse in mempool.
<cocoon>
my concerns: percentage of nodes run core for bitcoin? percentage of people that use core org for bip and read that they need post on a mailing list? do we have a process to add/remove people in this? can we improve this?
sipsorcery has joined #bitcoin-core-dev
<luke-jr>
to be clear, BIPs are not part of Core. The bitcoin github org just has multiple groups and multiple projects.
<luke-jr>
and only each person can decide which node implementation they run; feel free to encourage more use of others
<luke-jr>
(also, while the topic of bitcoin/bitcoin group members would be on-topic here, things like "what impl people run" does indeed seem better suited for #bitcoin and broader community chats; let's stick to just dev-specific topics here, so non-devs can more readily participate in the other topics ☺)
B_1o1 has quit [Quit: Connection closed]
shesek has quit [Remote host closed the connection]
<cocoon>
luke-jr: BIPs are not part of core. How do you explain this to whole world including laanwj who knows this exists: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-April/018871.html. I have tried my best to share they use an implementation they like or fork but NETWORK EFFECT is a thing you cannot go against. If you every try to do
<cocoon>
marketing for knots, more github activity, more tweets, more mailing list indirect involvement, r/bitcoin suggesting as an alternative etc. maybe it would work. I would encourage people for both: core and knots.
Talkless has joined #bitcoin-core-dev
lucasdcf_ has quit [Read error: Connection reset by peer]