brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
upekkha has quit [Quit: upekkha]
upekkha has joined #bitcoin-core-dev
metallicc has quit [Remote host closed the connection]
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
evanlinjin has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
hashfunc65d has quit [Ping timeout: 250 seconds]
SpellChecker has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
kobie has quit [Remote host closed the connection]
a1ph4byte20 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
PaperSwordAlt has quit [Read error: Connection reset by peer]
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
mikehu44 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
a1ph4byte20 has quit [Quit: Client closed]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d4475ea7ae70...0d080a183bfc
<bitcoin-git> bitcoin/master e71c51b Shashwat: refactor: rename command -> message type in comments in the src/net* files
<bitcoin-git> bitcoin/master 2b09593 Shashwat: scripted-diff: Rename message command to message type
<bitcoin-git> bitcoin/master 0d080a1 MacroFake: Merge bitcoin/bitcoin#24141: Rename message_command variables in src/net* ...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24141: Rename message_command variables in src/net* and src/rpc/net.cpp (master...220124-message) https://github.com/bitcoin/bitcoin/pull/24141
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
salvatoshi has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
szkl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
djb27__ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
jetpack has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
jetpack has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
bitdex has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/0d080a183bfc...1ad5d5088d69
<bitcoin-git> bitcoin/master a4fd440 Hennadii Stepanov: build: Pass missed `strip` tool via `config.site`
<bitcoin-git> bitcoin/master 80cd993 Hennadii Stepanov: scripted-diff: Rename INSTALLNAMETOOL -> INSTALL_NAME_TOOL
<bitcoin-git> bitcoin/master f87594d Hennadii Stepanov: build: No need to provide defaults for darwin-specific tools
<bitcoin-git> [bitcoin] fanquake merged pull request #24866: build: No longer need to hack the `PATH` variable in `config.site` (master...220415-tools) https://github.com/bitcoin/bitcoin/pull/24866
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
evanlinjin has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
belcher has quit [Ping timeout: 272 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ZeroMaster has quit [Ping timeout: 260 seconds]
belcher has joined #bitcoin-core-dev
ZeroMaster has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 246 seconds]
Evel-Knievel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] jonatack opened pull request #25067: validation, refactor: make MainSignalsInstance() a class, move to h (master...make-MainSignalsInstance-a-class-and-move-to-header-file) https://github.com/bitcoin/bitcoin/pull/25067
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
ZeroMaster has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
remyers[m] has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
szkl has quit [Quit: Connection closed for inactivity]
Guyver2__ has joined #bitcoin-core-dev
Guyver2_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
bitdex has quit [Quit: = ""]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Guyver2__ has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit []
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
antonleviathan has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ad5d5088d69...7cc1860b12a5
<bitcoin-git> bitcoin/master a0e2a31 Hennadii Stepanov: build: Drop redundant checks for ranlib and strip tools
<bitcoin-git> bitcoin/master 7cc1860 fanquake: Merge bitcoin/bitcoin#24566: build: Drop redundant checks for ranlib and s...
<bitcoin-git> [bitcoin] fanquake merged pull request #24566: build: Drop redundant checks for ranlib and strip tools (master...220314-conf) https://github.com/bitcoin/bitcoin/pull/24566
antonleviathan has quit [Quit: Client closed]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<instagibbs> sipa, I was too afraid to ask
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25068: Wrap boost::replace_all (master...2205-util-string-📉) https://github.com/bitcoin/bitcoin/pull/25068
<achow101> Can someone block uvhw on github?
mikehu44_ has quit [Ping timeout: 248 seconds]
<sipa> Done.
<fanquake> I think I did earlier this morning
<fanquake> cleaned up all the spam PRs and other crap
<achow101> fanquake: I noticed some wiki vandalism from that user
<sipa> They were already blocked on the bitcoin org; I also blocked them from the bitcoin-core org.
<achow101> bips wiki specifically
<fanquake> I haven't seen anything in the wiki other than spam as of late. Mostly randoms/spammers creating pages. It'd be good to try and lock that down in some way?
<fanquake> *bips wiki
Guest42 has joined #bitcoin-core-dev
<lightlike> could also cleanup after Miminlaili (24410)
xyephy has joined #bitcoin-core-dev
Guest42 has quit [Quit: Ping timeout (120 seconds)]
xyephy has quit [Remote host closed the connection]
xyephy has joined #bitcoin-core-dev
xyephy has quit [Client Quit]
xyephy has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cc1860b12a5...c367736f85ac
<bitcoin-git> bitcoin/master bd6ceb4 whiteh0rse: test: port 'lint-shell.sh' to python
<bitcoin-git> bitcoin/master c367736 MacroFake: Merge bitcoin/bitcoin#24840: test: port 'lint-shell.sh' to python
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
<fanquake> lightlike: is that the right PR number?
<sipa> #24410
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<fanquake> oh right I see
<fanquake> I have blocked them, and minimized the comments
<fanquake> but we can't delete reviews unfortunately
baldur has joined #bitcoin-core-dev
xyephy has quit [Remote host closed the connection]
Evel-Knievel has quit [Ping timeout: 240 seconds]
xyephy has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hunglun opened pull request #25069: test: Add a new unit test for chain.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/25069
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
xyephy has quit [Remote host closed the connection]
seejee has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c367736f85ac...e4478d312f90
<bitcoin-git> bitcoin/master dcad5f7 fanquake: guix: consolidate kernel headers to 5.15
<bitcoin-git> bitcoin/master eb02713 fanquake: doc: add minimum required kernel version to dependencies.md
<bitcoin-git> bitcoin/master e4478d3 fanquake: Merge bitcoin/bitcoin#25006: guix: consolidate kernel headers to 5.15, spe...
<bitcoin-git> [bitcoin] fanquake merged pull request #25006: guix: consolidate kernel headers to 5.15, specify 3.2.0 as minimum supported (master...specify_minimum_kernel) https://github.com/bitcoin/bitcoin/pull/25006
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
<fanquake> Looks like #24993 has broken the linter ?
<gribble> https://github.com/bitcoin/bitcoin/issues/24993 | test, contrib, refactor: use `with` when opening a file by brunoerg · Pull Request #24993 · bitcoin/bitcoin · GitHub
martinus has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] brunoerg opened pull request #25070: contrib: fix dirname on `verify-commits` (master...2022-05-ci-fix) https://github.com/bitcoin/bitcoin/pull/25070
jonatack has quit [Ping timeout: 260 seconds]
cotsuka has quit [Quit: Ping timeout (120 seconds)]
cotsuka has joined #bitcoin-core-dev
Evel-Knievel has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e4478d312f90...460450836304
<bitcoin-git> bitcoin/master ded915e brunoerg: contrib: fix dirname on `verify-commits`
<bitcoin-git> bitcoin/master 4604508 fanquake: Merge bitcoin/bitcoin#25070: contrib: fix dirname on `verify-commits`
<bitcoin-git> [bitcoin] fanquake merged pull request #25070: contrib: fix dirname on `verify-commits` (master...2022-05-ci-fix) https://github.com/bitcoin/bitcoin/pull/25070
<fanquake> thanks
Talkless has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
seejee has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
evanlinjin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
csknk has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
sipsorcery has joined #bitcoin-core-dev
<theStack> are there currently any alternative concepts availabe or for discussion for BIP322? i'd like to focus more on generic signing support and wonder if there's a reason why the BIP322 PR (#24058) didn't get more traction yet
<gribble> https://github.com/bitcoin/bitcoin/issues/24058 | BIP-322 basic support by kallewoof · Pull Request #24058 · bitcoin/bitcoin · GitHub
jonatack has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
<laanwj> #startmeeting
<core-meetingbot> Meeting started Thu May 5 19:01:17 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<core-meetingbot> Available commands: action commands idea info link nick
<josibake> hi
<glozow> hi
<jonatack> hi
<dongcarl> hi
<achow101> hi
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball
<laanwj> morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
<instagibbs> :wave:
<theStack> hi
<laanwj> there's been one pre-proposed meeting topic for today: package relay updates (glozow)
<laanwj> any last minute topics?
<lightlike> hi
<laanwj> (you can propose meeting topics with #proposedmeetingtopic <topic> during any time of the week)
jonhbit has joined #bitcoin-core-dev
<kanzure> hi
<kvaciral> hi
<MarcoFalke> #proposedmeetingtopic LIFETIMEBOUND
<laanwj> ack
<laanwj> #topic High priority for review
<core-meetingbot> topic: High priority for review
<laanwj> there's 12 blockers and 1 labaled chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
<laanwj> anything to add/remove?
<sipa> hi
<ajonas> hi
<theStack> may i ask for #23662 to add (should be easy to review and fixes a significant slowdown of RPC calls that some users were reporting)
<gribble> https://github.com/bitcoin/bitcoin/issues/23662 | rpc: improve `getreceivedby{address,label}` performance by theStack · Pull Request #23662 · bitcoin/bitcoin · GitHub
<b10c> hi
<laanwj> theStack: added!
<theStack> thanks
<laanwj> anything else? anything on that list that is (almost) ready for merge?
<laanwj> seems not, time for next topic then
<laanwj> #topic Package relay updates (glozow)
<core-meetingbot> topic: Package relay updates (glozow)
<glozow> Hi! I originally planned to propose a proposal + roadmap, but I haven't had as much time to prepare for expected questions as I hoped, so I'll defer that to another week.
<glozow> I can give updates on what I’m working on, but no proposal this week. So my apologies for the disappointment if anybody came specifically expecting to see a proposal.
<glozow> I’ve split the project into two groups: mempool logic and p2p relay stuff. Since all the mempool logic apart from package RBF is done, I’m working on a p2p package relay BIP + implementation.
<laanwj> no problem, we can bring back the topic next week if you prefer that
<glozow> that would be lovely, thanks so much
<glozow> #24836 is the PR open for review if anybody wants to help out. #25038 is also open for browsing as well. Unfortunately there is a pinning attack that it doesn’t fix, so I am working out what to do about it. That’s why it’s a draft.
<gribble> https://github.com/bitcoin/bitcoin/issues/24836 | add RPC (-regtest only) for testing package policy by glozow · Pull Request #24836 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/25038 | BIP125-based Package RBF by glozow · Pull Request #25038 · bitcoin/bitcoin · GitHub
<glozow> that's all I wanted to share for today, thanks!
<instagibbs> if I may glozow, which pinning are you referring to? there are so many to choose from
<instagibbs> or just discuss on thread, nevermind!
<glozow> instagibbs: yeah good question. it's Rule #3 https://usercontent.irccloud-cdn.com/file/CoG1SqvV/image.png
<laanwj> thanks for the quick update, i'll take a look at #24836 some time this week
<gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24836 | add RPC (-regtest only) for testing package policy by glozow · Pull Request #24836 · bitcoin/bitcoin · GitHub
<glozow> yeah we can discuss offline 👍
<instagibbs> ok on same page :+1:
<laanwj> #topic LIFETIMEBOUND (MarcoFalke)
<core-meetingbot> topic: LIFETIMEBOUND (MarcoFalke)
<MarcoFalke> hi, so the attribute is used in some places
<MarcoFalke> Though, while it does catch some errors (temporaries), it doesn't catch most other issues
<MarcoFalke> (lifetime-related issues)
<MarcoFalke> And #20493
<gribble> https://github.com/bitcoin/bitcoin/issues/20493 | lifetimebound compile attribute · Issue #20493 · bitcoin/bitcoin · GitHub
<laanwj> is there anything better?
<sipa> I'd expect cases where temporaries are accidentally passed to be the ones that are most likely to be missed through code review.
<MarcoFalke> Only at run time: valgrind, msan, asan, etc
<laanwj> (besides switching to another programming language)
<laanwj> so i'd say this is the "Better than nothing" category then
<laanwj> combine it with run-time approaches
Talkless has quit [Quit: Konversation terminated!]
<sipa> And even if the analysis isn't all that strong, they're still useful as developer documentation.
<laanwj> and don't add functions that are clearly dangerous like return string views *ducks*
<MarcoFalke> I think it can be applied pretty broadly, basically everywhere where a pointer/reference is passed and the pointer/reference lifes on after the functions returns
<laanwj> yes
<MarcoFalke> So I think if we start applying them, the code will become a bit more verbose
<MarcoFalke> Just wanted to see if anyone would want to object that
csknk has quit [Quit: leaving]
<sipa> Just in function/constructor declarations, rights?
<laanwj> it depends on how much more verbose
<jonatack> I don't think it's too bad, see https://github.com/bitcoin/bitcoin/pull/25060/files for an example
<MarcoFalke> #20493 has a list, but it is not complete
<gribble> https://github.com/bitcoin/bitcoin/issues/20493 | lifetimebound compile attribute · Issue #20493 · bitcoin/bitcoin · GitHub
<laanwj> i mean there's clearly some degree of verbosity where it just becomes silly make-work and isn't worth it compared that what is gained
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<MarcoFalke> I think it is missing any stuff that was recently added at least: m_params references, and potentially more CBlockIndex passing
<laanwj> jonatack: that doesn't look bad
<laanwj> sipa: seems so then?
<MarcoFalke> Right, it only attaches to functions or function parameters
<laanwj> also important is how difficult it is to maintain, e.g. can we expect a lot of false positives when people compile with a different compiler
<sipa> Yeah, I don't mind adding them. I don't think we go start hunting down every last place where such an attribute could be added, but there seem to be very little downsides to adding them where appropriate.
<laanwj> (remembers -Wshadow)
<sipa> it preprocesses to nothing on non-clang compilers
<laanwj> right
<MarcoFalke> When I added it in #22278 for CScript I actually ran into the bug before, but for other places, I am less sure if it will be equally useful
<gribble> https://github.com/bitcoin/bitcoin/issues/22278 | Add LIFETIMEBOUND to CScript where needed by MarcoFalke · Pull Request #22278 · bitcoin/bitcoin · GitHub
<laanwj> well i think it's fine to add them then
<sipa> which bug?
<MarcoFalke> I did some odd CScript{ stuff } in tests and broke valgrind
<josibake> if it's encouraged to add them where appropriate, can we add something to the developer docs? perhaps a brief explanation of why to use them?
<sipa> hmm
<josibake> s/them/it
<MarcoFalke> Probably was []{return CScript{} << 1;}()
<MarcoFalke> Ah no, []-> decltype(auto) {return CScript{} << 1;}()
<MarcoFalke> Pretty obscure
<sipa> Is that returning a `CScript` or a (const) `CScript&`?
<sipa> (the latter would actually be a lifetime issue)
<MarcoFalke> operator<< returns &
<MarcoFalke> sipa: Yeah, that was the reason I added LIFETIMEBOUND
<sipa> Yes, but doesn't `-> decltype(auto)` return a non-reference?
<MarcoFalke> no, IIRC
<sipa> ok
<sipa> Sounds like the lifetimebound is doing its job then.
<jonatack> josibake: good point. i'll propose a doc along with another (non-contentious) developer notes improvement i have in mind
<sipa> decltype(auto) apparently can indeed deduce a reference type
<laanwj> that's quite a footgun in itself
<josibake> jonatack: ty!
<laanwj> any other topics?
<laanwj> seems like not; time to close the meeting, thanks for attending everyone
<laanwj> #endmeeting
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<core-meetingbot> Meeting ended Thu May 5 19:38:19 2022 UTC.
<jonatack> MarcoFalke: i've misplaced the url to your online test coverage report by codebase area
<jonatack> can you please remind me of the link?
<jonatack> ty!
<MarcoFalke> heh, index: https://marcofalke.github.io/btc_cov/
<jonatack> purrfect
evanlinjin has quit [Ping timeout: 240 seconds]
djb27__ has quit [Ping timeout: 246 seconds]
djb27__ has joined #bitcoin-core-dev
roconnor has quit [Ping timeout: 240 seconds]
___nick___ has quit [Ping timeout: 276 seconds]
<bitcoin-git> [bitcoin] Crypt-iQ closed pull request #24901: mempool: reduce lookups, insertions to cache in UpdateForDescendants (master...mempool_desc_patch) https://github.com/bitcoin/bitcoin/pull/24901
jonhbit has quit [Quit: Client closed]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
xyephy has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
xyephy has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Victorsueca has quit [Ping timeout: 248 seconds]
Victorsueca has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
earnestly has quit [Ping timeout: 272 seconds]
mudsip has quit []
utzig has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]
sipsorcery has joined #bitcoin-core-dev
<jonatack> The "Safer Usage Of C++" document mentioned by MarcoFalke in https://github.com/bitcoin/bitcoin/issues/20493#issuecomment-1113589139, and in particular the "Annotate Lifetimes" section, seems quite good.
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
AaronvanW has quit [Quit: Leaving...]
salvatoshi has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
salvatoshi has quit [Ping timeout: 276 seconds]
sipsorcery has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
Guest33 has joined #bitcoin-core-dev
Guest33 has quit [Client Quit]
hashfunc65d has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
bomb-on has quit [Quit: aллилѹіа!]
cotsuka has quit [Quit: The Lounge - https://thelounge.chat]
bitdex has joined #bitcoin-core-dev
cameron[m] has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]