brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
<caraponz> np, thanks achow101!
brunoerg has joined #bitcoin-core-dev
Victorsueca has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
dsc_ is now known as Guest970
Guest970 has quit [Killed (mercury.libera.chat (Nickname regained by services))]
bomb-on has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
caraponz has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Guest68 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
z9z0b3t1_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 244 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
Victorsueca has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Guest68 has quit [Quit: Client closed]
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
evanlinjin has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
mikehu44 has joined #bitcoin-core-dev
ronoaldo has quit [Ping timeout: 240 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
hashfunc1204 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
AaronvanW has quit [Ping timeout: 276 seconds]
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7b3343f3009d...bb83aba6c98b
<bitcoin-git> bitcoin/master b953ea6 Suhail Saqan: rpc: Put undocumented JSON failure mode behind a runtime flag
<bitcoin-git> bitcoin/master bb83aba MacroFake: Merge bitcoin/bitcoin#25161: rpc: Put undocumented JSON failure mode behin...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 276 seconds]
mikehu44_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guest70 has joined #bitcoin-core-dev
Guest70 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
evanlinjin has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
bitdex has quit [Ping timeout: 240 seconds]
yanmaani2 has quit [Ping timeout: 240 seconds]
SpellChecker has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25170: build: Enable RPC_DOC_CHECK on --enable-debug (master...2205-enable-rpc-doc-check-on-debug-🗿) https://github.com/bitcoin/bitcoin/pull/25170
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 244 seconds]
SpellChecker has joined #bitcoin-core-dev
yanmaani2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Keele_ has quit [Ping timeout: 256 seconds]
Keele has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Randolf has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
yanmaani2 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
yanmaani2 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
mudsip has quit []
x88x88x has quit [Remote host closed the connection]
AaronvanW has quit [Ping timeout: 246 seconds]
salvatoshi has joined #bitcoin-core-dev
hashfunc1204 has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
earnestly has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
ronoaldo has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
x88x88x has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 240 seconds]
AaronvanW has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kouloumos has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Randolf has quit [Quit: Leaving]
jonatack has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bb83aba6c98b...986bae8e7248
<bitcoin-git> bitcoin/master 42e3250 John Newbery: [net processing] [refactor] Move m_next_send_feefilter and m_fee_filter_se...
<bitcoin-git> bitcoin/master 290a8da John Newbery: [net processing] Comment all TxRelay members
<bitcoin-git> bitcoin/master b0a4ac9 John Newbery: [net processing] Add m_tx_relay_mutex to protect m_tx_relay ptr
<bitcoin-git> [bitcoin] fanquake merged pull request #22778: net processing: Reduce resource usage for inbound block-relay-only connections (master...2021-02-tx-relay-init) https://github.com/bitcoin/bitcoin/pull/22778
brunoerg has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/986bae8e7248...fdb82a30bed2
<bitcoin-git> bitcoin/master c65bf50 John Newbery: Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
<bitcoin-git> bitcoin/master bf6526f John Newbery: [test] Remove segwit argument from build_block_on_tip()
<bitcoin-git> bitcoin/master fdb82a3 fanquake: Merge bitcoin/bitcoin#25147: Net processing: follow ups to #20799 (removin...
<bitcoin-git> [bitcoin] fanquake merged pull request #25147: Net processing: follow ups to #20799 (removing support for v1 compact blocks) (master...20205_20799_follow_ups) https://github.com/bitcoin/bitcoin/pull/25147
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
SpellChecker has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
qubenix has quit [Quit: quit]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdb82a30bed2...345d860f3818
<bitcoin-git> bitcoin/master 174f58c Marnix: Add link to NetBSD release
<bitcoin-git> bitcoin/master 345d860 fanquake: Merge bitcoin/bitcoin#25166: doc: Add link to NetBSD release
<bitcoin-git> [bitcoin] fanquake merged pull request #25166: doc: Add link to NetBSD release (master...NetBSD-release-link) https://github.com/bitcoin/bitcoin/pull/25166
qubenix has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
noonien has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 256 seconds]
sudoforge has joined #bitcoin-core-dev
<michaelfolkson> caraponz: Not exhaustive but Optech tries to follow and announce who is supporting PSBTs https://bitcoinops.org/en/topics/psbt/
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
djb27__ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
djb27__ has quit [Read error: Connection reset by peer]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
djb27_ has quit [Ping timeout: 244 seconds]
<hebasto> looks like https://github.com/boostorg/process/issues/207 has been solved recently
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] sdaftuar closed pull request #20726: p2p: Add DISABLETX message for negotiating block-relay-only connections (master...2020-12-negotiate-block-relay) https://github.com/bitcoin/bitcoin/pull/20726
bitdex has quit [Quit: = ""]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/345d860f3818...e18fd4763e77
<bitcoin-git> bitcoin/master 7171ebc Martin Zumsande: index: Don't commit a best block before indexing it during sync
<bitcoin-git> bitcoin/master e18fd47 fanquake: Merge bitcoin/bitcoin#25074: index: During sync, commit best block after i...
<bitcoin-git> [bitcoin] fanquake merged pull request #25074: index: During sync, commit best block after indexing (master...202205_index_sync_order) https://github.com/bitcoin/bitcoin/pull/25074
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
Guest97 has joined #bitcoin-core-dev
Guest97 has quit [Client Quit]
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] theStack opened pull request #25171: rpc: wallet: remove `-deprecatedrpc=exclude_coinbase` logic (master...202205-rpc-remove_deprecated_include_coinbase_option) https://github.com/bitcoin/bitcoin/pull/25171
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
mikehu44_ has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
chinggg has joined #bitcoin-core-dev
chinggg has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e18fd4763e77...0de36941eca1
<bitcoin-git> [bitcoin] fanquake merged pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
<bitcoin-git> [bitcoin] fanquake opened pull request #25172: refactor: use std:: for mem*( funcs (master...use_std_variants) https://github.com/bitcoin/bitcoin/pull/25172
Ignush has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 246 seconds]
Ignush_ has joined #bitcoin-core-dev
Ignush_ has quit [Client Quit]
Ignush has quit [Quit: Leaving]
NorrinRadd has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
NorrinRadd has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
roconnor has quit [Ping timeout: 240 seconds]
Talkless has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<pinheadmz_> Is this a discrepency between bip341 and taproot sighash implementation?
<pinheadmz_> the bip says ANYONECANPAY commits to value of utxo being spent
<pinheadmz_> or is value || scriptpubkey in that cache.m_spent_outputs[in_pos] ?
<pinheadmz_> ok that must be it, its more explicit in the python version in tests
<pinheadmz_> ill show myself out (I'll show myself CTxOut)
<david-bakin> Decl of CTxOut in transactionh shows it is a struct with a CAmount and a CScript - it serializes as one after the other. I think it would be clearer if the 2 fields were in fact serialized separately as it shows in BIP-341. That's in fact what I did in the unit tests I'm writing - see https://github.com/bitcoin/bitcoin/pull/25097/files#diff-21483d0e032747850208f21325b29cde89e9c1f
<david-bakin> 55f83a7a166a388cc5c27115aR787
<pinheadmz_> david-bakin thanks !
jarthur has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<laanwj> hebasto: the solution looks weird https://github.com/boostorg/process/commit/7a81779ff77cb462170467c0146c5652da6b2cb9 seems like they just nested boost::filesystem under boost::process or am i misunderstanding something?
<hebasto> laanwj: I did not look into details
<laanwj> #startmeeting
<core-meetingbot> Meeting started Thu May 19 19:00:00 2022 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
<core-meetingbot> Available commands: action commands idea info link nick
<hebasto> hi
<jonatack> hi
<laanwj> hebasto: i was interested to see what they actually did to solve it (e.g. make it a choice, remove boost::Filesystem completely, etc) but... i don't really get it
<kvaciral> hi
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
<lightlike> hi
<laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
<achow101> hi
<sipa> hi
pk-b2 has joined #bitcoin-core-dev
<kanzure> hi
<laanwj> hi!
<_aj_> hi
<ariard> yo
<laanwj> looks like there have been no topics proposed in advance this week (you can propose meeting topics with #proposedmeetingtopic <topic> during any time of the week)
<laanwj> any last minute topics?
<instagibbs> hi
<b10c> hi
<laanwj> then let's begin with the usual
<laanwj> #topic High priority for review
<core-meetingbot> topic: High priority for review
<laanwj> there's currently 12 blockers and 2 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8
<laanwj> anything to add or remove?
<cfields> hi
<Murch> hi
<laanwj> or is anything on the list almost ready for merge?
<ariard> i think gleb is still happy to get more reviews on #23443
<gribble> https://github.com/bitcoin/bitcoin/issues/23443 | p2p: Erlay support signaling by naumenkogs · Pull Request #23443 · bitcoin/bitcoin · GitHub
<laanwj> imo it'd be good to have some more eyes on #22702, it's had quite a bit of review and testing, the comments have been addresed, i think it's more or less ready to go
<gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
<jonatack> laanwj: i've been running that branch as well (rebased to master), need to re-review it
<laanwj> jonatack: thanks!
<laanwj> ariard: yes, it's had quite a lot of review and ACKs, but looks like it has an unaddressed comment by jonatack
<laanwj> (and a discussion about include-what-you-use by jnewbery and glozow)
<jonatack> ariard: been chatting offline with gleb about review, those comments were only initial, i plan to review that child pull soon too
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<laanwj> though i'm not sure that' s something that holds up the PR
<ariard> jonatack: ah nice, yeah wasn't sure if it holds up the PR
<laanwj> right
<ariard> i'll ping him for the comments, meetings are usually late for him
geyaeb has quit [Ping timeout: 240 seconds]
<laanwj> ariard: thank you!
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<laanwj> anything else for high priority? any other topics?
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
<laanwj> i think #23595 is close too
<gribble> https://github.com/bitcoin/bitcoin/issues/23595 | util: Add ParseHex () helper by MarcoFalke · Pull Request #23595 · bitcoin/bitcoin · GitHub
geyaeb has joined #bitcoin-core-dev
<laanwj> there's some higher level discussion about updating the developer guide when to use std::byte but that doesn't have to hold up the PR
<laanwj> i don't think the change itself is controversial
___nick___ has joined #bitcoin-core-dev
<laanwj> if no one has further topics that concludes the meeting, thanks everyone for attending, see you next week
<laanwj> #endmeeting
<core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
<core-meetingbot> Meeting ended Thu May 19 19:18:08 2022 UTC.
<_aj_> s/if/since/ :)
Talkless has quit [Quit: Konversation terminated!]
<laanwj> hebasto: thinking of it, it's very possible that they're doing a trick like we do with an aliased namespace, that boost::process::filesystem can be an alias for either std::filesystem or boost::filesystem
<jonatack> perhaps one suggestion, maybe an occasional hint to active reviewers who are not here to look at the high priority ones, review appears to follow a power law concentration on the newly opened ones and the ones with github activity notifications (review attracts review...)
<laanwj> _aj_: right
<jonatack> (suggestion directed to myself as much as anyone else ;)
<laanwj> jonatack: how would we reach active reviewers that are not here
<jonatack> idk, maybe a nudge sentence by the irc logon bot
<ariard> we pray for their inner kharmas to read the post-meeting logs :)
<jonatack> just a thought :D
<laanwj> hehe
bomb-on has joined #bitcoin-core-dev
<jonatack> or a random (but somewhat rare) irc message courtesy of a friendly bot
<jonatack> s/reviewers who are not here/everyone/
<_aj_> i get review requests via the github feature from fanquake every now and then, which i find helpful
<fanquake> yea I try and promt people where I think it’s relevant
<_aj_> i guess it indicates both "this is something you're probably interested in, and it's liable to get merged if it's not buggy so is a productive use of time"
olokun has joined #bitcoin-core-dev
<fanquake> Yea. That is true as well
olokun has quit [Quit: Leaving]
olokun has joined #bitcoin-core-dev
<laanwj> yes, using that seems like a good idea, though mostly for things that aren't already high priority (which is supposed to be a prompt for *everyone* interested in it)
<olokun> only 200 members, should be way more. do we have a slack channel?
<sipa> please no
<bitcoin-git> [gui] ryanofsky opened pull request #600: refactor: Add OptionsModel getOption/setOption methods (master...pr/qtopt) https://github.com/bitcoin-core/gui/pull/600
<laanwj> it's not about the quantity of people here, not really
<bitcoin-git> [gui] ryanofsky opened pull request #601: refactor: Pass interfaces::Node references to OptionsModel constructor (master...pr/qtnode) https://github.com/bitcoin-core/gui/pull/601
___nick___ has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] brunoerg opened pull request #25173: test: add coverage for unknown network in -onlynet (master...2022-05-unknown-onlynet) https://github.com/bitcoin/bitcoin/pull/25173
<bitcoin-git> [gui] ryanofsky opened pull request #602: Unify bitcoin-qt and bitcoind persistent settings #15936 (master...pr/qtsopt) https://github.com/bitcoin-core/gui/pull/602
<dongcarl> libbitcoinkernel #24410 reviewers: I would love feedback on this: https://github.com/bitcoin/bitcoin/pull/24410#issuecomment-1132161124
<gribble> https://github.com/bitcoin/bitcoin/issues/24410 | [kernel 2a/n] Split hashing/index `GetUTXOStats` codepaths, decouple from `coinstatsindex` by dongcarl · Pull Request #24410 · bitcoin/bitcoin · GitHub
<dongcarl> Many thanks in advance!
bomb-on has quit [Quit: aллилѹіа!]
AaronvanW has quit [Quit: Leaving...]
<david-bakin> clang-format, using src/.clang-format as the style - comes up with some awfully long lines. It has `ColumnLimit: 0` which is supposed to "respect the input’s line breaking decisions within statements unless they contradict other rules" - so apparently I'm contradicting other rules. Very long expressions I guess that I had manually broken up into lines. What's the preferred style
<david-bakin> for avoiding this?
jarthur has joined #bitcoin-core-dev
ronoaldo has quit [Quit: Konversation terminated!]
bomb-on has joined #bitcoin-core-dev
ronoaldo has joined #bitcoin-core-dev
nahmane has joined #bitcoin-core-dev
nahmane has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 240 seconds]
bomb-on is now known as bolito-lover
bolito-lover has quit [Quit: aллилѹіа!]
bomb-on has joined #bitcoin-core-dev
kouloumos has quit [Quit: Connection closed for inactivity]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
pk-b2 has quit [Quit: Textual IRC Client: www.textualapp.com]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
tripleslash has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
tripleslash has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
<luke-jr> MarcoFalke abuses his merge access again with #25153
<gribble> https://github.com/bitcoin/bitcoin/issues/25153 | scripted-diff: Use getInt over get_int/get_int64 by MarcoFalke · Pull Request #25153 · bitcoin/bitcoin · GitHub
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<luke-jr> or rather, I guess fanquake did it
brunoerg has quit [Ping timeout: 260 seconds]
NorrinRadd has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
NorrinRadd has quit [Client Quit]
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
NorrinRadd has joined #bitcoin-core-dev
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ajtowns opened pull request #25174: net/net_processing: Add thread safety related annotations for CNode and Peer (master...202205-net-lock-annotations) https://github.com/bitcoin/bitcoin/pull/25174
brunoerg has quit [Ping timeout: 244 seconds]
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen___ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
Kaizen_K_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
frnandu has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
frnandu has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
olokun has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]