brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
hashfunc1a22 has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
hashfunc1a22 has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
BUSY has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 246 seconds]
BUSY has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
ghost43 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<david-bakin> WUT? Consider `base_blob<BITS>::SetHex(const char* psz)` from `uint256.cpp` It wants to do a big-endian external representation to little-endian internal representation, so it starts at the end of the string and works its way to the front. This is at lines 44-45 where it advances to the end and then you can see the `--` predecrements at lines 49 and 51. However! It does this by
<david-bakin> NIBBLES not BYTES! So the hex string "5A" becomes the byte "A5". This can't be right! But it IS used in `TransactionTableModel::updateTransaction`. There is no comment describing this behavior in `uint256.h` at the decl.
<david-bakin> luke-jr, fanquake, sipa: hate to bother you, but is this the intent? are there other places where endianness is at the nibble level, not the byte level?
brunoerg has quit [Ping timeout: 272 seconds]
ghost43 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<sipa> That sounds very strange.
<david-bakin> I guess it is used in a few other places too - there are two overloads, one for string constant, other for std::string
<david-bakin> well hold on, i may have misinterpreted what was going on - it's a bit trick - hold a bit
brunoerg has quit [Ping timeout: 260 seconds]
<david-bakin> well damn me I take it back - of course now I can't explain what I'm seeing in MY test but it is obviously my problem
<david-bakin> OK I APOLOGIZE
<luke-jr> david-bakin: various historical aspects of Bitcoin do some crazy things re endian
<luke-jr> (but I don't recall that one specifically)
<david-bakin> well I have seen that! some things are, when turned into hex strings, "backwards" from others - endianness in external representation is not uniform. but I think this was my brain damage.
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
<david-bakin> I outsmarted myself by cleverly choosing a test data set that was nearly palindromic ... but not quite ... well, live and learn SOME BAD IDEAS I guess, sorry!
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] aureleoules opened pull request #25183: rpc: Witness-only inputs for fundrawtransaction (master...2022-05-witness-only-fundrawtransaction) https://github.com/bitcoin/bitcoin/pull/25183
bitdex has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
Kaizen_K_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Common_ has joined #bitcoin-core-dev
dongcarl has quit [Quit: Ping timeout (120 seconds)]
dongcarl has joined #bitcoin-core-dev
common has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_K_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
ronoaldo has quit [Remote host closed the connection]
sudoforge has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
baldur has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
brunoerg has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
z9z0b3t1c has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
baldur has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 244 seconds]
kexkey has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
kouloumos has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Talkless has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
dougefish has quit [Quit: dougefish]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
dougefish has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ubba has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
olokun has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] mruddy closed pull request #24912: refactor: update CBlockIndex::nChainTx to be uint64_t (master...nchaintx_type) https://github.com/bitcoin/bitcoin/pull/24912
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
olokun has quit [Quit: Leaving]
x88x88x has quit [Quit: ZNC - https://znc.in]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
x88x88x has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
Guest71 has joined #bitcoin-core-dev
Guest71 has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
aleggg has quit [Ping timeout: 246 seconds]
aleggg has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
sudoforge has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
csknk has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
bitdex has quit [Quit: = ""]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guyver2 has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
csknk has quit [Ping timeout: 246 seconds]
bomb-on has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
<bitcoin-git> [gui] hebasto closed pull request #592: Drop wildcard support for address/label search in `AddressBookPage` (master...220423-wildcard) https://github.com/bitcoin-core/gui/pull/592
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
Kaizen_K_ has quit [Ping timeout: 246 seconds]
bitdex has quit [Ping timeout: 240 seconds]
sipsorcery has quit [Ping timeout: 260 seconds]
bomb-on has quit [Read error: Connection reset by peer]
bomb-on has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
MarcoFalke has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
MarcoFalke has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
MacroFake has joined #bitcoin-core-dev
<MacroFake> ping test
<b10c> pong
<MacroFake> sehr gut
bitdex has quit [Ping timeout: 240 seconds]
jarthur has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
sipsorcery has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
ubba has quit [Quit: Connection closed for inactivity]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guest3560 has joined #bitcoin-core-dev
Guest3560 has quit [Client Quit]
aleggg has quit [Ping timeout: 246 seconds]
kouloumos has quit []
kouloumos has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] Empact opened pull request #25184: refactor: Remove defunct attributes.h includes (master...2022-05-attributes-include) https://github.com/bitcoin/bitcoin/pull/25184
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
kexkey has quit [Ping timeout: 246 seconds]
Talkless has quit [Quit: Konversation terminated!]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
z9z0b3t1c has joined #bitcoin-core-dev
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kouloumos has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
noxx has joined #bitcoin-core-dev
noxx has quit [Quit: Leaving]
sipsorcery has joined #bitcoin-core-dev
<pinheadmz_> These comments "...after removing optional annex": https://github.com/bitcoin/bitcoin/blob/master/src/policy/policy.cpp#L260
<pinheadmz_> we dont really drop the annex anymore:
<pinheadmz_> but the stack size checks are still the same right? we just return false right away if there's an annex
brunoerg has joined #bitcoin-core-dev
theStack has quit [Quit: theStack]
brunoerg has quit [Ping timeout: 240 seconds]
sipsorcery has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
theStack has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
gossie has quit [Ping timeout: 250 seconds]
gossie has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]