brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<luke-jr> dongcarl: afaik, doing -> on a nullptr is always UB
jesseposner has quit [Quit: Textual IRC Client: www.textualapp.com]
brunoerg has joined #bitcoin-core-dev
<jamesob> dongcarl: it's a trick for allowing that annotation to work with nullable locks; it just doesn't enforce anything if there's no lock. See https://github.com/bitcoin/bitcoin/pull/22415#issuecomment-875999127
<dongcarl> Ah!
<dongcarl> Okay cool
<bitcoin-git> [bitcoin] brunoerg opened pull request #25220: rpc: fix incorrect warning for address type p2sh-segwit in createmultisig (master...2022-05-fix-incorrect-warning-createmultisig) https://github.com/bitcoin/bitcoin/pull/25220
brunoerg has quit [Remote host closed the connection]
<jamesob> dongcarl: predictably it boils down to patented ryanofsky cpp wizardry
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
earnestly has quit [Ping timeout: 260 seconds]
<luke-jr> laanwj: v23.0 rel notes don't have the changelog?
evanlinjin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
evanlinjin_ has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
evanlinjin_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
jesseposner has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
z9z0b3t1c has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
yanmaani3 has quit [Remote host closed the connection]
yanmaani3 has joined #bitcoin-core-dev
jtraub91 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jtraub91 has quit [Client Quit]
jtraub91 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
bairen has quit [Ping timeout: 240 seconds]
bairen has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] antoinedesbois opened pull request #25221: Improve CMedianFilter algorithm (master...timedata_bench) https://github.com/bitcoin/bitcoin/pull/25221
Guest52 has joined #bitcoin-core-dev
Guest52 has quit [Client Quit]
vysn has joined #bitcoin-core-dev
<jonatack> jamesob: nice! noting that
brunoerg has quit [Ping timeout: 260 seconds]
Lightsword has quit [Quit: ZNC]
Lightsword has joined #bitcoin-core-dev
<laanwj> luke-jr: correct
<laanwj> achow101: is there any way we can check/review #25201, besides just believing it and merging it :)
<gribble> https://github.com/bitcoin/bitcoin/issues/25201 | windeploy: Renewed windows code signing certificate by achow101 · Pull Request #25201 · bitcoin/bitcoin · GitHub
Lightsword has quit [Quit: ZNC]
Lightsword has joined #bitcoin-core-dev
Guest71 has joined #bitcoin-core-dev
Guest71 has quit [Client Quit]
cryptoquick has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
<luke-jr> laanwj: is that intentional? (I see it's a pain..)
brunoerg has joined #bitcoin-core-dev
PaperSwordAlt has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 240 seconds]
<laanwj> luke-jr: it's intentional in the sense that i didn't get around to doing it, i'm also not sure if it's worth the trouble (it's easy enough to get a list of merges/PRs, the time intensive is sorting them into categories), fwiw you seem to be only the second person to mention it at all
jarthur has quit [Quit: jarthur]
Lightsword has quit [Quit: ZNC]
Lightsword has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 255 seconds]
Guest71 has joined #bitcoin-core-dev
Guest71 has quit [Client Quit]
evanlinjin_ has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
Guest71 has joined #bitcoin-core-dev
Guest71 has quit [Client Quit]
brunoerg has quit [Ping timeout: 255 seconds]
evanlinjin_ has quit [Remote host closed the connection]
evanlinjin_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<laanwj> a lot of PRs only indirectly affect end users, and the ones that do directly affect user experience already require explicit mention in the release notes
brunoerg has joined #bitcoin-core-dev
evanlinjin_ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
<luke-jr> I suppose anyone who actually cares, can always just `git log`
<laanwj> right
<laanwj> e.g. "git log --merges --pretty=format:'%s' --abbrev-commit --reverse v22.0..v23.0" gets very close (there's some spurious lines due to subtree merges which could still be filtered out)
<laanwj> eh --abrev-commit is unneeded
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
jtraub91 has quit [Ping timeout: 246 seconds]
kouloumos has joined #bitcoin-core-dev
Aaronvan_ has quit [Quit: Leaving...]
agentcasey has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
PaperSwordAlt has quit [Ping timeout: 258 seconds]
common has joined #bitcoin-core-dev
Common_ has quit [Ping timeout: 272 seconds]
PaperSwordAlt has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
common has quit [Ping timeout: 240 seconds]
DavidBakin has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
david-bakin has quit [Ping timeout: 255 seconds]
z9z0b3t1c has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 255 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
bitdex has quit [Quit: = ""]
evanlinjin_ has joined #bitcoin-core-dev
<bitcoin-git> [gui] hebasto opened pull request #607: refactor: Skip manual signal disconnection in descructors (master...220526-handler) https://github.com/bitcoin-core/gui/pull/607
<achow101> laanwj: I could sign a message with the key?
<achow101> and sign one with the old one?
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/192d639a6b1b...cacbdbaa9531
<bitcoin-git> bitcoin/master bd7c5e2 David Bakin: Add BIP-341 specified constraints to `ComputeTaprootMerkleRoot`
<bitcoin-git> bitcoin/master cacbdba laanwj: Merge bitcoin/bitcoin#25132: consensus: Add BIP-341 specified constraints ...
<bitcoin-git> [bitcoin] laanwj merged pull request #25132: consensus: Add BIP-341 specified constraints in `ComputeTaprootMerkleRoot` (master...compute-taproot-merkle-root-asserts) https://github.com/bitcoin/bitcoin/pull/25132
<laanwj> achow101: yes, if that's not too much work
<laanwj> so the 'windows certificate' is a standard format certificate that can be check by openssl etc?
furszy has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/cacbdbaa9531...4901631dac6a
<bitcoin-git> bitcoin/master bd971bf laanwj: logging: Unconditionally log levels >= WARN
<bitcoin-git> bitcoin/master 18ec120 laanwj: http: Use severity-based logging for messages from libevent
<bitcoin-git> bitcoin/master ce92071 laanwj: leveldb: Log messages from leveldb with category and debug level
<bitcoin-git> [bitcoin] laanwj merged pull request #25202: log: Use severity-based logging for leveldb/libevent messages, reverse LogPrintLevel order (master...2022-05-logging-improved) https://github.com/bitcoin/bitcoin/pull/25202
furszy has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4901631dac6a...c324b07a541a
<bitcoin-git> bitcoin/master be6d431 James O'Beirne: doc: remove misleading AreInputsStandard() comment
<bitcoin-git> bitcoin/master c324b07 laanwj: Merge bitcoin/bitcoin#25210: doc: remove misleading AreInputsStandard() co...
<bitcoin-git> [bitcoin] laanwj merged pull request #25210: doc: remove misleading AreInputsStandard() comment (master...2022-05-areinputsstandard-comment) https://github.com/bitcoin/bitcoin/pull/25210
furszy has joined #bitcoin-core-dev
evanlinjin_ has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c324b07a541a...48eec3234749
<bitcoin-git> bitcoin/master 43ff37f mutatrum: Update zmq.md: Fix parameter in hwm example block
<bitcoin-git> bitcoin/master 48eec32 laanwj: Merge bitcoin/bitcoin#25216: Doc: Fix parameter in hwm example block
<bitcoin-git> [bitcoin] laanwj merged pull request #25216: Doc: Fix parameter in hwm example block (master...patch-1) https://github.com/bitcoin/bitcoin/pull/25216
evanlinjin_ has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 258 seconds]
PaperSwordAlt has quit [Ping timeout: 246 seconds]
yanmaani3 has quit [Remote host closed the connection]
yanmaani3 has joined #bitcoin-core-dev
<achow101> laanwj: yes, it's x509
<achow101> you can use openssl x509 to inspect it
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25222: refactor: Pass reference to LookUpStats (master...2205-ref-stat-😶) https://github.com/bitcoin/bitcoin/pull/25222
sipsorcery has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/48eec3234749...2642dee1364d
<bitcoin-git> bitcoin/master 0e55bc6 Ryan Ofsky: settings: Add update/getPersistent/isIgnored methods
<bitcoin-git> bitcoin/master 77fabff Ryan Ofsky: init: Remove Shutdown() node.args reset
<bitcoin-git> bitcoin/master f9fdcec Ryan Ofsky: settings: Add resetSettings() method
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #15936: interfaces: Expose settings.json methods to GUI (master...pr/qtset) https://github.com/bitcoin/bitcoin/pull/15936
sipsorcery has joined #bitcoin-core-dev
Nekorand has joined #bitcoin-core-dev
<hebasto> \o/
furszy has quit [Remote host closed the connection]
<jonatack> congrats ryanofsky!
<ryanofsky> Thanks! Will update the GUI side of this change
Nekorand has quit [Quit: Leaving]
evanlinjin_ has quit [Ping timeout: 240 seconds]
jetpack_ has quit [Ping timeout: 248 seconds]
jetpack has joined #bitcoin-core-dev
<bitcoin-git> [gui] hebasto closed pull request #435: Move third-party tx URL setting from Display to Wallet options tab (master...move-3partytx-setting) https://github.com/bitcoin-core/gui/pull/435
jesseposner has quit [Quit: Textual IRC Client: www.textualapp.com]
jesseposner has joined #bitcoin-core-dev
<bitcoin-git> [gui] hebasto closed pull request #484: Don't clear traffic graph when changing interval (master...RetainNetworkGraphOnIntervalChange) https://github.com/bitcoin-core/gui/pull/484
mudsip has joined #bitcoin-core-dev
mudsip has quit []
jarthur has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
<bitcoin-git> [gui] hebasto closed pull request #492: Show ToolTip on Network Traffic graph (master...NetworkGraphTooltip) https://github.com/bitcoin-core/gui/pull/492
sipsorcery has joined #bitcoin-core-dev
Guest22 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 258 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
Guest22 has quit [Quit: Client closed]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2642dee1364d...a0e8aff6051b
<bitcoin-git> bitcoin/master 6b63673 Sebastian Falbesoner: tracing: fix `coin_selection:aps_create_tx_internal` calling logic
<bitcoin-git> bitcoin/master a0e8aff Andrew Chow: Merge bitcoin/bitcoin#25003: tracing: fix `coin_selection:aps_create_tx_in...
<bitcoin-git> [bitcoin] achow101 merged pull request #25003: tracing: fix `coin_selection:aps_create_tx_internal` calling logic (master...202204-tracing_fix_coin_selection-aps_create_tx_internal_log) https://github.com/bitcoin/bitcoin/pull/25003
Kaizen_Kintsugi_ has quit [Ping timeout: 258 seconds]
<bitcoin-git> [bitcoin] dongcarl opened pull request #25223: miner: Make `mempool` optional, stop constructing temporary empty mempools (master...2022-05-kernelargs-mempool-miner) https://github.com/bitcoin/bitcoin/pull/25223
Talkless has joined #bitcoin-core-dev
aigoo has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a0e8aff6051b...c5e67be03bb0
<bitcoin-git> bitcoin/master c4c5b9c Anthony Towns: consensus/params: set default values for BIP9Deployment
<bitcoin-git> bitcoin/master c5e67be laanwj: Merge bitcoin/bitcoin#24032: Add defaults to vDeployments to avoid uniniti...
<bitcoin-git> [bitcoin] laanwj merged pull request #24032: Add defaults to vDeployments to avoid uninitialized variables (master...202112-deployments) https://github.com/bitcoin/bitcoin/pull/24032
jtraub91 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
<luke-jr> laanwj: achow101: at the end of the day, it's not like we're trusting the signing key - it could be any key really
<laanwj> luke-jr: true, i just like to do some sanity checks before merging something
<laanwj> it was just this base64 encoded blob :)
<laanwj> #startmeeting
___nick___ has joined #bitcoin-core-dev
<laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard b10c BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj larryruane lightlike luke-jr maaku marcofalke meshcollider michagogo
<laanwj> moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
<kanzure> hi
<kvaciral> hi
<sipa> hi
<luke-jr> hi
<laanwj> welcome to the weekly bitcoin-core-dev IRC meeting
<laanwj> there have been no topics proposed in advance (you can propose meeting topics with #proposedmeetingtopic <topic> during any time of the week)
<laanwj> any last minute ones?
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Client Quit]
Guest16 has joined #bitcoin-core-dev
<Murch> hi
<laanwj> ok let's start with the usual
<laanwj> #topic High priority for review
<laanwj> 8 blockers, 2 chasing concept ACK in https://github.com/bitcoin/bitcoin/projects/8 currently
<laanwj> does anyone want to add, or remove anything?
<_aj_> thanks laanwj :)
Guest19 has joined #bitcoin-core-dev
<laanwj> i guess we should add the next inststallment of bitcoin kernel
<laanwj> #25065 added
<gribble> https://github.com/bitcoin/bitcoin/issues/25065 | [kernel 2c/n] Introduce `kernel::Context`, encapsulate global init/teardown by dongcarl · Pull Request #25065 · bitcoin/bitcoin · GitHub
<jonatack> hi
<dongcarl> hi
<dongcarl> Just to be clear none of the [kernel 2*/n] PRs depend on each other, but yes 2c is the highest priority one
<dongcarl> laanwj: Thanks!
Guest19 has quit [Client Quit]
d has joined #bitcoin-core-dev
<laanwj> i assumed so, but, let's try to keep it to one PR per person :)
<jeremyrubin> instagibbs asked on Twitter if the naming scheme means something
d is now known as Guest7661
<dongcarl> laanwj: Oh of course :-)
<dongcarl> jeremyrubin: Not committing to a meaning just yet :-)
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guest16 has quit [Quit: Client closed]
<jeremyrubin> So just unique ids for now
<dongcarl> Well... none of the [kernel 2*/n] PRs depend on each other, but if I open a [kernel 3*/n] it might depend on some of the [kernel 2*/n] PRs
<laanwj> at least they're sequential and not randomly generated UUIDs
<dongcarl> lol, shoulda used emojis
<laanwj> yess
<jeremyrubin> Ah that makes more sense now. multi level modularization
<luke-jr> dongcarl: like marcofalke
<laanwj> onion skin dependency ordering
<luke-jr> I no longer check out Marco's branches by name, just origin-pull :P
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
<laanwj> any other topics?
<laanwj> that concludes the meeting for this week, bye
<laanwj> #endmeeting
Guest7661 has quit [Quit: Client closed]
<laanwj> core-meetingbot is so silent today
<laanwj> i think it's unable to speak here because it's not logged into nickserv
<_aj_> seems likely
Talkless has quit [Quit: Konversation terminated!]
vysn has quit [Ping timeout: 255 seconds]
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
aigoo has left #bitcoin-core-dev [#bitcoin-core-dev]
aigoo has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
sipsorcery has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 258 seconds]
dffgfdggf has joined #bitcoin-core-dev
dffgfdggf has left #bitcoin-core-dev [#bitcoin-core-dev]
<jamesob> mempool question: how could we hit the RBF #5 case (don't replace a tx that would evict more than 100 mempool entries) without first hitting the 25 descendants limit case? Isn't #5 subsumed by the descendant count limit?
<gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/5 | Make the version number the protocol version and not the client version · Issue #5 · bitcoin/bitcoin · GitHub
z9z0b3t1c has quit [Remote host closed the connection]
z9z0b3t1c has joined #bitcoin-core-dev
<jamesob> oh nevermind, I see...
<_aj_> jamesob: (maybe explain it anyway for anyone googling the same question in future?)
<instagibbs> you can replace more than one package at a time, e.g. 4 packages of 25 each by double spending one input from each
<instagibbs> (hi future person)
AaronvanW has joined #bitcoin-core-dev
kouloumos has quit [Quit: Connection closed for inactivity]
vysn has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 258 seconds]
vysn has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
earnestly has quit [Read error: Connection reset by peer]
jtraub91 is now known as bitcoinboi
AaronvanW has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
sipsorcery has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
mudsip has quit []
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
AaronvanW has quit [Ping timeout: 276 seconds]
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]