<bitcoin-git>
[bitcoin] mzumsande opened pull request #25237: rpc: Capture UniValue by ref for rpcdoccheck (master...202205_rpcdoc_capture) https://github.com/bitcoin/bitcoin/pull/25237
Guyver2 has left #bitcoin-core-dev [Closing Window]
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
evanlinjin_ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
ronoaldo has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 256 seconds]
<bitcoin-git>
[gui] hebasto opened pull request #608: qt, wallet, refactor: Make `WalletModel::sendCoins()` return `void` (master...220529-sendcoins) https://github.com/bitcoin-core/gui/pull/608
brunoerg has quit [Ping timeout: 255 seconds]
sipsorcery has quit [Ping timeout: 258 seconds]
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
<bitcoin-git>
[gui] hebasto opened pull request #609: qt, wallet, refactor: Drop unused `WalletModel::PaymentRequestExpired` (master...220529-expired) https://github.com/bitcoin-core/gui/pull/609
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
div72 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] kristapsk opened pull request #25238: script: Disable SC1004 check in `contrib/devtools/gen-bitcoin-conf.sh` (master...shellcheck-disable=SC1004) https://github.com/bitcoin/bitcoin/pull/25238
yanmaani3 has quit [Ping timeout: 240 seconds]
yanmaani3 has joined #bitcoin-core-dev
<div72>
ec_seckey_import_der in src/key.cpp rejects valid private keys according to the linked spec. It assumes the encoded private keys to be <127 characters and tries to parse the length field as a multi-byte even though the a 38-byte encoded key would also be valid according to the spec and would only take a single byte to encode the length.
<div72>
This bit my bottom today as OpenSSL encoded a key as 86 bytes and it's length field as a single byte and the code refused to parse it on another project. I already made a patch for myself, should I make a PR for this or since nobody else has encountered this for the 7 years this function has existed it's a no go?
<bitcoin-git>
[bitcoin] furszy opened pull request #25239: wallet: 'CommitTransaction', remove extra wtx lookup and add exception for db write error (master...2022_wallet_CommitTransaction_extra_lookup) https://github.com/bitcoin/bitcoin/pull/25239
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]