< bitcoin-git> [bitcoin] willyko opened pull request #17671: Fixed typo in gitian-build.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17671
< bitcoin-git> [bitcoin] practicalswift closed pull request #17666: random: Add missing thread-safety annotations for events_hasher (master...GUARDED_BY(events_mutex)) https://github.com/bitcoin/bitcoin/pull/17666
< bitcoin-git> [bitcoin] laanwj closed pull request #17312: Improve tracethread usability and trace loadblk thread (master...2019_10_tracedthread) https://github.com/bitcoin/bitcoin/pull/17312
< bitcoin-git> [bitcoin] practicalswift opened pull request #17674: tests: Add initialization order fiasco detection in Travis (master...initialization-order-fiasco) https://github.com/bitcoin/bitcoin/pull/17674
< bitcoin-git> [bitcoin] brakmic closed pull request #17623: rpc: add extensive file checks for dumptxoutset and dumpwallet (master...checks-for-dump-functions) https://github.com/bitcoin/bitcoin/pull/17623
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5aee0e2163cc...6fff333c9f00
< bitcoin-git> bitcoin/master 461e547 fanquake: doc: correct random.h docs after #17270
< bitcoin-git> bitcoin/master 55b2cb1 fanquake: random: mark RandAddPeriodic and SeedPeriodic as noexcept
< bitcoin-git> bitcoin/master 6fff333 Wladimir J. van der Laan: Merge #17507: random: mark RandAddPeriodic and SeedPeriodic as noexcept
< bitcoin-git> [bitcoin] laanwj merged pull request #17507: random: mark RandAddPeriodic and SeedPeriodic as noexcept (master...random_followups) https://github.com/bitcoin/bitcoin/pull/17507
< bitcoin-git> [bitcoin] practicalswift opened pull request #17675: tests: Annotate functional tests supporting bitcoin-cli (--usecli) as such (master...dash-dash-usecli) https://github.com/bitcoin/bitcoin/pull/17675
< bitcoin-git> [bitcoin] fanquake opened pull request #17676: depends: don't use OpenGL in Qt on macOS (master...macos_no_opengl) https://github.com/bitcoin/bitcoin/pull/17676
< emilengler> How do I propose a meeting topic? With "<#> proposedmeetingtopic <TOPIC> "?
< bitcoin-git> [bitcoin] practicalswift closed pull request #17051: tests: Add deserialization fuzzing harnesses (master...fuzzers-deserialize) https://github.com/bitcoin/bitcoin/pull/17051
< emilengler> #proposedmeetingtopic GUI CLI Arg test framework
< jamesob> is AppVeyor just barfing on every PR now?
< instagibbs> i havent seen it work in a while :shrug:
< jamesob> it's discouraging to think that #16945 probably just would've sailed through review if I hadn't bothered to add a unittest
< gribble> https://github.com/bitcoin/bitcoin/issues/16945 | refactor: introduce CChainState::GetCoinsCacheSizeState by jamesob . Pull Request #16945 . bitcoin/bitcoin . GitHub
< emilengler> When are the meetings still? 19:00 UTC?
< instagibbs> 1.5 hours from now it seems
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17678: depends: Support for S390X and POWER targets (master...1912-dependsNewTargets) https://github.com/bitcoin/bitcoin/pull/17678
< fanquake> jamesob Windows builds were broken by recent RNG changes, so appveyor is failing for all PRs atm.
< sipa> i rebased #17670 which should fix the RNG thing
< gribble> https://github.com/bitcoin/bitcoin/issues/17670 | Move events_hasher into RNGState() by sipa . Pull Request #17670 . bitcoin/bitcoin . GitHub
< jamesob> ah thanks fanquake sipa
< dongcarl> The "cache=" thing in UpdateTip messages correspond to the dbcache value right? As in, the dbcache flag value is what limits it?
< wumpus> the utxo cache is *part* of the dbcache
< dongcarl> wumpus: Ah so the "cache=" thing is the utxo cache then?
< wumpus> unused mempool space is also added to it; you can find the exact values in the log "Using ... MiB for in-memory UTXO set"
< wumpus> yes
< dongcarl> Not sure how others feel, but the cache= being in mebibytes and the dbcache flag being in megabytes is a little confusing
< wumpus> bah, I don't feel like that discussion :)
< dongcarl> Oh it seems hebasto already fixed it
< wumpus> great
< fanquake> 1x less thing to bike shed
< wumpus> #startmeeting
< lightningbot> Meeting started Thu Dec 5 19:00:45 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< emilengler> Hi
< fanquake> hi
< achow101> hi
< instagibbs> hi
< gleb> Hi
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< wumpus> jeremyrubin lightlike emilengler jonatack
< fjahr> Hi
< moneyball> hi
< meshcollider> hi
< warren> hi
< jamesob> hi
< sipa> hi
< wumpus> one proposed topic today in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a : GUI CLI Arg test framework
< fanquake> Is that name list growing? Bunch of names I don't recognise
< digi_james> Hi
< wumpus> it's always growing
< wumpus> I tend to add everyone that has ever said anything in a meeting
< emilengler> Lol
< fanquake> append only
< jonatack> hi
< warren> short proposed topic: announcement of the new mailing list host, new process if you want new dev or announce lists
< jamesob> "short"
< wumpus> thanks, let's start with the usual
< emilengler> Ok
< wumpus> #topic High priority for review
< wumpus> https://github.com/bitcoin/bitcoin/projects/8 8 blockers, 6 chasing concept ACK
< gleb> I want to add #16702 if that's possible.
< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< kanzure> hi
< nehan> [19:02:05] < wumpus> one proposed topic today in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a : GUI CLI Arg test framework
< nehan> (oops, sorry). also hi
< wumpus> hi!
< emilengler> Yeah I wanna talk about my proposed topic there^^
< emilengler> Would cover it now if it would be possible
< instagibbs> #17621 is a fix for the avoid_reuse leak, at least looking for concept ACKs
< gribble> https://github.com/bitcoin/bitcoin/issues/17621 | IsUsedDestination should count any known single-key address by instagibbs . Pull Request #17621 . bitcoin/bitcoin . GitHub
< instagibbs> (already on list)
< wumpus> added 16702
< wumpus> instagibbs: should it be under "chasing concept ACK" then instead of blockers?
< instagibbs> yeah actually
< gleb> Thank you!
< fanquake> Doesn't need to go on the list, but #17663 is going to be the base of a bunch of other PRs, if build system people want to take a look.
< gribble> https://github.com/bitcoin/bitcoin/issues/17663 | build: pass -dead_strip_dylibs to ld on macOS by fanquake . Pull Request #17663 . bitcoin/bitcoin . GitHub
< wumpus> escalating ever scarier linker argument names
< jamesob> hah
< fanquake> -Wl,-why_live has been getting some use today as well heh
< digi_james> lol
< wumpus> heh
< wumpus> #topic GUI CLI Arg test framework (emilengler)
< emilengler> Yes so let me first talk about it
< emilengler> I made a PR a few day ago "Add -guisettings" (Can someone post the id? I'm on my phone). Tests were suggested for it because it adds a cli paramter
< instagibbs> #17636
< emilengler> And there are Qt only cli parameters. I was wondering if it would be worth writing a test framework for qt args as well
< gribble> https://github.com/bitcoin/bitcoin/issues/17636 | qt: Add -guisettings option by emilengler . Pull Request #17636 . bitcoin/bitcoin . GitHub
< emilengler> If it is possile to test then
< emilengler> instagibbs: thanks
< wumpus> why is this a question? isn't testing things always good? what's the small print?
< emilengler> wumpus: Good question but it would be some effort und probably a bit maintaince as well and I don't know if it is actually worth to make a new framework (or heavily extend the current one) just for one extra parameter
< wumpus> I guess GUI things are hard to test in general
< sipa> well what would it be testing?
< wumpus> like 'does the window start minimized' is not that easy to measure
< sipa> right
< emilengler> sipa: It would test if a file is created
< sipa> that sounds easy
< sipa> probably doesn't need much of a "framework" at all
< fanquake> ryanofsky would like to know your thoughts if you are here
< wumpus> that's just anbother functional test riight
< fanquake> Given you are doing the settings refactoring
< emilengler> wumpus: Maybe we could add an extra qt parameter which makes some stdout. This is then getting parsed
< emilengler> wumpus: IIRC the current functional test framework is bitcoind only
< wumpus> anyhow, yes, testing GUI arguments would be nice, some are more realitic for automatic testing than others
< emilengler> Yes, things like -splash are probably impossible to test
< wumpus> you can run the currrent functional tests w/ bitcoin-qt
< wumpus> but yes, that one would be bitcoin-qt only
< emilengler> Ok still thanks for the clarification :). Things I wanted to say are done. Someone wants to say something about it?
< emilengler> Otherwise this topic would be done
< wumpus> let's go to warren's topic then
< sipa> emilengler: i don't know what exactly you're asking
< wumpus> #topic announcement of the new mailing list host (warren)
< warren> I must express apologies for the unexpected timing of transition of lists.linuxfoundation.org to a new host. Dealing with this for the past years has been stressful, evaluated alternatives were all found to have drawbacks and communications between parties has been slow. Oddly enough by not changing we ended up with the best outcome. After a brief service disruption due to misconfiguration the lists were back online later that day. End
< warren> result:
< warren> - No change to list addresses or archive URL's.
< warren> - The new host is cooperative, communicative and will properly maintain the mailing list server.
< warren> - New dev or announce lists can now be requested. For example bitcoin-knots-announce was created. I will put a policy on a webpage somewhere but it will be roughly: "This list server is for only FOSS and strongly preferred to be pertaining to open common infrastructure, specifications or standards. If you want lists for a niche or commercial project you probably should instead use Google Groups or something."
< warren> I must thank the Linux Foundation for years of politically neutral hosting of dev lists, and now the Oregon State University Open Source Lab (OSUOSL) for continued vendor neutral hosting. The OSUOSL is well known since the early 2000's for infrastructure support for thousands of Open Source projects.
< warren> fin
< warren> next
< warren> unless people have questions, but this isn't really a dev topic so just FYI
< jamesob> thanks warren!
< sipa> thanks for the update
< emilengler> Thanks
< sipa> and for all the time it took to get there :)
< wumpus> thanks warren!
< wumpus> there was some talk of changing the bitcoin-core-dev mailing list to an announcement list
< wumpus> as, effectively, that's what it is
< sipa> is anyone on it?
< wumpus> I have no idea, if not, I can stop doing announcements there
< warren> I suppose that's a simple change. Also consider if dev would like special interest group dev lists or other announce lists.
< sipa> i think for non-mailinglist aliases we can use @bitcoincore.org fine
< warren> wumpus: I can ask for subscriber statistics, in any case it's helpful to keep posting to the same place because the archives are in a well known location that won't change anytime soon
< wumpus> there was vaguely some interest in it as announcement list, let me see if I can find the bitcoincore.org PR
< warren> In past years the mailing list host was not cooperative, that's different now so we can make changes like this.
< wumpus> at the least, we don't need a discussion mailing list for bitcoinc core, but a mailer for version and RC announcements is useful
< wumpus> (as well as archive)
< warren> one consideration is the archive URL is well known and linked from elsewhere so we'd need redirects if it renames
< wumpus> cool :)
< wumpus> we can discuss that outside the meeting
< wumpus> any other topics?
< jonatack> thanks warren. OSUOSL appears to be a great choice.
< ariard> hey can I get #16426 on hp?
< gribble> https://github.com/bitcoin/bitcoin/issues/16426 | Reverse cs_main, cs_wallet lock order and reduce cs_main locking by ariard . Pull Request #16426 . bitcoin/bitcoin . GitHub
< wumpus> ariard: you're too late !
< wumpus> no, ofc
< ariard> wumpus: sorry wasn't there
< ariard> it might be a slight IBD improvement
< emilengler> FYI: This was discussed in the PR club yesterday iirc
< wumpus> ariard: blockers or chasing concept?
< ariard> due to not locking cs_main in BlockConnected/BlockDisconnected
< ariard> it's ready it pass all tests
< ariard> and got already a lot of concept acks
< ariard> hard commit is only the top one, because you need to invert lock order at once
< wumpus> ok added
< ariard> but I can still split the PR if people feel it's too much at once
< wumpus> (to blockers, then)
< ariard> thnaks
< wumpus> that concludes the meeting, I think
< wumpus> #endmeeting
< lightningbot> Meeting ended Thu Dec 5 19:25:11 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< emilengler> Thanks you!
< sipa> so, did anyone ever try running test_running with BITCOIND=.../src/qt/bitcoin-qt ?
< sipa> it's... very hollywood
< jonatack> For anyone interested in PR #16702, it will the topic of next week's PR Review Club session, Wednesday 11 December at 1800 UTC
< gribble> https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< instagibbs> sipa, welcome to cyber
< sipa> only 10 tests fail
< sipa> i'm surprised it works that well at all
< sipa> i did have to click a way a few dozen pop-up error messages
< elichai2> Lol that sounds funny. I'll try that too :)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fff333c9f00...910a4301b170
< bitcoin-git> bitcoin/master dddd09e MarcoFalke: test: Wait until mempool is loaded in wallet_abandonconflict
< bitcoin-git> bitcoin/master 910a430 MarcoFalke: Merge #17522: test: Wait until mempool is loaded in wallet_abandonconflict...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17522: test: Wait until mempool is loaded in wallet_abandonconflict (master...1911-testMempoolLoaded) https://github.com/bitcoin/bitcoin/pull/17522
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/910a4301b170...5d0b7f9e3d20
< bitcoin-git> bitcoin/master 8bda096 Pieter Wuille: Move events_hasher into RNGState()
< bitcoin-git> bitcoin/master 5d0b7f9 MarcoFalke: Merge #17670: Move events_hasher into RNGState()
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17670: Move events_hasher into RNGState() (master...201912_events_rngstate) https://github.com/bitcoin/bitcoin/pull/17670
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5d0b7f9e3d20...cf43f3f0a8ff
< bitcoin-git> bitcoin/master 1f9d5af practicalswift: tests: Add initialization order fiasco detection in Travis
< bitcoin-git> bitcoin/master cf43f3f MarcoFalke: Merge #17674: tests: Add initialization order fiasco detection in Travis
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17674: tests: Add initialization order fiasco detection in Travis (master...initialization-order-fiasco) https://github.com/bitcoin/bitcoin/pull/17674
< bitcoin-git> [bitcoin] willyko opened pull request #17680: gitian: fixed SC2001 regex (master...patch-2) https://github.com/bitcoin/bitcoin/pull/17680
< bitcoin-git> [bitcoin] achow101 opened pull request #17681: wallet: Keep inactive seeds after sethdseed and derive keys from them as needed (master...keep-inactive-seeds) https://github.com/bitcoin/bitcoin/pull/17681
< bitcoin-git> [bitcoin] hebasto closed pull request #17600: qt: Remove connection for unused accepted() signal in ReceiveRequestDialog (master...20191125-unused-connection) https://github.com/bitcoin/bitcoin/pull/17600