< elichai2> do you also have a script for linux? (not sure if I prefer local or vm) so I could just do `PR=15345 vagrant test linux` and it will compile&run locally all the unit and functional tests
< fanquake> elichai2 for Linux VMs? I've been using Docker for that https://github.com/fanquake/core-review/blob/master/docker/README.md
< fanquake> Although you could add Linux boxes to the vagrant file easily enough
< wumpus> ariard: elichai2:good point on -maxtipage,that should work too
< wumpus> although that will change the node's global perception of whether it's in IBD so may have some other consequences too (not sure)
< elichai2> ariard: wumpus Thanks! jamesob also told me about it. i'll try next time, for now I left it to sync to solve that heh
< elichai2> I still think an RPC command that can do it *while running* is nice
< wumpus> I think that's possible with the whitelist (HasPermission)
< wumpus> it would be good to write a guide on how to do this kind of benchmarking some day
< wumpus> I think many people have tried and run against the same issues over time and solved them in different ways but never documented it*shrug*
< bitcoin-git> [bitcoin] instagibbs opened pull request #17775: DecodeHexTx: Try case where txn has inputs first (master...decode_wit_first) https://github.com/bitcoin/bitcoin/pull/17775
< elichai2> wumpus: are there any benchmakrs for the changes in CRC32C in the new leveldb? it seems to be quite significant.
< fanquake> you could ask james to benchmark something specific https://github.com/bitcoin/bitcoin/pull/17398#issuecomment-556038507
< elichai2> fanquake: I want to benchmark the CRC32C specifically. maybe i'll isolate it. I just finished a profile with Intel VTune on full IBD with a local node on prune=550, still going through the data but it looks like `leveldb::port::AcceleratedCRC32C` is pretty high up there
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fef85bfa3cd...7f9fbb89e82f
< bitcoin-git> bitcoin/master 4f4ae6f fanquake: build: set AC_PREREQ to 2.69
< bitcoin-git> bitcoin/master 7f9fbb8 fanquake: Merge #17769: build: set AC_PREREQ to 2.69
< bitcoin-git> [bitcoin] fanquake merged pull request #17769: build: set AC_PREREQ to 2.69 (master...set_ac_prereq_264) https://github.com/bitcoin/bitcoin/pull/17769
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f9fbb89e82f...3e949380725c
< bitcoin-git> bitcoin/master 34d826e Emil Engler: doc: Mention PR Club in CONTRIBUTING.md
< bitcoin-git> bitcoin/master 3e94938 MarcoFalke: Merge #17772: doc: Mention PR Club in CONTRIBUTING.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17772: doc: Mention PR Club in CONTRIBUTING.md (master...2019-12-pr-club) https://github.com/bitcoin/bitcoin/pull/17772
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17773: test: Properly deserialize witness transactions in wallet_basic test (master...1912-testWalletVsizeWitness) https://github.com/bitcoin/bitcoin/pull/17773
< elichai2> luke-jr: Google is really angry about your site: http://luke.dashjr.org/programs/bitcoin/
< wumpus> elichai2: if you want to purely benchmark CRC, see https://github.com/laanwj/crcbench
< wumpus> as part of leveldb it's probably best to benchmark a whole sync on the target hw
< wumpus> the only thing that benchmarks bitcoind's database access pattern is really bitcoind
< elichai2> thanks
< elichai2> if anyone is interested this is my result from Intel VTune of a full IBD with prune with somewhat default configurations see: https://gist.github.com/elichai/7710dd6af58cd5017f970844e2610e55
< elichai2> was done between 2 local nodes. no internet connection. one fully updated the other (the that was profiled) is a new node on prune. (I'm rerunning this with a "full" Finalization(what ever that mean) changes now to verify)
< elichai2> And I hope i'll be able to soon upload the full data. (unlike perf Intel VTune reports are portable)
< elichai2> jamesob: :)
< emilengler> I need to join the meeting later. I will be home in around 20 minutes unfortunately
< wumpus> #startmeeting
< lightningbot> Meeting started Thu Dec 19 19:00:07 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< kanzure> hi
< jonatack> hi
< wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
< wumpus> jeremyrubin lightlike emilengler jonatack
< fanquake> hi
< wumpus> no proposed topics on the list: any last-minute ones?
< achow101> hi
< meshcollider> hi
< wumpus> #topic high priority for review
< achow101> #17261 for hi prio
< gribble> https://github.com/bitcoin/bitcoin/issues/17261 | Make ScriptPubKeyMan an actual interface and the wallet to have multiple by achow101 . Pull Request #17261 . bitcoin/bitcoin . GitHub
< wumpus> currently 8 blockers, 7 issues waiting for concept ack
< jnewbery_> hi
< wumpus> can anyone add 17261 pls I'm not logged in at the moment ^^
< gleb> Hi
< fanquake> I can
< sipa> only half present
< jonatack> 17261 is already hi prio
< fanquake> Would like to add #16392, as that is going to start blocking build system things
< gribble> https://github.com/bitcoin/bitcoin/issues/16392 | build: macOS toolchain update by fanquake . Pull Request #16392 . bitcoin/bitcoin . GitHub
< instagibbs> hi
< wumpus> sure
< wumpus> just means that everyone has to update their gitian builders to have the new SDK
< wumpus> which reminds me, is it possible to extract that again without access to a mac?
< fanquake> Yes and yes
< wumpus> cool!
< fanquake> although the new process is slightly more convoluted
< achow101> instructions for that?
< wumpus> I think that's important to document, to prevent everyone just swapping the same file like lat time :)
< fanquake> I think Carl also had some alternate instructions. Will check with him.
< wumpus> oh awesome
< fanquake> FYI if anyone is interested in where this build stuff is going, I posted a bit of a brain dump in #17768
< gribble> https://github.com/bitcoin/bitcoin/issues/17768 | build: various build system improvements . Issue #17768 . bitcoin/bitcoin . GitHub
< dongcarl> hi
< wumpus> #link fanquake's build system plans https://github.com/bitcoin/bitcoin/issues/17768
< wumpus> any other topics?
< * dongcarl> reading
< dongcarl> fanquake: yeah I forgot if we decided to add the headers from the SDK or clang
< dongcarl> but I remember Cory mentioning that it was okay to do the SDK one
< fanquake> dongcarl I think the resolution is in the #bitcoin-builds log, will recheck
< dongcarl> fanquake: thanks!
< wumpus> if there's no other topics, I think that concludes the meeting
< wumpus> #endmeeting
< lightningbot> Meeting ended Thu Dec 19 19:12:16 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< instagibbs> have a nice break everyone who is taking one
< fanquake> dongcarl I've also been putting together some more extensive notes about the benefits of the recent build system changes. Learning more about gnuplot than I like: https://imgur.com/a/zegTIvR
< jonatack> fanquake: nice
< emilengler> hi
< dongcarl> fanquake: Oh that's very cool
< fanquake> binaries sizes down, depends build times down, dynamic library dependence down. 0.20.0 already looking good hah
< MarcoFalke> quick, tag it before it gets worse
< MarcoFalke> 0.20.0 on christmas eve!
< dongcarl> fanquake: music to my ears
< wumpus> yess, after all, holidays are always the best time to do a release
< dongcarl> this holiday season... ditch your fireplace and snuggle up next to the flames of your untimely software release
< instagibbs> wumpus, taproot/schnorr/tapscript activation on jan 1st
< fanquake> dongcarl all wrapped up in a nice little Guix bundle heh
< bitcoin-git> [bitcoin] MarcoFalke pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/3e949380725c...6677be64f69b
< bitcoin-git> bitcoin/master 3f7dc9b Russell Yanofsky: refactor: Clean up long lines in settings code
< bitcoin-git> bitcoin/master 57e8b7a Russell Yanofsky: refactor: Clean up includeconf comments
< bitcoin-git> bitcoin/master dc0f148 Russell Yanofsky: refactor: Replace FlagsOfKnownArg with GetArgFlags
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17473: refactor: Settings code cleanups (master...pr/cleanset) https://github.com/bitcoin/bitcoin/pull/17473
< dongcarl> fanquake: bootstrappable, reproducible fire!
< bitcoin-git> [bitcoin] practicalswift opened pull request #17777: tests: Add fuzzing harness for DecodeHexTx(...) (master...fuzzers-decode_tx) https://github.com/bitcoin/bitcoin/pull/17777
< fanquake> macOS dylib count over time https://imgur.com/a/RmqF88A
< jeremyrubin> If you're interested, I made ##ctv-bip-review to discuss checktemplateverify
< fanquake> promag Need to do a more thorough benchmark, but #17746 seems to be slower in some cases. Have been testing with a 120k+ tx wallet
< gribble> https://github.com/bitcoin/bitcoin/issues/17746 | rpc: Remove vector copy from listtransactions by promag . Pull Request #17746 . bitcoin/bitcoin . GitHub