< bitcoin-git> [bitcoin] hackerrdave opened pull request #17751: doc: use recommended shebang approach in documentation code block (master...docs-shebang) https://github.com/bitcoin/bitcoin/pull/17751
< bitcoin-git> [bitcoin] hackerrdave opened pull request #17752: doc: fix directory path for secp256k1 subtree in developer-notes (master...docs-subtrees) https://github.com/bitcoin/bitcoin/pull/17752
< bitcoin-git> [bitcoin] practicalswift opened pull request #17753: util: Don't allow Base32/64-decoding or ParseMoney(...) on strings with embedded NUL characters. Add tests. (master...valid-as-c-string) https://github.com/bitcoin/bitcoin/pull/17753
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a595011f5a3c...c3628e448315
< bitcoin-git> bitcoin/master 7965e0b Emil Engler: doc: Add release note for RPC Whitelist
< bitcoin-git> bitcoin/master c3628e4 Wladimir J. van der Laan: Merge #17743: doc: Add release note for RPC Whitelist
< bitcoin-git> [bitcoin] laanwj merged pull request #17743: doc: Add release note for RPC Whitelist (master...2019-12-whitelist-release-note) https://github.com/bitcoin/bitcoin/pull/17743
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c3628e448315...5e4912f99096
< bitcoin-git> bitcoin/master ccdda96 fanquake: depends: skip building qt proxies
< bitcoin-git> bitcoin/master 29d56c6 fanquake: depends: -optimized-qmake is now -optimized-tools
< bitcoin-git> bitcoin/master 244501f fanquake: depends: disable unused qt networking features
< bitcoin-git> [bitcoin] laanwj merged pull request #17730: depends: remove Qt networking features (master...qt_no_lib_system_proxy) https://github.com/bitcoin/bitcoin/pull/17730
< bitcoin-git> [bitcoin] practicalswift opened pull request #17754: net: Don't allow resolving of std::string:s with embedded NUL characters. Add tests. (master...c_str-cleanup-netbase) https://github.com/bitcoin/bitcoin/pull/17754
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5e4912f99096...6b51cce65afd
< bitcoin-git> bitcoin/master ccc53e4 practicalswift: util: Don't allow ParseMoney(...) of strings with embedded NUL characters
< bitcoin-git> bitcoin/master 93cc18b practicalswift: util: Don't allow DecodeBase64(...) of strings with embedded NUL characters
< bitcoin-git> bitcoin/master a6fc26d practicalswift: util: Don't allow DecodeBase32(...) of strings with embedded NUL characters
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17753: util: Don't allow Base32/64-decoding or ParseMoney(...) on strings with embedded NUL characters. Add tests. (master...valid-as-c-string) https://github.com/bitcoin/bitcoin/pull/17753
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6b51cce65afd...806a2c602cdf
< bitcoin-git> bitcoin/master ec8dcb0 practicalswift: tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missi...
< bitcoin-git> bitcoin/master 893aa20 practicalswift: tests: Add fuzzing harness for CheckBlock(...) and other CBlock related fu...
< bitcoin-git> bitcoin/master 806a2c6 MarcoFalke: Merge #17071: tests: Add fuzzing harness for CheckBlock(...) and other CBl...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17071: tests: Add fuzzing harness for CheckBlock(...) and other CBlock related functions (master...fuzzers-block) https://github.com/bitcoin/bitcoin/pull/17071
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/806a2c602cdf...988eaf2fcb71
< bitcoin-git> bitcoin/master a5089f6 hackerrdave: fix directory path for secp256k1 subtree in developer-notes
< bitcoin-git> bitcoin/master 988eaf2 fanquake: Merge #17752: doc: fix directory path for secp256k1 subtree in developer-n...
< bitcoin-git> [bitcoin] fanquake merged pull request #17752: doc: fix directory path for secp256k1 subtree in developer-notes (master...docs-subtrees) https://github.com/bitcoin/bitcoin/pull/17752
< instagibbs> jonatack, I'm just trying to understand the PR in question. Like I said the comments in the PR/issues are light about actual motivation
< jonatack> np. what confuses me is that labels are associated with addresses, and send/receive are categories of txns (e.g. listtransactions). So labels having a send/receive purpose seems orthogonal/conflated (to me).
< instagibbs> mm ok
< jonatack> i'm not sure there is a clear roadmap on labels so putting it on the table seems good.
< instagibbs> I guess "send" for address makes no sense
< elichai2> could we parallelize the `loadblk` thread? whith assumevalid most of the processing is spent on that thread. the problem is that we need to have a up-to-the-block UTXO set to check that the txs are valid. but maybe we could pre-process the blocks and leave them as a list of used inputs and new outputs and then block by block verify that they're actually in the UTXO set and then remove+add the changes
< jonatack> and getaddressinfo otherwise doesn't return send/receive, just ismine true/false
< jonatack> instagibbs: i tried adding a unit test for #17677 after the previous round of changes that didn't affect any tests but didn't figure it out
< gribble> https://github.com/bitcoin/bitcoin/issues/17677 | Activate watchonly wallet behavior for LegacySPKM only by instagibbs . Pull Request #17677 . bitcoin/bitcoin . GitHub
< instagibbs> jonatack, I think for unit tests you're going to have to define a new spkm, add watchonly coins, then make sure they aren't added to the results of ListCoins
< jonatack> instagibbs: thanks
< bitcoin-git> [bitcoin] fanquake opened pull request #17756: build: remove WINDOWS_BITS from build system (master...remove_windows_bitness) https://github.com/bitcoin/bitcoin/pull/17756
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17593: test: move more utility functions into test utility library (master...201911_test_moveutil) https://github.com/bitcoin/bitcoin/pull/17593
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17593: test: move more utility functions into test utility library (master...201911_test_moveutil) https://github.com/bitcoin/bitcoin/pull/17593
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/988eaf2fcb71...48d64d73c06f
< bitcoin-git> bitcoin/master facbaf0 MarcoFalke: rpc: Use mempool from node context instead of global
< bitcoin-git> bitcoin/master fa660d6 MarcoFalke: node: Use mempool from node context instead of global
< bitcoin-git> bitcoin/master fa8e650 MarcoFalke: rest: Use mempool from node context instead of global
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17564: rpc: Use mempool from node context instead of global (master...1911-rpcNoTxPoolGlobal) https://github.com/bitcoin/bitcoin/pull/17564
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/48d64d73c06f...f9fd3a27fda3
< bitcoin-git> bitcoin/master 869b631 John Newbery: [qt] remove unused parameter from getWarnings()
< bitcoin-git> bitcoin/master 492c6dc John Newbery: util: change GetWarnings parameter to bool
< bitcoin-git> bitcoin/master 7aab8d1 John Newbery: [style] Code style fixups in GetWarnings()
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17750: util: change GetWarnings parameter to bool (master...2019-12-getwarnings) https://github.com/bitcoin/bitcoin/pull/17750
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f9fd3a27fda3...94c6f2bba451
< bitcoin-git> bitcoin/master 2cb4e8b Martin Zumsande: [test] move string helper functions into test library
< bitcoin-git> bitcoin/master f613e5d Martin Zumsande: [test] move mining helper functions into test library
< bitcoin-git> bitcoin/master 78e283e Martin Zumsande: [test] move wallet helper functions into test library
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17593: test: move more utility functions into test utility library (master...201911_test_moveutil) https://github.com/bitcoin/bitcoin/pull/17593
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #17110: appveyor: Add -l test_suite to .appveyor.yaml (master...master) https://github.com/bitcoin/bitcoin/pull/17110
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17110: appveyor: Add -l test_suite to .appveyor.yaml (master...master) https://github.com/bitcoin/bitcoin/pull/17110