00:28 < gwillen> what is the difference between tr(...) and _(...).translated ?

00:28 < gwillen> which one is preferred, or does it depend?

00:28 < gwillen> is there a doc or a guide somewhere on how to deal with translation stuff, especially when adding or changing UI strings?

00:29 < hebasto> gwillen: tr() is for Qt code

00:30 < hebasto> https://github.com/bitcoin/bitcoin/blob/master/doc/translation_strings_policy.md

00:30 < gwillen> thanks, I found https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md which only references tr() and does not mention _()

00:32 < gwillen> hmm, what does this mean for using strings from e.g. https://github.com/bitcoin/bitcoin/blob/master/src/util/error.cpp in the UI?

00:32 < emilengler> IIRC translations are only in bitcoin-qt

00:32 < emilengler> But I could be wrong on this

00:32 < emilengler> Ok, yes I'm wrong on this...

00:33 < emilengler> gwillen: strprintf is used when there are vairables in the string

00:33 < emilengler> Like %s means that the software will insert the string later

00:33 < gwillen> for the transaction errors, it seems like ideally they could appear both in RPC and in the GUI

00:33 < gwillen> but it sounds like RPC errors should not be translated and GUI errors should

00:34 < emilengler> I think so

00:36 < emilengler> I think a translated RPC system would make no sense as the commands tiself are in english and it is mostly used by power users who can speak english

00:39 < hebasto> gwillen: emilengler: Also see https://github.com/bitcoin/bitcoin/blob/master/src/util/translation.h

00:40 < emilengler> hebasto: Thanks

00:40 < emilengler> There we go, line 14: " * - in log and stderr: untranslated only"

00:54 < bitcoin-git> [bitcoin] hebasto opened pull request #17837: build: Refactor out Qt version check macro (master...20191230-autoconf-qt-version-macro) https://github.com/bitcoin/bitcoin/pull/17837

00:56 < fanquake> hebasto Instead of opening three very related PRs, that all touch the same file (and all conflict with each other), can you just combine them into one?

00:57 < hebasto> fanquake: I did know in advance that will be three pulls ;)

00:57 < fanquake> hebasto: that's fine. Just close the second two, and merge them into the first.

00:58 < hebasto> fanquake: will do

00:58 < fanquake> I'd assume all these changes you'd want to be testing at the same time anyways. It'll also save on doing gitian builds over and over.

00:58 < hebasto> totally agree

01:10 < bitcoin-git> [bitcoin] hebasto closed pull request #17836: build: Fix --with-gui configure option without argument (master...20191230-fix-withgui) https://github.com/bitcoin/bitcoin/pull/17836

01:11 < bitcoin-git> [bitcoin] hebasto closed pull request #17837: build: Refactor out Qt version check macro (master...20191230-autoconf-qt-version-macro) https://github.com/bitcoin/bitcoin/pull/17837

01:21 < hebasto> fanquake: done

01:43 < fanquake> hebasto thanks

05:41 < bitcoin-git> [bitcoin] kallewoof opened pull request #17838: test: test the >10 UTXO case for output groups (master...191231-test-avoidreuse-many-utxos) https://github.com/bitcoin/bitcoin/pull/17838

10:47 < bitcoin-git> [bitcoin] rex4539 opened pull request #17839: [build] depends macOS: hide linker visibility warnings (master...hide-warnings) https://github.com/bitcoin/bitcoin/pull/17839

17:53 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8830cb58abc8...99813a9745fe

17:53 < bitcoin-git> bitcoin/master aaaaad6 MarcoFalke: scripted-diff: Bump copyright of files changed in 2019

17:53 < bitcoin-git> bitcoin/master 99813a9 fanquake: Merge #17829: scripted-diff: Bump copyright of files changed in 2019

17:53 < bitcoin-git> [bitcoin] fanquake merged pull request #17829: scripted-diff: Bump copyright of files changed in 2019 (master...1912-bumpC) https://github.com/bitcoin/bitcoin/pull/17829

18:10 < bitcoin-git> [bitcoin] fanquake closed pull request #15103: fix getentropy import check on osx (master...getentropy-weak) https://github.com/bitcoin/bitcoin/pull/15103

18:31 < hebasto> fanquake: regarding your comment https://github.com/bitcoin/bitcoin/pull/17691#issuecomment-569970065

18:31 < hebasto> do you mean https://github.com/bitcoin-core/bitcoin-maintainer-tools ?

18:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/99813a9745fe...35fff5be60e8

18:33 < bitcoin-git> bitcoin/master df97e59 Hennadii Stepanov: doc: Update dependencies.md

18:33 < bitcoin-git> bitcoin/master 35fff5b fanquake: Merge #17825: doc: Update dependencies.md

18:33 < bitcoin-git> [bitcoin] fanquake merged pull request #17825: doc: Update dependencies.md (master...20191229-update-dependencies) https://github.com/bitcoin/bitcoin/pull/17825

18:33 < fanquake> hebasto yes

18:33 < hebasto> What kind of consent should there be in the community to do this?

18:34 < hebasto> Or should I just submit a pr for that?

18:36 < fanquake> Agreement that 600 lines of copyright header "management" bash doesn't belong in the same repository as (in an ideal world would only be) bitcoin core protocol development

18:36 < fanquake> See #16625 for when I moved the merge script over

18:36 < gribble> https://github.com/bitcoin/bitcoin/issues/16625 | scripts: remove github-merge.py by fanquake . Pull Request #16625 . bitcoin/bitcoin . GitHub

18:37 < fanquake> I'd like scripts like that to be moved somewhere else so we can forget about them and work on actual important stuff

18:37 < hebasto> agree

18:43 < bitcoin-git> [bitcoin] fanquake closed pull request #17792: 0.19: Backports (0.19...2019-12-backports) https://github.com/bitcoin/bitcoin/pull/17792