< wumpus> sipa: MarcoFalke has a PR open to fix those RPC calls causing GUI errors IIRC
< wumpus> I think the functional tests are meant to pass without user interaction after that
< wumpus> ... I can't find it though
< wumpus> oh that was #17444 and already merged
< gribble> https://github.com/bitcoin/bitcoin/issues/17444 | wallet: Avoid showing GUI popups on RPC errors (take 2) by MarcoFalke . Pull Request #17444 . bitcoin/bitcoin . GitHub
< wumpus> and #17070
< gribble> https://github.com/bitcoin/bitcoin/issues/17070 | wallet: Avoid showing GUI popups on RPC errors by MarcoFalke . Pull Request #17070 . bitcoin/bitcoin . GitHub
< sipa> wumpus: the popups i saw were mostly for bad configuration options
< sipa> so i guess init errors
< wumpus> ah, right
< wumpus> having the test screengrab and read out error dialogs probably goes a bit too far, so invalid option tssts should probably be skipped for the GUI
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf43f3f0a8ff...c7c9c4427847
< bitcoin-git> bitcoin/master bd44711 fanquake: build: pass -dead_strip_dylibs to ld on macOS
< bitcoin-git> bitcoin/master c7c9c44 Wladimir J. van der Laan: Merge #17663: build: pass -dead_strip_dylibs to ld on macOS
< bitcoin-git> [bitcoin] laanwj merged pull request #17663: build: pass -dead_strip_dylibs to ld on macOS (master...macos_ld_dead_strip_dylibs) https://github.com/bitcoin/bitcoin/pull/17663
< bitcoin-git> [bitcoin] practicalswift reopened pull request #17051: tests: Add deserialization fuzzing harnesses (master...fuzzers-deserialize) https://github.com/bitcoin/bitcoin/pull/17051
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c7c9c4427847...cb11324a63ef
< bitcoin-git> bitcoin/master 16f0a18 practicalswift: tests: Add corpora suppression (FUZZERS_MISSING_CORPORA) for fuzzers missi...
< bitcoin-git> bitcoin/master 897849d practicalswift: tests: Add deserialization fuzzing harnesses
< bitcoin-git> bitcoin/master cb11324 Wladimir J. van der Laan: Merge #17051: tests: Add deserialization fuzzing harnesses
< bitcoin-git> [bitcoin] laanwj merged pull request #17051: tests: Add deserialization fuzzing harnesses (master...fuzzers-deserialize) https://github.com/bitcoin/bitcoin/pull/17051
< bitcoin-git> [bitcoin] laanwj opened pull request #17682: util: Update tinyformat to upstream (master...2019_12_tinyformat) https://github.com/bitcoin/bitcoin/pull/17682
< bitcoin-git> [bitcoin] jonatack closed pull request #17535: test: add block height test to listsinceblock.py (master...rpc-wallet-blockheight-followups) https://github.com/bitcoin/bitcoin/pull/17535
< bitcoin-git> [bitcoin] jonatack reopened pull request #17535: test: add block height test to listsinceblock.py (master...rpc-wallet-blockheight-followups) https://github.com/bitcoin/bitcoin/pull/17535
< jonatack_> wumpus: re #17682, how to reproduce the -Wimplicit-fallthrough warnings... depends build? gcc 9 needed? am currently using gcc debian 8.3
< gribble> https://github.com/bitcoin/bitcoin/issues/17682 | util: Update tinyformat to upstream by laanwj . Pull Request #17682 . bitcoin/bitcoin . GitHub
< jonatack_> (hm, i need to remember to use the builds channel for these types of questions)
< wumpus> jonasschnelli: I see it on Ubuntu 1804 w/ the default gcc 7.4.0
< wumpus> sorry, jonatack_*
< jonatack> thanks wumpus
< ariard> #16688 is pretty useful and is mature enough now, just lack few more reviews
< gribble> https://github.com/bitcoin/bitcoin/issues/16688 | log: Add validation interface logging by jkczyz . Pull Request #16688 . bitcoin/bitcoin . GitHub
< ariard> already ACKed by john and me
< instagibbs> oooh, callback logging :)
< achow101> Is #17373 RTM? has 4 ACKS
< gribble> https://github.com/bitcoin/bitcoin/issues/17373 | wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet by achow101 . Pull Request #17373 . bitcoin/bitcoin . GitHub
< fanquake> achow101 looking
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cb11324a63ef...da1af855f9bf
< bitcoin-git> bitcoin/master d8daa8f practicalswift: pubkey: Assert CPubKey's ECCVerifyHandle precondition
< bitcoin-git> bitcoin/master da1af85 MarcoFalke: Merge #17275: pubkey: Assert CPubKey's ECCVerifyHandle precondition
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17275: pubkey: Assert CPubKey's ECCVerifyHandle precondition (master...assert-CPubKey-preconditions) https://github.com/bitcoin/bitcoin/pull/17275
< bitcoin-git> [bitcoin] fanquake pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/da1af855f9bf...4ee8a58ce77a
< bitcoin-git> bitcoin/master 596f646 Andrew Chow: Key pool: Move CanGetAddresses call
< bitcoin-git> bitcoin/master 9fcf8ce Andrew Chow: Rename Keep/ReturnKey to Keep/ReturnDestination and remove the wrapper
< bitcoin-git> bitcoin/master 65833a7 Andrew Chow: Add OutputType and CPubKey parameters to KeepDestination
< bitcoin-git> [bitcoin] fanquake merged pull request #17373: wallet: Various fixes and cleanup to keypool handling in LegacyScriptPubKeyMan and CWallet (master...wallet-box-pr-6) https://github.com/bitcoin/bitcoin/pull/17373
< bitcoin-git> [bitcoin] practicalswift opened pull request #17685: tests: Fix bug in the descriptor parsing fuzzing harness (descriptor_parse) (master...fix-descriptor_parse-fuzzing-harness) https://github.com/bitcoin/bitcoin/pull/17685
< instagibbs> achow101 needs a rebase :)
< jonatack> wallet meeting?
< achow101> I think meshcollider isn't around
< achow101> Does anyone have any wallet meeting topics? otherwise we can just skip this week's
< sipa> very short question: what do people think of permitting a list of public keys as public key expression in a descriptor?
< sipa> so you could have sh(wsh({03.....,02.....,03.....,....})) for example
< achow101> seems reasonable
< sipa> it means you can pre-expand other key derivation schemes into descritptors... though perhaps very long ones
< Talkless> jonatack: I've heard about "wallet meetings", do they have separate channel like PR club?
< achow101> Talkless: no, they happen here. meshcollider isn't here today and it doesn't seem like there would be much to say about it, so I didn't start the meeting
< jonatack> Talkless: the wallet meetings are held here and have meetbot integration (e.g. are logged at http://www.erisian.com.au/meetbot/bitcoin-core-dev/). For info on IRC meetings: https://github.com/jonatack/bitcoin-development/blob/master/bitcoin-core-dev-irc-meetings.txt
< Talkless> thanks achow101 jonatack
< instagibbs> if anyone has wallet PRs feel free to beg for review here I guess
< instagibbs> for me I have a few short ones. psbt-related: 17677, 16373, privacy: 17621
< jonatack> instagibbs: those look very manageable, will do this weekend. I have 2 simple deprecation PRs 17578 and 17585
< instagibbs> ill do the first of those when i can
< bitcoin-git> [bitcoin] fanquake opened pull request #17686: build: add -bind_at_load to macOS hardened LDFLAGS (master...macos_ld_explicit_bind_at_load) https://github.com/bitcoin/bitcoin/pull/17686