< roconnor> The test program in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189#c7 seems to work correctly in gcc 10.3
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/13f24d135b28...bb11a988fa52
< bitcoin-git> bitcoin/master cf971c9 fanquake: build: use -isysroot over --sysroot on macOS
< bitcoin-git> bitcoin/master bb11a98 fanquake: Merge bitcoin/bitcoin#21793: build: use `-isysroot` over `--sysroot` on ma...
< bitcoin-git> [bitcoin] fanquake merged pull request #21793: build: use `-isysroot` over `--sysroot` on macOS (master...macos_use_isysroot) https://github.com/bitcoin/bitcoin/pull/21793
< jonasschnelli> provoostenator: no... it uses a custom script
< jonasschnelli> (it should probably use the .ci/* ones
< jonasschnelli> 0.21.1 macOS is signed (signatures are pushed). Happy bulding.
< bitcoin-git> [bitcoin] jimmywilk opened pull request #21820: Bitcoinaws (master...master) https://github.com/bitcoin/bitcoin/pull/21820
< bitcoin-git> [bitcoin] fanquake closed pull request #21820: Bitcoinaws (master...master) https://github.com/bitcoin/bitcoin/pull/21820
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21821: test: Add missing test for empty P2WSH redeem (master...2105-testP2WSHemptyRedeem) https://github.com/bitcoin/bitcoin/pull/21821
< bitcoin-git> [gui] rebroad opened pull request #306: Revert "Peertableview alternating row colors" (master...revert-298-alt-row-colors) https://github.com/bitcoin-core/gui/pull/306
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21805: Send fewer feefilter messages (and avoid the wobbling issue) (master...SteadierFeefilter) https://github.com/bitcoin/bitcoin/pull/21805
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21812: ci: Enable D_GLIBCXX_DEBUG for multiprocess task (master...2104-ciDEBUG) https://github.com/bitcoin/bitcoin/pull/21812
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #21812: ci: Enable D_GLIBCXX_DEBUG for multiprocess task (master...2104-ciDEBUG) https://github.com/bitcoin/bitcoin/pull/21812
< bitcoin-git> [bitcoin] klementtan opened pull request #21822: test: resolve bug in test/functional/interface_bitcoin_cli.py (master...master) https://github.com/bitcoin/bitcoin/pull/21822
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb11a988fa52...d22e7ee93313
< bitcoin-git> bitcoin/master c5bb142 klementtan: test: resolve bug in test/functional/interface_bitcoin_cli.py - Test -geti...
< bitcoin-git> bitcoin/master d22e7ee MarcoFalke: Merge bitcoin/bitcoin#21822: test: resolve bug in interface_bitcoin_cli.py...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21822: test: resolve bug in interface_bitcoin_cli.py (master...master) https://github.com/bitcoin/bitcoin/pull/21822
< bitcoin-git> [bitcoin] prayank23 closed pull request #21815: Add `-maxoutfullrelay` (master...max-out-full-relay) https://github.com/bitcoin/bitcoin/pull/21815
< bitcoin-git> [gui] hebasto opened pull request #307: Make row color alternating in the Peers Tab switchable (master...210501-stripes) https://github.com/bitcoin-core/gui/pull/307
< bitcoin-git> [bitcoin] jonatack opened pull request #21823: script: update REVIEWERS (master...update-REVIEWERS) https://github.com/bitcoin/bitcoin/pull/21823
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21824: refactor: [index] Replace deprecated char with uint8_t in serialization (master...2105-refactorUint8_t) https://github.com/bitcoin/bitcoin/pull/21824
< bitcoin-git> [gui] rebroad opened pull request #308: Display progress of LoadBlockDB() on splash screen (master...SplashLoadBlockProgress) https://github.com/bitcoin-core/gui/pull/308
< gmaxwell> Greetings, I saw 0.21.1 was tagged! Congrats! Anyone have an expectation on when binaries will be posted?
< gmaxwell> Signaling starts in 15 blocks.
< sipa> gitian sigs are coming in, so probably soon
< wumpus> yes things look ready, will be a few hours until i'm able to do so though
< gmaxwell> wumpus: Super awesome!
< gmaxwell> 7 blocks to go.
< robert_spigler> πŸ˜€
< bitcoin-git> [bitcoin] jonatack opened pull request #21825: net: add I2P hardcoded seeds (master...i2p-hardcoded-seeds) https://github.com/bitcoin/bitcoin/pull/21825
< jonatack> wumpus: great πŸŽ‰
< hebasto> \o/
< provoostenator> 3 blocks to go. Nice timing on the release!
< provoostenator> (well on the binaries anyway)
< robert_spigler> wumpus: Awesome!
< provoostenator> Now just refresh: bitcoin-cli getblockchaininfo | jq '.softforks | .taproot'
< robert_spigler> just need to be put up on bitcoincore.org/en/releases now and an announcement
< achow101> 1 block to go
< wumpus> i'm not able to do so right now, maybe someone else can do the PR etc, otherwise i'll get to it tomorrow (same for the torrent)
< provoostenator> Whoever releases the torrent, make sure to ping me the hash, so I can whitelist it
< harding> I'll do the website stuff right now. I'll ping here so somebody can ack it.
< gmaxwell> watch "./bitcoin-cli getblocktemplate '{\"rules\": [\"segwit\"]}' | grep -i version"
< gmaxwell> is what I've been running.
< gmaxwell> 536870912 is non-signaling.
< gmaxwell> I think it's unlikely any major miners are paying attention to the GBT output for this, but it's not impossible.
< prusnak> congratz on the release!
< gmaxwell> "version": 536870916,
< robert_spigler> harding: awesome!
< jonatack> gmaxwell: same!
< provoostenator> gmaxwell: you already have a block at height 681,408?
< provoostenator> Oh wait, I see, that's the template
< gmaxwell> provoostenator: Right.
< gmaxwell> Now there is one.
< gmaxwell> and it didn't signal.
< bitcoin-git> [gui] hebasto opened pull request #309: gui: Add access to the Peers tab from the network icon (master...210501-network) https://github.com/bitcoin-core/gui/pull/309
< provoostenator> Two... didn't
< prusnak> and another one - not signalling
< achow101> unfortunately that's not at all surprising
< prusnak> and a third one
< gmaxwell> 198 blocks until activation this window is impossible.
< gmaxwell> (and pratically less than half that, since it's really unlikely to reach 100% at the end of the window)
< robert_spigler> gmaxwell: ?
< robert_spigler> 1815 to activate, 2013 still left
< robert_spigler> or, lock in I guess
< gmaxwell> robert_spigler: once there have been 201 non-signaling blocks in a given window activation is impossible in that window.
< gmaxwell> because 2016-1815.
< gmaxwell> And pratically less than that, because 100% signaling isn't likely to be achieved.
< gmaxwell> 4 non-signalers now.
< gmaxwell> I can't tell which pool the latest one is.
< sipa> "rawpool" according to mempool.space
< robert_spigler> gmaxwell: ah, I see, thanks
< gmaxwell> and antpool.
< robert_spigler> yep
< robert_spigler> hopefully making a full release announcement - bitcoin-core-dev, website, etc, will help. Maybe they just aren't fake signalling/running the RC1
< achow101> it's also 4 am in china...
< robert_spigler> achow101: didn't think of that
< gmaxwell> Binance agan then f2, speaking of F2. :P
< gmaxwell> wangchun__: long time no see! Is f2pool going to start signaling taproot soon? :P
< gmaxwell> It probably wasn't clear to pool operators that they could start signaling early.
< achow101> gmaxwell: I expect that he's still asleep
< harding> gmaxwell: I think aj also mentioned that pool operators may not have wanted to signal early to avoid causing "unknown versionbits" warnings in software.
< gmaxwell> achow101: just saw his client join. :P
< gmaxwell> harding: does that warning still even exist anymore?
< achow101> gmaxwell: ah. I have joins and parts muted
< achow101> gmaxwell: the unknown versionbits warning is still there but it also uses a threshold of 1815, so it wouldn't have triggered with early signaling unless it was enabled two weeks ago
< gmaxwell> Poolin two blocks not signaling.
< jarthur> I think wangchun__'s re-entrance was due to IRC Cloud connectivity hiccup
< harding> gmaxwell: I didn't think so, but maybe it's still in debug.log or something? I was a bit surprised myself to see aj mention it as a possible reason to avoid early signaling.
< achow101> if you run a testnet node, you should see the unknown versionbits warning
< gmaxwell> on one hand I totally expecetd the non-signaling, and yet somehow I am slightly disappointed.
< jarthur> gmaxwell definitely
< jarthur> Doesn't seem likely re avoiding the version warning, aren't most of those pools happily adjusting random versionbits as part of Overt ASICBoost?
< achow101> harding: I think you're thinking of the older "unknown version number" warning
< achow101> IIRC that one stuck around for a while but we removed it eventually
< gmaxwell> jarthur: they were triggering that warning for eons, but it eventually got changed to stop doing that. I'd thought the warning was removed entirely but it sounds like the threshold was just upped.
< jarthur> got it
< harding> achow101: does https://github.com/bitcoin-core/bitcoincore.org/pull/767 now address all of your feedback? I can merge it if it's all good.
< hsjoberg> Pardon the ignorant question, but isn't it possible for miners to signal despite not running 0.21.1? Just mine a block and set version bit 2 anyway.
< murch> hsjoberg: As far as I understand that's pretty much always the case, since the mining controllers need to be configured to signal
< gmaxwell> hsjoberg: absolutely. In practice the miner signaling is unrelated.
< achow101> harding: ack'd it
< harding> achow101: thanks!
< gmaxwell> hsjoberg: getblocktemplate returns a version number but AFAIK there is nothing that doesn't ignore it.
< hsjoberg> Yeah thanks, that's what I thought as well, and AFAICT the reason why we even have such high threshold for BIP9
< achow101> hsjoberg: yes, that's what false signaling is
< murch> Well yeah, it is indeed not released yet
< gmaxwell> hsjoberg: well the threshold being high is for a number of reasons. (1) because you need a very high supermajority enforcing to make sure any reorgs are short, (2) the test is done multiple times you need a higher threshold to make sure that a smaller supermajority is met, and (3) false signaling.
< gmaxwell> murch: Is it released when the branch is tagged or when the website is updated? I think currently 0.21.1 is simultaniously alive and dead. :P
< murch> Oh, did the gitian builds finish?
< hsjoberg> gmaxwell: Thank you for the explanation.
< gmaxwell> (I doubt many if any run the release binaries)
< achow101> murch: binaries are up, harding just added release blog post and release notes. all that's left is the release announcement mail
< murch> I mean… usually it was that miners should signal when they perceive the network to be ready to activate, but with a fixed activation date that is kinda moot
< achow101> and the torrent
< murch> mh, I guess I would say it's released when the release has been announced, but I see what you mean, gmaxwell ;)
< murch> achow101: kewl.
< harding> Website finished updating. https://bitcoincore.org/en/2021/05/01/release-0.21.1/
< sipa> harding: great, thanks
< robert_spigler> Awesome!
< robert_spigler> Release notes need to be added to https://github.com/bitcoin/bitcoin/tree/master/doc/release-notes
< robert_spigler> ^ And 0.21.1 placed as latest release
< bitcoin-git> [gui] rebroad closed pull request #308: Display progress of LoadBlockDB() on splash screen (master...SplashLoadBlockProgress) https://github.com/bitcoin-core/gui/pull/308
< gmaxwell> spiderpool and another poolin.
< jarthur> I sent out a notice to #bitcoin-miners. Is there a guide to constructing a signaling block for operators who don't use Core's getblocktemplate or use an older version than today's?
< jarthur> * #bitcoin-mining
< gmaxwell> what do you mean don't use core's getblocktemplate? 0_o
< gmaxwell> jarthur: logical OR 536870916 into their block version.
< jarthur> Thank you!
< gmaxwell> as in block.version |= 536870916; will set that bits required to activate taproot in addition to whatever else they have set.
< robert_spigler> harding: https://bitcoincore.org/en/releases/ is missing a link to 0.21.1
< harding> robert_spigler: I see a link, maybe Ctrl-shft refresh?
< robert_spigler> ah, sorry
< harding> robert_spigler: no worries, thanks for checking.
< bitcoin-git> [bitcoin] rebroad opened pull request #21827: Display progress of LoadBlockDB() on splash screen (master...SplashLoadBlockProgress) https://github.com/bitcoin/bitcoin/pull/21827
< robert_spigler> whoever controls @bitcoincoreorg on twitter should also make an announcement
< rebroad> what is #bitcoin-dev channel for now?
< rebroad> and how does one get permission to post in it?
< rebroad> robert_spigler announcement about what?
< gmaxwell> rebroad: bitcoin-dev channel was essentially abandoned long ago. I don't think it's for anything, I had heard it was going to get closed down.
< robert_spigler> rebroad: The 0.21.1 release