< bitcoin-git> [bitcoin] fanquake closed pull request #21965: Update Build OSX (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21965
< CrazyPython> Every 2016 blocks, Bitcoin contacts a centralized, man in the middle vulnerable system
< CrazyPython> Known as NTP. Are there any plans to fix this problem to prevent a chain split?
< sipa> lol wut?
< CrazyPython> sipa: Every 2016 blocks, Bitcoin adjusts the difficulty/block production rate per unit of work based on the wall clock 10 minutes
< CrazyPython> The wall clock 10 minutes is based on the operating system clock time, which uses NTP.
< BlueMatt> that is wholly untrue
< CrazyPython> How does the 10 minutes calibration work?
< BlueMatt> based on the timestamp included in the block header
< sipa> i guess that means "i see"
< bitcoin-git> [bitcoin] sipa opened pull request #21966: Software float encoding (master...202105_softfloat) https://github.com/bitcoin/bitcoin/pull/21966
< bitcoin-git> [bitcoin] ssb402 closed pull request #21960: test: Use zero compressed addresses for values in map (master...test-cnetaddr-canonical) https://github.com/bitcoin/bitcoin/pull/21960
< fanquake> do we need a new linter to stop the re-introduction on non-standard/boost-only <filesystem> code
< * fanquake> ducks
< bitcoin-git> [gui] jarolrod opened pull request #337: test: Use Regex Search in Apptests (master...regex-search-test) https://github.com/bitcoin-core/gui/pull/337
< fanquake> wumpus / sipa: can you block Modusto25
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21969: refactor: Switch serialize to uint8_t (Bundle 1/2) (master...2105-uin8t) https://github.com/bitcoin/bitcoin/pull/21969
< bitcoin-git> [gui] RandyMcMillan opened pull request #338: qt: peers-tab resizeColumnsToContents (master...tableview-resize) https://github.com/bitcoin-core/gui/pull/338
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21970: fuzz: Add missing CheckTransaction before CheckTxInputs (master...2105-fuzzTxFixes) https://github.com/bitcoin/bitcoin/pull/21970
< wumpus> fanquake: done
< fanquake> wumpus:please also block dasa376
< wumpus> fanquake: done
< wumpus> hebasto: no i hadn't, thank you for investigating
< wumpus> i'll add that and update the PR
< hebasto> thanks!
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ef34ee25ed3...7b87fca930ff
< bitcoin-git> bitcoin/master c10f27f practicalswift: net: Make IPv6ToString do zero compression as described in RFC 5952
< bitcoin-git> bitcoin/master 54548ba practicalswift: net: Avoid calling getnameinfo when formatting IPv6 addresses in CNetAddr:...
< bitcoin-git> bitcoin/master 7b87fca W. J. van der Laan: Merge bitcoin/bitcoin#21756: Avoid calling `getnameinfo` when formatting I...
< bitcoin-git> [bitcoin] laanwj merged pull request #21756: Avoid calling `getnameinfo` when formatting IPv6 addresses in `CNetAddr::ToStringIP` (master...simplify-ipv6-address-formatting) https://github.com/bitcoin/bitcoin/pull/21756
< aj> might want to ban P7-33 too -- https://github.com/bitcoin/bips/wiki/_Sidebar/_history
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21981: Remove unused float serialization (master...2105-NoSerFloat) https://github.com/bitcoin/bitcoin/pull/21981
< wumpus> wait, does 'bips' have a publicly editable wiki
< wumpus> aj: will do
< wumpus> anyhow, deleted the scammy sidebar and blocked the user
< michaelfolkson> wumpus: Yeah it appears the wiki is publicly editable. Maybe worth changing that luke-jr?
< wumpus> yes i don't know, if the idea is that outsiders can add their own comments to BIPs, then closing it to say org members only wouldn't be great
< aj> wumpus: i think that was the idea, but don't think it's worked very well; cf "Drop BIP comments" at https://github.com/bitcoin/bips/wiki/BIP-Process-wishlist
< michaelfolkson> Yeah I'
< michaelfolkson> Yeah I'd be a +1 for dropping comments
< michaelfolkson> Comments on the original PR (while it is still open) and then opening a new PR or posting to bitcoin-dev mailing list seems sufficient to me
< aj> wumpus: (an example of why wiki isn't great for that: that page is a mix of luke-jr's, michaelfolkson's and laurentmt's thoughts; but you can only tell which is which if you look at the history page)
< michaelfolkson> aj: Agreed
< wumpus> yes a message-based approach is better than a wiki for comments, the Talk pages on wikipedia also always seemed awkward to me
< bitcoin-git> [bitcoin] hebasto opened pull request #21983: build: Silent lupdate "unknown namespace/class" warnings (master...210517-lupdate) https://github.com/bitcoin/bitcoin/pull/21983
< bitcoin-git> [gui] hebasto merged pull request #323: English translations update (master...2021-05-translations-update) https://github.com/bitcoin-core/gui/pull/323
< bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7b87fca930ff...6d1d33d33491
< bitcoin-git> bitcoin/master 55c012d Hennadii Stepanov: qt: Extract translations correctly from UTF-8 formatted source
< bitcoin-git> bitcoin/master c34a49f W. J. van der Laan: qt: English translations update
< bitcoin-git> bitcoin/master 6d1d33d Hennadii Stepanov: Merge bitcoin-core/gui#323: English translations update
< michaelfolkson> I think 0racl3z needs to banned too
< wumpus> we're on a roll today
< michaelfolkson> So. much. banning. :)
< wumpus> couldn't that one be accidental?
< michaelfolkson> Multiple comments, I guess...
< wumpus> it does look pretty weird if you look at his other comments as well
< wumpus> all they do is randomly seemingly randomly approve PRs and post 'Thx!' sometimes multiple times
< wumpus> oh and completely unrelated quips like https://github.com/bitcoin/bips/pull/1096#issuecomment-827356885
< wumpus> bah
< wumpus> sure, going to block...
< michaelfolkson> I was going to write a comment saying please stop but yeah a block works too
< bitcoin-git> [bitcoin] jonatack closed pull request #21961: test: fix, restore and improve cnetaddr scoped id documentation (master...fix-and-improve-cnetaddr-scoped-id-test-documentation) https://github.com/bitcoin/bitcoin/pull/21961
< wumpus> jonatack: huh, why close
< jonatack> wumpus: it was made obsolete by #21756 merged a few hours ago
< gribble> https://github.com/bitcoin/bitcoin/issues/21756 | Avoid calling `getnameinfo` when formatting IPv6 addresses in `CNetAddr::ToStringIP` by practicalswift · Pull Request #21756 · bitcoin/bitcoin · GitHub
< wumpus> if i misunderstood it
< wumpus> ohhh :)
< jonatack> we no longer return any scoped ids
< wumpus> is that a good thing?
< wumpus> i admit that's a part of IPv6 i really never paid attention to
< wumpus> in any case at least it's now consistent between operating systems
< jonatack> but i've spend more time than i would have preferred chasing my tail on this
< jonatack> so i don't plan to look more into it
< jonatack> (at least, unless someone is affected or cares about it)
< wumpus> they can't be globally routed anyhow, so for the P2P code i'd say it's kind of irrelevant
< wumpus> happy to make a PR for that if anyone cares
< jonatack> well, i don't know if there's a reason against doing it but i'd review it
< wumpus> it's in the structure so there is something to be said for having it in the ToString() to avoid losing information leading to confusion
< wumpus> though again i have no idea how anything ends up in m_scope_id in the first place
< wumpus> ah CService::CService(const struct sockaddr_in6 &addr) : CNetAddr(addr.sin6_addr, addr.sin6_scope_id)
< luke-jr> michaelfolkson: that's kinda the point of a wiki?
< luke-jr> wumpus: thanks for cleaning it up
< bitcoin-git> [bitcoin] jnewbery closed pull request #18746: consensus: Don't add spent coins to the cache (master...2020-04-not-spent-and-fresh) https://github.com/bitcoin/bitcoin/pull/18746
< wumpus> jonatack: I don't understand practicalswift's reasoning that "scope ids don't make sense", either they're part of the protocol or not
< jonatack> i don't know either. maybe the idea is just that binding, listening and connecting is enough but not return them in the ToString()
< jonatack> i've been more or less stymied about it :D
< jonatack> but i have never used them myself, i have no claim to expertise other than trying to read the docs
< wumpus> anyhow going to do a PR that adds the %<scope_id> and brings back the tests
< jonatack> yay
< bitcoin-git> [bitcoin] laanwj opened pull request #21985: net: Return IPv6 scope id in `CNetAddr::ToStringIP()` (master...2021-05-scopeid) https://github.com/bitcoin/bitcoin/pull/21985
< luke-jr> sipa: can you take a look at https://github.com/bitcoin/bips/pull/935 ? there's 2 other BIPs affected with ACKs already; thanks