< luke-jr> fanquake: doesn't #21629 break using depends for most things, but using system BDB? or is that intended?
< gribble> https://github.com/bitcoin/bitcoin/issues/21629 | build: fix configuring when building depends with NO_BDB=1 by fanquake · Pull Request #21629 · bitcoin/bitcoin · GitHub
< fanquake> what do you mean by most things
< fanquake> how does it break them
< luke-jr> fanquake: it forces BDB support off, no?
< luke-jr> fanquake: eg, make depends NO_BDB=1 but with bdb4.8 on the system install
< luke-jr> previously I assume the system BDB would have been picked up and used
< fanquake> If that was the case then I think that was a bug, or at least not well documented that that would be the behaviour.
< sipa> i would have assumed that a depends build never uses any system library ar all
< fanquake> If you're building from depends you'd only want to be using the depends libraries
< luke-jr> ok, I wasn't sure
< bitcoin-git> [bitcoin] fanquake closed pull request #21764: build: produce Windows GUI build with Cirrus CI (master...cirrus-winbuild) https://github.com/bitcoin/bitcoin/pull/21764
< kallewoof> I don't feel uncomfortable talking to luke-jr about the BIP editor thing, but from what I understand, luke-jr believes that there is an outstanding NACK against me becoming a BIP editor from gmax, which I believe is the reason for the standstill. Personally I don't think one person's NACK should be such a deciding factor, especially since the reason for the NACK doesn't even exist anymore, but I'm not going to push the
< kallewoof> issue. If people want me to become BIP editor to help out I will gladly do so. My offer stands as it has for some time now.
< wumpus> kallewoof: gmaxwell retracted the NACK it should be okay now
< kallewoof> wumpus: That's my impression as well.
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21947: doc: Fix OSS-Fuzz links (master...2105-fuzzDoc) https://github.com/bitcoin/bitcoin/pull/21947
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b34bf2b42caa...61fea5217118
< bitcoin-git> bitcoin/master 07bc22e Klement Tan: docs: improve make with parallel jobs description.
< bitcoin-git> bitcoin/master 61fea52 MarcoFalke: Merge bitcoin/bitcoin#21942: docs: improve make with parallel jobs descrip...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21942: docs: improve make with parallel jobs description. (master...docs/improve-jX) https://github.com/bitcoin/bitcoin/pull/21942
< vasild> promag: https://github.com/bitcoin/bitcoin/pull/21943#discussion_r632360108 -- yes, I think it is pointless or even - undesirable. InactivityCheck() is a noop if executed <60s after the node has connected (can be changed with -peertimeout)
< vasild> if it happens that we do the InactivityCheck() >60s after the node has connected, this means it took that loop >60s to process the other nodes (using non-blocking IO)
< vasild> if that happens then InactivityCheck() will ask us to disconnect because node.nLastRecv == 0 || node.nLastSend == 0, ie nothing has been received or sent to the node for 60s after it connected. But this seems wrong because we would not have attempted to send or receive anything.
< vasild> thus I think InactivityCheck() on just accepted nodes is undesirable.
< promag> vasild: add an early commit that changes that behavior first by moving the accept connections to the end? as it is seems like an unintentional change
< vasild> yes, I am looking into doing that
< promag> vasild: great, note that I'm noob on net/p2p code
< vasild> me too
< promag> ^^
< sipa> if you guys keep improving the p2p/net code i'll soon be a noob at it again too ;)
< promag> sipa: I thought you just do bitcoin stuff
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/61fea5217118...b82c3a0075db
< bitcoin-git> bitcoin/master fae814c MarcoFalke: fuzz: Remove incorrect float round-trip serialization test
< bitcoin-git> bitcoin/master b82c3a0 W. J. van der Laan: Merge bitcoin/bitcoin#21929: fuzz: Remove incorrect float round-trip seria...
< bitcoin-git> [bitcoin] laanwj merged pull request #21929: fuzz: Remove incorrect float round-trip serialization test (master...2105-fuzzFloat) https://github.com/bitcoin/bitcoin/pull/21929
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b82c3a0075db...ecf5f2c1a06e
< bitcoin-git> bitcoin/master 469a5bc fanquake: build: build Boost with -fcf-protection when targeting Darwin
< bitcoin-git> bitcoin/master 42b589d fanquake: scripts: test for MACHO control flow instrumentation
< bitcoin-git> bitcoin/master ecf5f2c W. J. van der Laan: Merge bitcoin/bitcoin#21889: macho: check for control flow instrumentation...
< bitcoin-git> [bitcoin] laanwj merged pull request #21889: macho: check for control flow instrumentation (master...build_boost_fcf_protectcion) https://github.com/bitcoin/bitcoin/pull/21889
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21948: test: Fix off-by-one in mockscheduler test RPC (master...2105-testMock1) https://github.com/bitcoin/bitcoin/pull/21948
< murch> Seems like a bunch of the freenode staff is considering resigning over some corporate takeover.
< bitcoin-git> [gui] jarolrod opened pull request #329: fix console buttons hitbox on macOS (master...fix-cb-hitbox) https://github.com/bitcoin-core/gui/pull/329