< bitcoin-git>
bitcoin/master 29c9e2c Hennadii Stepanov: wallet: Do not iterate a directory if having an error while accessing it
< bitcoin-git>
bitcoin/master a31a1ce Samuel Dobson: Merge bitcoin/bitcoin#21907: wallet: Do not iterate a directory if having ...
< bitcoin-git>
[bitcoin] meshcollider merged pull request #21907: wallet: Do not iterate a directory if having an error while accessing it (master...210510-win) https://github.com/bitcoin/bitcoin/pull/21907
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21940: refactor: Mark CAddrMan::Select const (master...2105-addrmanConstSelect) https://github.com/bitcoin/bitcoin/pull/21940
< wumpus>
promag: oh uhm oops seems I was checking the wrong binary, have retracted the ACK for now and will redo the check
< wumpus>
promag: updated my github post, it checks out anyway
< wumpus>
it appears that even with optimization disabled, gcc does some kind of optimization for clearing small data structures
< promag>
Thanks wumpus
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #21941: fuzz: Call const member functions in addrman fuzz test only once (master...2105-fuzzAddrConst) https://github.com/bitcoin/bitcoin/pull/21941
< bitcoin-git>
[bitcoin] klementtan opened pull request #21942: docs: improve make with parallel jobs description. (master...docs/improve-jX) https://github.com/bitcoin/bitcoin/pull/21942
< bitcoin-git>
[bitcoin] vasild opened pull request #21943: Dedup and RAII-fy the creation of a copy of CConnman::vNodes (master...raiify_copying_vnodes) https://github.com/bitcoin/bitcoin/pull/21943
< bitcoin-git>
[bitcoin] theStack opened pull request #21945: test: add P2PK support to MiniWallet (master...202005-test-miniwallet-support-p2pk) https://github.com/bitcoin/bitcoin/pull/21945
< Arvidt>
What is that version "v22.0" on the last line of https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md ? Is it not Bitcoin version (they all start with v0.) ? Would make sense, since V.0.22 is not released yet and there are backports to 0.20 and 0.21 ongoing.
< achow101>
Arvidt: we've dropped the leading 0. from the version number for the next release
< bitcoin-git>
[bitcoin] ariard opened pull request #21946: Document and test lack of inherited signaling in RBF policy (master...2021-05-rbf-noinheritance) https://github.com/bitcoin/bitcoin/pull/21946
< dongcarl>
We’re nearing the start of the contingency buffer period for Guix, in fact, #21239 should be the last piece needed before we reach feature-parity with Gitian.
< dongcarl>
I’d like to do a full dress-rehearsal (with codesigning) of some commit (perhaps just a version of #21239) this week or the next. I’ve already tried with my personal developer certs with win/osx to make sure there aren’t any glaring issues, but perhaps having others try it out will reveal some UX hiccups that can be addressed somewhat easily.
< dongcarl>
I'd be curious if there'd be problems with codesigning an intermediary commit with our certs? I'm guessing that might lead to problems if people get a hold of the resulting binary?
< wumpus>
dongcarl: why would that lead to problems?
< achow101>
dongcarl: considering the current cert is expired, I don't see why not. the only problem might be in making the signature
< achow101>
still working on getting a new cert
< dongcarl>
Oh! Signing with expired certs should be fine then...
< wumpus>
i mean, we're not going to upload it to bitcoincoreorg, but even if so, it'd be like a pre-rc
< dongcarl>
I'm just worried people might try to pass it off as a new release of core or something...
< wumpus>
nah, doubtful
< dongcarl>
Okay :-)
< dongcarl>
Once we have enough review on the codesigning PR
< dongcarl>
We can decide on a commit and do the dress rehearsal
< wumpus>
i don't think it is code signing that makes the difference in people's minds there
< dongcarl>
wumpus: Heh that's true
< wumpus>
things like announcements, articles, release notes, etc are
< wumpus>
right, let's try to review and merge 21239 soon
< dongcarl>
Incidentally, does it matter that osslsign defaults to using sha1 as the digest?
< wumpus>
then pick a commit
< dongcarl>
I noticed when checking my self-signed binary...
< wumpus>
isn't sha1 very broken?
< dongcarl>
Right, that's why I was curious... We can supply a flag and choose another digest easily tho
< achow101>
If the default is sha1, then that's what we've been using
< dongcarl>
Just wanted to make sure if there were any justifications or if it was just overlooked
< wumpus>
maybe some old version of windows supports only sha1? i don't know what is the minimum we support nowadays
< dongcarl>
I think the codesigning scheme in windows supports having multiple digests
< dongcarl>
So we can also just do sha1+sha256
< wumpus>
does that complicate the attachment?
< dongcarl>
Hmmm, unsure. We can check if the older versions that only support sha1 are too old for us. Anyway, I can open an issue abt this :-)
< wumpus>
I think we should initially try with a modern, non-broken digest
< wumpus>
if any problems come up i'm sure we'll hear about it
< dongcarl>
That too :-)
< dongcarl>
That's it from me!
< wumpus>
thank you!
< jnewbery>
wumpus: I have a couple of requests/announcements.
< jnewbery>
1. I think it's probably time to merge https://github.com/bitcoin/bips/pull/1116 (adding Kalle as BIP editor). It was proposed three weeks ago, has 15 ACKs, and no substantive opposition.
< jnewbery>
"I endorse Harding's recommendations."
< michaelfolkson>
Is there an argument to wait until Taproot has activated (hopefully soon) in case drama on that starts up again? Unfair on Kalle to drop him in it otherwise
< michaelfolkson>
Whatever Kalle's preference I guess
< jnewbery>
Kalle has ACKed
< jnewbery>
luke-jr: are you going to merge this PR?
< michaelfolkson>
luke-jr can chat to Kalle and work out whatever is best. I think everyone is happy with Kalle
< jnewbery>
luke-jr: if you're not prepared to merge it, does it make sense for someone else with commit access to the repo to merge the PR?
< luke-jr>
I'm sorry I am behind, but I don't think breaking process or merging without looking at it properly is an appropriate route to take
< jnewbery>
The process has been followed. This has achieved community consensus
< michaelfolkson>
If Kalle is happy to sort it out with Luke I don't see the problem. Kalle can flag if he's uncomfortable with his discussions with Luke or how fast it is going
< wumpus>
after you've merged it, kallewoof can help you, so it makes sense to prioritize it maybe
< luke-jr>
wumpus: yes
< jnewbery>
If you're unwilling to merge, then I propose that someone else with merge access go ahead and add kallewoof
< wumpus>
ok, anything else?
< jnewbery>
wumpus: what's the plan here?
< jnewbery>
luke-jr is very clearly blocking something that has overwhelming support
< wumpus>
i don't know, please don't ask too much from me now
< fjahr>
michaelfolkson: not sure what needs to be sorted out, as jnewbery said, kalle has acked :)
< luke-jr>
jnewbery: I propose you stop trolling
< michaelfolkson>
Kalle flags if he's uncomfortable with anything. We' re all happy with Kalle and he can discuss with Luke
< jnewbery>
wumpus: I'm not asking very much at all. Just that what has overwhelming support gets done
< michaelfolkson>
If Kalle comes here and says Luke is blocking the progress then we have a problem. If he doesn't and he's happy with how discussions are going with Luke I don't think we have a problem
< michaelfolkson>
Up to Kalle
< ariard>
jnewbery: what's the worst-case scenario if this PR isn't merged and things stay as they are? anyone is free to fork and start maintaining a bip repo if they don't like current editorship
< jnewbery>
ariard: luke-jr doesn't own the bips repo. He's the steward of a shared resource. He's abusing that stewardship
< luke-jr>
no, I am not, liar
< luke-jr>
you are acting maliciously now
< ariard>
jnewbery: a shared resource which is super easy to fork :)
< luke-jr>
I have better things to do than put up with this abuse, ttyl
< michaelfolkson>
We doing this again? Just leave it to Kalle. If he's uncomfortable with anything he can raise it. Everyone has agreed to give responsibility to Kalle, trust his judgement
< wumpus>
i don't think this is going anywhere like this, any other topics?
< jnewbery>
wumpus: I'm still curious what's required to get this merged
< wumpus>
there is really not that much hurry to make it heated like this
< michaelfolkson>
You should have proposed yourself as a BIP editor if you don't trust Kalle to move this along jnewbery
< jnewbery>
michaelfolkson: stop playing games. It's 4:30am in Japan right now. Kalle isn't here.
< wumpus>
why does it have to happen here and now
< jnewbery>
he's ACKed the PR and is ready to be editor
< michaelfolkson>
Games? For trusting Kalle? Rather than imposing my judgement on him? SUre
< jnewbery>
wumpus: I'm just asking what needs to happen to get the PR merged
< wumpus>
luke-jr already said he's going to merge it