< gmaxwell> sipa: it's not clear to me how it's possible to implement the policy to remove floods sent by the far side. You can tell that you already have the txn when you recieve the flood, so presumably you would have put it to be recon .. but it might have already been reconed and not part of your current recon set?
< sipa> gmaxwell: in that case you don't remove it?
< sipa> i believe the set is kept explicitly, not just in sketch form
< gmaxwell> ah
< gmaxwell> that works then.
< bitcoin-git> [bitcoin] sipa opened pull request #21859: Add minisketch subtree and integrate in build/test (master...202105_minisketch) https://github.com/bitcoin/bitcoin/pull/21859
< sipa> ... 7712 lines
< sipa> really?
< fanquake> That's a lot of lines
< sipa> it seems correct
< bitcoin-git> [bitcoin] fanquake opened pull request #21860: [0.21] Backport update to Boost download URL (0.21...backport_boost_download) https://github.com/bitcoin/bitcoin/pull/21860
< sipa> jnewbery: feel like having a look at https://github.com/sipa/minisketch/pull/35 ?
< gmaxwell> sipa: secret to programmer 'productivity' -- tables.
< sipa> gmaxwell: hmm?
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3f8f238deb5a...dc8da2a68554
< bitcoin-git> bitcoin/master fafb880 MarcoFalke: refactor: [index] Replace deprecated char with uint8_t in serialization
< bitcoin-git> bitcoin/master dc8da2a fanquake: Merge bitcoin/bitcoin#21824: refactor: [index] Replace deprecated char wit...
< bitcoin-git> [bitcoin] fanquake merged pull request #21824: refactor: [index] Replace deprecated char with uint8_t in serialization (master...2105-refactorUint8_t) https://github.com/bitcoin/bitcoin/pull/21824
< gmaxwell> sipa: the minisketch LOC is 95% tables.
< gmaxwell> Development Effort Estimate, Person-Years (Person-Months) = 1.84 (22.05)
< gmaxwell> strangly thats maybe not that far off. :P
< sipa> gmaxwell: more like 30%, actually
< sipa> or less
< gmaxwell> hm! I guess they just look huge when scrolling past them.
< sipa> there are 161 field implementations, and each have a few tables
< sipa> together that's 2000 lines or so
< gmaxwell> most of the loc are in build-aux. :P
< gmaxwell> src/ is:
< gmaxwell> SLOCDirectorySLOC-by-Language (Sorted)
< gmaxwell> 1945 fields cpp=1945
< gmaxwell> 1548 top_dir cpp=1548
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dc8da2a68554...779aaa7f03b2
< bitcoin-git> bitcoin/master fa5f938 MarcoFalke: test: Remove new_tx reference
< bitcoin-git> bitcoin/master fa5591d MarcoFalke: test: Hide tx rehash in helper
< bitcoin-git> bitcoin/master fa066f1 MarcoFalke: test: Run feature_cltv with MiniWallet
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21754: test: Run feature_cltv with MiniWallet (master...2104-testCltvNoWallet) https://github.com/bitcoin/bitcoin/pull/21754
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/194b9b8792d9...bbd89d23b3d0
< bitcoin-git> bitcoin/0.21 856de5b fdov: build,boost: update download url.
< bitcoin-git> bitcoin/0.21 bbd89d2 MarcoFalke: Merge bitcoin/bitcoin#21860: [0.21] Backport update to Boost download URL
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21860: [0.21] Backport update to Boost download URL (0.21...backport_boost_download) https://github.com/bitcoin/bitcoin/pull/21860
< jnewbery> sipa: sure. I'll take a look!
< aj> jnewbery: is see #21789 is proposed which conflicts with both #18685 and #19438; we going to try to get the latter two in first?
< gribble> https://github.com/bitcoin/bitcoin/issues/18685 | consensus: Simplify ConnectTrace by jnewbery · Pull Request #18685 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/21789 | refactor: Remove ::Params() global from CChainState by MarcoFalke · Pull Request #21789 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19438 | Introduce deploymentstatus by ajtowns · Pull Request #19438 · bitcoin/bitcoin · GitHub
< aj> gribble has a weird sorting order
< jnewbery> 18685 isn't holding anything up and doesn't have any ACKs on the current branch, so I'm fine to rebase it
< jnewbery> I would like to see your 19438 merged though
< jnewbery> (I still don't think you need a class for VersionBitsCache though: https://github.com/bitcoin/bitcoin/pull/19438#pullrequestreview-644568911)
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21862: test: Set regtest.BIP65Height = 112 to speed up tests (master...2105-testFasterBip65) https://github.com/bitcoin/bitcoin/pull/21862
< aj> jnewbery: a class keeps the lock and locked data structure together so EXC_LOCKS_REQ(!mutex) works and doesn't need to be downgraded to LOCKS_EXCLUDED(mutex), but *shrug*
< jnewbery> is the difference between EXC_LOCKS_REQ(!mutex) and LOCKS_EXCLUDED(mutex) documented somewhere?
< bitcoin-git> [gui] jarolrod opened pull request #317: Direction col peers (master...direction-col-peers) https://github.com/bitcoin-core/gui/pull/317
< aj> jnewbery: REQ(!x) fails unless the compiler is sure x is not held, EXLCUDED(x) only fails if the compiler is sure x is held; but what the compiler is sure about is a bit weird
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/779aaa7f03b2...00a9b0647ee3
< bitcoin-git> bitcoin/master c90f6e5 Carl Dong: guix: Consistently use gcc-8 for $HOST
< bitcoin-git> bitcoin/master 00a9b06 W. J. van der Laan: Merge bitcoin/bitcoin#21799: guix: Use `gcc-8` across the board
< bitcoin-git> [bitcoin] laanwj merged pull request #21799: guix: Use `gcc-8` across the board (master...2021-04-guix-gcc-memcmp) https://github.com/bitcoin/bitcoin/pull/21799
< bitcoin-git> [gui] jarolrod opened pull request #318: Add `Copy address` Peers Tab Context Menu Action (master...copy-addr-peer) https://github.com/bitcoin-core/gui/pull/318
< bitcoin-git> [bitcoin] jonatack closed pull request #21855: fuzz: enable passing a max value to FuzzedDataProvider::ConsumeEnum() (master...ConsumeEnum-enable-passing-max-value) https://github.com/bitcoin/bitcoin/pull/21855
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/00a9b0647ee3...b7c2625703f4
< bitcoin-git> bitcoin/master 465967b fanquake: gitian: install LIEF in gitian container
< bitcoin-git> bitcoin/master 2e7a9f7 fanquake: guix: install LIEF in Guix container
< bitcoin-git> bitcoin/master 7e7eae7 fanquake: contrib: use f strings in security-check.py
< bitcoin-git> [bitcoin] laanwj merged pull request #21664: contrib: use LIEF for macOS and Windows symbol & security checks (master...macos_win_lief) https://github.com/bitcoin/bitcoin/pull/21664
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7c2625703f4...cdcf82622d49
< bitcoin-git> bitcoin/master a549188 fanquake: build: fix configuring when building depends with NO_BDB=1
< bitcoin-git> bitcoin/master cdcf826 W. J. van der Laan: Merge bitcoin/bitcoin#21629: build: fix configuring when building depends ...
< bitcoin-git> [bitcoin] laanwj merged pull request #21629: build: fix configuring when building depends with NO_BDB=1 (master...fixup_depends_sqlite_only_build) https://github.com/bitcoin/bitcoin/pull/21629
< bitcoin-git> [gui] kristapsk opened pull request #319: gui: Paste button in Open URI dialog (master...uri-paste) https://github.com/bitcoin-core/gui/pull/319
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cdcf82622d49...df21e500d6bc
< bitcoin-git> bitcoin/master fa872c9 Carl Dong: depends: Fix id_string invocations
< bitcoin-git> bitcoin/master df21e50 W. J. van der Laan: Merge bitcoin/bitcoin#21427: depends: Fix id_string invocations
< bitcoin-git> [bitcoin] laanwj merged pull request #21427: depends: Fix id_string invocations (master...2021-03-fix-build_id_construction) https://github.com/bitcoin/bitcoin/pull/21427
< jnewbery> sipa: thanks for the opportunity to dive deeper into c++ copy/move elision rules (:
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/df21e500d6bc...fb43d7cb1e60
< bitcoin-git> bitcoin/master f09e6b2 Jon Atack: test: fix off-by-ones in rpc_fundrawtransaction
< bitcoin-git> bitcoin/master fb43d7c W. J. van der Laan: Merge bitcoin/bitcoin#21787: test: fix off-by-ones in rpc_fundrawtransacti...
< bitcoin-git> [bitcoin] laanwj merged pull request #21787: test: fix off-by-ones in rpc_fundrawtransaction assertions (master...fix-fundrawtxn-assertions) https://github.com/bitcoin/bitcoin/pull/21787
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fb43d7cb1e60...75b3a32f033b
< bitcoin-git> bitcoin/master fa80a11 MarcoFalke: test: Add missing test for empty P2WSH redeem
< bitcoin-git> bitcoin/master 75b3a32 W. J. van der Laan: Merge bitcoin/bitcoin#21821: test: Add missing test for empty P2WSH redeem...
< bitcoin-git> [bitcoin] laanwj merged pull request #21821: test: Add missing test for empty P2WSH redeem (master...2105-testP2WSHemptyRedeem) https://github.com/bitcoin/bitcoin/pull/21821
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75b3a32f033b...23109cc5485b
< bitcoin-git> bitcoin/master 65f30e4 Jon Atack: doc: add -addrinfo troubleshooting section to tor.md
< bitcoin-git> bitcoin/master 23109cc W. J. van der Laan: Merge bitcoin/bitcoin#21753: doc: add -addrinfo to tor docs
< bitcoin-git> [bitcoin] laanwj merged pull request #21753: doc: add -addrinfo to tor docs (master...tor-doc-addrinfo) https://github.com/bitcoin/bitcoin/pull/21753
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/23109cc5485b...3275c6e578b4
< bitcoin-git> bitcoin/master fa81c30 MarcoFalke: refactor: Move pruning/reindex/importing globals to blockstorage
< bitcoin-git> bitcoin/master fa247a3 MarcoFalke: refactor: Move block storage globals to blockstorage
< bitcoin-git> bitcoin/master fa7e64d MarcoFalke: move-only: Move constants to blockstorage
< bitcoin-git> [bitcoin] laanwj merged pull request #21727: refactor: Move more stuff to blockstorage (master...2104-blockstorage) https://github.com/bitcoin/bitcoin/pull/21727
< wumpus> fanquake: thanks for making the release 0.21.1 on github https://github.com/bitcoin/bitcoin/releases/tag/v0.21.1, i forgot
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3275c6e578b4...54617fad9988
< bitcoin-git> bitcoin/master 9268270 Jon Atack: doc: update reduce-memory.md peer connections info
< bitcoin-git> bitcoin/master 300234a Jon Atack: doc: update bitcoin.conf maxconnections info
< bitcoin-git> bitcoin/master 54617fa W. J. van der Laan: Merge bitcoin/bitcoin#21709: doc: update reduce-memory.md and bitcoin.conf...
< bitcoin-git> [bitcoin] laanwj merged pull request #21709: doc: update reduce-memory.md and bitcoin.conf -maxconnections info (master...update-reduce-memory-doc) https://github.com/bitcoin/bitcoin/pull/21709
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.21: https://github.com/bitcoin/bitcoin/compare/bbd89d23b3d0...8584a4460d52
< bitcoin-git> bitcoin/0.21 8584a44 W. J. van der Laan: doc: Archive and clean out release notes post-0.21.1
< wumpus> ^ ready for 0.21.1.1 when the windows code signing signature comes in
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54617fad9988...576300afb0ec
< bitcoin-git> bitcoin/master 47c3ea0 Adam Jonas: doc: add OSS-Fuzz section to fuzzing.md doc
< bitcoin-git> bitcoin/master 576300a MarcoFalke: Merge bitcoin/bitcoin#21856: doc: add OSS-Fuzz section to fuzzing.md doc
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21856: doc: add OSS-Fuzz section to fuzzing.md doc (master...add-oss-fuzz) https://github.com/bitcoin/bitcoin/pull/21856
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/576300afb0ec...a0f46028fcd2
< bitcoin-git> bitcoin/master fab1eb6 MarcoFalke: test: Fix feature_config_args.py intermittent issue
< bitcoin-git> bitcoin/master a0f4602 MarcoFalke: Merge bitcoin/bitcoin#21814: test: Fix feature_config_args.py intermittent...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21814: test: Fix feature_config_args.py intermittent issue (master...2104-testInt3) https://github.com/bitcoin/bitcoin/pull/21814
< MarcoFalke> All known intermittent issues with known fixes are fixed now. If you see more popping up, please do report them. ( cc ajonas )
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a0f46028fcd2...b8b68014129e
< bitcoin-git> bitcoin/master 2896c6c Jon Atack: doc: update addnode rpc help
< bitcoin-git> bitcoin/master 79685a8 Jon Atack: doc: update -addnode config option help
< bitcoin-git> bitcoin/master b4fcbcf Jon Atack: doc: update -maxconnections config option help
< bitcoin-git> [bitcoin] laanwj merged pull request #21710: doc: update helps for addnode rpc and -addnode/-maxconnections config options (master...update-addnode-docs) https://github.com/bitcoin/bitcoin/pull/21710
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b8b68014129e...1b9a5236e99f
< bitcoin-git> bitcoin/master 6f6bb3e windsok: test: fix file permissions on various scripts
< bitcoin-git> bitcoin/master 46b025e windsok: test: add new python linter to check file names and permissions
< bitcoin-git> bitcoin/master 1b9a523 W. J. van der Laan: Merge bitcoin/bitcoin#21740: test: add new python linter to check file nam...
< bitcoin-git> [bitcoin] laanwj merged pull request #21740: test: add new python linter to check file names and permissions (master...file-permissions-linter) https://github.com/bitcoin/bitcoin/pull/21740
< bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/1b9a5236e99f...32f1f021bf99
< bitcoin-git> bitcoin/master fabb6df Guido Vranken: script: Replace address-of idiom with vector data() method
< bitcoin-git> bitcoin/master fa05ddd MarcoFalke: refactor: Use CPubKey vector constructor where possible
< bitcoin-git> bitcoin/master face961 MarcoFalke: refactor: Use only one temporary buffer in CreateObfuscateKey
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21817: refactor: Replace &foo[0] with foo.data() (master...2104-refactorData) https://github.com/bitcoin/bitcoin/pull/21817
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/32f1f021bf99...128b98fce36d
< bitcoin-git> bitcoin/master 931684b James O'Beirne: validation: fix ActivateSnapshot to use hardcoded nChainTx
< bitcoin-git> bitcoin/master 91d93aa James O'Beirne: validation: remove nchaintx from assumeutxo metadata
< bitcoin-git> bitcoin/master 128b98f MarcoFalke: Merge bitcoin/bitcoin#21681: validation: fix ActivateSnapshot to use hardc...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21681: validation: fix ActivateSnapshot to use hardcoded nChainTx (master...2021-04-au-nchaintx-fix) https://github.com/bitcoin/bitcoin/pull/21681
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21863: ci: Set depends DEBUG=1 for msan tasks to get line numbers (master...2105-ciMsanDebug) https://github.com/bitcoin/bitcoin/pull/21863
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #21863: ci: Set depends DEBUG=1 for msan tasks to get line numbers (master...2105-ciMsanDebug) https://github.com/bitcoin/bitcoin/pull/21863
< bitcoin-git> [bitcoin] glozow opened pull request #21864: fix permissions on 00_setup_env_native_fuzz_with_msan.sh (master...2021-05-lint) https://github.com/bitcoin/bitcoin/pull/21864
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/128b98fce36d...f8575bce3118
< bitcoin-git> bitcoin/master d48565d glozow: fix permissions on 00_setup_env_native_fuzz_with_msan
< bitcoin-git> bitcoin/master f8575bc MarcoFalke: Merge bitcoin/bitcoin#21864: fix permissions on 00_setup_env_native_fuzz_w...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21864: fix permissions on 00_setup_env_native_fuzz_with_msan.sh (master...2021-05-lint) https://github.com/bitcoin/bitcoin/pull/21864
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21865: ci: Properly pass msan cflags (master...2105-ciMsan) https://github.com/bitcoin/bitcoin/pull/21865
< bitcoin-git> [bitcoin] dongcarl opened pull request #21866: [Bundle 7/7] validation: Farewell, global Chainstate! (master...2020-10-libbitcoinruntime-v9) https://github.com/bitcoin/bitcoin/pull/21866