< bitcoin-git> [gui] jarolrod opened pull request #345: qt: connection type translator comments (master...connection-translator-comments) https://github.com/bitcoin-core/gui/pull/345
< meshcollider> So is the bot in here
< achow101> Yes
< bitcoin-git> [bitcoin] jarolrod opened pull request #22080: doc: add maxuploadtarget to bitcoin.conf example (master...maxuploadtarget-example) https://github.com/bitcoin/bitcoin/pull/22080
< bitcoin-git> [bitcoin] apitko closed pull request #21499: doc: add maxuploadtarget to bitcoinf.conf example (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21499
< bitcoin-git> [bitcoin] MitchellTesla opened pull request #22081: Test - Do not patch or merge** adds gif image to readme description (master...test) https://github.com/bitcoin/bitcoin/pull/22081
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #22081: Test - Do not patch or merge** adds gif image to readme description (master...test) https://github.com/bitcoin/bitcoin/pull/22081
< bitcoin-git> [bitcoin] martinus opened pull request #22082: test: update nanobench from release 4.0.0 to 4.3.2 (master...2021-05-update-nanobench) https://github.com/bitcoin/bitcoin/pull/22082
< bitcoin-git> [bitcoin] glozow opened pull request #22084: [WIP] package testmempoolaccept followups (master...20833-followups) https://github.com/bitcoin/bitcoin/pull/22084
< hebasto> jonasschnelli: thanks for updating macos sdk on bitcoinbuilds.org! https://bitcoinbuilds.org/index.php?build=10949 looks fine now
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c041cb348e6...811aa24c7111
< bitcoin-git> bitcoin/master 6fe0516 Jon Atack: contrib: add torv3 seed nodes for testnet, drop v2 ones
< bitcoin-git> bitcoin/master 811aa24 W. J. van der Laan: Merge bitcoin/bitcoin#22060: contrib: add torv3 seed nodes for testnet, dr...
< bitcoin-git> [bitcoin] laanwj merged pull request #22060: contrib: add torv3 seed nodes for testnet, drop v2 ones (master...torv3-testnet-hardcoded-seeds) https://github.com/bitcoin/bitcoin/pull/22060
< laanwj> ohh the only drawback of using the name laanwj here is that the bot keeps highlighting me when i merge something
< bitcoin-git> [bitcoin] laanwj closed pull request #21981: Remove unused float serialization (master...2105-NoSerFloat) https://github.com/bitcoin/bitcoin/pull/21981
< meshcollider> laanwj: welcome to the club haha
< laanwj> meshcollider: haha thank you !
< bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/811aa24c7111...b789914f1723
< bitcoin-git> bitcoin/master 8b77133 Hennadii Stepanov: qt: Replace disambiguation strings with translator comments
< bitcoin-git> bitcoin/master b789914 Hennadii Stepanov: Merge bitcoin-core/gui#332: Replace disambiguation strings with translator...
< bitcoin-git> [gui] hebasto merged pull request #332: Replace disambiguation strings with translator comments (master...210515-trcom) https://github.com/bitcoin-core/gui/pull/332
< bitcoin-git> [gui] hebasto opened pull request #346: English translations update (master...210527-tr) https://github.com/bitcoin-core/gui/pull/346
< bitcoin-git> [gui] hebasto closed pull request #292: WIP: translate strings (#288) (master...translate-service-strings) https://github.com/bitcoin-core/gui/pull/292
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b789914f1723...22b845291cdf
< bitcoin-git> bitcoin/master cb7eba2 Hennadii Stepanov: build: Use Qt archive of the same version as the compiled binaries
< bitcoin-git> bitcoin/master 22b8452 W. J. van der Laan: Merge bitcoin/bitcoin#22063: build: Use Qt archive of the same version as ...
< bitcoin-git> [bitcoin] laanwj merged pull request #22063: build: Use Qt archive of the same version as the compiled binaries (master...210525-version) https://github.com/bitcoin/bitcoin/pull/22063
< bitcoin-git> [gui] hebasto merged pull request #346: English translations update (master...210527-tr) https://github.com/bitcoin-core/gui/pull/346
< bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22b845291cdf...7076bba84177
< bitcoin-git> bitcoin/master bfb53dd Hennadii Stepanov: scripted-diff: Fix ellipsis after pr20773
< bitcoin-git> bitcoin/master df4c81f Hennadii Stepanov: English translations update
< bitcoin-git> bitcoin/master 7076bba Hennadii Stepanov: Merge bitcoin-core/gui#346: English translations update
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7076bba84177...e20745c1bd1d
< bitcoin-git> bitcoin/master 654472a Dhruv Mehta: [fuzz] Add serialization to deserialization test
< bitcoin-git> bitcoin/master 35571d8 Dhruv Mehta: [fuzz] Occasional valid checksum for transport serialization fuzz test
< bitcoin-git> bitcoin/master e337145 Dhruv Mehta: [fuzz] Occasional valid magic bytes for transport serialization test
< bitcoin-git> [bitcoin] laanwj merged pull request #22029: [fuzz] Improve transport deserialization fuzz test coverage (master...v1-transport-serializer-fuzzing) https://github.com/bitcoin/bitcoin/pull/22029
< bitcoin-git> [bitcoin] fanquake opened pull request #22086: test: remove BasicTestingSetup from unit tests that don't need it (master...remove_unneeded_test_setup) https://github.com/bitcoin/bitcoin/pull/22086
< hebasto> laanwj: could you have another look into #22025?
< gribble> https://github.com/bitcoin/bitcoin/issues/22025 | refactor: Group and re-order CAddrMan members by access type by hebasto · Pull Request #22025 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e20745c1bd1d...ea1e5c2c714f
< bitcoin-git> bitcoin/master 5cd7f8a Hennadii Stepanov: refactor: Do not expose CAddrMan members as protected without need
< bitcoin-git> bitcoin/master 8caf60d Hennadii Stepanov: move-only: Group and re-order CAddrMan members by access type
< bitcoin-git> bitcoin/master ea1e5c2 W. J. van der Laan: Merge bitcoin/bitcoin#22025: refactor: Group and re-order CAddrMan members...
< bitcoin-git> [bitcoin] laanwj merged pull request #22025: refactor: Group and re-order CAddrMan members by access type (master...210523-cam) https://github.com/bitcoin/bitcoin/pull/22025
< hebasto> laanwj: thanks!
< bitcoin-git> [bitcoin] amadeuszpawlik opened pull request #22087: Sanitize ports (master...sanitize_ports) https://github.com/bitcoin/bitcoin/pull/22087
< orionwl[m]> matrix bridge test
< orionwl[m]> looks like you can join here now through matrix #bitcoin-core-dev:libera.chat
< sipa> i read you loud and clear
< BlueMatt> kool
< laanwj> yes, neat
< glozow> darosior: heh, seemed a shame to lose so many review comments
< jamesob> welcome to the new network, same as the old network
< laanwj> hopefully not
< laanwj> having to move IRC servers once was enough
< laanwj> speaking of which, is anyone still on freenode? if so, it might be helpful to mention that the IRC meeting in 5 minutes will be here ,not there as originally planned
< fjahr> sipa did already 5 min ago
< laanwj> ok thanks!
< laanwj> #startmeeting
< core-meetingbot> Meeting started Thu May 27 19:00:08 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
< core-meetingbot> Available commands: action commands idea info link nick
< jamesob> hi
< achow101> hi
< michaelfolkson> hi
< provoostenator> hi
< meshcollider> hi
< hebasto> hi
< ariard> hi
< fjahr> hi
< laanwj> last week was a bit hectic on IRC due to the server transition, but i don't think we have proposed meeting topics (if we do, please correct me)
< laanwj> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
< sipa> hi
< laanwj> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
< jonatack> hi
< laanwj> also if you have any last minute meeting topic, of course
< jamesob> if we have nothing else, here's a quick update on assumeutxo: I'm towards the end of a (pretty involved) rebase and will be pushing that up soon. afterwards I'll run manual tests and start on writing some functional tests.
< achow101> proposed topic: which versions to re-release with new windows code signing cert?
< ariard> laanwj: you might need to update the meeting ping with few nicknames upgrade :)
< jarolrod> hi
< laanwj> ariard: if there's any you'd like to add let me know
< ariard> laanwj: yours is changed at least
< jonatack> _aj_: s/aj/_aj_/
< jonatack> s/bluematt/BlueMatt/
< laanwj> ariard: jonatack good point
< darosior> hi
< laanwj> #topic High priority for review
< core-meetingbot> topic: High priority for review
< laanwj> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, no bugfixes, nothing chasing Concept ACK
< achow101> couple things were merged
< laanwj> anything to add/remove, or that is almost ready for merge?
< sipa> can i have #22051 ?
<@gribble> https://github.com/bitcoin/bitcoin/issues/22051 | Basic Taproot derivation support for descriptors by sipa · Pull Request #22051 · bitcoin/bitcoin · GitHub
< laanwj> i suppose #20833 is
<@gribble> https://github.com/bitcoin/bitcoin/issues/20833 | rpc/validation: enable packages through testmempoolaccept by glozow · Pull Request #20833 · bitcoin/bitcoin · GitHub
< achow101> #22008 for me
<@gribble> https://github.com/bitcoin/bitcoin/issues/22008 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< jamesob> can I have #21526?
<@gribble> https://github.com/bitcoin/bitcoin/issues/21526 | validation: UpdateTip/CheckBlockIndex assumeutxo support by jamesob · Pull Request #21526 · bitcoin/bitcoin · GitHub
< sipa> #22008 again, bot?
<@gribble> https://github.com/bitcoin/bitcoin/issues/22008 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
< ariard> yes 20833 is pretty mature, would be glad to have few last eyes on it
< achow101> sipa: I guess the bot just hates me
< darosior> ariard: looking at it, currently getting up to date with all the precedent comments
< laanwj> achow101: sipa jamesob added
< jamesob> thanks
< ariard> darosior: thanks
< laanwj> #topic Versions to re-release with new windows code signing cert (achow101)
< core-meetingbot> topic: Versions to re-release with new windows code signing cert (achow101)
< achow101> I finally got a new windows code signing cert
< laanwj> imo don't re-release anything, just use the cert for new versions
< achow101> the versions that were affected by the previous cert being revoked are 0.21.1, 0.21.0, 0.20.1, 0.20.0, and 0.19.2
< achow101> the question is which should we do a x.x.x.1 release for with the new cert
< achow101> 0.21.1.1 I think is obvious
< laanwj> people can always use the zip for installation on windows if they want
< laanwj> yes
< achow101> it would be nice of each major version had a version that didn't fail to install on windows
< laanwj> 0.21 needs a new release anyway, why not 0.21.2 though
< sipa> do we things queued up for 0.21.2?
< sipa> right, that
< laanwj> i saw MarcoFalke already did bafckports
< achow101> provoostenator suggested making a 0.20.2 since there's stuff for it too
< jonasschnelli> hi
< laanwj> #22022
<@gribble> https://github.com/bitcoin/bitcoin/issues/22022 | Final backports for 0.21.2rc1 by MarcoFalke · Pull Request #22022 · bitcoin/bitcoin · GitHub
< laanwj> clearly the certificate change needs to be backported too
< laanwj> oh, thats in there
< achow101> are there enough things to be backported for 0.21.2? We did 0.21.1 only 4 weeks ago
< laanwj> i mean, we're going to do a release anyway right
< laanwj> normally i'd say no
< achow101> true
< sipa> right, given that there are repo changes for the new cert anyway, it'd necessitate doing the full build process over, and just the codesigning step?
< laanwj> yeah! if it was a matter of simply attaching the signature (no rebuild) it would be different
< achow101> I could just attach the signature.. it just wouldn't fit within gitian
< jonasschnelli> does the new codesigning LLC obtains apple code signing certificates already?
< achow101> jonasschnelli: no
< laanwj> achow101: so it would need a different script than the normal signature attachment
< jonasschnelli> They might want to see a D.U.N.S number (which could take a few days to get).
< achow101> jonasschnelli: we have a duns number
< achow101> laanwj: yes, and future gitian builds would get a different result
< jonasschnelli> good... then a matter of minutes (and 99$) to get one
< achow101> new release is the path of least resistance still I think
< laanwj> yes
< achow101> What about for the 0.19 branch then?
< achow101> there haven't been any other backports
< laanwj> no strong opinion on that, we could do a 0.19.2.1 if anyone really wants one, i'm not sure it's the effort just for a certificate update
< sipa> how many 0.19 are there on the network?
< achow101> oh, we never finished releasing 0.20.2, the latest tag there is for 0.20.2rc1. I guess now's the time to do that.
< laanwj> achow101: hah we didn't finish the 0.20 release ... no one complained
< laanwj> achow101: yes
< sipa> that's going to be a *big* 0.20.2rc2 i guess
< sipa> or just 0.20.3
< laanwj> sipa: but people already on the network with 0.19 don't need to upgrade just to get a different codesigning cert :)
< laanwj> after all, the certificate is for the installer only not the binary that is run
< jonasschnelli> sipa: cat dnsseed.dump | grep " 100.00% 100.00% 100.00%" | grep "/Satoshi:0.19" | wc -l --> 38
< laanwj> that would have been *much* worse
< sipa> laanwj: of course; just to get an idea of popularity, however bogus the measurement is
< achow101> I'm fine with leaving 0.19 as it is. it's almost eol anyways
< laanwj> i think i stick with my original response, use the cert for new releases if they are needed anyuway
< emzy> sipa: $ cat dnsseed.dump | grep " 100.00% 100.00% 100.00%" | grep "/Satoshi:0.19" | wc -l --> 56
< jonasschnelli> 518 "good" 0.19 nodes on my seeder
< laanwj> then do a 0.21.2 soon
< achow101> laanwj: sgtm
< achow101> #22017 is the pr
<@gribble> https://github.com/bitcoin/bitcoin/issues/22017 | Update Windows code signing certificate by achow101 · Pull Request #22017 · bitcoin/bitcoin · GitHub
< laanwj> and 0.20.2 i guess which has been in rc for too long
< laanwj> #topic Assumeutxo update (jamesob)
< core-meetingbot> topic: Assumeutxo update (jamesob)
< jamesob> As stated early, just finishing up a big rebase and will push that today, to be followed shortly with manual/functional tests
< jamesob> *earlier
< jamesob> thanks for everyone's patience and help so far
< laanwj> jamesob: thanks for the update
< jamesob> anytime
< laanwj> any other topics for today?
< ariard> jamesob: quite awesome to hear progress on assumeutxo :)
< jamesob> thanks ariard! I'm excited
< laanwj> #endmeeting
< core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
< core-meetingbot> Meeting ended Thu May 27 19:29:44 2021 UTC.
< dongcarl> g_chainman de-globalization reviewers: Since we're just a few weeks away from feature freeze, I'd love to get bundle 6 in ASAP (bundle 7 will be the last one and removes all review-only assertions)
< bitcoin-git> [bitcoin] jarolrod opened pull request #22088: doc: improve note on choosing posix mingw32 (master...windows-ubuntu-note) https://github.com/bitcoin/bitcoin/pull/22088
< jamesob> dongcarl: will be reviewing that in the next few days
< dongcarl> jamesob: Thanks :-)
< jonatack> i'm preparing to push finished versions of the tor v2 removal and the inbound eviction protection generalized to multiple special networks (onion, i2p, others)
< laanwj> i'm testing the torv2 removal PR on one of my nodes, haven't run into any problems yet
< _aj_> laanwj: #19438 for highpri pls?
<@gribble> https://github.com/bitcoin/bitcoin/issues/19438 | Introduce deploymentstatus by ajtowns · Pull Request #19438 · bitcoin/bitcoin · GitHub
< laanwj> and it's only connecting to torv3s as expected (even though the Tor is old enough to still support torv2)
< jonatack> laanwj: thanks! i've been testing it very extensively these past days, including with seeds, etc, and all is well. am toying with bumping the Format version for the fuzzing inputs
< laanwj> _aj_: added
< laanwj> achow101: so first step, i guess, is to merge #22017 into master?
<@gribble> https://github.com/bitcoin/bitcoin/issues/22017 | Update Windows code signing certificate by achow101 · Pull Request #22017 · bitcoin/bitcoin · GitHub
< achow101> laanwj: yes
< _aj_> laanwj: tnx
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ea1e5c2c714f...2e8f3928f1dd
< bitcoin-git> bitcoin/master 167fb1f Andrew Chow: Update Windows code signing certificate
< bitcoin-git> bitcoin/master 2e8f392 W. J. van der Laan: Merge bitcoin/bitcoin#22017: Update Windows code signing certificate
< bitcoin-git> [bitcoin] laanwj merged pull request #22017: Update Windows code signing certificate (master...2021-win-codesign-cert) https://github.com/bitcoin/bitcoin/pull/22017
< _aj_> achow101: ever get an explanation/excuse for why they cancelled the old cert btw?
< achow101> _aj_: nope
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.20: https://github.com/bitcoin/bitcoin/compare/56311988bff1...55631547ea88
< bitcoin-git> bitcoin/0.20 5563154 Andrew Chow: Update Windows code signing certificate
< laanwj> _aj_: yes, that was really awful, i feel we owe an explanation for that
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/2f9f9b37b595...461b9b11b20a
< bitcoin-git> bitcoin/0.19 461b9b1 Andrew Chow: Update Windows code signing certificate
< cfields> sorry I've missed this cert stuff. Can anyone give a quick tl;dr of what happened?
< achow101> cfields: comodo unexpectedly revoked the previous cert when I tried to renew it. Then it was a pain to get a new cert because the validation rules have changed. So we had to make a new LLC for that and it took some time.
< bitcoin-git> [bitcoin] theStack opened pull request #22089: test: MiniWallet: fix fee calculation for P2PK and check tx vsize (master...202105-test-miniwallet-fix_p2pk_fee_calculation) https://github.com/bitcoin/bitcoin/pull/22089
< achow101> the revocation was retroactive so all of our previous releases signed with that cert now won't install on windows
< laanwj> dongcarl: yes, will look into that soon
< cfields> ugh, right, I guess timestamped signatures don't help with that by design.
< cfields> that's very annoying.
< cfields> nice to see that revocation works as intended though, I guess :p
< dongcarl> :-)
< laanwj> very good that it works though slightly scary that it can just happen under us arbitarily
< laanwj> happy it's only the installer that is signed, imagine if the actual binary was signed and suddenly was rejected when trying to start it
< sipa> laanwj: i'm kind of surprised things don't already work that way
< sipa> (but also relieved)
< achow101> it works that way on mac though
< laanwj> of course it does :(
< sipa> of course it does, indeed
< bitcoin-git> [bitcoin] laanwj pushed 15 commits to master: https://github.com/bitcoin/bitcoin/compare/2e8f3928f1dd...7257e50dba36
< bitcoin-git> bitcoin/master 42cf8b2 glozow: [validation] make CheckSequenceLocks context-free
< bitcoin-git> bitcoin/master 897e348 glozow: [coins/mempool] extend CCoinsViewMemPool to track temporary coins
< bitcoin-git> bitcoin/master 249f43f glozow: [refactor] add option to disable RBF
< bitcoin-git> [bitcoin] laanwj merged pull request #20833: rpc/validation: enable packages through testmempoolaccept (master...package-testmempoolaccept) https://github.com/bitcoin/bitcoin/pull/20833
< bitcoin-git> [bitcoin] bram00767 opened pull request #22090: Update superblocks.yaml bram (master...bram-darras) https://github.com/bitcoin/bitcoin/pull/22090
< bitcoin-git> [bitcoin] fanquake closed pull request #22090: Update superblocks.yaml bram (master...bram-darras) https://github.com/bitcoin/bitcoin/pull/22090
< dongcarl> When I was looking at it... It seems like the actual binary isn't actually codesigned, but I'm most likely wrong
< dongcarl> I think it's only the installer that's codesigned...
< dongcarl> the NSIS installer
< cfields> <laanwj> happy it's only the installer that is signed ...
< cfields> you're not wrong :)
< dongcarl> Ah right
< dongcarl> :-)