<bitcoin-git>
[bitcoin] tiagosh opened pull request #31775: rpc: collect transaction fees on generateblock (master...2025/01/collect-fees-on-generateblock) https://github.com/bitcoin/bitcoin/pull/31775
<yancy>
Hi, I was wondering if can get help reviewing 31656. It's been open a few weeks now and had some inital review but I haven't had any responses as of late.
<stevenroose>
I think i recall reading that bitcoind started adding random delays to tx relay recently. Is that behavior also enabled in regtest by default? Is there a flag to turn it off?
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
<sipa>
stevenroose: it has literally always done that
<sipa>
yancy: it's your responsibility to convince reviewers it's worth their time; there are many more things waiting for review
kevkevin has quit [Remote host closed the connection]
twistedline has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
<yancy>
sipa, thanks for the feedback. It's probably not a very interesting PR since it's just a simple improvement to the test-suit. That being said, the test isn't actually testing what it purports to in it's current state.
<yancy>
jon_atack, thanks I read through your post, and I'm happy to review PRs as I find them that I can give feedback on.
<yancy>
jon_atack and sipa - let me know if there's something more interesting you want help reviewing :)
kevkevin has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
robobub has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<lightlike>
stevenroose: for local testing, you can whitelist your peer for immediate relay. many of our functional tests use "-whitelist=noban,in,out@127.0.0.1" for example.
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]