#bitcoin-core-dev on 2025-02-12 — searchable irc log

2025-01-16 14:22 achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:25 johnzwen- has quit [Quit: Leaving...]

00:25 johnzweng has joined #bitcoin-core-dev

00:25 cman has joined #bitcoin-core-dev

00:26 conman has quit [Ping timeout: 260 seconds]

00:41 jonatack has joined #bitcoin-core-dev

00:45 szkl has quit [Quit: Connection closed for inactivity]

00:45 pyth has joined #bitcoin-core-dev

00:51 pyth has quit [Ping timeout: 268 seconds]

00:52 pyth has joined #bitcoin-core-dev

01:08 pyth has quit [Ping timeout: 260 seconds]

01:24 eugenesiegel has quit [Quit: Client closed]

01:29 <bitcoin-git> [bitcoin] luke-jr opened pull request #31845: Add -pruneduringinit option to temporarily use another prune target during IBD (master...pruneduringinit) https://github.com/bitcoin/bitcoin/pull/31845

01:37 Cory58 has quit [Quit: Client closed]

01:37 Cory58 has joined #bitcoin-core-dev

01:44 zeropoint has quit [Quit: leaving]

01:58 Cory58 has quit [Quit: Client closed]

01:58 Cory58 has joined #bitcoin-core-dev

02:46 brunoerg has quit [Remote host closed the connection]

02:55 brunoerg has joined #bitcoin-core-dev

02:59 brunoerg has quit [Ping timeout: 252 seconds]

03:06 jonatack has quit [Ping timeout: 260 seconds]

03:07 jonatack has joined #bitcoin-core-dev

04:22 bitdex has joined #bitcoin-core-dev

04:39 brunoerg has joined #bitcoin-core-dev

04:43 jamesob443688173 has quit [Read error: Connection reset by peer]

04:43 jamesob15665 has quit [Read error: Connection reset by peer]

04:44 brunoerg has quit [Ping timeout: 268 seconds]

04:45 jamesob15665 has joined #bitcoin-core-dev

04:45 jamesob443688173 has joined #bitcoin-core-dev

04:47 jarthur has joined #bitcoin-core-dev

05:01 cmirror has joined #bitcoin-core-dev

05:07 jon_atack has joined #bitcoin-core-dev

05:08 jonatack has quit [Ping timeout: 244 seconds]

05:10 jonatack has joined #bitcoin-core-dev

05:12 jon_atack has quit [Ping timeout: 252 seconds]

05:29 SpellChecker has quit [Remote host closed the connection]

05:31 SpellChecker has joined #bitcoin-core-dev

05:52 flow has quit [Ping timeout: 252 seconds]

05:56 flow has joined #bitcoin-core-dev

05:57 abubakarsadiq has quit [Quit: Connection closed for inactivity]

06:01 mcey_ has quit [Remote host closed the connection]

06:01 mcey_ has joined #bitcoin-core-dev

06:04 Cory58 has quit [Quit: Client closed]

06:04 Cory58 has joined #bitcoin-core-dev

06:07 jamesob156653 has joined #bitcoin-core-dev

06:09 jamesob443688173 has quit [Ping timeout: 248 seconds]

06:09 jamesob15665 has quit [Ping timeout: 248 seconds]

06:09 jamesob156653 is now known as jamesob15665

06:20 emcy__ has joined #bitcoin-core-dev

06:24 mcey_ has quit [Ping timeout: 272 seconds]

06:45 robobub has joined #bitcoin-core-dev

06:58 jonatack has quit [Ping timeout: 268 seconds]

07:01 jonatack has joined #bitcoin-core-dev

07:32 <bitcoin-git> [gui-qml] davidgumberg opened pull request #443: doc: Add missing fedora dependency (main...2-11-24-fedora-build-docs) https://github.com/bitcoin-core/gui-qml/pull/443

07:33 szkl has joined #bitcoin-core-dev

07:34 pyth has joined #bitcoin-core-dev

07:34 jonatack has quit [Ping timeout: 244 seconds]

07:54 Cory58 has quit [Quit: Client closed]

07:54 Cory58 has joined #bitcoin-core-dev

07:54 pyth has quit [Remote host closed the connection]

08:10 josie has quit [Ping timeout: 260 seconds]

08:10 josie has joined #bitcoin-core-dev

08:38 jarthur has quit [Quit: jarthur]

08:48 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c65233230f18...a44ccedcc2cc

08:48 <bitcoin-git> bitcoin/master 76c0901 fanquake: guix: remove test-security/symbol-check scripts

08:48 <bitcoin-git> bitcoin/master a44cced merge-script: Merge bitcoin/bitcoin#31818: guix: remove test-security/symbol-check scrip...

08:48 <bitcoin-git> [bitcoin] fanquake merged pull request #31818: guix: remove test-security/symbol-check scripts (master...remove_test_sec_scripts) https://github.com/bitcoin/bitcoin/pull/31818

08:55 Cory58 has quit [Quit: Client closed]

08:55 Cory58 has joined #bitcoin-core-dev

09:41 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a44ccedcc2cc...0b6ed342b574

09:41 <bitcoin-git> bitcoin/master f605f7a Cory Fields: build: refactor: set debug definitions in main CMakeLists

09:41 <bitcoin-git> bitcoin/master 56a9b84 Cory Fields: build: set build type and per-build-type flags as early as possible

09:41 <bitcoin-git> bitcoin/master 0b6ed34 merge-script: Merge bitcoin/bitcoin#31711: build: set build type and per-build-type flag...

09:41 <bitcoin-git> [bitcoin] fanquake merged pull request #31711: build: set build type and per-build-type flags as early as possible (master...cmake-early-checks-flags) https://github.com/bitcoin/bitcoin/pull/31711

10:18 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0b6ed342b574...42251e00e8bb

10:18 <bitcoin-git> bitcoin/master b28917b Hennadii Stepanov: depends: Make default `host` and `build` comparable

10:18 <bitcoin-git> bitcoin/master 42251e0 merge-script: Merge bitcoin/bitcoin#30584: depends: Make default `host` and `build` comp...

10:19 <bitcoin-git> [bitcoin] fanquake merged pull request #30584: depends: Make default `host` and `build` comparable (master...240804-cross) https://github.com/bitcoin/bitcoin/pull/30584

10:22 TallTim_ has joined #bitcoin-core-dev

10:23 Guyver2 has joined #bitcoin-core-dev

10:25 TallTim has quit [Ping timeout: 252 seconds]

10:42 brunoerg has joined #bitcoin-core-dev

10:47 brunoerg has quit [Ping timeout: 248 seconds]

10:49 hernanmarino has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]

10:51 hernanmarino has joined #bitcoin-core-dev

11:06 Cory58 has quit [Quit: Client closed]

11:06 Cory58 has joined #bitcoin-core-dev

11:18 <bitcoin-git> [bitcoin] maflcko opened pull request #31846: test: Remove stale gettime test (master...2502-test-stale-time) https://github.com/bitcoin/bitcoin/pull/31846

11:24 pyth has joined #bitcoin-core-dev

11:38 pyth has quit [Remote host closed the connection]

12:25 Guest74 has joined #bitcoin-core-dev

12:25 Guest74 has quit [Client Quit]

12:31 agentcasey_ has joined #bitcoin-core-dev

12:31 agentcasey has quit [Ping timeout: 252 seconds]

12:36 brunoerg has joined #bitcoin-core-dev

12:36 agentcasey has joined #bitcoin-core-dev

12:37 agentcasey_ has quit [Ping timeout: 260 seconds]

12:40 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

12:54 <bitcoin-git> [bitcoin] s373nZ opened pull request #31847: [WIP] build: name install targets as components (master...31745-install-components) https://github.com/bitcoin/bitcoin/pull/31847

13:02 jespada has joined #bitcoin-core-dev

13:18 abubakarsadiq has joined #bitcoin-core-dev

13:26 brunoerg has quit [Remote host closed the connection]

13:32 brunoerg has joined #bitcoin-core-dev

14:02 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42251e00e8bb...87ce116058f2

14:02 <bitcoin-git> bitcoin/master fa3a4ea MarcoFalke: test: Remove stale gettime test

14:02 <bitcoin-git> bitcoin/master 87ce116 merge-script: Merge bitcoin/bitcoin#31846: test: Remove stale gettime test

14:02 <bitcoin-git> [bitcoin] fanquake merged pull request #31846: test: Remove stale gettime test (master...2502-test-stale-time) https://github.com/bitcoin/bitcoin/pull/31846

14:14 <laanwj> Sjors: re #31407 afaik the "part of the file was not parsed" warning has been there for a long time

14:14 <corebot> https://github.com/bitcoin/bitcoin/issues/31407 | guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries by achow101 · Pull Request #31407 · bitcoin/bitcoin · GitHub

14:14 zeropoint has joined #bitcoin-core-dev

14:36 jonatack has joined #bitcoin-core-dev

14:48 <bitcoin-git> [bitcoin] darosior closed pull request #31792: Double check all block rules in `ConnectBlock`, not only `CheckBlock` (master...2502_ctx_checks_in_connectblock) https://github.com/bitcoin/bitcoin/pull/31792

14:50 Cory58 has quit [Quit: Client closed]

14:50 Cory58 has joined #bitcoin-core-dev

14:54 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/87ce116058f2...534414ca9d4f

14:54 <bitcoin-git> bitcoin/master fa952ac MarcoFalke: ci: Skip read-write of default env vars

14:54 <bitcoin-git> bitcoin/master 534414c merge-script: Merge bitcoin/bitcoin#31678: ci: Skip read-write of default env vars

14:54 <bitcoin-git> [bitcoin] fanquake merged pull request #31678: ci: Skip read-write of default env vars (master...2501-ci-skip) https://github.com/bitcoin/bitcoin/pull/31678

14:58 Guyver2 has joined #bitcoin-core-dev

15:03 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/534414ca9d4f...ede388d03df0

15:03 <bitcoin-git> bitcoin/master c4e4983 Cory Fields: build: avoid unnecessary dependencies on generated headers

15:03 <bitcoin-git> bitcoin/master 12fa951 Cory Fields: build: simplify dependency graph

15:03 <bitcoin-git> bitcoin/master ede388d merge-script: Merge bitcoin/bitcoin#30911: build: simplify by flattening the dependency ...

15:03 <bitcoin-git> [bitcoin] fanquake merged pull request #30911: build: simplify by flattening the dependency graph (master...cmake-flatten-dependencies) https://github.com/bitcoin/bitcoin/pull/30911

15:14 <bitcoin-git> [bitcoin] s373nZ closed pull request #31847: [WIP] build: name install targets as components (master...31745-install-components) https://github.com/bitcoin/bitcoin/pull/31847

15:17 Cory58 has quit [Quit: Client closed]

15:17 Cory58 has joined #bitcoin-core-dev

15:19 bitdex has quit [Quit: = ""]

15:20 brunoerg has quit [Remote host closed the connection]

15:21 brunoerg has joined #bitcoin-core-dev

15:26 brunoerg has quit [Ping timeout: 248 seconds]

15:38 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ede388d03df0...713bf66b1f77

15:38 <bitcoin-git> bitcoin/master f89f168 Hennadii Stepanov: depends: Fix compiling `libevent` package on NetBSD

15:38 <bitcoin-git> bitcoin/master 713bf66 merge-script: Merge bitcoin/bitcoin#31500: depends: Fix compiling `libevent` package on ...

15:38 <bitcoin-git> [bitcoin] fanquake merged pull request #31500: depends: Fix compiling `libevent` package on NetBSD (master...241214-libevent-netbsd) https://github.com/bitcoin/bitcoin/pull/31500

15:38 jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]

15:54 jonatack has quit [Read error: Connection reset by peer]

15:55 jonatack has joined #bitcoin-core-dev

15:56 bugs_ has joined #bitcoin-core-dev

16:00 jespada has joined #bitcoin-core-dev

16:01 brunoerg has joined #bitcoin-core-dev

16:07 <bitcoin-git> [bitcoin] 0xB10C opened pull request #31848: test, tracing: don't use problematic `bpf_usdt_readarg_p()` (master...2025-01-dont-use-bpf_usdt_readarg_p) https://github.com/bitcoin/bitcoin/pull/31848

16:30 brunoerg has quit [Read error: Connection reset by peer]

16:31 brunoerg has joined #bitcoin-core-dev

16:42 jarthur has joined #bitcoin-core-dev

16:50 YaShhhh has joined #bitcoin-core-dev

16:51 YaShhhh has quit [Client Quit]

16:57 jonatack has quit [Remote host closed the connection]

16:59 jonatack has joined #bitcoin-core-dev

17:00 <bitcoin-git> [bitcoin] fanquake opened pull request #31849: depends: set `CMAKE_*_COMPILER_TARGET` in toolchain (master...clang_cross_toolchain) https://github.com/bitcoin/bitcoin/pull/31849

17:05 jonatack has quit [Read error: Connection reset by peer]

17:05 jonatack has joined #bitcoin-core-dev

17:19 brunoerg has quit [Ping timeout: 260 seconds]

17:21 brunoerg has joined #bitcoin-core-dev

17:24 Guest11 has joined #bitcoin-core-dev

17:26 Guest11 has quit [Client Quit]

17:45 <bitcoin-git> [bitcoin] fanquake opened pull request #31850: ci: switch MSAN to use prebuilt Clang binaries (master...prebuilt_clang) https://github.com/bitcoin/bitcoin/pull/31850

17:48 jonatack has quit [Remote host closed the connection]

17:49 jonatack has joined #bitcoin-core-dev

17:51 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/713bf66b1f77...048ef98626b9

17:51 <bitcoin-git> bitcoin/master 3edaf0b fanquake: depends: add missing Darwin objcopy

17:51 <bitcoin-git> bitcoin/master 048ef98 merge-script: Merge bitcoin/bitcoin#31840: depends: add missing Darwin objcopy

17:51 <bitcoin-git> [bitcoin] fanquake merged pull request #31840: depends: add missing Darwin objcopy (master...missing_darwin_objcopy) https://github.com/bitcoin/bitcoin/pull/31840

17:56 TheRec has quit []

18:03 Cory58 has quit [Quit: Client closed]

18:04 Cory58 has joined #bitcoin-core-dev

18:08 jeremiahr has joined #bitcoin-core-dev

18:11 jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]

18:29 jonatack has quit [Ping timeout: 260 seconds]

18:31 jonatack has joined #bitcoin-core-dev

18:31 jeremiahr has quit [Quit: Client closed]

18:40 Talkless has joined #bitcoin-core-dev

18:58 rkrux has joined #bitcoin-core-dev

19:08 rkrux has quit [Quit: Client closed]

19:14 rkrux has joined #bitcoin-core-dev

19:15 jespada has joined #bitcoin-core-dev

19:18 <instagibbs> is there any way to make a one-off comment while you have a review pending or do I have to complete/cancel the review to do so

19:18 <instagibbs> (on github))

19:28 rkrux has quit [Quit: Client closed]

19:28 rkrux has joined #bitcoin-core-dev

19:36 <darosior> instagibbs: Maybe you can leave a comment in the discussion thread with a link to the line in the "Files changed" tab

19:36 <sipa> username instagibbs2 is available

19:36 <instagibbs> sipa now that's scaling

19:36 <sipa> NgU

19:37 <_aj_> i hear that guy's a real square

19:39 Cory58 has quit [Quit: Client closed]

19:40 Cory58 has joined #bitcoin-core-dev

19:44 Guest96 has joined #bitcoin-core-dev

19:50 rkrux has quit [Ping timeout: 240 seconds]

19:52 <glozow> darosior: yeah but those links disappear on next push

19:53 Guest96 has quit [Ping timeout: 240 seconds]

19:54 brunoerg has quit [Remote host closed the connection]

19:55 brunoerg has joined #bitcoin-core-dev

19:57 rkrux has joined #bitcoin-core-dev

20:01 rkrux has quit [Client Quit]

20:01 rkrux has joined #bitcoin-core-dev

20:01 brunoerg has quit [Remote host closed the connection]

20:02 brunoerg has joined #bitcoin-core-dev

20:02 Cory58 has quit [Quit: Client closed]

20:03 Cory58 has joined #bitcoin-core-dev

20:04 brunoerg has quit [Remote host closed the connection]

20:11 rkrux has quit [Changing host]

20:11 rkrux has joined #bitcoin-core-dev

20:11 jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]

20:13 brunoerg has joined #bitcoin-core-dev

20:16 rkrux has quit [Quit: Client closed]

20:16 rkrux has joined #bitcoin-core-dev

20:18 brunoerg has quit [Ping timeout: 268 seconds]

20:23 <achow101> instagibbs: isn't there a "leave single comment" button?

20:23 rkrux has quit [Quit: Client closed]

20:24 <instagibbs> not that I'm aware

20:24 <instagibbs> just going to have to finish this round of queued review comments..

20:28 <darosior> glozow: yeah i assumed he'd have finished his in progress review by then

20:28 <achow101> huh, i guess it's not there once a review is started

20:30 <instagibbs> darosior optimistic

20:35 Talkless has quit [Quit: Konversation terminated!]

20:40 brunoerg has joined #bitcoin-core-dev

20:58 luke-jr_ has joined #bitcoin-core-dev

20:59 luke-jr has quit [Ping timeout: 252 seconds]

21:01 <bitcoin-git> [bitcoin] davidgumberg opened pull request #31851: doc: build: Fix instructions for msvc gui builds (master...2-12-25-msvc-docs) https://github.com/bitcoin/bitcoin/pull/31851

21:33 zIppEd is now known as zIpped

21:38 Cory58 has quit [Quit: Client closed]

21:38 Cory58 has joined #bitcoin-core-dev

21:46 luke-jr has joined #bitcoin-core-dev

21:48 Cory58 has quit [Quit: Client closed]

21:49 Cory58 has joined #bitcoin-core-dev

21:49 luke-jr_ has quit [Ping timeout: 252 seconds]

22:23 emcy__ has quit [Ping timeout: 276 seconds]

22:46 mcey has joined #bitcoin-core-dev

22:47 bugs_ has quit [Quit: Leaving]

22:47 mcey has quit [Remote host closed the connection]

22:47 mcey has joined #bitcoin-core-dev

22:54 andytoshi has quit [Ping timeout: 252 seconds]

22:58 mcey_ has joined #bitcoin-core-dev

23:01 mcey has quit [Ping timeout: 248 seconds]

23:05 andytoshi has joined #bitcoin-core-dev

23:15 S3RK_ has joined #bitcoin-core-dev

23:18 S3RK has quit [Ping timeout: 272 seconds]

23:20 brunoerg has quit [Remote host closed the connection]

23:21 brunoerg has joined #bitcoin-core-dev

23:26 brunoerg has quit [Ping timeout: 265 seconds]

23:31 xokia has joined #bitcoin-core-dev

23:37 brunoerg has joined #bitcoin-core-dev

23:42 brunoerg has quit [Ping timeout: 252 seconds]