#bitcoin-core-dev on 2025-02-11 — searchable irc log

2025-01-16 14:22 achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:05 <bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ff3171f96d37...79f02d56ef78

00:05 <bitcoin-git> bitcoin/master c1a5d5c Lőrinc: Split out bech32 separator char to header

00:05 <bitcoin-git> bitcoin/master 9b7023d Lőrinc: Fuzz HRP of bech32 as well

00:05 <bitcoin-git> bitcoin/master 79f02d5 Ava Chow: Merge bitcoin/bitcoin#30623: test: Fuzz the human-readable part of bech32 ...

00:05 <bitcoin-git> [bitcoin] achow101 merged pull request #30623: test: Fuzz the human-readable part of bech32 as well (master...l0rinc/bech32-testing) https://github.com/bitcoin/bitcoin/pull/30623

00:11 otoburb_ has quit [Quit: leaving]

00:11 otoburb has joined #bitcoin-core-dev

00:18 jonatack has joined #bitcoin-core-dev

00:41 <bitcoin-git> [bitcoin] crStiv opened pull request #31839: streams: Add stream position validation in BufferedFile::AdvanceStream (master...фффф) https://github.com/bitcoin/bitcoin/pull/31839

00:51 jonatack has quit [Quit: WeeChat 4.5.1]

00:58 agentcasey has quit [Ping timeout: 252 seconds]

00:58 agentcasey has joined #bitcoin-core-dev

00:59 Guest49 has joined #bitcoin-core-dev

01:11 Cory58 has quit [Quit: Client closed]

01:11 jackielove4u has quit [Ping timeout: 252 seconds]

01:12 Cory58 has joined #bitcoin-core-dev

01:12 infernix has quit [Ping timeout: 252 seconds]

01:17 jackielove4u has joined #bitcoin-core-dev

01:18 Cory58 has quit [Quit: Client closed]

01:18 Cory58 has joined #bitcoin-core-dev

01:21 infernix has joined #bitcoin-core-dev

01:33 brunoerg has joined #bitcoin-core-dev

01:38 brunoerg has quit [Ping timeout: 252 seconds]

01:43 zIppEd has joined #bitcoin-core-dev

01:51 eugenesiegel has quit [Ping timeout: 240 seconds]

01:53 infernix has quit [Ping timeout: 265 seconds]

01:59 Guest49 has quit [Quit: Client closed]

02:00 infernix has joined #bitcoin-core-dev

02:13 robobub has quit [Quit: Connection closed for inactivity]

02:15 pyth has joined #bitcoin-core-dev

02:18 Cory58 has quit [Quit: Client closed]

02:19 Cory58 has joined #bitcoin-core-dev

02:23 ryanofsky has quit [Remote host closed the connection]

02:23 ryanofsky has joined #bitcoin-core-dev

02:24 pyth has quit [Ping timeout: 244 seconds]

02:24 pyth has joined #bitcoin-core-dev

02:25 b10c[m] has quit [Ping timeout: 248 seconds]

02:25 stratospher[m] has quit [Ping timeout: 248 seconds]

02:25 BlueMattTest has quit [Ping timeout: 248 seconds]

02:25 Sjors[m] has quit [Ping timeout: 248 seconds]

02:25 sr_gi[m] has quit [Ping timeout: 248 seconds]

02:25 BlueMattMtrxBot has quit [Ping timeout: 248 seconds]

02:25 bitcoin-git has quit [Ping timeout: 248 seconds]

02:37 pyth has quit [Ping timeout: 252 seconds]

02:38 sr_gi[m] has joined #bitcoin-core-dev

02:39 BlueMattMtrxBot has joined #bitcoin-core-dev

02:39 stratospher[m] has joined #bitcoin-core-dev

02:39 BlueMattTest has joined #bitcoin-core-dev

02:41 Sjors[m] has joined #bitcoin-core-dev

02:44 b10c[m] has joined #bitcoin-core-dev

02:46 bitcoin-git has joined #bitcoin-core-dev

02:47 pyth has joined #bitcoin-core-dev

03:00 greypw1495085 has quit [Remote host closed the connection]

03:01 greypw1495085 has joined #bitcoin-core-dev

03:05 zeropoint has quit [Quit: leaving]

03:08 pyth has quit [Remote host closed the connection]

03:08 Cory58 has quit [Quit: Client closed]

03:09 Cory58 has joined #bitcoin-core-dev

03:27 kevkevin has joined #bitcoin-core-dev

03:29 kevkevin_ has quit [Ping timeout: 252 seconds]

03:57 mcey_ has joined #bitcoin-core-dev

04:00 emcy__ has quit [Ping timeout: 268 seconds]

04:04 bitdex has joined #bitcoin-core-dev

05:01 cmirror has quit [Remote host closed the connection]

05:01 cmirror has joined #bitcoin-core-dev

05:13 Cory58 has quit [Quit: Client closed]

05:13 Cory58 has joined #bitcoin-core-dev

05:33 agentcasey has quit [Remote host closed the connection]

05:33 agentcasey has joined #bitcoin-core-dev

05:42 Cory58 has quit [Quit: Client closed]

05:42 Cory58 has joined #bitcoin-core-dev

05:48 agentcasey has quit [Quit: ZNC 1.10.x-git-27-bfd731cf - https://znc.in]

05:50 agentcasey has joined #bitcoin-core-dev

06:01 mcey_ has quit [Remote host closed the connection]

06:01 mcey_ has joined #bitcoin-core-dev

06:15 samaltman has quit [Ping timeout: 252 seconds]

06:27 samaltman has joined #bitcoin-core-dev

06:35 upekkha has quit []

06:35 upekkha has joined #bitcoin-core-dev

06:51 adiabat_ has quit [Ping timeout: 268 seconds]

06:55 adiabat_ has joined #bitcoin-core-dev

07:03 Victor_sueca has quit [Quit: Gone frying asparagus or my Windows had a BSOD]

07:03 adiabat_ has quit [Remote host closed the connection]

07:04 adiabat_ has joined #bitcoin-core-dev

07:05 Victor_sueca has joined #bitcoin-core-dev

07:05 jonatack has joined #bitcoin-core-dev

07:06 <bitcoin-git> [bitcoin] maflcko closed pull request #31839: streams: Add stream position validation in BufferedFile::AdvanceStream (master...фффф) https://github.com/bitcoin/bitcoin/pull/31839

07:15 Victor_sueca has quit [Quit: Gone frying asparagus or my Windows had a BSOD]

07:28 sdfgsdfg has joined #bitcoin-core-dev

07:28 sdfgsdfg has quit [Changing host]

07:28 sdfgsdfg has joined #bitcoin-core-dev

07:43 Victor_sueca has joined #bitcoin-core-dev

07:54 sdfgsdfg has quit [Quit: Client closed]

08:58 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79f02d56ef78...2507ebdf1b26

08:58 <bitcoin-git> bitcoin/master 8fe552f Martin Zumsande: test: add missing sync to p2p_tx_download.py

08:58 <bitcoin-git> bitcoin/master 2507ebd merge-script: Merge bitcoin/bitcoin#31837: test: add missing sync to p2p_tx_download.py

08:58 <bitcoin-git> [bitcoin] fanquake merged pull request #31837: test: add missing sync to p2p_tx_download.py (master...202502_txtest_missing_sync) https://github.com/bitcoin/bitcoin/pull/31837

09:21 Guyver2 has joined #bitcoin-core-dev

09:54 dviola has quit [Quit: WeeChat 4.5.1]

10:22 angusp has quit [Remote host closed the connection]

10:23 greypw1495085 has quit [Remote host closed the connection]

10:23 greypw1495085 has joined #bitcoin-core-dev

10:45 <laanwj> PR #31022 is maybe RFM, would be good to get the tests for PCP in

10:46 <corebot> https://github.com/bitcoin/bitcoin/issues/31022 | test: Add mockable steady clock, tests for PCP and NATPMP implementations by laanwj · Pull Request #31022 · bitcoin/bitcoin · GitHub

10:54 rkrux has joined #bitcoin-core-dev

10:56 <bitcoin-git> [bitcoin] fanquake opened pull request #31840: depends: add missing Darwin objcopy (master...missing_darwin_objcopy) https://github.com/bitcoin/bitcoin/pull/31840

11:26 rkrux has quit [Quit: Client closed]

11:33 Guyver2 has left #bitcoin-core-dev [Closing Window]

11:35 angusp has joined #bitcoin-core-dev

11:53 brunoerg has joined #bitcoin-core-dev

11:55 Cory58 has quit [Quit: Client closed]

11:55 Cory58 has joined #bitcoin-core-dev

12:21 <bitcoin-git> [bitcoin] fanquake pushed 6 commits to 27.x: https://github.com/bitcoin/bitcoin/compare/bf03c458e994...1e7041a9f3a1

12:21 <bitcoin-git> bitcoin/27.x 166fea7 0xb10c: test: fix MIN macro-redefinition

12:21 <bitcoin-git> bitcoin/27.x c70bd78 Hennadii Stepanov: depends: Fix CXXFLAGS on NetBSD

12:21 <bitcoin-git> bitcoin/27.x a1db79c Hennadii Stepanov: depends: Fix spacing issue

12:21 <bitcoin-git> [bitcoin] fanquake merged pull request #31422: [27.x] More backports (27.x...some_more_27_backports) https://github.com/bitcoin/bitcoin/pull/31422

12:25 Cory58 has quit [Quit: Client closed]

12:25 Cory58 has joined #bitcoin-core-dev

12:26 jespada has joined #bitcoin-core-dev

12:48 <bitcoin-git> [bitcoin] ryanofsky pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2507ebdf1b26...86528937e5c4

12:48 <bitcoin-git> bitcoin/master 2ffea09 Sjors Provoost: build: disable bitcoin-node if daemon is not built

12:48 <bitcoin-git> bitcoin/master 8652893 Ryan Ofsky: Merge bitcoin/bitcoin#31834: build: disable bitcoin-node if daemon is not ...

12:48 <bitcoin-git> [bitcoin] ryanofsky merged pull request #31834: build: disable bitcoin-node if daemon is not built (master...2025/02/daemon-multiprocess) https://github.com/bitcoin/bitcoin/pull/31834

13:17 eugenesiegel has joined #bitcoin-core-dev

13:39 <willcl-ark> Do we have a process in place, or planned, for how we handle changes to the *.capnp files in the project (e.g. versioning)? I suppose at this time they are mainly internal interfaces so we can change as we like, but AFAIU capnp folks often follow a grpc-style scheme where breaking changes get a new type. I'm not convinced this totally makes sense for us, but could be wise to consider what

13:39 <willcl-ark> our approach to this might be for the future.

13:40 bitdex has quit [Quit: = ""]

13:42 <bitcoin-git> [bitcoin] maflcko opened pull request #31841: test: Clear scheduler after init to increase fuzz stability (master...2502-fuzz-stable) https://github.com/bitcoin/bitcoin/pull/31841

13:45 zeropoint has joined #bitcoin-core-dev

14:30 brunoerg_ has joined #bitcoin-core-dev

14:33 brunoerg has quit [Ping timeout: 248 seconds]

15:01 <laanwj> i remember something like that was discussed at some point, but no such process is documented right now

15:12 bugs_ has joined #bitcoin-core-dev

15:26 jonatack has quit [Ping timeout: 252 seconds]

15:28 jonatack has joined #bitcoin-core-dev

15:38 jonatack has quit [Ping timeout: 252 seconds]

15:56 jonatack has joined #bitcoin-core-dev

16:05 eugenesiegel has quit [Ping timeout: 240 seconds]

16:07 SpellChecker has quit [Remote host closed the connection]

16:08 SpellChecker has joined #bitcoin-core-dev

16:52 brunoerg_ has quit [Remote host closed the connection]

16:53 brunoerg has joined #bitcoin-core-dev

16:54 brunoerg has quit [Remote host closed the connection]

16:55 brunoerg has joined #bitcoin-core-dev

16:55 jespada has quit [Ping timeout: 265 seconds]

16:57 jespada has joined #bitcoin-core-dev

17:05 brunoerg has quit [Remote host closed the connection]

17:06 brunoerg has joined #bitcoin-core-dev

17:07 preimage has joined #bitcoin-core-dev

17:07 brunoerg has quit [Remote host closed the connection]

17:10 brunoerg has joined #bitcoin-core-dev

17:23 eugenesiegel has joined #bitcoin-core-dev

17:31 aleggg has joined #bitcoin-core-dev

17:57 Talkless has joined #bitcoin-core-dev

18:12 Guest10 has joined #bitcoin-core-dev

18:13 Guest10 has quit [Client Quit]

18:16 jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]

18:30 jespada has joined #bitcoin-core-dev

18:48 PaperSword has quit [Quit: PaperSword]

18:51 mcey has joined #bitcoin-core-dev

18:54 mcey_ has quit [Ping timeout: 248 seconds]

19:01 PaperSword has joined #bitcoin-core-dev

19:04 <bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/86528937e5c4...c65233230f18

19:04 <bitcoin-git> bitcoin/master ab1d3ec laanwj: net: Add optional length checking to CService::SetSockAddr

19:04 <bitcoin-git> bitcoin/master 0364832 laanwj: util: Add mockable steady_clock

19:04 <bitcoin-git> bitcoin/master caf9521 laanwj: net: Use mockable steady clock in PCP implementation

19:05 <bitcoin-git> [bitcoin] achow101 merged pull request #31022: test: Add mockable steady clock, tests for PCP and NATPMP implementations (master...2024-10-pcp-tests) https://github.com/bitcoin/bitcoin/pull/31022

19:10 <sipa> glozow: in #31829, what is the reason for having a global orphan tx limit in addition to a global announcement limit?

19:10 <corebot> https://github.com/bitcoin/bitcoin/issues/31829 | p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs by glozow · Pull Request #31829 · bitcoin/bitcoin · GitHub

19:14 eugenesiegel has quit [Quit: Client closed]

19:23 Cory58 has quit [Quit: Client closed]

19:23 Cory58 has joined #bitcoin-core-dev

20:10 Talkless has quit [Quit: Konversation terminated!]

20:29 brunoerg has quit [Remote host closed the connection]

20:30 brunoerg has joined #bitcoin-core-dev

20:36 jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]

20:39 <bitcoin-git> [bitcoin] theuni opened pull request #31844: cmake: add a component for each binary (master...cmake-install-components) https://github.com/bitcoin/bitcoin/pull/31844

20:56 btcab has joined #bitcoin-core-dev

21:24 jonatack has quit [Read error: Connection reset by peer]

21:26 jonatack has joined #bitcoin-core-dev

21:31 jonatack has quit [Read error: Connection reset by peer]

21:38 btcab has quit [Quit: Client closed]

21:43 brunoerg has quit [Remote host closed the connection]

21:43 brunoerg has joined #bitcoin-core-dev

21:48 brunoerg has quit [Ping timeout: 252 seconds]

21:56 <glozow> #proposedmeetingtopic Kill-Shill-Merge for v29.0 Milestone, on a jitsi call right after the IRC meeting

21:56 * darosior seldom reviews milestone PRs but is +1

22:04 brunoerg has joined #bitcoin-core-dev

22:14 <glozow> sipa: the main reason is that to continue supporting the `-maxorphantxs` option that we have right now. I didn't want the PR to involve a discussion about deprecating it / changing the meaning etc

22:14 <glozow> is to*

22:21 brunoerg has quit [Remote host closed the connection]

22:27 dzxzg has joined #bitcoin-core-dev

22:28 brunoerg has joined #bitcoin-core-dev

22:32 brunoerg has quit [Ping timeout: 252 seconds]

22:35 brunoerg has joined #bitcoin-core-dev

22:37 dzxzg has quit [Quit: Client closed]

22:40 brunoerg has quit [Ping timeout: 244 seconds]

22:45 dzxzg has joined #bitcoin-core-dev

22:54 eugenesiegel has joined #bitcoin-core-dev

22:56 bugs_ has quit [Quit: Leaving]

22:57 brunoerg has joined #bitcoin-core-dev

23:06 preimage has quit [Quit: WeeChat 4.5.1]

23:14 dzxzg has quit [Quit: Client closed]

23:18 dzxzg has joined #bitcoin-core-dev

23:20 dzxzg has quit [Client Quit]

23:24 bcdarc_ has joined #bitcoin-core-dev

23:25 darosior has quit [Read error: Connection reset by peer]

23:25 darosior9 is now known as darosior

23:25 mcey has quit [Ping timeout: 265 seconds]

23:25 virtu has quit [Ping timeout: 265 seconds]

23:25 virtu has joined #bitcoin-core-dev

23:28 bcdarc has quit [Ping timeout: 252 seconds]

23:34 monlovesmango has joined #bitcoin-core-dev

23:36 monlovesmango has quit [Client Quit]