<bitcoin-git>
[bitcoin] stephenmiracle4 opened pull request #31914: i deleted a commented line in invalid_signer.py file (master...mimibest) https://github.com/bitcoin/bitcoin/pull/31914
<bitcoin-git>
[bitcoin] stephenmiracle4 opened pull request #31915: i deleted a commented line in invalid_signer.py file (master...mimibest) https://github.com/bitcoin/bitcoin/pull/31915
<bitcoin-git>
[bitcoin] fanquake closed pull request #31353: rpc, cli: add getbalances#total, and use it for -getinfo (master...2024-11-total-wallet-balance) https://github.com/bitcoin/bitcoin/pull/31353
<achow101>
There are no pre-proposed meeting topics this week. Any last minute ones to add?
<lightlike>
hi
<pinheadmz>
yo
<jarolrod>
hi
<brunoerg>
hi
<fjahr>
hi
<Murch[m]>
hi
<_aj_>
what? it's daytime
<glozow>
achow101: we should talk about 29.0?
<achow101>
glozow: yes, after wg updates
<glozow>
👍
<sr_gi[m]>
hi
<achow101>
#topic Erlay WG Update (sr_gi, gleb, marcofleon)
<kevkevin_>
hi
<vasild_>
hi
<stickies-v>
hi
<sr_gi[m]>
We have been exploring a recent idea from @sipa for when to send out, and respond to reconciliation requests. The preliminary results looked promising on my end, and @gleb have also double checked this on his. I think this is a good enough approach to start moving into testing this with real nodes, either in a small deployment or using Warnet, so we are likely to start moving towards implementing this now
<vasild_>
#here
<sr_gi[m]>
That's me, i'll be sharing more concrete results once I have them written down
vasild_ is now known as vasild
<achow101>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<TheCharlatan>
hi
<kanzure>
hi
<sipa>
not much to report; i'm addressing review comments (mostly by abubakarsadiq) on #31363, which remains the thing to review, but i'm starting to think it's unlikely to make it in for 29.0 ;)
<achow101>
The three current PRs (can go in any order) are #31622, #31243, and #31247. They have all been getting review, and all seem possibly close to being merged, but probably after branch off.
<corebot>
https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
<corebot>
https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<achow101>
#topic Legacy Wallet Removal WG Update (achow101)
<bitcoin-git>
[bitcoin] laanwj opened pull request #31916: init: Handle dropped UPnP support more gracefully (master...2025-02-upnp-setting-upgrade) https://github.com/bitcoin/bitcoin/pull/31916
<achow101>
#31495 was merged, we're quite close to finally killing the legacy wallet
<corebot>
https://github.com/bitcoin/bitcoin/issues/31495 | wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases by achow101 · Pull Request #31495 · bitcoin/bitcoin · GitHub
<cfields>
🎉
<achow101>
There's only 2 main PRs remaining in this project, #31250 is next and it disables the legacy wallet. The last PR is #28710 which deletes the legacy wallet and BDB.
<achow101>
I think we'll probably miss 29.0 for this.
michael__ has quit []
<sipa>
A recurring theme.
<achow101>
#topic orphan resolution WG Update (glozow)
Emc99 has quit [Quit: Client closed]
michael__ has joined #bitcoin-core-dev
<glozow>
I've been selling #31829 as a "bug fix" after seeing https://delvingbitcoin.org/t/stats-on-orphanage-overflows/1421. But it's not a regression (orphanage has just always been bad). Also, over the past week, I've been finding some concerning bounds related to worksets and block handling, which is why it has a few extra commits now. This makes me feel like it'd be too rushed for v29 so I have removed it from the milestone.
<corebot>
https://github.com/bitcoin/bitcoin/issues/31829 | p2p: improve TxOrphanage denial of service bounds and increase -maxorphantxs by glozow · Pull Request #31829 · bitcoin/bitcoin · GitHub
Emc99 has joined #bitcoin-core-dev
<glozow>
Also, I've been discussing some other approaches with sipa - maybe we can huddle on it at coredev. So perhaps the extra time will lead to a neater solution. I've also been told the iterators are massively confusing, heh.
<glozow>
Sorry to add it to the "missed v29" pile
<sipa>
30.0 will be a banger
<glozow>
sipa: yes
<jonatack>
PR salesmanship FTW
<achow101>
#topic QML GUI WG Update (jarolrod)
<jarolrod>
We set up the working group and have had pretty interesting conversations over there, energy all over the place :D
<jarolrod>
(again message me if you want in)
<jarolrod>
First week of convos led to the realization that a few key points should be made clear:
<jarolrod>
1. The QML GUI is being developed as a drop in replacement for the Qt Widgets GUI first and foremost, that means the intention is that (after Qt6), the QML GUI could be dropped in and the Qt Widgets GUI removed as a clean swap. That’s the only goal for when it’s ready to be included into the main repo.
<jarolrod>
This comparison table has features from the Qt Widgets GUI mapped to support in the QML GUI; note that this table also has some future ambitions in it (such as silent payments, android): https://bitcoincore.app/features/
<jarolrod>
2. We’ve obviously been pretty vocal about other future ambitions such as the GUI on Android, which already had been the case with the Qt Widgets GUI (minus stability and persistence that we’ve added with an android specific file https://github.com/bitcoin-core/gui-qml/blob/main/src/qt/android/AndroidManifest.xml), but it would actually be useful like a smartphone app is with the QML GUI thanks to the design work and
<jarolrod>
the QML framework.
<jarolrod>
This is a future ambition, but as an ambition the design work and some code begins to reflect that future ambition. This doesn’t influence the main goal of getting this in as a replacement for the Qt Widgets GUI, and if there is strong objection to supporting android, this ambition can be clipped.
<jarolrod>
so think of qml gui just replacement for qt widgets gui!
<jarolrod>
Johnny has an update on dev
<jarolrod>
johnny9dev: ^
<jarolrod>
he's having issues with is irc lol
<achow101>
he's not logged in
<jarolrod>
johnny9dev: Hi guys, I’m Johnny. I’ve been contributing to the qml project for sometime now working with the designers to translate their designs into our QML views. The last week I was focused on the PR “Introduce Send pages for singlesig, sigle input/output send” (https://github.com/bitcoin-core/gui-qml/pull/445). There are still some UX pieces to address with this PR before merging but the core components and
<jarolrod>
modules are in place for it to complete the feature
<jarolrod>
we also had discussions on the website redesign, so join the wg if you have any opinions on that
<jarolrod>
fin!
johnny9dev has quit [Quit: Updating details, brb]
<achow101>
big update, thanks!
<glozow>
by website design, which website do you mean?
johnny9dev has joined #bitcoin-core-dev
<jarolrod>
bitcoincore.org
<achow101>
#topic 29.0 feature freeze
GRM28 has joined #bitcoin-core-dev
<glozow>
jarolrod: is that related to the gui? I'm confused by that
<glozow>
I didn't know we were redesigning bitcoincore.org :O
<jarolrod>
glozow: I posted a video before here, it's not related to the gui, its adjacent, we got good feedback on how the website could better help current contributors from Murch[m]
GRM28 has quit [Client Quit]
johnny9dev has quit [Changing host]
johnny9dev has joined #bitcoin-core-dev
<achow101>
The schedule says that today is feature freeze. Are the 5 PRs remaining in the milestone all bug fixes?
<johnny9dev>
hi
<glozow>
achow101: from what I can tell, those 5 should stay for 29
<corebot>
https://github.com/bitcoin/bitcoin/issues/31407 | guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries by achow101 · Pull Request #31407 · bitcoin/bitcoin · GitHub
<Murch[m]>
just to reiterate, my feedback was that one of the main objectives should be that it continues to be low maintenance, and yeah, the RPC docs being easier to navigate would be cool
<cfields>
The fact that it's mostly buildsystem stuff remaining not really surprising imo as it's for sure an artifact of CMake going in for v29. It should calm way down for v30.
<sipa>
yeah
<sipa>
we may also see increased reports/issues after release candidates due to the build system change
<cfields>
Yeah, and I expect rc1 may be a bit bumpy.
<achow101>
For 31161, it's not symlinking the old binary locations?
<bitcoin-git>
[bitcoin] l0rinc opened pull request #31917: fuzz: provide more realistic values to the base58(check) decoders (master...l0rinc/base-encoding-input-fuzz-size-reduction) https://github.com/bitcoin/bitcoin/pull/31917
<glozow>
Not surprised by the list, CMake is probably the biggest change for this release
<hebasto>
achow101: that commit was reverted as not quite portable
<cfields>
achow101: hebasto removed the symlinking as it had issues (multi-config, windows), and fanquake didn't like the idea of supporting back-compat forever.
rkrux has joined #bitcoin-core-dev
<dzxzg>
I can take a look at 31916 (davidgumberg)
<glozow>
Is there anything that is close to merge but not on the milestone? Let's get those in today.
<instagibbs>
ok, I'll take away my ack and re-ack tomorrow :P
purpleKarrot has joined #bitcoin-core-dev
<dergoegge>
what additional testing are we expecting?
<achow101>
dergoegge: for me, it's not about whether pre-sync works or doesn't, but rather whether checkpoints is catching some issue that we won't realize until its gone
<glozow>
has anybody done a full IBD with it?
<glozow>
not that that's a sufficient test, just wondering
<achow101>
in any case, one of the acks says merge after branching, which means it shouldn't be counted at this time
<sipa>
agree with achow101
<lightlike>
also, it doesn't have any direct benefit to users, the benefit is more of a long-term cleanup one, so I see no need to have it in a specific release.
<stickies-v>
+1 instagibbs . I don't think anyone needs this urgently, so as long as it doesn't interfere with our maintenance burden too much it seems more careful to do it after branch off
<dergoegge>
it's not about urgency just seems weird to have "i have concerns" and "seems good to wait" without elaboration hold it up
<achow101>
was that not enough elaboration?
<glozow>
It's on 30.0, which means it'll be merged right after branch off.
Emc99 has quit [Quit: Client closed]
Emc99 has joined #bitcoin-core-dev
<sipa>
dergoegge: i don't think there is anything wrong with aiming to have big changes merged early in a release cycle, so they get a few months extra testing, whatever that means
<sipa>
and "what additional testing are we expecting", well, we don't know, that's the point
<jonatack>
for v29, when is the deadline for dns hardcoded seeds updating? i don't recall if it is feature freeze or can be later
<sipa>
if we could perfectly reason about all potential impacts this could have, it'd be merged already
<achow101>
jonatack: before rc1 generally
<glozow>
before branch off would be my preference
<jonatack>
ty
<_aj_>
is there any benefit to having them removed in 29.0?
<glozow>
_aj_: I think no, similar to lightlike's point. I don't think any users would be upset that they don't get this in v29
<glozow>
jonatack: can I assume you're opening a PR for it?
<dergoegge>
it's just about understanding the acceptance criteria for me here
<dergoegge>
no rush or benefit to have it in 29
<dergoegge>
I just don't see a reason to wait after all the work that went into it already, but multiple people disagree and that's fine too
<achow101>
Murch[m]: is that topic for today?
<Murch[m]>
yes
<jonatack>
glozow: hardcoded dns seeds, can do if achow101 doesn't. i have a cjdns node that was removed due to it becoming a pruned node, but it's back to full archival now.
<achow101>
#topic BIP3 (Murch[m])
rkrux has quit [Quit: Client closed]
<Murch[m]>
Hey, I announced a while back that my BIP3, the new BIP Process Proposal is getting somewhere
<Murch[m]>
I’m done with my planned work on it
rkrux has joined #bitcoin-core-dev
<Murch[m]>
So, as Bitcoin developers, if you are interested in the BIP Process, I would like to invite you to review and leave feedback
<Murch[m]>
if you think it’s something you would like to have, I would also appreciate if you left a comment to indicate your support ,since there seems to be some lethargy with getting it merged as draft
<bitcoin-git>
bitcoin/master 63a8791 jurraca: contrib: fix BUILDDIR in gen-bitcoin-conf script and gen-manpages.py
<bitcoin-git>
bitcoin/master 9d7672b Ava Chow: Merge bitcoin/bitcoin#31742: contrib: fix BUILDDIR in gen-bitcoin-conf scr...
<bitcoin-git>
[bitcoin] achow101 merged pull request #31742: contrib: fix BUILDDIR in gen-bitcoin-conf script and gen-manpages.py (master...fix-builddir) https://github.com/bitcoin/bitcoin/pull/31742
<bitcoin-git>
[bitcoin] fanquake closed pull request #29589: consensus: Consistently encode and decode `OP_1NEGATE` similar to other small ints in Script (master...2024-03-07-op1neg-py) https://github.com/bitcoin/bitcoin/pull/29589
piku has quit [Quit: Leaving]
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git>
bitcoin/master 71bf829 Hennadii Stepanov: cmake: Convert `check_cxx_source_compiles_with_flags` to a function
<bitcoin-git>
[bitcoin] fanquake merged pull request #31662: cmake: Do not modify `CMAKE_TRY_COMPILE_TARGET_TYPE` globally (master...250115-target-type) https://github.com/bitcoin/bitcoin/pull/31662
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] fanquake closed pull request #31328: test: locking -testdatadir when not specified and then deleting lock and dir at end of test (master...lockTestDataDir) https://github.com/bitcoin/bitcoin/pull/31328
<bitcoin-git>
[bitcoin] mahdirahimi1999 opened pull request #31919: Refactor file handling with context managers in multiple files (master...refactor/file-handling-improvement) https://github.com/bitcoin/bitcoin/pull/31919
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<bitcoin-git>
[bitcoin] theuni opened pull request #31920: build: create Depends build type for depends and use it by default for depends builds (master...cmake-depends-config2) https://github.com/bitcoin/bitcoin/pull/31920
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has quit [Read error: Connection reset by peer]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]