<corebot>
https://github.com/bitcoin/bitcoin/issues/30205 | test: add mocked Sock that can read/write custom data and/or CNetMessages by vasild · Pull Request #30205 · bitcoin/bitcoin · GitHub
<bitcoin-git>
[bitcoin] marcofleon closed pull request #31001: refactor: ensure type safety for txid and wtxid in `RelayTransaction` (master...2024/09/relaytx-type-safety) https://github.com/bitcoin/bitcoin/pull/31001
pyth has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
pyth has quit [Ping timeout: 244 seconds]
jonatack has joined #bitcoin-core-dev
<sipa>
glozow: what are the expectations around the per-peer work set? does it make sense for an announcement to exist for a peer, if it's also not in the work set?
<glozow>
sipa: it doesn't make sense to have something in work set that isn't also in `m_orphans`, no
<glozow>
(also, I previously said something silly - it's a set, so duplicates are not possible)
<sipa>
glozow: sure, but i'm asking about the opposite: something that is in a specific peer's set of announcements, but not in its work set
<bitcoin-git>
[bitcoin] Sjors opened pull request #31834: build: disable bitcoin-node if daemon is not built (master...2025/02/daemon-multiprocess) https://github.com/bitcoin/bitcoin/pull/31834
<glozow>
oh yes definitely, that's the case until we receive a parent of the orphan
<glozow>
work set = the orphans to re-validate because a parent of it was accepted to mempool (so it might not be an orphan anymore)
<sipa>
oooh
<sipa>
so generally work_set and announcements are mutually exclusive (up to laziness, because we might not have evaluated this)?
<glozow>
hm, not mutually exclusive. announcements should be a superset of work_set (up to laziness)
<sipa>
ah, because just being in the work set doesn't mean the orphan was fully resolved - it might have more remaining missing parents?
<glozow>
yes
<glozow>
and we don't remove it from announcements when we are putting in the work set
bitdex has quit [Quit: = ""]
<sipa>
yep
<glozow>
we could consider cleaning worksets up synchronously in EraseTx
<sipa>
i was under the assumption that the workset would be superset of announcements, so it'd be weird that worksets are limit to 100, but per-peer announcements can grow way beyond that... but it sounds like it's rather the opposite
<bitcoin-git>
bitcoin/master 4b58d55 Vasil Dimov: test: move the implementation of StaticContentsSock to .cpp
<bitcoin-git>
bitcoin/master f186414 Vasil Dimov: test: put the generic parts from StaticContentsSock into a separate class
<bitcoin-git>
bitcoin/master b448b01 Vasil Dimov: test: add a mocked Sock that allows inspecting what has been Send() to it
<bitcoin-git>
[bitcoin] ryanofsky merged pull request #30205: test: add mocked Sock that can read/write custom data and/or CNetMessages (master...DynSock) https://github.com/bitcoin/bitcoin/pull/30205
jonatack has joined #bitcoin-core-dev
<instagibbs>
work sets are the subset of announcement's we're possibly devoting future resources to re-validate and orphan, right? How would it be a superset of what a peer has told us about?
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<sipa>
instagibbs: by me misunderstanding what it was about
jonatack has quit [Ping timeout: 260 seconds]
<instagibbs>
fair enough
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]