01:17 < kallewoof> fanquake: sure thing!

03:37 < bitcoin-git> [bitcoin] promag opened pull request #17878: wip: zmq: Support -zmqpubwallettx (master...2019-01-zmqpubwallettx) https://github.com/bitcoin/bitcoin/pull/17878

04:59 < bitcoin-git> [bitcoin] Sjors opened pull request #17879: gui: uncheck encrypt by default when creating wallet (master...2020/01/ui-create-wallet) https://github.com/bitcoin/bitcoin/pull/17879

05:11 < bitcoin-git> [bitcoin] fanquake opened pull request #17880: build: add -Wdate-time to Werror flags (master...add_Werror_date_time) https://github.com/bitcoin/bitcoin/pull/17880

07:46 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b949ac9697a6...e8e79958a7b2

07:46 < bitcoin-git> bitcoin/master 71af793 fanquake: scripts: fix check-symbols & check-security argument passing

07:46 < bitcoin-git> bitcoin/master e8e7995 fanquake: Merge #17857: scripts: fix symbol-check & security-check argument passing

07:47 < bitcoin-git> [bitcoin] fanquake merged pull request #17857: scripts: fix symbol-check & security-check argument passing (master...security_check_args) https://github.com/bitcoin/bitcoin/pull/17857

07:58 < bitcoin-git> [bitcoin] fanquake opened pull request #17881: [0.18] scripts: fix check-symbols & check-security argument passing (0.18...018_backport_17857) https://github.com/bitcoin/bitcoin/pull/17881

08:11 < bitcoin-git> [bitcoin] jonatack closed pull request #17812: config, test: asmap functional tests and feature refinements (master...feature-asmap) https://github.com/bitcoin/bitcoin/pull/17812

08:12 < bitcoin-git> [bitcoin] jonatack reopened pull request #17812: config, test: asmap functional tests and feature refinements (master...feature-asmap) https://github.com/bitcoin/bitcoin/pull/17812

11:39 < bitcoin-git> [bitcoin] Binh0103 opened pull request #17882: Create ccpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/17882

11:40 < bitcoin-git> [bitcoin] fanquake closed pull request #17882: Create ccpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/17882

15:28 < elichai2> Another reason why we want enum classes is that you can't do forward declaration with a "regular" enum :/

15:44 < hebasto> elichai2: from EMC++ item 10 - "In C++11, unscoped enums may also be forward-declared, but only after a bit of additional work."

15:46 < elichai2> lol. what is "but only after a bit of additional work"? I couldn't make it work(and neither people in #c++) even though some stackoverflow people said it can be done

15:58 < hebasto> elichai2: https://github.com/bitcoin/bitcoin/blob/master/src/interfaces/wallet.h#L28

15:59 < elichai2> yeah that's a way to do it. but this means you also specify the enum like that

16:00 < elichai2> hebasto: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/ismine.h#L18

16:01 < elichai2> so if you already edit the enums just make it an enum class ?\_(?)_/?

16:01 < hebasto> agree - we want enum classes; see #17877

16:01 < gribble> https://github.com/bitcoin/bitcoin/issues/17877 | qt, refactor: Make enums in BitcoinUnits class scoped by hebasto . Pull Request #17877 . bitcoin/bitcoin . GitHub

16:02 < elichai2> :D

16:25 < ryanofsky> you can forward declare normal enums with "enum MyEnum : int;" You need to explicitly specify the integer type so the compiler knows what type will fit all the enum values

16:38 < elichai2> ryanofsky: don't you also need to explictly specify the integer type on the enum definition?

16:40 < elichai2> ryanofsky: http://cpp.sh/3nqis

16:45 < elichai2> that's really weird. https://github.com/bitcoin/bitcoin/blob/master/src/node/context.cpp so these includes are to make https://github.com/bitcoin/bitcoin/blob/master/src/node/context.h compile. but that means that no one can include this header without including them too

16:53 < elichai2> well IWYU doesn't agree with me so I guess i'm wrong. ha. (anyone understands this?)

17:52 < elichai2> god we have a lot of files lol

18:20 < ryanofsky> elichai2, yes declaration and definition should be consistent and both use the same types or no types. but the compiler can't detect inconsistencies in all cases (different .cpp files)

19:54 < bitcoin-git> [bitcoin] IPGlider opened pull request #17884: utils: Use fallback for macOS in AllocateFileRange (master...workaround_apfs_allocation_problem) https://github.com/bitcoin/bitcoin/pull/17884

22:41 < ariard> what the rational to update protocol version number ? #16442 adds new p2p messages, but don't bump it, at the contrary protocol version has been bumped for bip37/bip152

22:41 < gribble> https://github.com/bitcoin/bitcoin/issues/16442 | Serve BIP 157 compact filters by jimpo . Pull Request #16442 . bitcoin/bitcoin . GitHub