achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
zeropoint has quit [Quit: Lost terminal]
salvatoshi has quit [Ping timeout: 248 seconds]
flag has quit [Ping timeout: 245 seconds]
flag has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dbc89b604c4d...1d0a1a60e83b
<bitcoin-git> bitcoin/master 9132824 Hennadii Stepanov: qt: 29.0 translations update
<bitcoin-git> bitcoin/master 1d0a1a6 merge-script: Merge bitcoin/bitcoin#32004: qt: 29.0 translations update
<bitcoin-git> [bitcoin] fanquake merged pull request #32004: qt: 29.0 translations update (master...250305-tr) https://github.com/bitcoin/bitcoin/pull/32004
<bitcoin-git> [bitcoin] fanquake closed pull request #32036: docs: fix grammatical typos in documentation files (master...Amountoftypos) https://github.com/bitcoin/bitcoin/pull/32036
TheRec has quit []
TheRec has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1d0a1a60e83b...e38f09b776c1
<bitcoin-git> bitcoin/master fac1dd9 MarcoFalke: test: Fix authproxy named args debug logging
<bitcoin-git> bitcoin/master e38f09b merge-script: Merge bitcoin/bitcoin#31955: test: Fix authproxy named args debug logging
<bitcoin-git> [bitcoin] fanquake merged pull request #31955: test: Fix authproxy named args debug logging (master...2502-test-fix-auth) https://github.com/bitcoin/bitcoin/pull/31955
Guest47 has joined #bitcoin-core-dev
Guest47 has quit [Client Quit]
pseudoramdom has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 260 seconds]
conman has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e38f09b776c1...502d47203e7e
<bitcoin-git> bitcoin/master 026bb22 Hennadii Stepanov: cmake: Set top-level target output locations
<bitcoin-git> bitcoin/master 568fcdd Hennadii Stepanov: scripted-diff: Adjust documentation per top-level target output location
<bitcoin-git> bitcoin/master 502d472 merge-script: Merge bitcoin/bitcoin#31161: cmake: Set top-level target output locations
<bitcoin-git> [bitcoin] fanquake merged pull request #31161: cmake: Set top-level target output locations (master...241026-top) https://github.com/bitcoin/bitcoin/pull/31161
synexic has quit [Quit: Ping timeout (120 seconds)]
synexic has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
pseudoramdom has quit [Ping timeout: 260 seconds]
Guest15 has joined #bitcoin-core-dev
Guest15 has quit [Quit: Client closed]
jonatack has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 252 seconds]
robobub has joined #bitcoin-core-dev
flag has quit [Ping timeout: 268 seconds]
flag has joined #bitcoin-core-dev
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] kevincatty opened pull request #32037: chore: remove redundant words in comment (master...master) https://github.com/bitcoin/bitcoin/pull/32037
<bitcoin-git> [bitcoin] fanquake closed pull request #32037: chore: remove redundant words in comment (master...master) https://github.com/bitcoin/bitcoin/pull/32037
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 246 seconds]
salvatoshi has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
dunxen has quit [Read error: Connection reset by peer]
dunxen has joined #bitcoin-core-dev
<hebasto> PSA: after merging #31161, all build artifacts are now collected in the `bin/` and `lib/` subdirectories of your build directory
<corebot> https://github.com/bitcoin/bitcoin/issues/31161 | cmake: Set top-level target output locations by hebasto · Pull Request #31161 · bitcoin/bitcoin · GitHub
<laanwj> nice!
<laanwj> now that out-of-tree builds are the default, mirroring the deployment structure makes more sense than mirroring the source tree
<hebasto> indeed
<hebasto> btw, we explicitly disable in-source builds
<hebasto> it is recommended to clean or delete an existing build dir before configuring the build system to avoid any potential disruption
<laanwj> my first impulse was "is this wise to do last minute for 0.29?", but, all in all i think it was better to get it in sooner than later, as it is now going to be less pain switching from HEAD to 0.29 and back
WizJin has joined #bitcoin-core-dev
pseudoramdom has joined #bitcoin-core-dev
<laanwj> eg there is no in-between cmake release that does things differently
pseudoramdom has quit [Ping timeout: 276 seconds]
conman has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/502d47203e7e...7bb4c82d8ba5
<bitcoin-git> bitcoin/master 59c4930 Hodlinator: qa: Enable feature_init.py on Windows
<bitcoin-git> bitcoin/master 7bb4c82 Hennadii Stepanov: Merge bitcoin/bitcoin#32021: qa: Enable feature_init.py on Windows
<bitcoin-git> [bitcoin] hebasto merged pull request #32021: qa: Enable feature_init.py on Windows (master...2025/03/windows_feature_init) https://github.com/bitcoin/bitcoin/pull/32021
<fanquake> laanwj: it was basically the case that we either do it now, or never
<fanquake> we weren't going to break everything again in 30.x
conman has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7bb4c82d8ba5...8cb6ab0b971a
<bitcoin-git> bitcoin/master a3baead marcofleon: validation: use wtxid instead of txid in CheckEphemeralSpends
<bitcoin-git> bitcoin/master e637dc2 marcofleon: refactor: Replace uint256 type with Wtxid in PackageMempoolAcceptResult st...
<bitcoin-git> bitcoin/master 8cb6ab0 merge-script: Merge bitcoin/bitcoin#32025: validation, fix: Use wtxid instead of txid in...
<bitcoin-git> [bitcoin] fanquake merged pull request #32025: validation, fix: Use wtxid instead of txid in `CheckEphemeralSpends` (master...2025/03/fix-txid-to-wtxid) https://github.com/bitcoin/bitcoin/pull/32025
rkrux has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #32038: depends: remove `NO_HARDEN` option (master...depends_remove_noharden) https://github.com/bitcoin/bitcoin/pull/32038
<laanwj> fanquake: right!
dermoth has quit [Read error: Connection reset by peer]
dermoth has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
jespada has joined #bitcoin-core-dev
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 246 seconds]
rkrux has quit [Ping timeout: 240 seconds]
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 246 seconds]
jespada_ has quit [Ping timeout: 252 seconds]
dunxen has quit [Ping timeout: 252 seconds]
jespada has joined #bitcoin-core-dev
_flooded has joined #bitcoin-core-dev
TallTim_ has joined #bitcoin-core-dev
salvatoshi_ has joined #bitcoin-core-dev
TallTim has quit [Remote host closed the connection]
salvatoshi has quit [Read error: Connection reset by peer]
_flood has quit [Ping timeout: 252 seconds]
rkrux has joined #bitcoin-core-dev
<fjahr> #31689 might be RFM
<corebot> https://github.com/bitcoin/bitcoin/issues/31689 | Benchmark Chainstate::ConnectBlock duration by Eunovo · Pull Request #31689 · bitcoin/bitcoin · GitHub
WizJin has quit [Read error: Connection reset by peer]
<glozow> should have a release note for 31161 if we don’t already?
<hebasto> glozow: already done
<hebasto> point 5 under build system changes
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
pyth has quit [Remote host closed the connection]
pyth has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] soldate opened pull request #32040: pull request test (master...master) https://github.com/bitcoin/bitcoin/pull/32040
<bitcoin-git> [bitcoin] soldate closed pull request #32040: pull request test (master...master) https://github.com/bitcoin/bitcoin/pull/32040
<bitcoin-git> [bitcoin] glozow pushed 0 commit to 29.x: https://github.com/bitcoin/bitcoin/compare/29.x
<glozow> hebasto: thanks!
rkrux has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] glozow opened pull request #32041: build: bump CLIENT_VERSION_MAJOR to 29 (master...2025-03-bump-version-major) https://github.com/bitcoin/bitcoin/pull/32041
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8cb6ab0b971a...aa68ed27b894
<bitcoin-git> bitcoin/master a3f0e9a glozow: [build] bump CLIENT_VERSION_MAJOR to 29
<bitcoin-git> bitcoin/master aa68ed2 merge-script: Merge bitcoin/bitcoin#32041: build: bump CLIENT_VERSION_MAJOR to 29
<bitcoin-git> [bitcoin] fanquake merged pull request #32041: build: bump CLIENT_VERSION_MAJOR to 29 (master...2025-03-bump-version-major) https://github.com/bitcoin/bitcoin/pull/32041
pseudoramdom has joined #bitcoin-core-dev
pseudoramdom has quit [Ping timeout: 245 seconds]
Guest99 has joined #bitcoin-core-dev
Guest99 has quit [Quit: Client closed]