achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
pablomartin has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
pyth has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
pablomartin has quit [Remote host closed the connection]
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Remote host closed the connection]
zeropoint has quit [Quit: leaving]
<bitcoin-git> [bitcoin] suiyuan1314 opened pull request #32006: docs: fix typos (master...fix/typos) https://github.com/bitcoin/bitcoin/pull/32006
cman has quit [Quit: Konversation terminated!]
eval-exec has quit [Remote host closed the connection]
pyth has quit [Remote host closed the connection]
conman has joined #bitcoin-core-dev
conman has quit [Client Quit]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
bitdex has joined #bitcoin-core-dev
Saturday7 has quit [Ping timeout: 276 seconds]
WizJin__ has joined #bitcoin-core-dev
WizJin_ has quit [Ping timeout: 276 seconds]
PaperSword has quit [Quit: PaperSword]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Earnestly has quit [Ping timeout: 265 seconds]
mcey has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #bitcoin-core-dev
<luke-jr> v28.1.knots20250305 tagged if anyone is available to do guix builds
WizJin_ has joined #bitcoin-core-dev
WizJin__ has quit [Ping timeout: 245 seconds]
jadi has quit [Ping timeout: 244 seconds]
PaperSword has joined #bitcoin-core-dev
Guest17 has joined #bitcoin-core-dev
WizJin__ has joined #bitcoin-core-dev
Guest17 has quit [Client Quit]
WizJin_ has quit [Ping timeout: 268 seconds]
Saturday7 has joined #bitcoin-core-dev
pyth has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
adiabat_ has quit [Ping timeout: 244 seconds]
adiabat_ has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
qxs has quit [Remote host closed the connection]
pablomartin has joined #bitcoin-core-dev
Saturday7 has quit [Ping timeout: 246 seconds]
janb84 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/bd0ee07310c3...9f3dcacef733
<bitcoin-git> bitcoin/master 0683b8e glozow: [kernel] update assumed blockchain and chainstate sizes for v29
<bitcoin-git> bitcoin/master 80926af glozow: [kernel] update assumevalid and minimumChainWork for v29
<bitcoin-git> bitcoin/master dd23c53 glozow: [kernel] update chainTxData for v29
<bitcoin-git> [bitcoin] fanquake merged pull request #31978: kernel: pre-29.x chainparams and headerssync update (master...2025-03-v29-chainparams) https://github.com/bitcoin/bitcoin/pull/31978
Earnestly has joined #bitcoin-core-dev
pyth has quit [Remote host closed the connection]
WizJin has joined #bitcoin-core-dev
WizJin has joined #bitcoin-core-dev
WizJin__ has quit [Ping timeout: 248 seconds]
cornfeedhobo has quit [Ping timeout: 276 seconds]
bitdex has quit [*.net *.split]
vasild has quit [*.net *.split]
ghost43 has quit [*.net *.split]
greypw14950857 has quit [*.net *.split]
SpellChecker has quit [*.net *.split]
janb84 has quit [*.net *.split]
cornfeedhobo has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
WizJin_ has joined #bitcoin-core-dev
WizJin has quit [Ping timeout: 245 seconds]
vasild has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
rkrux has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] xiaobei0715 opened pull request #32008: chore: update copyright year to present (master...copyright) https://github.com/bitcoin/bitcoin/pull/32008
<bitcoin-git> [bitcoin] fanquake closed pull request #32008: chore: update copyright year to present (master...copyright) https://github.com/bitcoin/bitcoin/pull/32008
^Dan has joined #bitcoin-core-dev
pyth has joined #bitcoin-core-dev
^Dan has left #bitcoin-core-dev [#bitcoin-core-dev]
rkrux has quit [Quit: Client closed]
batara has joined #bitcoin-core-dev
batara has quit [Client Quit]
pyth has quit [Remote host closed the connection]
Guyver2 has joined #bitcoin-core-dev
pyth has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
pyth has quit [Remote host closed the connection]
<stickies-v> #proposedmeetingtopic review club
dzxzg has joined #bitcoin-core-dev
TallTim_ has joined #bitcoin-core-dev
<darosior> stickies-v: does this club serve zombies?
TallTim has quit [Ping timeout: 248 seconds]
<stickies-v> i can dm you the recipe every first wed of the month, no problem
Emc99 has joined #bitcoin-core-dev
<achow101> #startmeeting
<corebot> achow101: Meeting started at 2025-03-06T16:00+0000
<corebot> achow101: Current chairs: achow101
<corebot> achow101: Useful commands: #action #info #idea #link #topic #motion #vote #close #endmeeting
<corebot> achow101: Participants should now identify themselves with '#here' or with an alias like '#here FirstLast'
<jarolrod> hi
<stickies-v> hi
<achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko marcofleon maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
<vasild> hi
<darosior> hi
<dergoegge> hi
<abubakarsadiq> hi
<shiza> hi
<sr_gi[m]> hi
rkrux has joined #bitcoin-core-dev
<dzxzg> hi
<achow101> There is 1 preproposed meeting topic this week, any last minute ones to add?
<TheCharlatan> hi
<lightlike> hi
<rkrux> hi
preimage has joined #bitcoin-core-dev
<achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
<vasild> #here
<sr_gi[m]> I've been running the last set of planned simulations this week. I'm currently moving to implementing the changes on the open PR so we can test this with real nodes
<sr_gi[m]> Will be trying this on Warnet as soon as we have a working version, and then proceed with the PR
<sr_gi[m]> The results on simulation look promising :)
<sr_gi[m]> That's it on my end
<achow101> #topic Kernel WG Update (TheCharlatan)
<b10c> hi
<TheCharlatan> We discussed some ways forward towards getting the kernel API merged during the recent dev meeting.
<TheCharlatan> The consensus was that the current API is not likely to get shipped in the upcoming release
<TheCharlatan> Especially its reliance on assumeutxo mechanics and inflexibility towards other validation models are painpoints
<TheCharlatan> At the same time, building out applications a bit more to inform design decisions, as well as getting better feedback on how the API changes as validation code evolves would be easier to do if the API were merged sooner than later.
Guest65 has joined #bitcoin-core-dev
<achow101> "not likely to get shipped in the upcoming release" <-- 29.0 or 30.0?
<TheCharlatan> So the focus in the near term will likely be trying to get it merged over the next months, albeit not slated as a library shipped in the releases quite yet.
Guest65 has quit [Client Quit]
<TheCharlatan> achow101: 30
<Sjors[m]> hi
<furszy> hi
<TheCharlatan> I will also try to work on a separate "big branch" with many of the desired changes to get the API into shape similarly to what Carl did to initially get a library together.
<TheCharlatan> that's all from me :)
<achow101> #topic MuSig2 WG Update (achow101)
<achow101> I've addressed recent reviews on #31622
<corebot> https://github.com/bitcoin/bitcoin/issues/31622 | psbt: add non-default sighash types to PSBTs and unify sighash type match checking by achow101 · Pull Request #31622 · bitcoin/bitcoin · GitHub
<achow101> I had to add a check that signatures are valid DER since one of the recent pushes caused a fuzz test failure
<achow101> This is possibly a breaking change, although I don't expect it to actually impact anyone
<achow101> The other current PRs to review are #31247 and #31243.
<corebot> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 · Pull Request #31247 · bitcoin/bitcoin · GitHub
<corebot> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<achow101> #31243 seems rfm once we branch
<corebot> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<achow101> #topic Legacy Wallet Removal WG Update (achow101)
<achow101> Sjors opened #31961 which pulls out the commit the makes sqlite required when the wallet is enabled.
<corebot> https://github.com/bitcoin/bitcoin/issues/31961 | Require sqlite when building the wallet by Sjors · Pull Request #31961 · bitcoin/bitcoin · GitHub
<achow101> I've rebased #31250 and #28710 to on top of it.
<corebot> https://github.com/bitcoin/bitcoin/issues/31250 | wallet: Disable creating and loading legacy wallets by achow101 · Pull Request #31250 · bitcoin/bitcoin · GitHub
<corebot> https://github.com/bitcoin/bitcoin/issues/28710 | Remove the legacy wallet and BDB dependency by achow101 · Pull Request #28710 · bitcoin/bitcoin · GitHub
<achow101> As was mentioned at CoreDev, these PRs are primarily deletions and it would be great to get these in to help reduce scope :)
<jon_atack> hi
<jarolrod> oh we're reducinngggg
<achow101> #topic QML GUI WG Update (jarolrod, johnny9dev)
<glozow> achow: \o/
<jarolrod> No substantial update this week, several of us were traveling last week or currently are
<jarolrod> Progress on the activity and send work should be wrapping up soon, and a lot of what you guys saw at the core dev should be in the repo by the next meeting.
<jarolrod> And more to show at the next meeting!
<jarolrod> fin
<achow101> #topic orphan resolution WG Update (glozow)
<vasild> next IRC or coredev meeting?
<jarolrod> next irc meeting
<vasild> :)
<instagibbs> slight difference
<jarolrod> BIG
<glozow> hi! i wrote an update on the PR, but won’t get to it in the next couple weeks
<instagibbs> 👍
dzxzg has quit [Quit: Client closed]
dzxzg43 has joined #bitcoin-core-dev
dzxzg43 is now known as dzxzg
<achow101> #topic 29.0 Milestone
dzxzg has quit [Client Quit]
<glozow> Ok not sure if my connection is strong enough but:
<glozow> There are a few small things left before we can do branch-off, e.g. #31960 which needs some review.
<glozow> Please also remember to add release notes and check your name in the credits https://github.com/bitcoin-core/bitcoin-devwiki/wiki/29.0-Release-Notes-draft
<glozow> In particular I'm waiting on a CMake note from hebasto and a -O3 note from sipa
<glozow> I think we are aiming for a RC testing guide meeting on March 19
<corebot> https://github.com/bitcoin/bitcoin/issues/31960 | seeds: add signet/testnet4, update makeseeds regex, minblocks, fixed seeds by jonatack · Pull Request #31960 · bitcoin/bitcoin · GitHub
<dergoegge> you skipped the fuzzing wg
<achow101> dergoegge: oops, didn't see you. will do after this topic
dzxzg has joined #bitcoin-core-dev
<achow101> The only non-procedural pr is #31161
<corebot> https://github.com/bitcoin/bitcoin/issues/31161 | cmake: Set top-level target output locations by hebasto · Pull Request #31161 · bitcoin/bitcoin · GitHub
<achow101> Was there a resolution to that? IIRC it was discussed by a few people at CoreDev.
<bitcoin-git> [bitcoin] fanquake opened pull request #32009: RFC contrib: turn off compression of macOS SDK to fix determinism (across distros) (master...macos_sdk_select) https://github.com/bitcoin/bitcoin/pull/32009
<achow101> There's also still a bunch of build system issues open. Are they being fixed or punted to the next release?
<achow101> glozow: still planning to branch today?
<glozow> We can wait a few days
<jon_atack> glozow: achow101: I'll update the seeds pull shortly, might ping here if any questions
<brunoerg> hi
<glozow> I'd rather wait than backport
<glozow> jon_atack: thanks
<achow101> indeed
<glozow> might be dropping off now, sorry
<achow101> #topic Fuzzing WG Update (dergoegge)
<dergoegge> For those that didn't attend the "functional fuzz test" spark session at coredev, I briefly summarized the idea here: https://gist.github.com/dergoegge/3036796551095a9ce7535fb5d74e6656
<dergoegge> I'll occasionally give updates on this effort here or in the fuzzing wg
<achow101> #proposedmeetingtopic review club (stickies-v)
<corebot> achow101: Unknown command: #proposedmeetingtopic
<achow101> #topic review club (stickies-v)
<stickies-v> we had a brief in-person discussion last week about reviewing the review club (https://bitcoincore.reviews/ )
<stickies-v> one suggestion with good support was to give space to working groups to host PRs that they’d like more discussion or transparency on
<stickies-v> so, are there any WGs interested in proposing (and ideally hosting) a PR review club?
Guyver2 has left #bitcoin-core-dev [Closing Window]
<sipa> hi
<stickies-v> if it's okay with everyone, i'll make this a semi-recurring topic on this meeting, but you can always leave a request/suggestion on our newly pinned issue: https://github.com/bitcoin-core-review-club/website/issues/791
<achow101> stickies-v: feel free to propose it as a topic whenever you want to
<stickies-v> thank you! that's all for me
<achow101> sipa: would you like to give a cluster mempool update?
<jon_atack> stickies-v: there seems to be support for returning to a weekly format
<sipa> achow101: sure
<jon_atack> ofc that is load mostly on you two unless the same people are willing to host
<stickies-v> jon_atack: so far we have 0 people offering to host, though :D
<achow101> #topic Cluster Mempool WG Update (sdaftuar, sipa)
<jon_atack> yes. hosting twice a year by a dozen or two people would move the dial on that. I would do that if you need.
<sipa> not that much to report, #31363 has started getting reviews (thanks, abubakarsadiq and instagibbs!), looks to make good progress
<corebot> https://github.com/bitcoin/bitcoin/issues/31363 | cluster mempool: introduce TxGraph by sipa · Pull Request #31363 · bitcoin/bitcoin · GitHub
<sipa> on the research side, i've been having good discussions with aj and others about a min-cut linearization algorithm, i hope to have a prototype to experiment with soon
<sipa> that's it for me
<achow101> Any other topics to discuss this week?
jadi has joined #bitcoin-core-dev
<abubakarsadiq> @jon_atack I think it may be due to a lack of interest in hosting that it is only once a month. If I recall correctly, there have been multiple review clubs in the past after we switched to a monthly schedule when there was interest
<achow101> #endmeeting
<corebot> achow101: Meeting ended at 2025-03-06T16:38+0000
Emc99 has quit [Quit: Client closed]
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
dzxzg has quit [Ping timeout: 240 seconds]
brunoerg_ has joined #bitcoin-core-dev
brunoerg_ has quit [Client Quit]
brunoerg has quit [Ping timeout: 248 seconds]
rkrux has quit [Quit: Client closed]
pablomartin has quit [Ping timeout: 248 seconds]
zeropoint has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9f3dcacef733...c7d216ac9461
<bitcoin-git> bitcoin/master d76647e fanquake: ci: use LLVM 20.1.0 for MSAN
<bitcoin-git> bitcoin/master c7d216a merge-script: Merge bitcoin/bitcoin#31993: ci: use LLVM 20.1.0 for MSAN
<bitcoin-git> [bitcoin] fanquake merged pull request #31993: ci: use LLVM 20.1.0 for MSAN (master...msan_llvm_20_1_0) https://github.com/bitcoin/bitcoin/pull/31993
LainExperiments has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c7d216ac9461...a9a2b669f3e0
<bitcoin-git> bitcoin/master c873ab6 fanquake: doc: remove note about macOS self-signing
<bitcoin-git> bitcoin/master a9a2b66 Ava Chow: Merge bitcoin/bitcoin#32003: doc: remove note about macOS self-signing
<bitcoin-git> [bitcoin] achow101 merged pull request #32003: doc: remove note about macOS self-signing (master...remove_code_signing_note) https://github.com/bitcoin/bitcoin/pull/32003
Talkless has joined #bitcoin-core-dev
andytoshi has quit [Ping timeout: 245 seconds]
andytoshi has joined #bitcoin-core-dev
WizJin_ has quit [Quit: Leaving]
WizJin has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 260 seconds]
LainExperiments has quit [Ping timeout: 240 seconds]
LainExperiments7 has joined #bitcoin-core-dev
LainExperiments has joined #bitcoin-core-dev
LainExperiments7 has quit [Ping timeout: 240 seconds]
LainExperiments4 has joined #bitcoin-core-dev
LainExperiments has quit [Ping timeout: 240 seconds]
LainExperiments4 has quit [Ping timeout: 240 seconds]
TallTim_ is now known as TallTim
preimage has quit [Quit: WeeChat 4.5.2]
jespada has quit [Ping timeout: 248 seconds]
jespada has joined #bitcoin-core-dev
janb84 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has quit [Read error: Connection reset by peer]
brunoerg has quit [Client Quit]
dermoth has quit [Ping timeout: 272 seconds]
dermoth has joined #bitcoin-core-dev
Guest11 has joined #bitcoin-core-dev
Guest11 has quit [Client Quit]
Guest11 has joined #bitcoin-core-dev
Guest11 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
pyth has joined #bitcoin-core-dev
twistedline has quit [Ping timeout: 248 seconds]
twistedline has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
jon_atack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
twistedline has quit [Ping timeout: 260 seconds]
twistedline_ has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
PaperSword has quit [Remote host closed the connection]
pablomartin has quit [Ping timeout: 268 seconds]
<bitcoin-git> [bitcoin] hodlinator opened pull request #32010: qa: Fix TxIndex race conditions (master...2025/02/txindex_test_race) https://github.com/bitcoin/bitcoin/pull/32010
conman has joined #bitcoin-core-dev