abubakarsadiq has quit [Quit: Connection closed for inactivity]
pablomartin has quit [Ping timeout: 244 seconds]
pablomartin has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 268 seconds]
pablomartin has quit [Remote host closed the connection]
nanotube has quit [Quit: *poof*]
<laanwj>
lightlike: i'm not sure, maybe if the warnings are clear enough? wouldn't want "just don't produce the binary" leading to accidentally pass the tests in the CI instead of flag a problem
<laanwj>
acting based on what should be there is not bad behavior for tests
<bitcoin-git>
bitcoin/master 329a0dc ismaelsadeeq: doc: clarify the documentation of `Assume`
<bitcoin-git>
bitcoin/master a54baa8 merge-script: Merge bitcoin/bitcoin#32100: doc: clarify the documentation of `Assume` as...
<bitcoin-git>
[bitcoin] fanquake merged pull request #32100: doc: clarify the documentation of `Assume` assertion (master...03-2025-clarify-assume-doc) https://github.com/bitcoin/bitcoin/pull/32100
salvatoshi__ has quit [Ping timeout: 276 seconds]
salvatoshi__ has joined #bitcoin-core-dev
aLeSD has quit [Remote host closed the connection]
jurraca has quit [Quit: leaving]
Guest28 has joined #bitcoin-core-dev
cold has quit [Ping timeout: 246 seconds]
midnight has quit [Ping timeout: 260 seconds]
Guest28 has quit [Quit: Client closed]
midnight has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] musaHaruna opened pull request #32152: test: add p2pk support to wallet_implicity_segwit.py (master...add-p2pk-support-to-wallet-implicity-segwit-test) https://github.com/bitcoin/bitcoin/pull/32152
yuvic has joined #bitcoin-core-dev
yuvic has joined #bitcoin-core-dev
yuvic has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] rkrux opened pull request #32153: wallet: remove redundant `Assert` call when block is disconnected (master...wallet-block) https://github.com/bitcoin/bitcoin/pull/32153
yuvic has joined #bitcoin-core-dev
yuvic has joined #bitcoin-core-dev
yuvic has quit [Client Quit]
aLeSD has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #32154: fuzz: Avoid integer sanitizer warnings in policy_estimator target (master...2503-fuzz-isan) https://github.com/bitcoin/bitcoin/pull/32154
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko closed pull request #32152: test: add p2pk support to wallet_implicity_segwit.py (master...add-p2pk-support-to-wallet-implicity-segwit-test) https://github.com/bitcoin/bitcoin/pull/32152
ubbabeck has quit [Ping timeout: 245 seconds]
Saturday7 has quit [Ping timeout: 248 seconds]
Christoph_ has quit [Ping timeout: 260 seconds]
Christoph_ has joined #bitcoin-core-dev
Saturday7 has joined #bitcoin-core-dev
aLeSD has quit [Remote host closed the connection]
dermoth has quit [Ping timeout: 260 seconds]
abubakarsadiq has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Remote host closed the connection]
jespada has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin4btc_ has joined #bitcoin-core-dev
pablomartin4btc has quit [Ping timeout: 244 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
andytosh1 has joined #bitcoin-core-dev
andytoshi has quit [Ping timeout: 245 seconds]
OGU has joined #bitcoin-core-dev
OGU has quit [Changing host]
OGU has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
pyth has quit [Quit: Leaving]
bitdex has quit [Quit: = ""]
pablomartin4btc_ has quit [Ping timeout: 245 seconds]
Cory21 has quit [Quit: Client closed]
Cory21 has joined #bitcoin-core-dev
codingp110 has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
codingp110 has quit [Client Quit]
jespada has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
<TheCharlatan>
Debate is still if a c++ header might be the better choice after all
<TheCharlatan>
Thanks to some quick reviews we now also have a simple functional test for bitcoin-chainstate, which could make it a bit easier to ensure the library is actually usable and to validate future changes to the API.
<TheCharlatan>
I am still waiting for more reviews on #31382. It is useful, because it cleans up the shutdown logic a bit and gets rid of the last remaining warts in bitcoin-chainstate.
<laanwj>
an C API is extremely useful for dynamic loading from non-C++ languages, but it could be done the other way around, wrapping the C++ one i guess
rkrux has quit [Ping timeout: 240 seconds]
<TheCharlatan>
laanwj can you add a comment about that to 30595?
<laanwj>
sure
<glozow>
#topic QML GUI WG Update (jarolrod, johnny9dev)
<johnny9dev>
The first iteration of the Send form was merged this week. bitcoin-core/gui-qml#445
<johnny9dev>
Christoph has opened a design discussion on Coin Selection at https://github.com/BitcoinDesign/Bitcoin-Core-App/issues/153 and Michael has provided a nice updated prototype. I encourage anyone interested in Coin Control to take a look and leave a comment if there is anything you would like to see.
<johnny9dev>
My plans for the next week are to open up a PR for the multiple recipients form as well as get bitcoin-core/gui-qml#441 and bitcoin-core/gui-qml#434 merged.
<glozow>
#topic Script Validation WG Update (fjahr)
<fjahr>
#31689 has been merged and I am currently working on adding tests for #29491 which has seen some discussion on the approach. Happy to get more eyes on it so that we know early enough if we want changes to the secp API.
<sipa>
on the research front, i've implemented the min-cut based algorithm from the 1989 paper, which seems to work very well (10s of microseconds for all our "hard" clusters in the benchmark)
mentalbarcode has joined #bitcoin-core-dev
<sipa>
if the paper, and my implementation of it, is correct, it has O(n^3) complexity, though the worst cases are still ~100x slower than our actual benchmarks, so worst case runtimes would be in the milliseconds range
<sipa>
lots of open questions, but very promising
<sipa>
that's it for me
<furszy>
glozow: Only legacy wallet removal update is #32149 finding. Other than that, #31250 still needs a rebase.
pablomartin4btc has quit [Ping timeout: 248 seconds]
Talkless has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] instagibbs reopened pull request #26398: Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only (master...relax_too_small_tx_equality) https://github.com/bitcoin/bitcoin/pull/26398
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
OGU has joined #bitcoin-core-dev
OGU has quit [Changing host]
OGU has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] darosior opened pull request #32155: miner: timelock the coinbase to the mined block's height (master...2502_height_in_cb_locktime) https://github.com/bitcoin/bitcoin/pull/32155
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
Talkless has quit [Quit: Konversation terminated!]