<darosior>
big +1 to what fjahr and glozow said about not only opening the trivial nit PR but also the "dopamine hit" of jumping in and ACKing them, worse yet bikeshedding them.
Guest49 has joined #bitcoin-core-dev
Guest49 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
eval-exec has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
conman has quit [Quit: Konversation terminated!]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
zeropoint has quit [Quit: leaving]
jonatack has joined #bitcoin-core-dev
joetor5 has joined #bitcoin-core-dev
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
joetor5 has quit [Quit: Client closed]
flow has quit [Ping timeout: 245 seconds]
agentcasey has quit [Read error: Connection reset by peer]
agentcasey has joined #bitcoin-core-dev
flow has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
greypw1495085720 has quit [Ping timeout: 264 seconds]
<bitcoin-git>
bitcoin/master d5537c1 Lőrinc: fuzz: make sure DecodeBase58(Check) is called with valid values more often
<bitcoin-git>
bitcoin/master ab2df17 merge-script: Merge bitcoin/bitcoin#31917: fuzz: provide more realistic values to the ba...
<bitcoin-git>
[bitcoin] fanquake merged pull request #31917: fuzz: provide more realistic values to the base58(check) decoders (master...l0rinc/base-encoding-input-fuzz-size-reduction) https://github.com/bitcoin/bitcoin/pull/31917
<bitcoin-git>
bitcoin/master 9157d9e Sjors Provoost: build: use make < 3.82 syntax for define directive
<bitcoin-git>
bitcoin/master 83a9e55 merge-script: Merge bitcoin/bitcoin#32070: build: use make < 3.82 syntax for define dire...
<bitcoin-git>
[bitcoin] fanquake merged pull request #32070: build: use make 3.82 syntax for define directive (master...2025/03/capnp-make) https://github.com/bitcoin/bitcoin/pull/32070
Christoph_ has joined #bitcoin-core-dev
flow has quit [Ping timeout: 260 seconds]
Christoph_ has quit [Quit: Christoph_]
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
flow has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 244 seconds]
sliv3r__ has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
<Sjors[m]>
In the example of #32077 we could have pointed the author to the earlier attempt to document all op codes. IIRC the decision then was to not bother, so that might justify not fixing individual typos either.
<Sjors[m]>
More generally we could encourage making a more ambitious fix, e.g. not just one typo but also the recent ones found by the linter.
<Sjors[m]>
And maybe a placeholder text along the lines of what was said above about trivial changes by new contributors, which is nicer than just closing. Unless we're sure it's an AI.
<Sjors[m]>
(with a link to the contributor guidelines)
luke-jr has quit [Ping timeout: 246 seconds]
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #bitcoin-core-dev
<instagibbs>
I think those are slightly different cases (I felt adding a bunch of possibly misleading comments bad regardless of churn) but I think closing with a canned "this is why we don't touch consensus code for linty reasons" comment would be nice
conman has quit [Quit: Konversation terminated!]
aleggg has quit [Remote host closed the connection]
aleggg has joined #bitcoin-core-dev
montxero has quit [Remote host closed the connection]
jetpack has quit [Quit: ZNC 1.8.2+deb2+deb11u1 - https://znc.in]
jetpack has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #bitcoin-core-dev
MyNetAz has quit [Remote host closed the connection]
MyNetAz has joined #bitcoin-core-dev
MyNetAz has quit [Remote host closed the connection]
Cory has quit [Quit: Client closed]
Cory has joined #bitcoin-core-dev
MyNetAz has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] naiyoma opened pull request #32079: test: Add test coverage for rpcwhitelistdefault when unset (master...test/whitelistdeafult_test_followup) https://github.com/bitcoin/bitcoin/pull/32079
pyth has quit [Read error: Connection reset by peer]