01:07
<
fanquake >
Would someone like to review the backporting in #17881
07:28
<
kallewoof >
luke-jr: I ran into that issue last night! (not auto-gen block413567.raw.h) I was scratching my head for awhile over that one...
10:46
<
promag >
#17792 is ready i think
10:48
<
promag >
also, if possible, #17878 could be in HP chasing ack
11:37
<
promag >
anyone can explain why importmulti calls EnsureWalletIsUnlocked?
12:02
<
luke-jr >
kallewoof: another one is src/qt/moc_paymentserver.cpp - been deleting it for years now :x
14:07
<
jnewbery >
#16688 ready for merge I think
17:33
<
hebasto >
MarcoFalke: mind looking into #17893 ?
19:00
<
wumpus >
#startmeeting
19:00
<
lightningbot >
Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00
<
wumpus >
#bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
19:00
<
wumpus >
jeremyrubin lightlike emilengler jonatack hebasto
19:01
<
wumpus >
any last minute proposals?
19:01
<
wumpus >
#topic High priority for review
19:02
<
wumpus >
anything to add/remove or ready for merge?
19:02
<
promag >
can #17878 be in hp?
19:02
<
promag >
"Chasing Concept ACK"
19:02
<
wumpus >
I don't think a wip PR should be in high priority or review
19:03
<
wumpus >
ohh yes that's okay
19:03
<
jb55 >
looks like #13339 is finally ready though?
19:04
<
promag >
going to address latest ryanofsky review
19:04
<
jb55 >
testing it locally now
19:04
<
wumpus >
that's good to know
19:04
<
promag >
prolly a release note saying that win is not supported
19:05
<
wumpus >
that definitely took a long and difficult review cycle for on first glance, easy functionality
19:06
<
wumpus >
#topic 0.19.1 release
19:06
<
emilengler >
3 PRs need backports rn
19:06
<
wumpus >
I think it'd be a good idea to do a 0.19.1 release soon, there have been quite a few bug fixes
19:06
<
promag >
yeah, could be in 0.19.1
19:06
<
jb55 >
that would be great
19:07
<
wumpus >
emilengler: yes, there are still a few things tagged for backport to 0.19 that could make it in
19:07
<
achow101 >
Can #17156 be added for backport 10 0.19.1?
19:07
<
promag >
I have 2 bug fixes #16923 #17457 but not sure they will get enough review
19:07
<
wumpus >
especialy the macosx disk usage
19:09
<
wumpus >
well, my idea is to do the 0.19.1 release soon-ish, so things that require long review cycle and aren't super urgent could wait for 0.19.2 I think
19:09
<
wumpus >
would be nice though
19:09
<
promag >
when then?
19:10
<
wumpus >
when the remaining tagged PRs are merged
19:10
<
wumpus >
and backported ofc
19:10
<
wumpus >
dunno about #15706 though
19:11
<
promag >
then please tag #13339
19:11
<
wumpus >
that's not a bugfix
19:11
<
hebasto >
#15706 needs more eyes
19:11
<
promag >
so 0.20 I guess
19:12
<
wumpus >
promag: yes I'd hope so
19:12
<
wumpus >
if it wouldn't make 0.20 either it'd be absurd
19:13
<
wumpus >
hebasto: it's hard to get review for m4 build system stuff, could hope cfields_ takes a look at it :)
19:14
<
wumpus >
any other topics?
19:15
<
wumpus >
#endmeeting
19:16
<
instagibbs >
sipa, bye
19:31
<
jnewbery >
wumpus: I missed the meeting but #16688 is RFM
19:35
<
wumpus >
jnewbery: thanks
20:06
<
bitcoin-git >
bitcoin/master 428ac70 Jeffrey Czyz: Add VALIDATION to BCLog::LogFlags
20:06
<
bitcoin-git >
bitcoin/master 72f3227 Jeffrey Czyz: Format CValidationState properly in all cases
20:06
<
bitcoin-git >
bitcoin/master 6edebac Jeffrey Czyz: Refactor FormatStateMessage for clarity
23:19
<
fanquake >
aj: no, not that I've ever seen
23:56
<
promag >
"Waiting for author" can be removed from 17843