< fanquake>
meshcollider: can you confirm #17603 is closed by just that PR, and isn't also waiting for the other one mentioned in the PR body? Or diregard if you are looking at the other one now.
< wumpus>
it spends its time sleeping or waiting for i/o
< wumpus>
done some shotgun profiling: fdatasync is the culprit, everyt ime
< wumpus>
in CBanDB::Write ?!?
< wumpus>
why is the BanMan dumping the ban list between every benchmark
< promag>
fanquake: I've included instagibbs fix in the backport
< fanquake>
promag thanks, can you update the pr body
< promag>
will do after ci
< promag>
it that doesn't go well then we could split the backport and push the non controversial to 0.19
< promag>
*if
< wumpus>
removing the m_node.banman instantiation it runs in 4 seconds
< promag>
quite a difference indeed
< wumpus>
can't reproduce it on any other machine, so seems a local issue, still strange, I've noticed slowness with fdatasync in VMs before but not on bare hw
< bitcoin-git>
[bitcoin] kallewoof closed pull request #17838: test: test the >10 UTXO case for output groups (master...191231-test-avoidreuse-many-utxos) https://github.com/bitcoin/bitcoin/pull/17838
< wumpus>
going to test #16702
< gribble>
https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs . Pull Request #16702 . bitcoin/bitcoin . GitHub
< elichai2>
which python version do we require in the functional test?
< fanquake>
3.5
< fanquake>
See the .python-version file
< elichai2>
hmm `p2p_invalid_messages.py` fails for me in 3.8 because of a warning it prints
< elichai2>
oh wait
< elichai2>
it requires 3.5
< elichai2>
i'll check and PR
< fanquake>
We support >= 3.5
< elichai2>
(I thought the "fix" requires python 3.7)
< bitcoin-git>
[bitcoin] fanquake opened pull request #17929: build: pass optimization flags to the linker (master...pass_optimizations_to_linker) https://github.com/bitcoin/bitcoin/pull/17929
< promag>
fanquake: updated pr body
< fanquake>
promag thanks. Can you also add #17634
< wumpus>
python 3.8 definitely supposed to be supported, if it doesn't that's a bug
< promag>
jamesob: will blockman have it's own mutex?
< promag>
going to push the worst pr of 2020, sorry
< fanquake>
"delete whitespace"
< fanquake>
At least there's another 11 months for someone to steal the title
< bitcoin-git>
[bitcoin] promag opened pull request #17930: rpc: Don't lock cs_main in getblock if verbosity=0 (master...2020-01-getblock-avoid-lock) https://github.com/bitcoin/bitcoin/pull/17930
< promag>
fanquake: lol
< promag>
I said it's stupid :| it's wrong
< bitcoin-git>
[bitcoin] promag closed pull request #17930: rpc: Don't lock cs_main in getblock if verbosity=0 (master...2020-01-getblock-avoid-lock) https://github.com/bitcoin/bitcoin/pull/17930
< promag>
I don't get it, does ReadBlockFromDisk requires the lock or not?
< bitcoin-git>
[bitcoin] elichai opened pull request #17931: test: Fix p2p_invalid_messages failing in Python 3.8 because of warning (master...2020-01-coroutine) https://github.com/bitcoin/bitcoin/pull/17931
< jamesob>
promag: it certainly could, though because I don't think there'd be a huge performance impact I was going to wait until after the assumeutxo functionality all gets merged to start worrying about splitting the locks up - which I do think is probably worth doing
< bitcoin-git>
[bitcoin] btc-coder opened pull request #17932: replace deprecated method of recursive_directory_iterator with the st... (master...master) https://github.com/bitcoin/bitcoin/pull/17932
< bitcoin-git>
[bitcoin] dongcarl opened pull request #17933: guix: Pin Guix using `guix time-machine` (master...2020-01-guix-time-machine) https://github.com/bitcoin/bitcoin/pull/17933
< hebasto>
promag: fanquake: ty
< bitcoin-git>
[bitcoin] hebasto opened pull request #17934: doc: Use CONFIG_SITE variable instead of --prefix option (master...20200115-prefix-depends) https://github.com/bitcoin/bitcoin/pull/17934
< bitcoin-git>
[bitcoin] brakmic opened pull request #17935: gui: hide HD icon when no wallet loaded (master...hdwallet-icon-handling) https://github.com/bitcoin/bitcoin/pull/17935
< bitcoin-git>
[bitcoin] fanquake closed pull request #17932: replace deprecated method of recursive_directory_iterator with the st... (master...master) https://github.com/bitcoin/bitcoin/pull/17932
< luke-jr>
fwiw, I found a new getbalance bug on v0.19.0.1; debugging now
< bitcoin-git>
[bitcoin] promag opened pull request #17937: gui: Remove WalletView and BitcoinGUI circular dependency (master...2020-01-remove-walletview-bitcoingui) https://github.com/bitcoin/bitcoin/pull/17937