< bitcoin-git> [bitcoin] LarryRuane closed pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365
< bitcoin-git> [bitcoin] meshcollider closed pull request #17902: fixed typo in comment, iff -> if (master...blarney-typo) https://github.com/bitcoin/bitcoin/pull/17902
< bitcoin-git> [bitcoin] LarryRuane reopened pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365
< hebasto> ryanofsky: what is the reason to a user to provide -prune=NNN option during the first bitcoin-qt start (or along with -choosedatadir)?
< hebasto> on master the intro dialog just swallows NNN and returns prune=true
< bitcoin-git> [bitcoin] practicalswift opened pull request #17904: [wip] build: Switch from C++11 to C++17 (master...c++17) https://github.com/bitcoin/bitcoin/pull/17904
< ryanofsky> hebasto, i'm pretty sure it's just a corner case. or maybe someone very clever would do it to save a mouse click. code should just be simple and not do complicated things for this case, is long as behavior is reasonable
< hebasto> could we just skip this corner case, as current behavior is inconsistent?
< hebasto> providing -prune=NNN during the first bitcoin-qt does not actually set prune to NNN MiB as expected (both before pr17696 and now on master)
< hebasto> ryanofsky: I found such behavior working on your comments to #17453
< gribble> https://github.com/bitcoin/bitcoin/issues/17453 | gui: Fix intro dialog labels when the prune button is toggled by hebasto . Pull Request #17453 . bitcoin/bitcoin . GitHub
< luke-jr> hebasto: ryanofsky: someone should just rebase Knots' intro to Core; it's handled this stuff for a long time
< luke-jr> (or alternatively merge rwconf so it's simply another PR)
< ryanofsky> yes, i thought the part of that change replacing >=550 check with >1 had no effect, but you are right that it does have some minor effect. either way i'd suggest reverting that change
< hebasto> ryanofsky: reverting that change seems ok, but is it nicer to drop -prune command-line option parsing in the intro?
< hebasto> luke-jr: do you mean #11082 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr . Pull Request #11082 . bitcoin/bitcoin . GitHub
< ryanofsky> hebasto, i'm just inclined to have prs do one thing at a time so changes are simple and can we don't wind up bundling bad changes with good changes
< hebasto> ryanofsky: totally agree
< ryanofsky> maybe another reason somebody would want to use -prune setting at startup is that the intro dialog doesn't currently allow adjusting the size, and so supporting it lets them do that
< ryanofsky> or did we remove that ability in the last pr...
< ryanofsky> luke-jr, would be curious to see a screenshot of knots intro, maybe post it to an github issue for RFC
< hebasto> no, we didn't
< luke-jr> hebasto: yes 11082 is rwconf, dependency of lots of improvements in Knots that haven't made it into Core yet
< hebasto> ryanofsky: just intro's output is boolean prune, not integer
< ryanofsky> thanks, i remember now, last pr only hardcodes the 2gb when pruning is disabled, otherwise it would use the commadn line value
< hebasto> yes, it would use the command line value *inside* the Intro; but the output is bool only.
< ryanofsky> and continue to use the provided value after the intro (to prune data if the box is checked), i'm assuming?
< luke-jr> don't have a screenshot handy, but it has a field to enter the size in MB
< luke-jr> porting to Core would likely require using GB instead
< luke-jr> (and tells you how stale your wallet backups can be with given size)
< hebasto> ryanofsky: no, it doesn't...
< ryanofsky> hmm why doesn't it get used? it looks like it be converted to gb, but saved and force set after that
< hebasto> before 17696 it sets to existed gui setting or default; now it set to default
< hebasto> never to provided command-line option
< ryanofsky> ok, i'm confused about why because it seems to be calling gArgs.GetArg("-prune", 0) which should have the command line value
< ryanofsky> but i can look into it more if i'm just being dense
< ryanofsky> not sure if you had a question for me, you can ignore my comments if they are inapplicable
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17905: gui: Avoid redundant tx status updates (master...pr/ipc-txup) https://github.com/bitcoin/bitcoin/pull/17905
< bitcoin-git> [bitcoin] ryanofsky opened pull request #17906: gui: Set CConnman byte counters earlier to avoid uninitialized reads (master...pr/ipc-count) https://github.com/bitcoin/bitcoin/pull/17906
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e7f84503571c...62b189b91d4f
< bitcoin-git> bitcoin/master 0874a10 Aaron Clauson: Ignore msvc linker warning and update to msvc build instructions.
< bitcoin-git> bitcoin/master 62b189b fanquake: Merge #17899: msvc: Ignore msvc linker warning and update to msvc build in...
< bitcoin-git> [bitcoin] fanquake merged pull request #17899: msvc: Ignore msvc linker warning and update to msvc build instructions. (master...mavc_linkerwarns) https://github.com/bitcoin/bitcoin/pull/17899
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62b189b91d4f...f8c69677a1a8
< bitcoin-git> bitcoin/master 8b2f471 Hennadii Stepanov: qa: Fix double-negative arg test
< bitcoin-git> bitcoin/master f8c6967 fanquake: Merge #17893: qa: Fix double-negative arg test
< bitcoin-git> [bitcoin] fanquake merged pull request #17893: qa: Fix double-negative arg test (master...20200107-fix-doublenegative-test) https://github.com/bitcoin/bitcoin/pull/17893