< kallewoof> fanquake: mind removing "needs conceptual review" from #16411 ? It's no longer chasing Concept ACK.
< gribble> https://github.com/bitcoin/bitcoin/issues/16411 | BIP-325: Signet support by kallewoof . Pull Request #16411 . bitcoin/bitcoin . GitHub
< fanquake> kallewoof: done
< kallewoof> thanks!
< promag> wumpus: regarding https://github.com/bitcoin/bitcoin/pull/17965#issuecomment-576008959, do you mean 0.19.2?
< fanquake> If anyone disagrees with my comments, please let me know: https://github.com/bitcoin/bitcoin/pull/17958#issuecomment-576196490
< wumpus> promag: no, I mean 0.20, this bug isn't in 0.19 right?
< promag> nope
< promag> I tend to agree with jonasschnelli comment there, but I also think that until split off we can fix without reverting hebasto pr
< wumpus> fanquake: I completely agree with you there
< wumpus> fanquake: we should try to avoid re-introducing getinfo, if there's additional info that needs to be exposed on RPC, it's best to group it in into one of the existing categories
< wumpus> if that's *really* not possible, it'd be fine to add a category
< wumpus> but "general" is very aspecific and meh
< wumpus> congrats on getting #17896 merged, I've added #17957 to high priority for review instead
< gribble> https://github.com/bitcoin/bitcoin/issues/17896 | Serialization improvements (step 2) by sipa . Pull Request #17896 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17957 | Serialization improvements step 3 (compression.h) by sipa . Pull Request #17957 . bitcoin/bitcoin . GitHub
< sipa> wumpus: thanks!
< wumpus> it looks like 0.19.1 is kind of dead in the water, because #17897 #17892 #17887 (all to fix MacOS issues I suppose?) are not really getting reviews or tested ACKs
< gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo . Pull Request #17897 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17892 | bug-fix: delay flushing undo files until after they are finalized by kallewoof . Pull Request #17892 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17887 | bug-fix macos: give free bytes to F_PREALLOCATE by kallewoof . Pull Request #17887 . bitcoin/bitcoin . GitHub
< wumpus> FWIW I think it's worth doing 0.19.1 without them if this takes too long
< wumpus> we had plans to make the release *soon* two weeks ago in the meeting
< wumpus> if you use macos, please help
< hebasto> the closed #17035 was added to the 0.19 milestone. Is it worth to add its replacement, #17453, to the 0.20 milestone?
< gribble> https://github.com/bitcoin/bitcoin/issues/17035 | qt: Fix text display when state of prune button is changed by emilengler . Pull Request #17035 . bitcoin/bitcoin . GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/17453 | gui: Fix intro dialog labels when the prune button is toggled by hebasto . Pull Request #17453 . bitcoin/bitcoin . GitHub
< luke-jr> wumpus: might be a good idea to add #17946 to 0.19.1 too; not sure how dangerous the current situation is, but fixing it should be harmless at least
< gribble> https://github.com/bitcoin/bitcoin/issues/17946 | Fix GBT: Restore "!segwit" and "csv" to "rules" key by luke-jr . Pull Request #17946 . bitcoin/bitcoin . GitHub
< luke-jr> (that is, I'm suggesting a github tag for 0.19.1 and merging it in if it manages to beat rc1 into master)
< wumpus> if it's critical we should add it, but at the current pace, the list of PRs for 0.19.1 is growing faster than they're reviewed
< wumpus> if it can wait for 0.19.2 it's probably better to postpone it
< luke-jr> I haven't heard of any real-world problems, but I don't know if that's because miners are unaffected in practice, or because they haven't upgraded yet
< luke-jr> wumpus: if it's just macos stuff lacking reviews, though, this one isn't macos :)
< * luke-jr> wonders how many devs use mac
< bitcoin-git> [bitcoin] hebasto opened pull request #17968: qt: Ensure that ModalOverlay is resized properly (master...20200120-fix-modaloverlay) https://github.com/bitcoin/bitcoin/pull/17968
< wumpus> luke-jr: dunno it seems to be getting attention but no ACKs yet
< promag> I'm on macos
< promag> #17897 is not macos specific
< gribble> https://github.com/bitcoin/bitcoin/issues/17897 | init: Stop indexes on shutdown after ChainStateFlushed callback. by jimpo . Pull Request #17897 . bitcoin/bitcoin . GitHub
< promag> hebasto: will look later
< hebasto> promag: ty
< bitcoin-git> [bitcoin] laanwj pushed 10 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/bb123c6527c0...98159132c3e7
< bitcoin-git> bitcoin/0.19 179d55f Joao Barbosa: zmq: Fix due to invalid argument and multiple notifiers
< bitcoin-git> bitcoin/0.19 7e66d04 Russell Yanofsky: Drop signal CClientUIInterface::LoadWallet
< bitcoin-git> bitcoin/0.19 eafcea7 Joao Barbosa: gui: Fix duplicate wallet showing up
< bitcoin-git> [bitcoin] laanwj merged pull request #17792: 0.19: Backports (0.19...2019-12-backports) https://github.com/bitcoin/bitcoin/pull/17792
< promag> please add 17457 to project 2
< promag> 13339 15202 17878 too
< promag> not sure why I can't do it
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a654626f076a...7e841f3f9b6c
< bitcoin-git> bitcoin/master e1c582c Sanjay K: contrib: makeseeds: Read suspicious hosts from a file instead of hardcoding
< bitcoin-git> bitcoin/master 7e841f3 Wladimir J. van der Laan: Merge #17823: scripts: Read suspicious hosts from a file instead of hardco...
< bitcoin-git> [bitcoin] laanwj merged pull request #17823: scripts: Read suspicious hosts from a file instead of hardcoding (master...master) https://github.com/bitcoin/bitcoin/pull/17823
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7e841f3f9b6c...5d2ff75e2070
< bitcoin-git> bitcoin/master 297e098 Ben Woosley: Fix doxygen errors
< bitcoin-git> bitcoin/master 5d2ff75 Wladimir J. van der Laan: Merge #17945: doc: Fix doxygen errors
< bitcoin-git> [bitcoin] laanwj merged pull request #17945: doc: Fix doxygen errors (master...2020-01-wdocumentation) https://github.com/bitcoin/bitcoin/pull/17945
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5d2ff75e2070...daae6403d8bd
< bitcoin-git> bitcoin/master bcad014 practicalswift: tests: Add fuzzing harness for DecodeHexTx(...)
< bitcoin-git> bitcoin/master 3f95fb0 practicalswift: build: Sort fuzzing harnesses to avoid future merge conflicts
< bitcoin-git> bitcoin/master daae640 Wladimir J. van der Laan: Merge #17777: tests: Add fuzzing harness for DecodeHexTx(...)
< bitcoin-git> [bitcoin] laanwj merged pull request #17777: tests: Add fuzzing harness for DecodeHexTx(...) (master...fuzzers-decode_tx) https://github.com/bitcoin/bitcoin/pull/17777
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/daae6403d8bd...631df3ee87ec
< bitcoin-git> bitcoin/master f2645c2 fanquake: windows: Enable heap terminate-on-corruption
< bitcoin-git> bitcoin/master 3d5d7aa fanquake: windows: remove call to SetProcessDEPPolicy
< bitcoin-git> bitcoin/master 631df3e Wladimir J. van der Laan: Merge #17916: windows: Enable heap terminate-on-corruption
< bitcoin-git> [bitcoin] laanwj merged pull request #17916: windows: Enable heap terminate-on-corruption (master...win_set_heap_terminate_on_corruption) https://github.com/bitcoin/bitcoin/pull/17916