00:34 < bitcoin-git> [bitcoin] Empact opened pull request #17907: Fix improper Doxygen inline comments (master...settings-documentation) https://github.com/bitcoin/bitcoin/pull/17907

04:20 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f8c69677a1a8...e258ce792a48

04:20 < bitcoin-git> bitcoin/master 498cdbb Ben Woosley: Fix improper Doxygen inline comments

04:20 < bitcoin-git> bitcoin/master e258ce7 fanquake: Merge #17907: doc: Fix improper Doxygen inline comments

04:21 < bitcoin-git> [bitcoin] fanquake merged pull request #17907: doc: Fix improper Doxygen inline comments (master...settings-documentation) https://github.com/bitcoin/bitcoin/pull/17907

12:47 < bitcoin-git> [bitcoin] hebasto opened pull request #17908: qa, qt: Remove QFont warnings with QT_QPA_PLATFORM=minimal (master...20200111-qttest-minimal-warn) https://github.com/bitcoin/bitcoin/pull/17908

13:24 < hebasto> hmm, the option to restart travis job is missing for me now...

13:28 < luke-jr> hebasto: does Travis know you're logged in?

13:30 < hebasto> sure, I'm logged in. It is possible to "Sign Out"

13:32 < hebasto> luke-jr: signed out -> signed in. It works now, Thanks!

17:58 < Kiminuo> https://github.com/bitcoin/bitcoin/blob/master/src/net_processing.cpp#L2448 - Could anyone explain this further to me? Is that byte 0x00 required for some specific reason or is it how Satoshi did that?

18:05 < sipa> Kiminuo: the p2p protocol used to have no distinction between cblock and cblockheader

18:05 < sipa> headers were just submitted as blocks with no transactiond

18:10 < Kiminuo> thanks, that makes sene

18:10 < Kiminuo> *sense

23:12 < emilengler> Is there an efficient way to get the output type from a "WalletAddress"?

23:12 < emilengler> Or from a CTxDestination

23:14 < sipa> a CTxDestination is a boost::variant

23:15 < sipa> it has a bunch of built in methods to query the type

23:16 < emilengler> sipa: I see but what's the "best way" to get the output type from it

23:16 < emilengler> Looks like there is no function which returns OutputType where CTxDestination is a parameter of

23:29 < sipa> no, that's impossible

23:29 < sipa> you can't distinguish p2sh multisig from p2sh-p2wsh multisig for example

23:29 < sipa> just based on the address

23:30 < emilengler> Ok thanks

23:30 < sipa> what are you trying to do?

23:31 < emilengler> In bitcoin-qt I wanna sort out all non legacy addresses in the sign message dialog as they are useless in this case anyway

23:32 < emilengler> The addressbook*

23:33 < luke-jr> can't signmessage with p2sh either, so that's doable

23:34 < luke-jr> should be able to just use .get

23:34 < emilengler> luke-jr: get? Of which object?

23:35 < luke-jr> the CTxDestination

23:37 < luke-jr> boost::get<PKHash>(&dest)

23:38 < emilengler> So I need to check every possible type?

23:38 < luke-jr> only PKHash because that's the only type that's valid for signing

23:38 < luke-jr> dest.type() is another way, possibly more efficient and more flexible

23:38 < emilengler> Oh sure

23:39 < emilengler> thanks

23:39 < emilengler> what is with .which()

23:43 < emilengler> luke-jr: Thx, works