< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2ed74a43a05a...a4a93a0badb3
< bitcoin-git> bitcoin/master 8313fa8 Russell Yanofsky: gui: Set CConnman byte counters earlier to avoid uninitialized reads
< bitcoin-git> bitcoin/master a4a93a0 fanquake: Merge #17906: gui: Set CConnman byte counters earlier to avoid uninitializ...
< bitcoin-git> [bitcoin] fanquake merged pull request #17906: gui: Set CConnman byte counters earlier to avoid uninitialized reads (master...pr/ipc-count) https://github.com/bitcoin/bitcoin/pull/17906
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a4a93a0badb3...ceb789cf3a90
< bitcoin-git> bitcoin/master c902c4c Jon Layton: doc: Add to Doxygen documentation guidelines
< bitcoin-git> bitcoin/master ceb789c fanquake: Merge #17873: doc: Add to Doxygen documentation guidelines
< bitcoin-git> [bitcoin] fanquake merged pull request #17873: doc: Add to Doxygen documentation guidelines (master...doxygen-developer-notes-improvements) https://github.com/bitcoin/bitcoin/pull/17873
< fanquake> promag thanks
< promag> fanquake: np, let me know if I should include more
< fanquake> Waiting on at least 3 other PRs to be merged first. Nothing else that is merged is currently tagged for backport.
< promag> which 3?
< promag> doh
< fanquake> minus the qt library checking I'd assume
< fanquake> Would like to get the macOS fixes in, so we stop running people out of disk space.
< fanquake> In fact I'm going to add all of these to the bug-fixes column in the high-prio project.
< fanquake> As we'd like to do a 0.19.1 soon.
< wumpus> yes, seems like a good idea
< kallewoof> There's actually a problem still remaining even with those two PRs... Apple filesystem seems to have a non-fixable bug right now where any over-pre-allocation will permanently result in that file being bigger than needed. No amount of ftruncate or F_PUNCHHOLE calls will fix it.
< kallewoof> Non-fixable = by devs, I mean. Apple can definitely fix it
< fanquake> kallewoof you have an upstream ticket open hey
< kallewoof> I'm leaning towards not using F_PREALLOCATE at all, for APFS. I can reliably detect if it IS APFS by checking if it is able to punch hole (HFS cannot)
< kallewoof> fanquake: Yes, but no one knows when Apple fixes, or if they realize it's a bug.
< fanquake> Yea. Looks like there have been APFS related issues floating around for at least a few years. i.e https://github.com/arvidn/libtorrent/pull/2450
< kallewoof> I was excited when I realized what punchhole does earlier today, but that doesn't seem to do anything. If someone sees an issue with my code, that'd be useful: https://pastebin.com/yrm2r8sm
< kallewoof> Weird. That libtorrent fix seems to indicate APFS doesn't allow F_PREALLOCATE at all, which is not right.
< fanquake> Going to ping him in our thread and see if he can comment.
< kallewoof> Sounds good
< sipa> arvidn currently works for blockstream, btw
< fanquake> sipa that's the main reason I felt like I could ping him
< fanquake> Already received a reply. Quick turnaround.
< bitcoin-git> [bitcoin] emilengler closed pull request #17901: Add feature to get specific help (master...2020-01-get-specific-help) https://github.com/bitcoin/bitcoin/pull/17901
< instagibbs> promag, somehow 0.19 wallet isn't finding destination records in wallet when it should... very odd bug
< bitcoin-git> [bitcoin] luke-jr opened pull request #17923: Use PACKAGE_NAME in GUI modal overlay and bitcoin-wallet (master...fix_pkgname_202001) https://github.com/bitcoin/bitcoin/pull/17923
< bitcoin-git> [bitcoin] instagibbs opened pull request #17924: IsUsedDestination shouldn't use key id as script id for ScriptHash (master...reuse_regression) https://github.com/bitcoin/bitcoin/pull/17924
< hebasto> MarcoFalke: oh, I realized that issue #17912 should be opened in the 'bitcoin-core/packaging' repo. Sorry.
< gribble> https://github.com/bitcoin/bitcoin/issues/17912 | bitcoin-core snap issues . Issue #17912 . bitcoin/bitcoin . GitHub
< luke-jr> instagibbs: good find
< luke-jr> I wonder if there's a good way to make it non-compilable
< instagibbs> yeah hurt to find :( I think so, left it open for discussion on the thread
< instagibbs> luke-jr, gave up for now, let me know if you think of something better :)
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #17925: Improve UpdateTransactionsFromBlock with Epochs (master...epoch-mempool-clean-split) https://github.com/bitcoin/bitcoin/pull/17925
< dongcarl> "they" are either null or unroutable... And "we" are going to broadcast our onion address?
< sipa> dongcarl: maybe it's wrong...
< dongcarl> :-/
< bitcoin-git> [bitcoin] practicalswift opened pull request #17926: tests: Add key_io fuzzing harness. Fuzz additional functions in existing fuzzing harnesses. (master...fuzzers-key_io-etc) https://github.com/bitcoin/bitcoin/pull/17926