< bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/631df3ee87ec...742f84d0de79
< bitcoin-git> bitcoin/master e3b19d8 Gregory Sanders: QT: bump fee returns PSBT on clipboard for watchonly-only wallets
< bitcoin-git> bitcoin/master 3c30d71 Gregory Sanders: QT: Change bumpFee asserts to simple error message
< bitcoin-git> bitcoin/master 742f84d fanquake: Merge #17492: QT: bump fee returns PSBT on clipboard for watchonly-only wa...
< bitcoin-git> [bitcoin] fanquake merged pull request #17492: QT: bump fee returns PSBT on clipboard for watchonly-only wallets (master...gui_bump_psbt) https://github.com/bitcoin/bitcoin/pull/17492
< bitcoin-git> [bitcoin] kallewoof opened pull request #17980: test: add missing #include to fix compiler errors (master...200122-tests-cuckoo-dequeue) https://github.com/bitcoin/bitcoin/pull/17980
< fanquake> kallewoof: hopefully the fix is that simple!
< kallewoof> fanquake: we'll know in half an hour or so :)
< fanquake> kallewoof: looks good. Has made it through to the functional tests. Wanna update the PR to mention it closes #17976.
< gribble> https://github.com/bitcoin/bitcoin/issues/17976 | Appveyor ci fails again . Issue #17976 . bitcoin/bitcoin . GitHub
< kallewoof> Oh, yeah okay
< kallewoof> Nice
< kallewoof> Done
< fanquake> :thu
< fanquake> ?
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/742f84d0de79...e45463a06abe
< bitcoin-git> bitcoin/master a5a2654 Karl-Johan Alm: test: add missing #include to fix compiler errors
< bitcoin-git> bitcoin/master e45463a fanquake: Merge #17980: test: add missing #include to fix compiler errors
< bitcoin-git> [bitcoin] fanquake merged pull request #17980: test: add missing #include to fix compiler errors (master...200122-tests-cuckoo-dequeue) https://github.com/bitcoin/bitcoin/pull/17980
< bitcoin-git> [bitcoin] giulio92 opened pull request #17981: Docs: Improve release-process.md formatting (master...release-process-formatting) https://github.com/bitcoin/bitcoin/pull/17981
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45463a06abe...a51aa2880d12
< bitcoin-git> bitcoin/master 9dd58ca Jim Posen: init: Stop indexes on shutdown after ChainStateFlushed callback.
< bitcoin-git> bitcoin/master a51aa28 fanquake: Merge #17897: init: Stop indexes on shutdown after ChainStateFlushed callb...
< bitcoin-git> [bitcoin] fanquake merged pull request #17897: init: Stop indexes on shutdown after ChainStateFlushed callback. (master...index-commit) https://github.com/bitcoin/bitcoin/pull/17897
< bitcoin-git> [bitcoin] fanquake pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/98159132c3e7...9d980c1f7f6f
< bitcoin-git> bitcoin/0.19 9d980c1 Jim Posen: init: Stop indexes on shutdown after ChainStateFlushed callback.
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/9d980c1f7f6f...4cf73504220e
< bitcoin-git> bitcoin/0.19 4cf7350 Wladimir J. van der Laan: Merge branch '0.19_2' into 0.19
< fanquake> In case anyone is wondering what has just happened; I had a lapse of concentration while preparing commits for backport (planning on cherry-picking to a branch and opening a PR), and accidentally pushed 9d980c1f7f6fd0eb686d3cc94ba4698547f151c2 straight to the 0.19 branch. wumpus has pushed 4cf73504220e95ea1c4961509ea757ce6d393a9b as a followup to 0.19 to add a Tree-SHA512 hash.
< kallewoof> Now that you mention it it did look kinda odd. I just assumed it ws because it wasn't master. :)
< wumpus> we kept it as it was as it's a good backport, avoiding the need to do a force-push
< kallewoof> FTR, verified the backport matches the original.
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a51aa2880d12...0a8b68cdf7d2
< bitcoin-git> bitcoin/master fae7530 MarcoFalke: scripted-diff: Set gitian arch back to amd64
< bitcoin-git> bitcoin/master 0a8b68c MarcoFalke: Merge #17483: build: Set gitian arch back to amd64
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17483: build: Set gitian arch back to amd64 (master...1911-gitianRevertToAmd64) https://github.com/bitcoin/bitcoin/pull/17483
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0a8b68cdf7d2...0038e536de6e
< bitcoin-git> bitcoin/master 219417b Hennadii Stepanov: Revert "refactor: Simplify connection syntax"
< bitcoin-git> bitcoin/master 70e4706 Hennadii Stepanov: Revert "refactor: Remove never used default parameter"
< bitcoin-git> bitcoin/master 0038e53 Wladimir J. van der Laan: Merge #17965: qt: Revert changes of pr17943
< bitcoin-git> [bitcoin] laanwj merged pull request #17965: qt: Revert changes of pr17943 (master...20200119-revert17943) https://github.com/bitcoin/bitcoin/pull/17965
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038e536de6e...04f78b818f02
< bitcoin-git> bitcoin/master 75163f4 Karl-Johan Alm: bug-fix macos: give free bytes to F_PREALLOCATE
< bitcoin-git> bitcoin/master 04f78b8 Wladimir J. van der Laan: Merge #17887: bug-fix macos: give free bytes to F_PREALLOCATE
< bitcoin-git> [bitcoin] laanwj merged pull request #17887: bug-fix macos: give free bytes to F_PREALLOCATE (master...macos-f_preallocate_fix) https://github.com/bitcoin/bitcoin/pull/17887
< jeremyrubin> hebasto: btw if you're interested in eliminating dependencies, you might be interested in reviewing https://github.com/JeremyRubin/bitcoin/pull/7
< jeremyrubin> Currently we maintain an entire *data structure* in the mempool just because of a circular resolution issue
< jeremyrubin> And we then have to do all these extra map lookups too rather than just keeping the data in the owning class
< sipa> i haven't followed up on the fuzzing work that's been done to the codebase... but i wonder has anyone considered using a dummy signature checker, and fuzzing script execution with it?
< wumpus> not sure either, would be best to ask practicalswift
< phantomcircuit> sipa, i dont think anybody has done that
< sipa> maybe i'll spend some time looking into how fuzzing works :)
< instagibbs> sipa, you shoudl attend the PR review club they did it 2 weeks ago :)
< sipa> i have not mastered the skill of attending meetings held in the past
< wumpus> hehe
< instagibbs> here I dropped this: ;
< jonatack> heh, the review club is gradually transitioning into a bitcoin optech-like resource
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/04f78b818f02...1ae46dce60a1
< bitcoin-git> bitcoin/master 9574de8 practicalswift: net: Avoid using C-style NUL-terminated strings as arguments in the netbas...
< bitcoin-git> bitcoin/master fefb916 practicalswift: tests: Add tests to make sure lookup methods fail on std::string parameter...
< bitcoin-git> bitcoin/master 7a046cd practicalswift: tests: Avoid using C-style NUL-terminated strings as arguments
< bitcoin-git> [bitcoin] laanwj merged pull request #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests. (master...c_str-cleanup-netbase) https://github.com/bitcoin/bitcoin/pull/17754
< phantomcircuit> sipa, is it easy to replace the signature checker for a script instance?
< phantomcircuit> iirc i looked into it but realized i'd need to much with the internals of the scripting stuff more than i wanted to
< sipa> phantomcircuit: the script interpreter literally takes in an object that abstracts that out
< sipa> you can pass one in that always returns true
< sipa> no code changes to the script interpreter itself needed
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ae46dce60a1...a3d198c93cbe
< bitcoin-git> bitcoin/master 76bf972 fanquake: scripts: fix check-symbols & check-security argument passing
< bitcoin-git> bitcoin/master c491368 fanquake: scripts: add MACHO dylib checking to symbol-check.py
< bitcoin-git> bitcoin/master a3d198c Wladimir J. van der Laan: Merge #17863: scripts: Add MACHO dylib checks to symbol-check.py
< bitcoin-git> [bitcoin] laanwj merged pull request #17863: scripts: Add MACHO dylib checks to symbol-check.py (master...add_macos_dylib_checks) https://github.com/bitcoin/bitcoin/pull/17863
< phantomcircuit> sipa, neat, then it should be pretty easy to do
< sipa> see the BaseSignatureChecker passed to EvalScript/VerifyScript
< dongcarl> jonasschnelli: Rebased a few of the net refactor PRs for you :-)
< bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a3d198c93cbe...4a072330763b
< bitcoin-git> bitcoin/master fa5d709 MarcoFalke: ci: Move wrap-qemu into separate script
< bitcoin-git> bitcoin/master faba467 MarcoFalke: ci: Fix QEMU_USER_CMD parse issues
< bitcoin-git> bitcoin/master fabb946 MarcoFalke: ci: Install needed gcc and qemu-user iff cross-compiling
< bitcoin-git> [bitcoin] laanwj merged pull request #17767: ci: Fix qemu issues (master...1912-ciFixWrapQemu) https://github.com/bitcoin/bitcoin/pull/17767
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17984: test: Add p2p test for forcerelay permission (master...2001-qaTxForceRelay) https://github.com/bitcoin/bitcoin/pull/17984
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #17985: net: Remove forcerelay of rejected txs (master...2001-p2pNoDeadCode) https://github.com/bitcoin/bitcoin/pull/17985
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a072330763b...7a311fa54a93
< bitcoin-git> bitcoin/master f7453dc fanquake: build: remove linking librt for backwards compatibility
< bitcoin-git> bitcoin/master 7a311fa Wladimir J. van der Laan: Merge #17738: build: remove linking librt for backwards compatibility
< bitcoin-git> [bitcoin] laanwj merged pull request #17738: build: remove linking librt for backwards compatibility (master...remove_librt_back_compat) https://github.com/bitcoin/bitcoin/pull/17738