Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
preemz has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
zxrqmz88 has joined #bitcoin-core-dev
zxrqmz88 has quit [Remote host closed the connection]
a1ph4byte has joined #bitcoin-core-dev
a1ph4byte has quit [Quit: Client closed]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
hashfunc1ebd has quit [Ping timeout: 248 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
bitdex has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
djb27 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
kobie has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
<bitcoin-git>
[bitcoin] martinus opened pull request #25057: refactor: replace remaining boost::split with StringSplit (master...2022-04-boost-split-exorcism) https://github.com/bitcoin/bitcoin/pull/25057
sudoforge has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
<fanquake>
regular / active contributors are added fairly sporadically
<bytes1440000>
based on commits?
<fanquake>
no
<bytes1440000>
okay thanks
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
merlin_moci has joined #bitcoin-core-dev
<merlin_moci>
Who decides to add new people to the bitcoin-core organisation on Github?
merlin_moci has left #bitcoin-core-dev [#bitcoin-core-dev]
merlin_moci has joined #bitcoin-core-dev
<merlin_moci>
Who decides to add new people to the bitcoin-core organisation on Github?
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
<merlin_moci>
Is there some public decision process one can follow?
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
<jonatack>
merlin_moci: my impression is people are occasionally nominated by a maintainer/admin/member, and that it's based on activity (probably mostly consistent, good-quality code review) over maybe 6-12 months or so
<jonatack>
on an ad hoc basis
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
evanlinjin has joined #bitcoin-core-dev
<merlin_moci>
jonatack that makes sense to me. I suppose you have to be an experienced developer to make a good-quality code review right?
merlin_moci has quit [Quit: Client closed]
merlin_moci has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
szkl has quit [Quit: Connection closed for inactivity]
merlin_moci has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
evanlinjin has joined #bitcoin-core-dev
Guest73 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Guest73 has quit [Client Quit]
Guest93 has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guest93 has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
merlin_moci has quit [Ping timeout: 252 seconds]
merlin_moci has joined #bitcoin-core-dev
goatpig has quit [Remote host closed the connection]
merlin_moci has quit [Quit: Client closed]
viniciuslazzari has joined #bitcoin-core-dev
<josibake>
merlin_moci: perhaps this goes without saying, but you don't need to be added to the github org to start opening prs/reviewing code
merlin_moci has joined #bitcoin-core-dev
jarthur_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 250 seconds]
doppo has quit [Ping timeout: 240 seconds]
szkl has joined #bitcoin-core-dev
doppo has joined #bitcoin-core-dev
<merlin_moci>
Can you make good-quality code reviews and become a member of bitcoin-core without being a developer?
___nick___ has joined #bitcoin-core-dev
Guest93 has joined #bitcoin-core-dev
Guest93 has quit [Quit: Ping timeout (120 seconds)]
Talkless has quit [Quit: Konversation terminated!]
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
<jonatack>
merlin_moci: if you have the knack and work at it consistently over time, it may be possible, or at least, not impossible? enjoying the process, the concepts, the code, the challenge, and having a deep desire to help bitcoin, and people, and your fellow contributors...might be some viable motivations for doing it over the long term...just an
<jonatack>
opinion, of course
<sipa>
What does "not being a developer" mean if you're doing useful developer work?
<merlin_moci>
I guess one doesn't need to be able to read or write code to maintain docs and fix typos in comments
<jonatack>
Yes, I was going to begin by asking what their definition of "developer" is; perhaps some people define it as requiring formal education or work experience
<jonatack>
merlin_moci: you would need to be able to read/write code
<jonatack>
you can learn, but it's essential
<lightlike>
making it your goal to become a member of the github org would set you up for a big disappointment as it changes almost nothing in practice - maintainers will be able to request from you over the github interface, but that's about it. it's not like it's a secret club.
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #25060: blockstorage: add LIFETIMEBOUND to GetFirstStoredBlock()::start_time (master...add-LIFETIMEBOUND-to-GetFirstStoredBlock-start_time) https://github.com/bitcoin/bitcoin/pull/25060
szkl has quit [Quit: Connection closed for inactivity]
hashfunc65d has joined #bitcoin-core-dev
<merlin_moci47>
Actually I was thinking about a hypothetical social engineering scenario. Suppose Bob likes ethereum and Bob is in love with Alice. However, Alice wants to marry a member of Bitcoin Core because she wants her Kids to become real cypherpunks. How can Bob get Alice while minimising his effort?
<merlin_moci47>
- Is there a minimum number of code reviews required?
<merlin_moci47>
- Are there any quality checks?
<merlin_moci47>
- How many members of Bitcoin Core have to agree for Bob to get invited?
merlin_moci47 has quit [Quit: Client closed]
merlin_moci has joined #bitcoin-core-dev
merlin_moci has quit [Client Quit]
merlin_moci has joined #bitcoin-core-dev
antonleviathan has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
djb27 has quit [Ping timeout: 248 seconds]
yanmaani has quit [Ping timeout: 240 seconds]
djb27 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Guyver2 has quit [Ping timeout: 260 seconds]
yanmaani has joined #bitcoin-core-dev
antonleviathan has quit [Quit: Client closed]
djb27 has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
SpellChecker has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
<dongcarl>
Hi all, are we also going to remove the instances of `GetAdjustedTime()` or no? I've kinda lost track of where we landed on that discussion... Ping MarcoFalke
<dongcarl>
the instances of `GetAdjustedTime()` in validation*
bomb-on has quit [Quit: aллилѹіа!]
tun4 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]