Heston has quit [Read error: Connection reset by peer]
brunoerg has quit [Remote host closed the connection]
Aaronvan_ has quit [Quit: Leaving...]
infernix has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
provoostenator has quit [Ping timeout: 240 seconds]
bitcoin-git has quit [Ping timeout: 248 seconds]
stijnbtc[m]1 has quit [Ping timeout: 240 seconds]
BlueMatt[m] has quit [Ping timeout: 240 seconds]
untor3h[m] has quit [Ping timeout: 240 seconds]
cryptoquick has quit [Quit: Ping timeout (120 seconds)]
sipa has quit [Ping timeout: 240 seconds]
dunxen has quit [Ping timeout: 260 seconds]
ademan[m] has quit [Ping timeout: 252 seconds]
Murch has quit [Ping timeout: 252 seconds]
willcl_ark has quit [Ping timeout: 256 seconds]
cameron[m] has quit [Ping timeout: 248 seconds]
kvaciral has quit [Ping timeout: 248 seconds]
arturomf94[m] has quit [Ping timeout: 248 seconds]
cryptoquick has joined #bitcoin-core-dev
remyers[m] has quit [Ping timeout: 260 seconds]
stijnbtc[m] has quit [Ping timeout: 260 seconds]
kakolainen[m] has quit [Ping timeout: 260 seconds]
nanotube has quit [Ping timeout: 276 seconds]
nanotube has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
ademan[m] has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
david-bakin has quit [Remote host closed the connection]
untor3h[m] has joined #bitcoin-core-dev
belcher has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 256 seconds]
david-bakin has joined #bitcoin-core-dev
<david-bakin>
BIP-341, among others, uses an algorithm called hash_TapSigHash (that is, "hash" with a subscript "TapSigHash". It does NOT say where this algorithm is specified, and I can't find it. If I look in the source code I see (`interpreter.cpp`) it seems to be the case that the hasher is initialized with the SHA256 of the string "TapSighash" - but why? I'd like to see the BIP (or wiki?)
arturomf94[m] has joined #bitcoin-core-dev
cameron[m] has joined #bitcoin-core-dev
stijnbtc[m]1 has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
kvaciral has joined #bitcoin-core-dev
belcher has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
<david-bakin>
oh wait - looks like it is "Tagged Hashes" in BIP-340, NVM
kakolainen[m] has joined #bitcoin-core-dev
Murch has joined #bitcoin-core-dev
BlueMatt[m] has quit [Ping timeout: 250 seconds]
sipa has quit [Ping timeout: 250 seconds]
untor3h[m] has quit [Ping timeout: 250 seconds]
dunxen has quit [Ping timeout: 250 seconds]
stijnbtc[m]1 has quit [Ping timeout: 240 seconds]
stijnbtc[m] has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
remyers[m] has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
dunxen has joined #bitcoin-core-dev
stijnbtc[m]1 has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
untor3h[m] has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
heston_ is now known as Heston
belcher has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
belcher has joined #bitcoin-core-dev
ZeroMaster has quit [Ping timeout: 260 seconds]
mekster66949 has quit [Quit: mekster66949]
mekster66949 has joined #bitcoin-core-dev
Evel-Knievel has joined #bitcoin-core-dev
mekster66949 has quit [Client Quit]
mekster66949 has joined #bitcoin-core-dev
TheRec has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
mekster66949 has quit [Quit: mekster66949]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 256 seconds]
Guest57 has joined #bitcoin-core-dev
mekster66949 has joined #bitcoin-core-dev
ronoaldo has quit [Quit: Konversation terminated!]
<earnestly>
Is it possible to generate the manuals without X11 (for bitcoin-qt)? It appears when using --version, I get 'qt.qpa.xcb: could not connect to display' and an IOT instruction abort
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
<hebasto>
Earnestly: no, unfortunately. It seems there's an open issue in the gui repo
Guest33 has quit [Quit: Client closed]
mikehu44_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
mikehu44 has quit [Ping timeout: 256 seconds]
<laanwj>
seems like a bug (though, there are various compromises with regard to bitcoin-qt initialization, that might make it necessary to initialize qt before showing the options/help, dunno)
sipsorcery has joined #bitcoin-core-dev
Guyver2_ has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<laanwj>
maybe it's no longer necessary to do that: we used to have the options help translatable, this is no longer the case
<laanwj>
no, it's more nasty: on windows we show the help message as a dialog, that's why the logic is so late
<bitcoin-git>
[bitcoin] fanquake closed pull request #18689: rpc: allow dumptxoutset to dump human-readable data (master...feature-utxo-ascii) https://github.com/bitcoin/bitcoin/pull/18689
<bitcoin-git>
[bitcoin] fanquake closed pull request #19358: torcontrol : avoid to set wrong outbound proxy and network settings when creating an inbound onion service. (master...pr351-bitcoin) https://github.com/bitcoin/bitcoin/pull/19358
<bitcoin-git>
[bitcoin] fanquake closed pull request #19880: fix CTxMemPool::TrimToSize to put only confirmed coins in pvNoSpendsRemaining (master...simplify-trimtosize) https://github.com/bitcoin/bitcoin/pull/19880
sudoforge has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #18988: RFC: Introducing AltNet, a pluggable framework for alternative transports (master...2020-05-rfc-altstack) https://github.com/bitcoin/bitcoin/pull/18988
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25117: test: Check msg type in msg capture is followed by zeros (master...2205-test-zero-🚛) https://github.com/bitcoin/bitcoin/pull/25117
bitdex has joined #bitcoin-core-dev
jonatack has quit [Quit: Connection closed]
vysn has joined #bitcoin-core-dev
david-bakin has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
mikehu44_ has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] furszy opened pull request #25118: wallet: unify “allow/block other inputs“ concept (master...2022_coinControl_unify_allowOtherInputs) https://github.com/bitcoin/bitcoin/pull/25118
ZeroMaster has joined #bitcoin-core-dev
furszy has joined #bitcoin-core-dev
furszy has quit [Quit: Client closed]
sipsorcery has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
ronoaldo has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #25119: net, refactor: move StartExtraBlockRelayPeers() from header to implementation (master...move-StartExtraBlockRelayPeers-from-header-to-implementation) https://github.com/bitcoin/bitcoin/pull/25119
jonatack has quit [Ping timeout: 260 seconds]
vysn has quit [Ping timeout: 260 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
pkwsj has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
pkwsj has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 276 seconds]
sipsorcery has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #25120: test: fix DWARF string_view linker error in blockfilter_tests (master...fix-DWARF-string_view-linker-error) https://github.com/bitcoin/bitcoin/pull/25120
<laanwj>
anything to add, remove, or that is on the list and (almost) ready for merge?
<jeremyrubin>
Would be good to get more conceptual review on #22876, which is a precursor for my high prio. has conceptual ack that this is a bit of an issue in how our script flag system is set up, is an issue that affects any and all R&D on things that happen in script wrt discouraging (e.g. CTV, APO, etc).
<gribble>
https://github.com/bitcoin/bitcoin/issues/22876 | [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test by JeremyRubin · Pull Request #22876 · bitcoin/bitcoin · GitHub
<jeremyrubin>
but it seems that theres some sentiment there might be a 'purer' way to handle it... i dont have any other ideas other than what i did
<laanwj>
should i add it to chasing concept ACK?
<jeremyrubin>
i'm not sure
<jeremyrubin>
maybe _aj_ should have a look since he's maintaining the APO branch?
<jeremyrubin>
How would you write test vectors for APO without these patches?
<laanwj>
oh, just added it
<jeremyrubin>
seems fine
<jeremyrubin>
i just want to underscore this isn't a ctv specific precursor, impacts anyone working on any opcode stuff if you want to write test vectors. so please review if you're doing that at all
<laanwj>
yes it seems like a pretty general tests change, judging from the title
<laanwj>
anything else to add/remove? any other topics people would like to discuss?
<_aj_>
jeremyrubin: will look
furszy has quit [Quit: Client closed]
<jeremyrubin>
ah also #22954 is related to the earlier one for any following along, equivalent for tx_valid/tx_invalid
<gribble>
https://github.com/bitcoin/bitcoin/issues/22954 | [TESTS] Allow tx_invalid.json tests to include flag rules for if_unset: [A,B,C] then_unset: [D] by JeremyRubin · Pull Request #22954 · bitcoin/bitcoin · GitHub
<jeremyrubin>
probably getting the first one looked over would be sufficient for now though
<laanwj>
better to focus on one at a time probably
<laanwj>
seems no other topics! well, another short meeting then, hope you can use the rest of the time for reviewing :)
<dongcarl>
Hi all, just wanted to let folks know that the libbitcoinkernel 2b (#25064) and 2c ( #25065) PRs are not dependent on the much longer kernel 2a PR, they are completely separate and much shorter!
<jonatack>
dongcarl: do you have any preference regarding which one to look at first?
furszy has quit [Quit: Client closed]
furszy has joined #bitcoin-core-dev
<jonatack>
(24410, i guess)
<laanwj>
dongcarl: thanks for the update!
bomb-on has quit [Quit: aллилѹіа!]
<dongcarl>
jonatack: No strong preference at all. I appreciate any review on any open PR!
jonhbit has quit [Quit: Client closed]
Talkless has quit [Quit: Konversation terminated!]
<david-bakin>
Can someone take a quick look at a failing `lint` run - https://cirrus-ci.com/task/5219398502842368 - I can't figure out what the error is referring to - doesn't mention a filename - how can I fix this? Thank you! "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe0 in position 1141: invalid continuation byte"
<david-bakin>
Seems to be when checking circular dependencies which is very odd since the only thing that is supposed to be in this PR is a new unit test.
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
Guest33 has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 252 seconds]
kexkey has joined #bitcoin-core-dev
<sipa>
these aren't really "full" death tests . la Googletest as it is not trapping
<sipa>
That . is a non-UTF8 character.
<sipa>
In the new file you're adding.
<sipa>
The circular dependency test is trying to parse your added file, and failing.
bomb-on has joined #bitcoin-core-dev
<jonatack>
david-bakin: you can try running those 3 failing linters on the command line with your changes to check locally
<jonatack>
i use a bash alias for checking functional tests; it cds into root and does: test/lint/lint-circular-dependencies.py ; ./test/lint/lint-python.py ; ./test/lint/lint-whitespace.py
BUSY has quit [Ping timeout: 246 seconds]
<david-bakin>
oh. i thought that a-with-accent was just a unicode char i pasted in. thanks for the instruction on how to run the linters locally, I will do that from now on
<sipa>
It is a unicode character, but it's not UTF-8 encoded.
<_aj_>
dongcarl: #24595?
<gribble>
https://github.com/bitcoin/bitcoin/issues/24595 | deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns · Pull Request #24595 · bitcoin/bitcoin · GitHub
<sipa>
It appears to be ISO8859-1
<jonatack>
*for checking all pull requests actually
<david-bakin>
eek. then vscode did the wrong thing. i'll have to be careful!
<sipa>
iso8859-1 is common in microsoft land, i think
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25121: test: compare `/mempool/info` response with `getmempoolinfo` RPC (master...2022-05-rest-mempool-info) https://github.com/bitcoin/bitcoin/pull/25121
Guest33 has quit [Ping timeout: 252 seconds]
bomb-on has quit [Quit: aллилѹіа!]
bomb-on has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] furszy opened pull request #25122: rpc: getreceivedbylabel, return early if no addresses were found in the address book. (master...2022_RPC_getreceivedbylabel_return_early) https://github.com/bitcoin/bitcoin/pull/25122
kexkey has quit [Quit: kexkey]
djb27__ has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
djb27_ has quit [Ping timeout: 276 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
djb27__ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Remote host closed the connection]
SpellChecker has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
djb27__ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Acen has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 246 seconds]
bomb-on has quit [Quit: aллилѹіа!]
sipsorcery has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
l2xl has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] fjahr opened pull request #25123: test: Use addconnection for robustness in index prune test (master...202205-index-prune-fix) https://github.com/bitcoin/bitcoin/pull/25123