david-bakin has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
cmirror has joined #bitcoin-core-dev
david-bakin has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
AaronvanW has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
bitdex has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
jarthur has joined #bitcoin-core-dev
<david-bakin>
Is there a limitation that the CI tests can't run nested Boost Test test suites?
<david-bakin>
I'm getting most of the CI jobs failing because "test setup error: no test cases matching filter or all test cases were disabled" - the "Running tests:" messages show only my _inner_ test suite running not the outer one
<david-bakin>
hi! i've been answering your comment on the PR - thank you for looking at this!
<david-bakin>
it runs for me and should for you as well! it _does_ print messages about assertions triggered, but those are death tests where the assertion is 1) expected! and 2) caught by a Boost Test `ExecutionMonitor` so that it can _check_ that the assertion was triggered.
<david-bakin>
proper behavior is to print the message and then pass the test.
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
<david-bakin>
hah! this documention comes _just in time_ for me, thank you MarcoFalke for thinking of it ...
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
djb27__ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
djb27_ has quit [Ping timeout: 240 seconds]
<jonatack>
-0, this repo isn't a good place for git documentation
<david-bakin>
no, but it is in `CONTRIBUTING.md` which already has a little help there for squashing commits ... ?
<david-bakin>
I myself look for good recipes for this sort of thing on stackoverflow but it could be useful here anyway?
SpellChecker_ has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<jonatack>
might be better to remove the existing git documentation, there are good external resources dedicated to it, which anyone can find
<orionwl>
jonatack: the squashing thing comes up so often it's useful to point people at it
orionwl is now known as laanwj
<laanwj>
almost every new contributor needs that explained
<laanwj>
i agree our repo is not the place for more extensive git documentation
<jonatack>
people will still require explanations anyway; maybe can add an appropriate link if wanted to the pre-prepared maintainer replies
<laanwj>
jonatack: the contributing doc seems to be useful, in contrast to git documentation which explains the details of every option it gives some steps that will (often) just work
<laanwj>
for our specific workflow, that is
brunoerg has quit [Ping timeout: 248 seconds]
<laanwj>
luke-jr: i don't understand why you get the dbus timeout, dbus is fully local and it should either instantly fail to connect to the bus, or instantly connect, having a timeout is really strange and i've never heard of it happening before
AaronvanW has joined #bitcoin-core-dev
<laanwj>
it comes across as some kind of local configuration issue
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44_ has quit [Ping timeout: 272 seconds]
vasild has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
z9z0b3t1c has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
szkl has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
mikehu44_ has quit [Ping timeout: 240 seconds]
kexkey has joined #bitcoin-core-dev
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
kexkey has quit [Quit: kexkey]
salvatoshi has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
evanlinjin has quit [Ping timeout: 240 seconds]
<sipa>
Signet just passed 2^40 chainwork!
<david-bakin>
I have a non-bitcoin-specific "process" question: If I get a suggestion in a PR that has actual code and the button "commit suggestion" and I press the button - how does that fix, committed in bitcoin/bitcoin, get back to my fork? Do I just do it manually (create a patch any apply it) or??
<sipa>
It adds a commit to the branch of yours which is backing the PR.
<sipa>
If you click it, and then git fetch, you'll see that commit locally too, allowing you to squash/rebase it as well.
<jamesob>
david-bakin: in the past I've just applied the patch locally during a `rebase` and, if it's a substantial enough suggestion, added co-author credits with `Co-authored-by: foo <bar@baz.com>`
___nick___ has joined #bitcoin-core-dev
<david-bakin>
alright then! impressive feature on their part!
goatpig has quit [Remote host closed the connection]
TheRec has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
djb27_ has joined #bitcoin-core-dev
Zenton has quit [Ping timeout: 240 seconds]
djb27__ has quit [Ping timeout: 240 seconds]
<michaelfolkson>
Signet just passed 2^40 chainwork! -> Shoulda made Signet PoS #changethecode
* michaelfolkson
leaves
<dhruv>
are there instructions somewhere on how to reproduce a fuzz crash from CI output? I have the base unit, but do not have access to the qa-assets directory or the crash-** file since it is CI
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
<dhruv>
(just found "re-run with terminal access" on cirrus CI)
kouloumos has joined #bitcoin-core-dev
<jonatack>
dhruv: there is also the "Reproduce a fuzzer crash reported by the CI" section in doc/fuzzing.md
<jonatack>
david-bakin: same as jamesob, manual update with rebase -- in my case, the motivation is to avoid github-specific whistles and features and prefer an agnostic workflow in the local dev environment)
<darosior>
dhruv: wild guess as i didn't check but iirc libfuzzer gives you the seed in base64, so you can just recreate a binary file locally and feed that to your fuzzer
flooded has joined #bitcoin-core-dev
<jonatack>
dhruv: haven't done it for some time now, what is your CI crash case?
<jonatack>
* current status, git pulling a few hundred MiB of qa-assets
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
<dhruv>
darosior: yeah, i ended up being able to do that by using the cirrus ci terminal access. Turns out a base64{0} seed just meant I needed to create an empty file
<dhruv>
jonatack: haha yeah it takes a while. i was able to reproduce it though using the terminal access
<jonatack>
dhruv: thanks, glad the terminal access worked, i might check if the fuzzing doc is still working
___nick___ has joined #bitcoin-core-dev
<dhruv>
jonatack: I didn't follow the "git pull qa-assets" part (since you're already in the qa-assets dir at that point) plus, the crash seed isn't committed (and perhaps that makes sense because the code is not on master yet?)
<lightlike>
dhruv: I think the crash seed must be part of the qa-asset repo, the CI doesn't do any actual fuzzing, as in creating new random seeds. So checking out the latest version of the qa-asset repo and just running all seeds against your branch should have worked as well.
SpellChecker has quit [Remote host closed the connection]
<lightlike>
(all seeds for the specific fuzz target that failed)
SpellChecker has joined #bitcoin-core-dev
<dhruv>
lightlike: i see, that makes sense
emcy_ has quit [Quit: Leaving]
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
Guest7769 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]