<bitcoin-git>
bitcoin/master ef6dbe6 Suhas Daftuar: Respond to getheaders if we have sufficient chainwork
<bitcoin-git>
bitcoin/master a35f963 Suhas Daftuar: Add test for getheaders behavior
<bitcoin-git>
bitcoin/master 5f65aff MacroFake: Merge bitcoin/bitcoin#24178: p2p: Respond to getheaders if we have suffici...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24178: p2p: Respond to getheaders if we have sufficient chainwork (master...2022-01-headers-response-requires-minchainwork) https://github.com/bitcoin/bitcoin/pull/24178
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
ubba has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 258 seconds]
Guyver2 has quit [Ping timeout: 255 seconds]
aleggg has joined #bitcoin-core-dev
Guyver2__ has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
Guyver2_ has quit [Ping timeout: 272 seconds]
z9z0b3t1c has quit [Ping timeout: 246 seconds]
mikehu44 has quit [Ping timeout: 246 seconds]
kanka has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
kanka has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 240 seconds]
evanlinjin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 240 seconds]
noonien has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
evanlinjin has joined #bitcoin-core-dev
noonien has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guest30 has joined #bitcoin-core-dev
Guest30 has quit [Client Quit]
noonien has quit [Quit: Ping timeout (120 seconds)]
noonien has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 258 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 258 seconds]
<sdaftuar>
_aj_: I'm not sure I think of that bip125 issue as a bug in the code -- I think the code does what is intended, and the BIP should just be clarified
<sdaftuar>
(er, does what was intended -- i think a wholesale improvement to that policy would be good too)
<fanquake>
want to triple check your not running on aarch64
<sipa>
triple checking my target triplet?
z9z0b3t1c has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 255 seconds]
Guyver2__ has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has quit [Ping timeout: 240 seconds]
mikehu44 has quit [Ping timeout: 255 seconds]
furszy has quit []
common has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
nanotube has quit [Quit: *poof*]
<bitcoin-git>
[bitcoin] klementtan opened pull request #25256: logging: Add leveldb thread name and fix logging empty thread name (master...add_leveldb_threadname) https://github.com/bitcoin/bitcoin/pull/25256
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
ronoaldo has joined #bitcoin-core-dev
<_aj_>
sdaftuar: sure; looks more to me like the spec stopped making sense when the implementation got serious, but same difference
ronoaldo has quit [Quit: Konversation terminated!]
ronoaldo has joined #bitcoin-core-dev
<sdaftuar>
the BIP was written after the code was, to try to explain to wallet developers how to think about it; i think that detail around "yes of course descendants of rbf-signalling transactions should be thought of as replaceable, but you need to conflict with the rbf-signalling parent to do so" was just difficult to put into words.
<instagibbs>
hmm.
<_aj_>
sdaftuar: well that's lame!
<_aj_>
sdaftuar: (spec not matching already written code, i mean)
<_aj_>
sdaftuar: are there fundamental problems with doing it the way described in the bip, or just "that's not what we were trying to do but it might work" or "it's slightly slower, uses slightly more memroy, slightly annoying to implement, etc" ?
<instagibbs>
yeah the spec is clearly stating the other way
<instagibbs>
imo
<sdaftuar>
to be clear, when you say the way defined in the BIP, you mean: look at all in-mempool ancestors of a transaction and see if any are signaling for RBF, and if so, allow rbf of the transaction which is being conflicted?
<_aj_>
yes
<sdaftuar>
that seems like a bad thing to code up, imo. you might have to look at a lot of stuff, as a new transaction can conflict with up to 100 transactions as BIP 125 is written now, and each might have 24 parents
<sdaftuar>
i'd rather we just move to full rbf and call it a day
<instagibbs>
ACK!
<_aj_>
yeah, you'd need to cache the"any-ancestor-signals-rbf" and update that cache when ancestors get confirmed
<_aj_>
sounds like the "might work, might not" case to me
<sdaftuar>
sure, and not really worth the effort imo
<_aj_>
yeah
<sipa>
is the implemented/intended behavior "a transaction with RBF signalling can be replaced, even if it has non-RBF-signalling descendants"?
<sdaftuar>
isn't there also a discrepancy in the bip and iplementation around how signalling is defined? i can't remember for sure off the top of my head, but i believe we only look at the first input of a transaction to see if it's signalling, rather than all inputs
<sdaftuar>
sipa: yes
<sipa>
thanks, now i finally understand what the discussion is actually about :)
<sdaftuar>
oh, maybe im wrong about that
<sdaftuar>
(the signaling issue)
furszy has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
<sipa>
if we'd want to change the RBF policy anyway, concept ACK full RBF...
jonatack has joined #bitcoin-core-dev
<_aj_>
hmm, last time i thought about full rbf, i think bitgo was actively using non-signalling of rbf as an essential input to the 'accept-zeroconf' logic
<_aj_>
bah, bitrefill
<instagibbs>
lots of services do
<instagibbs>
but like...
<_aj_>
i can't seem to find the twitter thread i'm thinking of
furszy has quit [Remote host closed the connection]
sipsorcery has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
Guest60 has joined #bitcoin-core-dev
Guest60 has quit [Client Quit]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25257: p2p: Disconnect manual peers and not discourage all peers with the same address on getblocktxn msg corruption (master...2205-no-misbehaving-🌷) https://github.com/bitcoin/bitcoin/pull/25257
pkwsj has joined #bitcoin-core-dev
ubba has quit [Quit: Connection closed for inactivity]
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 250 seconds]
furszy has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
metallicc99 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
metallicc99 has quit [Remote host closed the connection]
metallicc has quit [Ping timeout: 260 seconds]
metallicc99 has joined #bitcoin-core-dev
<bytes1440000>
I think knots has the option to use full rbf, opt in or no rbf. Also has options to disallow address reuse in mempool, set minimum fee rate for replacement tx and other things.
<bytes1440000>
are you sure 'make clean' was required?
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
gwillen1 is now known as gwillen
<hebasto>
bytes1440000: error is not the same :) It seems you have no android cross-compile toolchain installed
<bytes1440000>
hmmm
<bytes1440000>
let me install that and try again
<bitcoin-git>
[bitcoin] ryanofsky reopened pull request #22764: build: Include qt sources for parsing with extract_strings.py (master...210821-translation) https://github.com/bitcoin/bitcoin/pull/22764
<hebasto>
bytes1440000: `/home/hebasto/Android/Sdk/ndk/23.1.7779620/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android28-clang` points to `/home/hebasto` :)
<hebasto>
I think you have different toolchain location
<hebasto>
just sanity check all variables provided to `make -C depends`
<bytes1440000>
yeah I just copied same command and forgot to change the variables
<hebasto>
also double check NDK version in paths
pkwsj has quit [Ping timeout: 252 seconds]
pkwsj has joined #bitcoin-core-dev
<bytes1440000>
I tried this and manually checked all paths are correct: make -C depends HOST=aarch64-linux-android ANDROID_SDK=/home/test/Android/Sdk ANDROID_NDK=/home/test/Android/Sdk/ndk/24.0.8215888/ ANDROID_API_LEVEL=28 ANDROID_TOOLCHAIN_BIN=/home/test/Android/Sdk/ndk/24.0.8215888/toolchains/llvm/prebuilt/linux-x86_64/bin
<hebasto>
bytes1440000: suggesting to switch to NDK 23; and submit an issue about bug with NDK 24 (but not sure if enough devs would care about support for non-LTS version of NDK)