brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
<luke-jr> sipa: about 1/3 of the Knots patchset at this point is simply bugfixes that presumably should be uncontroversial conceptually
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
theStack has quit [Quit: Lost terminal]
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 246 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has quit [Ping timeout: 248 seconds]
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
evanlinjin has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
AaronvanW has quit [Remote host closed the connection]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
AaronvanW has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 252 seconds]
lukedashjr is now known as luke-jr
AaronvanW has quit [Ping timeout: 260 seconds]
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
sipsorcery has joined #bitcoin-core-dev
aleggg has joined #bitcoin-core-dev
cmirror has quit [Ping timeout: 276 seconds]
AaronvanW has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 272 seconds]
aleggg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/91a42d63efaf...8270740befa3
<bitcoin-git> bitcoin/master 8c5533c Sebastian Falbesoner: rpc: remove deprecated "softforks" field from getblockchaininfo
<bitcoin-git> bitcoin/master a01b92a Sebastian Falbesoner: doc: add release notes about removal of the `deprecatedrpc=softforks` flag
<bitcoin-git> bitcoin/master 8270740 MacroFake: Merge bitcoin/bitcoin#25114: rpc: remove deprecated "softforks" field from...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25114: rpc: remove deprecated "softforks" field from getblockchaininfo (master...202205-rpc-remove_deprecated_softforks_from_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/25114
AaronvanW has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8270740befa3...0be1dc1f56f6
<bitcoin-git> bitcoin/master 8edd0d3 Sebastian Falbesoner: refactor: reduce scope of lock `m_most_recent_block_mutex`
<bitcoin-git> bitcoin/master 83003ff Sebastian Falbesoner: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex
<bitcoin-git> bitcoin/master 0be1dc1 MacroFake: Merge bitcoin/bitcoin#24062: refactor: replace RecursiveMutex `m_most_rece...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #24062: refactor: replace RecursiveMutex `m_most_recent_block_mutex` with Mutex (master...202201-refactor_replace_recursive_mutex_cs_last_block) https://github.com/bitcoin/bitcoin/pull/24062
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git> [bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
<bitcoin-git> [bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
salvatoshi has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
ronoaldo has quit [Quit: Konversation terminated!]
djb27_ has joined #bitcoin-core-dev
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
SpellChecker_ has joined #bitcoin-core-dev
bitdex_ has quit [Ping timeout: 240 seconds]
SpellChecker has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
Guest1 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
SpellChecker_ has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Guest1 has quit [Quit: Client closed]
jonatack has quit [Ping timeout: 260 seconds]
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
bitdex_ has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
kexkey has quit [Ping timeout: 248 seconds]
kexkey has joined #bitcoin-core-dev
bitdex_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0be1dc1f56f6...1ab389b1bac1
<bitcoin-git> bitcoin/master c9fdaa5 Sebastian Falbesoner: wallet: CreateTransactionInternal(): return out-params as (optional) struct
<bitcoin-git> bitcoin/master 4c5ceb0 Sebastian Falbesoner: wallet: CreateTransaction(): return out-params as (optional) struct
<bitcoin-git> bitcoin/master 1ab389b fanquake: Merge bitcoin/bitcoin#20640: wallet, refactor: return out-params of Create...
<bitcoin-git> [bitcoin] fanquake merged pull request #20640: wallet, refactor: return out-params of CreateTransaction() as optional struct (master...202012-refactor-wallet-createtransaction-return_out_params_in_optstruct) https://github.com/bitcoin/bitcoin/pull/20640
yanmaani1 has joined #bitcoin-core-dev
yanmaani has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
sudoforge has quit [Ping timeout: 240 seconds]
yanmaani2 has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 240 seconds]
z9z0b3t1_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
z9z0b3t__ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 250 seconds]
theStack has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
<jonatack> david-bakin: i agree, some things can be different coming from companies or other open source projects. if helpful wrote a few articles about it at https://jonatack.github.io/articles, perhaps the most useful one is https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core
<jonatack> (i try to keep them up to date, so don't hesitate to LMK if anything isn't)
outfox has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 260 seconds]
szkl has quit [Quit: Connection closed for inactivity]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
mikehu44 has quit [Quit: No Ping reply in 180 seconds.]
mikehu44 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] jonatack opened pull request #25155: GetTimeSeconds() removal followups (master...GetTimeSeconds-removal-followups) https://github.com/bitcoin/bitcoin/pull/25155
outfox has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
bitdex_ has quit [Quit: = ""]
SpellChecker has quit [Remote host closed the connection]
kexkey has quit [Ping timeout: 248 seconds]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
mikehu44 has quit [Ping timeout: 246 seconds]
mikehu44 has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
<jamesob> sorry, have been out of IRC for a bit; are we not using designated initializers anymore? https://github.com/bitcoin/bitcoin/pull/25064#issuecomment-1127842628
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<bitcoin-git> [bitcoin] jonatack closed pull request #25155: GetTimeSeconds() removal followups (master...GetTimeSeconds-removal-followups) https://github.com/bitcoin/bitcoin/pull/25155
<laanwj> i think the conclusion from the last meeting it was discussed was that it's okay to use them because all supported compilers effectively support them, but dunno
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
<jamesob> laanwj: ah okay, thanks
___nick___ has joined #bitcoin-core-dev
<laanwj> i'd guess someone commented on dongcarl using them
sudoforge has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
z9z0b3t__ has quit []
<laanwj> it's hard enough to get things merged without anything controversial
yanmaani2 has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] jonatack opened pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<david-bakin> jonatack - thanks! will look at those articles
SpellChecker_ has quit [Quit: bye]
<jamesob> laanwj: haha no kidding
ronoaldo has joined #bitcoin-core-dev
<_aj_> jamesob: #24531 -- VS 2019 (which CI uses) doesn't support them, and figuring out how to fix that isn't trivial
<gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
<sipsorcery> _aj_: in fairness VS2019 does seem support them it just seems to want to use a massive amount of memory to compile them...
<_aj_> sipsorcery: doesn't support them with the amount of memory we currently allocate for those CI jobs :-P
<sipsorcery> proof of memory
sudoforge has quit [Quit: 404]
<sipa> pom pom pom
<sipa> 🍎
sudoforge has joined #bitcoin-core-dev
<_aj_> does being a pom pom expert make sipa a cheerleader?
kexkey has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<TallTim> > <
yanmaani2 has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
<sipa> i wonder if cheerleaders in France say apple apple.
<sipa> *use
mikehu44 has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1ab389b1bac1...dd8a2df488f6
<bitcoin-git> bitcoin/master 652b54e laanwj: bench: Add `--sanity-check` flag, use it in `make check`
<bitcoin-git> bitcoin/master 4f31c21 laanwj: bench: Make all arguments -kebab-case
<bitcoin-git> bitcoin/master dd8a2df fanquake: Merge bitcoin/bitcoin#25107: bench: Add `--sanity-check` flag, use it in `...
<bitcoin-git> [bitcoin] fanquake merged pull request #25107: bench: Add `--sanity-check` flag, use it in `make check` (master...2022-05-bench-one-iteration) https://github.com/bitcoin/bitcoin/pull/25107
evanlinjin has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd8a2df488f6...d5d40d59f8d1
<bitcoin-git> bitcoin/master ada8358 amadeuszpawlik: Sanitize port in `addpeeraddress()`
<bitcoin-git> bitcoin/master d5d40d5 fanquake: Merge bitcoin/bitcoin#23679: Sanitize `port` in `addpeeraddress()`
<bitcoin-git> [bitcoin] fanquake merged pull request #23679: Sanitize `port` in `addpeeraddress()` (master...sanitize_port_rpc) https://github.com/bitcoin/bitcoin/pull/23679
ulrichard has joined #bitcoin-core-dev
moneyball__ has joined #bitcoin-core-dev
FelixWeis_ has joined #bitcoin-core-dev
hugohn_ has joined #bitcoin-core-dev
schmidty_ has joined #bitcoin-core-dev
hsmiths_ has joined #bitcoin-core-dev
josibake_ has joined #bitcoin-core-dev
Lightsword_ has joined #bitcoin-core-dev
instagibbs_ has joined #bitcoin-core-dev
pinheadmz_ has joined #bitcoin-core-dev
javi404_ has joined #bitcoin-core-dev
takinbo_ has joined #bitcoin-core-dev
orionwl has joined #bitcoin-core-dev
gwillen1 has joined #bitcoin-core-dev
_aj__ has joined #bitcoin-core-dev
_aj__ has quit [Changing host]
_aj__ has joined #bitcoin-core-dev
doppo_ has joined #bitcoin-core-dev
kanzure_ has joined #bitcoin-core-dev
baakeydo1 has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
BUSY has quit [*.net *.split]
sipa has quit [*.net *.split]
stijnbtc[m] has quit [*.net *.split]
instagibbs has quit [*.net *.split]
javi404 has quit [*.net *.split]
schmidty has quit [*.net *.split]
kanzure has quit [*.net *.split]
baldur has quit [*.net *.split]
doppo has quit [*.net *.split]
laanwj has quit [*.net *.split]
takinbo has quit [*.net *.split]
pinheadmz has quit [*.net *.split]
hsmiths has quit [*.net *.split]
Lightsword has quit [*.net *.split]
_aj_ has quit [*.net *.split]
hugohn has quit [*.net *.split]
josibake has quit [*.net *.split]
FelixWeis has quit [*.net *.split]
baakeydow has quit [*.net *.split]
gwillen has quit [*.net *.split]
moneyball_ has quit [*.net *.split]
hsmiths_ is now known as hsmiths
schmidty_ is now known as schmidty
FelixWeis_ is now known as FelixWeis
Lightsword_ is now known as Lightsword
baldur has joined #bitcoin-core-dev
<jamesob> _aj_: ah okay, thankks
BUSY has joined #bitcoin-core-dev
stijnbtc[m] has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] brunoerg opened pull request #25158: rpc, wallet: add abandoned field for all categories of transaction in ListTransaction (master...2022-05-abandoned-listtransactions) https://github.com/bitcoin/bitcoin/pull/25158
z9z0b3t1c has quit [Ping timeout: 246 seconds]
salvatoshi has quit [Ping timeout: 272 seconds]
jonatack has quit [Ping timeout: 248 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
<dongcarl> Nah no one commented on my using them, but I just wanted to get this PR through without waiting on #24531. Likely will need something like #24531 for later PRs that add a bunch of members to these Options structs tho
<gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/24531 | Use designated initializers by MarcoFalke · Pull Request #24531 · bitcoin/bitcoin · GitHub
<dongcarl> jamesob: ^
bomb-on has joined #bitcoin-core-dev
<jamesob> dongcarl: gotcha, thanks
<_aj__> dongcarl: if you make a function to do the construction, you can use clang-tidy's bugprone-argument-comment to check you're initializing what you think you are
_aj__ is now known as _aj_
<dongcarl> _aj__: Right... If we don't get anywhere with the designated initializers support I might just do that... Thinking of it, there might be cases where having a constructor is nicer since you can have some logic in there... Will have a think
<_aj_> dongcarl: seems worth doing in the meantime to me, still inconvenient compared to designated initializers
<_aj_> dongcarl: (but works for functions not just structs, so prob still useful even with them)
<david-bakin> I like the naming of those "bugprone" arguments. I wish compiler messages used that as a tag for certain warnings. In fact, compiler warnings should all have tags like "bugprone", "undef behavior",
<david-bakin> "impl-defined behavior", etc.
Talkless has joined #bitcoin-core-dev
Guest55 has joined #bitcoin-core-dev
kanzure_ is now known as kanzure
Guest55 has quit [Client Quit]
sipsorcery has quit [Ping timeout: 240 seconds]
outfox has joined #bitcoin-core-dev