Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] Empact opened pull request #25152: refactor: Split util/system into exception, shell, and fs-specific files (master...2022-05-split-system) https://github.com/bitcoin/bitcoin/pull/25152
<bitcoin-git>
[bitcoin] Empact closed pull request #24455: refactor: Split ArgsManager out of util/system (master...2022-03-util-args-manager) https://github.com/bitcoin/bitcoin/pull/24455
salvatoshi has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
ronoaldo has quit [Quit: Konversation terminated!]
djb27_ has joined #bitcoin-core-dev
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
SpellChecker_ has joined #bitcoin-core-dev
bitdex_ has quit [Ping timeout: 240 seconds]
SpellChecker has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
Guest1 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
SpellChecker_ has quit [Ping timeout: 240 seconds]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Guest1 has quit [Quit: Client closed]
jonatack has quit [Ping timeout: 260 seconds]
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bitdex_ has quit [Ping timeout: 240 seconds]
bitdex_ has joined #bitcoin-core-dev
bitdex_ has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25153: scripted-diff: Use getIntT over get_int/get_int64 (master...2205-uni-int-🗝) https://github.com/bitcoin/bitcoin/pull/25153
outfox has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
bitdex_ has quit [Quit: = ""]
SpellChecker has quit [Remote host closed the connection]
kexkey has quit [Ping timeout: 248 seconds]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25156: Disconnect block-relay-only peers with relay permission when they fill tx announcements (master...2205-block-relay-only-why-tx-inv-🤗) https://github.com/bitcoin/bitcoin/pull/25156
<laanwj>
i think the conclusion from the last meeting it was discussed was that it's okay to use them because all supported compilers effectively support them, but dunno
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
<jamesob>
laanwj: ah okay, thanks
___nick___ has joined #bitcoin-core-dev
<laanwj>
i'd guess someone commented on dongcarl using them
sudoforge has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
z9z0b3t__ has quit []
<laanwj>
it's hard enough to get things merged without anything controversial
yanmaani2 has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] jonatack opened pull request #25157: Fix -rpcwait with -netinfo returning negative time durations (master...update-time-in-rpcwait-and-netinfo) https://github.com/bitcoin/bitcoin/pull/25157
<david-bakin>
jonatack - thanks! will look at those articles
SpellChecker_ has quit [Quit: bye]
<jamesob>
laanwj: haha no kidding
ronoaldo has joined #bitcoin-core-dev
<_aj_>
jamesob: #24531 -- VS 2019 (which CI uses) doesn't support them, and figuring out how to fix that isn't trivial
<bitcoin-git>
[bitcoin] brunoerg opened pull request #25158: rpc, wallet: add abandoned field for all categories of transaction in ListTransaction (master...2022-05-abandoned-listtransactions) https://github.com/bitcoin/bitcoin/pull/25158
z9z0b3t1c has quit [Ping timeout: 246 seconds]
salvatoshi has quit [Ping timeout: 272 seconds]
jonatack has quit [Ping timeout: 248 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
<dongcarl>
Nah no one commented on my using them, but I just wanted to get this PR through without waiting on #24531. Likely will need something like #24531 for later PRs that add a bunch of members to these Options structs tho
<_aj__>
dongcarl: if you make a function to do the construction, you can use clang-tidy's bugprone-argument-comment to check you're initializing what you think you are
_aj__ is now known as _aj_
<dongcarl>
_aj__: Right... If we don't get anywhere with the designated initializers support I might just do that... Thinking of it, there might be cases where having a constructor is nicer since you can have some logic in there... Will have a think
<_aj_>
dongcarl: seems worth doing in the meantime to me, still inconvenient compared to designated initializers
<_aj_>
dongcarl: (but works for functions not just structs, so prob still useful even with them)
<david-bakin>
I like the naming of those "bugprone" arguments. I wish compiler messages used that as a tag for certain warnings. In fact, compiler warnings should all have tags like "bugprone", "undef behavior",
<david-bakin>
"impl-defined behavior", etc.
Talkless has joined #bitcoin-core-dev
Guest55 has joined #bitcoin-core-dev
kanzure_ is now known as kanzure
Guest55 has quit [Client Quit]
sipsorcery has quit [Ping timeout: 240 seconds]
outfox has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
theStack has quit [Remote host closed the connection]
kexkey has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] ishaanam opened pull request #25159: test: use `sendall` in wallet_taproot.py tests (master...wallet_taproot_sendall_fix) https://github.com/bitcoin/bitcoin/pull/25159
evanlinjin has quit [Ping timeout: 240 seconds]
kexkey has joined #bitcoin-core-dev
<achow101>
luke-jr: do you only see the segfaul with bitcoin-qt? and can you get it reliably?
<achow101>
it doesn't always segfault for me, just sometimes
<achow101>
and never in gdb
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
dviola has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<luke-jr>
achow101: every time, yes
<luke-jr>
I didn't try bitcoind tho
Brad has joined #bitcoin-core-dev
Brad has quit [Client Quit]
<luke-jr>
achow101: maybe it's reliable for me because of UBSan?
<achow101>
oh, could be
<achow101>
lemme try that
kexkey has quit [Quit: kexkey]
kexkey has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
kexkey has quit [Client Quit]
kexkey has joined #bitcoin-core-dev
<achow101>
luke-jr: can you bisect for the commit that introduced the problem?
<luke-jr>
k
<luke-jr>
confirmed bitcoind is not affected FWIW
<luke-jr>
curiously, bitcoind errors out MUCH faster than -qt :o
<achow101>
the backtrace you posted seems like maybe it's a problem with InitError and not specifically an unsupported wallet types problem
<luke-jr>
possibly, though I got the impression it was trying to cleanup a wallet that wasn't loaded
<luke-jr>
unrelated: randomly getting `QVariant::load: unknown user type with name BitcoinUnits::Unit.` - is this fixed recently, or should I open an issue?
<luke-jr>
bleh, branch-23 has the segfault too
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
<achow101>
i've not seen that error before
<luke-jr>
when I tried to debug it earlier, it disappeared on me :|
<sipa>
Ah, a Heisenbug.
___nick___ has quit [Ping timeout: 272 seconds]
<luke-jr>
oh, I guess Core never merged the dbus timeout fix - that's probably why -qt is slower
<luke-jr>
(obviously the --with-system-* are noops on Core commits)
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
ulrichard has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
<luke-jr>
f3a17bbe5f7d23b6ecc20e363920492b50859dad is the first bad commit; qt: Do not exit and re-enter main event loop during shutdown
sipsorcery has quit [Ping timeout: 276 seconds]
<luke-jr>
achow101: no, commenting that line doesn't fix it
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<achow101>
I think maybe the problem is that the splash screen cleans itself up after the node's walletcontext is cleaned up and that results in a wallet cleanup function callback accessing something that's already gone?
<achow101>
It's definitely segfaulting on the context.wallet_load_fns.erase(it) in HandleLoadWallet in src/wallet/wallet.cpp
<achow101>
and this function is called when SplashScreen's m_handler_load_wallet is being deleted when SplashScreen is deleted
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
<bitcoin-git>
[bitcoin] suhailsaqan opened pull request #25161: rpc: Put undocumented JSON failure mode behind a runtime flag (master...master) https://github.com/bitcoin/bitcoin/pull/25161
<luke-jr>
achow101: gotta run for a bit, but I reduced the revert to http://dpaste.com/HQBQY5FGH which "fixes" the crash
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
jarthur_ has quit [Quit: jarthur_]
bitdex has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
Zenton has quit [Ping timeout: 252 seconds]
brunoerg has quit [Remote host closed the connection]