<bitcoin-git>
[bitcoin] fanquake merged pull request #25090: doc: Explain Bitcoin Core instead of Bitcoin in README.md (master...2205-doc-intro-🥒) https://github.com/bitcoin/bitcoin/pull/25090
evanlinjin has quit [Ping timeout: 240 seconds]
bairen has quit [Remote host closed the connection]
sipsorcery has quit [Ping timeout: 248 seconds]
ronoaldo has quit [Quit: Konversation terminated!]
sipsorcery has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44_ has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
AaronvanW has joined #bitcoin-core-dev
<laanwj>
yes, that benchmark that absurdly long
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
mikehu44 has quit [Ping timeout: 256 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
nouni has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
djb27_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
djb27 has quit [Ping timeout: 240 seconds]
AaronvanW has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Saloframes has quit [Read error: Connection reset by peer]
Saloframes has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
nouni has quit [K-Lined]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<lightlike>
what's the reason the benchmarks are part of "make check" in the first place? They're great when comparing, e.g. PR with master, but what does running them all in isolation accomplish?
sudoforge has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guest81 has quit [Ping timeout: 252 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
evanlinjin has quit [Ping timeout: 240 seconds]
Saloframes has quit [Read error: Connection reset by peer]
<sipa>
@lightlike The fact that they run at all, and don't trigger runtime errors, perhaps?
<laanwj>
lightlike: it used to run the benchmarks with 1 cycle (very quickly) to do a sanity check as sipa says, i think at some point it got changed to just "run the benchmarks"
<laanwj>
which is pretty pointless as the output goes to /dev/null
<lightlike>
i see. I guess an alternative would be to make this a task run separately in the CI instead of "make check" - in that case, some longer-running benchmarks might be acceptable.
Kaizen_K_ has quit [Ping timeout: 260 seconds]
<jonatack>
there is also the --disable-bench configure flag
mudsip has joined #bitcoin-core-dev
mudsip has quit []
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
l2xl_ has joined #bitcoin-core-dev
l2xl has quit [Ping timeout: 248 seconds]
<laanwj>
i'd personally prefer restoring it to 'run one cycle', i think it's good to check that the bench doesn't crash but there's not reason to run the full benchmark
<laanwj>
yeah --disable-bench prevents the benchmark from being built
<sipa>
@laanwj Agree.
<sipa>
Doing more than 1 iteration doesn't add anything.
<laanwj>
looks like bench_bitcoin currently has no command line flag for that
Guest15 has joined #bitcoin-core-dev
<sipa>
there is one for setting a minimum runtime per test though; does setting that to 0 reduce runtime?
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<lightlike>
sipa: for me, min_time=0 reduces runtime only if each cycle is much faster than the default 10milliseconds (i.e. when the bench was already very fast to begin with), but not otherwise.
ronoaldo has joined #bitcoin-core-dev
Guest15 has quit [Quit: Client closed]
<laanwj>
-min_time=0 doesn't have a noticable effect here on runtime (both with and without is around 5m20)
furszy has joined #bitcoin-core-dev
furszy has quit [Remote host closed the connection]
furszy has joined #bitcoin-core-dev
<laanwj>
working on a patch to add an argument for one-iteration behavior
<laanwj>
wait, even with one iteration that benchmark seems to be slow
<laanwj>
still, 2m is better than 5m, will PR i
<bitcoin-git>
[bitcoin] laanwj opened pull request #25107: bench: Add `--one-iteration` flag, use it in `make check` (master...2022-05-bench-one-iteration) https://github.com/bitcoin/bitcoin/pull/25107
<bitcoin-git>
[bitcoin] fanquake opened pull request #25110: tidy: use modernize-use-raw-string-literal (master...modernize_use_raw_string_literal) https://github.com/bitcoin/bitcoin/pull/25110
kexkey has joined #bitcoin-core-dev
Victorsueca has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
kexkey has quit [Quit: kexkey]
kexkey has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
Aaronvan_ has joined #bitcoin-core-dev
kexkey has quit [Quit: kexkey]
kexkey has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 252 seconds]
lukedashjr is now known as luke-jr
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Talkless has quit [Quit: Konversation terminated!]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
___nick___ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
KolbyML78 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
hashfunc802 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<earnestly>
When bitcoind is used with -noconnect (don't intend to download blockchain) on a device with 40M of space, it tries to initialise databases and returns 'Error: Disk space is too low!' Is there either a way to tell bitcoind that no download is intended, or a documented amount of minimum space needed in this context?
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<sipa>
Earnestly: I don't think so. But why are you running bitcoin core in the first place then?
<earnestly>
offline machine
<earnestly>
(I.e. using it for a cold wallet)
kexkey has quit [Ping timeout: 246 seconds]
<sipa>
Yeah, that's fair. There really should be a utility binary that can do offline signing with all the features bitcoin core itself has.
<earnestly>
I don't mind providing the space, but I wasn't able to find it noted anywhere (I suppose the source code will tell me)
<sipa>
See CheckDiskSpace() in src/util/system.cpp
kexkey has joined #bitcoin-core-dev
<earnestly>
Thanks, // 50 MiB :D
<sipa>
bitcoin core is really intended to be able to connect to the network; if there are things it can do without, those should be moved (or at least made accessible) to utility binaries
<earnestly>
Yes I understand
<earnestly>
There's a few things going around, like multiprocess, which might be able to break it up in a way which helps towards that
<sipa>
I don't think multiprocess is related.
<earnestly>
Not directly I thought, but yeah, I'll add more space for the time being, thanks for narrowing it down for me
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Evel-Knievel has quit []
bairen has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
hashfunc802 has quit [Ping timeout: 260 seconds]
sipsorcery has quit [Ping timeout: 240 seconds]
sipsorcery has joined #bitcoin-core-dev
KolbyML has joined #bitcoin-core-dev
KolbyML78 has left #bitcoin-core-dev [#bitcoin-core-dev]
z9z0b3t1c has quit [Remote host closed the connection]
sipsorcery has quit [Ping timeout: 248 seconds]
Heston has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]