<bitcoin-git>
bitcoin/22.x 344537c Ryan Ofsky: qt: Avoid crash on startup if int specified in settings.json
<bitcoin-git>
bitcoin/22.x 04fdd64 laanwj: Merge bitcoin/bitcoin#25180: [22.x] qt: Avoid crash on startup if int spec...
<bitcoin-git>
[bitcoin] laanwj merged pull request #25180: [22.x] qt: Avoid crash on startup if int specified in settings.json (22.x...pr/setint22) https://github.com/bitcoin/bitcoin/pull/25180
yanmaani3 has quit [Remote host closed the connection]
yanmaani3 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 258 seconds]
<bitcoin-git>
bitcoin/master d4b3dc5 Hennadii Stepanov: contrib: Remove keys that are no longer used for merging
<bitcoin-git>
bitcoin/master b4f6869 laanwj: Merge bitcoin/bitcoin#25197: contrib: Remove keys that are no longer used ...
<bitcoin-git>
[bitcoin] laanwj merged pull request #25197: contrib: Remove keys that are no longer used for merging (master...220524-keys) https://github.com/bitcoin/bitcoin/pull/25197
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<jamesob>
witness-versioned transactions. Can someone remind me of the rationale?
<jamesob>
s/pubkeys/scriptPubKeys
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
<jamesob>
Oh... I guess future witness versions are ruled out later on in the AreInputsStandard(...) checks
<stick>
jamesob: why we wouldn’t want unupgraded nodes to relay them?
<stick>
this will cause splits in the network, no?
<stick>
(relay network)
<jamesob>
stick: if an unupgraded miner was relayed a future witness version that was actually an invalid spend (per the new rules) they could mine a block that would split the chain between upgraded and non-upgraded
<sipa>
jamesob: The policy for spends was later changed in #20165 (specific for taproot, but the general idea behind it would be applicable for other softforks too).
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
<TallTim>
Just a lowly full-node operator here (BTC), but I can tell you if we ever collectively go down the road supporting Miner Extractable Value, that is when I'll be looking to jump ship. Rubin is right about being cautious to avoid it.
vysn has quit [Ping timeout: 240 seconds]
<instagibbs>
TallTim, wrong channel for random FUD sorry
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<TallTim>
No fud, just a statement of truth. Pursuit of MEV results in me re-evaluating my involvement. Cheers.
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
<lightlike>
this is probably related to today's optech newsletter, so not entirely random, but still offtopic for this channel.
<TallTim>
True, a topic relating to discussion in this very channel is off-topic. My mistake. Thank you.
<sipa>
TallTim: This channel is about the development of the Bitcoin Core software, an implementation of the Bitcoin protocol. It is not the place to discuss the direction the Bitcoin protocol itself is going.
<TallTim>
Clarification then - did a meeting take place here regarding the topic?
<sipa>
No?
<TallTim>
Please indicate with yes/no.
<TallTim>
Then my source was too vague, my mistake.
<instagibbs>
there was a CTV meeting which is where optech picked up the discussion...
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
mudsip has joined #bitcoin-core-dev
Guest3 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guest3 has quit [Client Quit]
Zenton has quit [Ping timeout: 260 seconds]
mrlemke has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
furszy has quit [Remote host closed the connection]
mudsip has quit []
bitdex has quit [Ping timeout: 240 seconds]
Guest73 has joined #bitcoin-core-dev
geyaeb has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guest73 has quit [Quit: Ping timeout (120 seconds)]
vysn has quit [Ping timeout: 258 seconds]
evanlinjin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] furszy opened pull request #25213: fuzz: fix crash at coinselection, add missing fee rate. (master...2022_fuzz_solve_coinselection) https://github.com/bitcoin/bitcoin/pull/25213
furszy has joined #bitcoin-core-dev
Nekorand has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Nekorand has quit [Quit: Leaving]
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #25214: libmultiprocess build fix: ipc/capnp/init.capnp.h: No such file or directory (master...pr/mpdep) https://github.com/bitcoin/bitcoin/pull/25214
PaperSword has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
darosior has quit [Read error: Connection reset by peer]
darosior has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
furszy has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 258 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 258 seconds]
Kaizen_K_ has quit [Ping timeout: 255 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen___ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 258 seconds]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen___ has quit [Ping timeout: 255 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 255 seconds]
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Aaronvan_ has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
z9z0b3t1_ has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 244 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]
sipsorcery has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 258 seconds]
noonien has joined #bitcoin-core-dev
Guest65 has joined #bitcoin-core-dev
Guest65 has quit [Client Quit]
vysn has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
<dongcarl>
I might have asked this before but, in our fuzzing framework, we only call the initialize_* function once at the beginning then the FUZZ_TARGET_INIT multiple times, right?
kexkey has quit [Ping timeout: 255 seconds]
kexkey has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] jonatack opened pull request #25217: scripts and tools: update lint-logs.py with LogPrintLevel() (master...update-logs-linter-script-with-LogPrintLevel) https://github.com/bitcoin/bitcoin/pull/25217
<sipa>
dongcarl: FUZZ_TARGET_INIT is just a macro; it defines a fuzz function (the body following the macro) which gets run once for every fuzzer input, with an initializer whose name is the second argument to the macro.
<dongcarl>
sipa: But the initializer only gets run once right?
<sipa>
yes
<sipa>
and only if that fuzzer is actually selected (through the env FUZZ variable).
<dongcarl>
cool cool, thanks!
<bitcoin-git>
[bitcoin] furszy opened pull request #25218: wallet: introduce generic 'Result' classes and connect it to `CreateTransaction` and `GetNewDestination` (master...2022_generic_result) https://github.com/bitcoin/bitcoin/pull/25218
furszy has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] natanleung opened pull request #25219: test: deploymentinfo.cpp unit tests (master...deploymentinfo_unit_test) https://github.com/bitcoin/bitcoin/pull/25219
brunoerg has quit [Remote host closed the connection]
earnestly has quit [Read error: Connection reset by peer]
earnestly has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 244 seconds]
<dongcarl>
Hi folks, what happens when we do `EXCLUSIVE_LOCKS_REQUIRED(m_mempool->cs)` and m_mempool is nullptr? What about when we LOCK(m_mempool->cs) and m_mempool is nullptr?