2021-03-25

< jeremyrubin> Either can be compatible with a subsequent BIP8 release
< ariard> i've reviewed both, i've a preference for bip9-amendment, would review both anyway
< luke-jr> sipa: not sure why BIP350 would be eligible for backporting at all
< wumpus> #topic How far do we want to backport BIP350/bech32m support? (sipa)
< sipa> oh short topic: how far do we want to backport BIP350/bech32m support?

2021-03-23

< bitcoin-git> [bitcoin] luke-jr closed pull request #21460: BIP8: Minimal common changes (master...bip8_minimal) https://github.com/bitcoin/bitcoin/pull/21460

2021-03-22

< bitcoin-git> [bitcoin] achow101 opened pull request #21507: Implement BIP8 lockinontimeout (master...bip8) https://github.com/bitcoin/bitcoin/pull/21507

2021-03-18

< jeremyrubin> I don't think "BIP9 is dead" is useful here

2021-03-17

< bitcoin-git> [bitcoin] luke-jr opened pull request #21460: BIP8: Minimal common changes (master...bip8_minimal) https://github.com/bitcoin/bitcoin/pull/21460

2021-03-09

< sipa> amiti: i think that's fair... i also don't really know what the issue would be with a sendaddrtypes message with a bitvector of bip155 network types for example (apart from not wanting to deal with that too right now)
< sipa> aj: i think ariard is trying to point out that bip37/bip60 only talk about *announcing* transactions, not sending (possibly unannounced) transactions
< ariard> aj: right but imo current bip60 semantic isn't clear with what the sender is allowed to do
< sipa> if you're going by reading the spec by the letter... what does bip60"s fRelay flag even mean for a client that chooses not.to implement bip37?
< aj> ariard: I run a -blocksonly node. You run a bip60 compliant node. I tell you fRelay=false. You don't send me any txes. You told me fRelay=true. Therefore I can send you a tx, without violating bip60.
< ariard> aj: my point was bip37 original scope was unclear if it concerns only inv(tx) or any tx-related message, bip338 has the merit to clarify
< bitcoin-git> [bitcoin] luke-jr opened pull request #21399: Genericide BIP9 in variable/type names and comments (master...vbits_rename) https://github.com/bitcoin/bitcoin/pull/21399

2021-03-08

< bitcoin-git> [bitcoin] achow101 opened pull request #21392: Implement BIP 8 based Speedy Trial activation (master...bip8-speedy-trial) https://github.com/bitcoin/bitcoin/pull/21392

2021-03-07

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21334: test: Additional (refactored) BIP9 tests (master...2021/03/bip9_tests) https://github.com/bitcoin/bitcoin/pull/21334
< bitcoin-git> bitcoin/master 1020b04 MarcoFalke: Merge #21334: test: Additional (refactored) BIP9 tests

2021-03-06

< bitcoin-git> [bitcoin] ajtowns opened pull request #21377: Speedy trial support for versionbits (master...202103-bip9-speedy-trial-support) https://github.com/bitcoin/bitcoin/pull/21377

2021-03-04

< achow101> andytoshi: I've pushed the updated tests to my bips pr too
< andytoshi> achow101: in BIP174, the test vector "PSBT with unknown types in the inputs" describes an input which has keytype 0x0f and key 0102030405060708. this is a valid PSBT
< sipa> so i guess we could list BIP60 as implemented, actually
< MarcoFalke> Bitcoin Core implements BIP60, but doesn't require peers to implement it. (Like any other optional BIP)
< ariard> even the original bip37 is really unclear if fRelay semantic is to disable tx-relay or just tx-announcement
< sdaftuar> sipa: but we're compatible with bip60 peers, and i think we now expect our peers to always read our fRelay flag if its' set to false, right?
< luke-jr> it doesn't require breakign non-BIP60 peers
< sipa> luke-jr: BIP60 is about predictably-sized version messages, not just the fRelay flag
< ariard> MarcoFalke: i mean here https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md, for a dev writing another bitcoin client and trying to understand core behavior
< sipa> we don't support bip60 and never have
< ariard> fwiw, core doesn't even commit to bip60 as a supported bip
< MarcoFalke> so replace BIP338 with a breaking p2p change and blocksonly meaning "feefilter=max"?
< sdaftuar> MarcoFalke: well my guess is that bip37/bip60 is more widely supported on the network. feefilter has always been optional
< jnewbery> MarcoFalke: BIP60 is version 70002. feefilter is version 70013.

2021-03-02

< bitcoin-git> [bitcoin] Sjors opened pull request #21334: Additional (refactored) BIP9 tests (master...2021/03/bip9_tests) https://github.com/bitcoin/bitcoin/pull/21334

2021-02-28

< sipa> it'd probably not be a bad idea to have bip32 derivation in the test framework

2021-02-26

< michaelfolkson> "I like a hidden option in Core which is always there from day one, which is lot=true or taproot-bip8-lot-true or something that would change lockinontimeout to true and also change the default user agent string so you can tell people are running it. That’s good because by the time 6 months comes almost everyone has upgraded anyway, they’ve just got to change their config." (From the Sydney Socratic)
< sipa> you may mean bip147
< sipa_> bip62 is not consensus
< shesek> (NULLDUMMY being validness rather than standardness as of bip62)

2021-02-22

< bitcoin-git> [gui] MarcoFalke merged pull request #206: Display fRelayTxes and bip152_highbandwidth_{to, from} in peer details (master...add-fields-to-peer-details) https://github.com/bitcoin-core/gui/pull/206

2021-02-20

< wumpus> i think what i need is a way to generate a *derived xpub* for a custom path in the wallet, i can do this with external tooling (e.g. darosior's bip32 python module), but afaik not from bitcoin core itself?

2021-02-17

< jb55> I don't even think recommending bip39 support to 'newbies' would be a good idea. ideally there would be an easy way to connect a hardware wallet and get descriptors that way vs bip39 on your computer
< sipa> there are a few things that can be worked on towards supporting that, like descriptor export, getting descriptor wallets in general less experimental, and things like bip39 support in descriptors directly
< sipa> there is an issue for BIP39 support in descriptors somewhere

2021-02-13

< bitcoin-git> bitcoin/master b08cbd0 Wladimir J. van der Laan: Merge #21028: doc/bips: Add BIPs 43, 44, 49, and 84
< bitcoin-git> bitcoin/master c943326 Luke Dashjr: doc/bips: Add BIPs 43, 44, 49, and 84
< bitcoin-git> [bitcoin] laanwj merged pull request #21028: doc/bips: Add BIPs 43, 44, 49, and 84 (master...bips_44-49-84) https://github.com/bitcoin/bitcoin/pull/21028

2021-02-12

< sipa> well, because multi doesn't exist in bip342 (no OP_CHECKMULTISIG due to not batch verifiable)

2021-02-10

< bitcoin-git> [bitcoin] danben opened pull request #21144: test: convert feature_bip_sequence.py to use MiniWallet (master...test-feature-bip68-sequence-without-wallet) https://github.com/bitcoin/bitcoin/pull/21144

2021-02-09

< bioverse> I have a nano ledger s with some bitcoin. I have the 24 words and wallet in a safe place. I went to https://iancoleman.io/bip39/ using a Ubuntu live from USB. I put the 24 mnemonic words and could not find any bitcoin address ever used. I freaked. I thought. Oh my god! I ordered a second brand new nano ledger s. Put the 24 words, using ledger live in a brand new laptop and my coins were there in the brand new ledger nano s. I am safe. But I have

2021-02-05

< bitcoin-git> bitcoin/master e1e6714 Jon Atack: doc: refer to BIPs 339/155 in feature negotiation
< bitcoin-git> bitcoin/master 3931732 Wladimir J. van der Laan: Merge #20646: doc: refer to BIPs 339/155 in feature negotiation
< bitcoin-git> [bitcoin] laanwj merged pull request #20646: doc: refer to BIPs 339/155 in feature negotiation (master...signet-keep-post-verack-sendaddrv2-peers) https://github.com/bitcoin/bitcoin/pull/20646
< bitcoin-git> [bitcoin] jonatack reopened pull request #20646: doc: refer to BIPs 339/155 in feature negotiation (master...signet-keep-post-verack-sendaddrv2-peers) https://github.com/bitcoin/bitcoin/pull/20646
< bitcoin-git> [bitcoin] jonatack closed pull request #20646: doc: refer to BIPs 339/155 in feature negotiation (master...signet-keep-post-verack-sendaddrv2-peers) https://github.com/bitcoin/bitcoin/pull/20646
< dr_orlovsky> so BIP43-type new purpose value for P2TR will be a good solution in this respect as well?
< sipa> i guess that means this whole point is moot, and we should probably have a deep look at proving security of ECDSA and Schnorr signatures of linearly related keys (as those created by P2C-tweaking or BIP32 derivation result)
< sipa> yeah, you'll probably want a separate bip32 path for P2TR outputs; but that has nothing to do with ECDSA/Schnorr; you just don't want to reuse the same keys
< sipa> i don't know if that needs a standard like BIP43 - perhaps it helps

2021-02-04

< aj> sdaftuar: maybe you should game the system and post your bips on stackoverflow?
< jonatack> jonasschnelli: ok. i thought it might be the blocker for bip324 impl

2021-02-03

< luke-jr> sdaftuar: yeah, I'll get to BIPs later today

2021-02-01

< bitcoin-git> [gui] jonatack opened pull request #206: Display fRelayTxes and bip152_highbandwidth_{to, from} in peer details (master...add-fields-to-peer-details) https://github.com/bitcoin-core/gui/pull/206

2021-01-29

< bitcoin-git> [bitcoin] luke-jr opened pull request #21028: doc/bips: Add BIPs 44, 49, and 84 (master...bips_44-49-84) https://github.com/bitcoin/bitcoin/pull/21028

2021-01-28

< sipa> luke-jr: can i have a BIP number for bip-bech32m? (there are a few other things in the bips repo that want your attention too, i think)

2021-01-25

< bitcoin-git> [bitcoin] achow101 closed pull request #16463: [BIP 174] Implement serialization support for GLOBAL_XPUB field. (master...bip174-xpub) https://github.com/bitcoin/bitcoin/pull/16463

2021-01-21

< nickler> luke-jr: what are the relevant PRs and issues? The two from aj to the BIP8 and your #19573?
< sdaftuar> sipa: whether bips are the right place or not is unclear to me, but i think communicating relay policies like this so that 3rd party wallets know what behavior to aim for is helpful. in the case of bip125, my hesitation towards amending or redrafting is that we should fix the implementation in other ways anyway
< sipa> if there really is a discrepancy between bip125 and what bitcoin core implements, it could be mentioned in doc/bips.md
< sipa> i don't think these things belong in BIPs

2021-01-20

< pinheadmz> is BIP125 (RBF) accurate with the implementation? Specifically, is it the absolute fees that are compared between replaces and replacing tx? or the fee rate?

2021-01-12

< sipa> BIP141 defines witness script
< jeremyrubin> I think where I got confused is (non-core, going to move convo to appropriate channel) https://docs.rs/bitcoin/0.25.2/bitcoin/util/bip143/struct.SigHashCache.html#method.signature_hash requires a scriptcode field
< sdaftuar> sipa: my understanding as well that there are no BIPs on it
< sipa> i don't think it's unreasonable to recommend not relaying addresses to disabletx peers; so far addr relay is completely local policy anyway with no BIPs discussing it at all afaik
< jnewbery> sdaftuar: do you have any further thoughts about what a future addr relay negotiation method would look like? I know you were pushing for something similar with BIP155
< sdaftuar> but to do all that, we need to give nodes a way to know that an inbound peer is a block-relay-only peer. currently block-relay-only peers use the fRelay flag from BIP37 to instruct their peer they don't want transactions
< sdaftuar> but BIP37 allows for transaction relay to resume with a FILTERCLEAR message

2021-01-10

< luke-jr> bips.md?
< sipa> sdaftuar_: also added a mention of BIP339 in the release notes

2021-01-04

< vasild> but I failed to verify the callers of the constructor CSubNet(CNetAddr&) which used to create one-host-subnet before and would also "work" for torv2 addresses (in the code before bip155) by matching a single address
< vasild> jonatack: when I extended CNetAddr to support longer-than-16-bytes addresses (as part of bip155) I also changed CSubNet to only handle ipv4 and ipv6 addresses - because it contains char netmask[16]; it makes no sense to apply it to e.g. 32 byte torv3 address

2020-12-29

< bitcoin-git> [bitcoin] kallewoof closed pull request #20154: BIP-322 support (master...202010-bip322) https://github.com/bitcoin/bitcoin/pull/20154

2020-12-24

< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20189: test: Switch to BIP341's suggested scheme for outputs without script (master...202010_taproot_std_noscript) https://github.com/bitcoin/bitcoin/pull/20189
< bitcoin-git> bitcoin/master 812baaa Pieter Wuille: Switch to BIP341's suggested scheme for outputs without script
< bitcoin-git> bitcoin/master cc592a8 MarcoFalke: Merge #20189: test: Switch to BIP341's suggested scheme for outputs withou...

2020-12-16

< jnewbery> If you consider BIP37 and optional standard, then it's not really a violation of the protocol to send tx INVs after receiving a version with fRelay = false
< vasild> eventually, maybe we would update bip155 to mandate the i2p addr size is allowed to be either 32 or 35 bytes

2020-12-14

< bitcoin-git> bitcoin/master 096bd37 MarcoFalke: Merge #20592: doc: update wtxidrelay documentation per BIP339
< bitcoin-git> bitcoin/master 4b7b58b Jon Atack: Update net_processing WTXID documentation per BIP339
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20592: doc: update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592

2020-12-11

< wumpus> this is the best reference of course: https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki

2020-12-10

< sipa> i missed that push too; i just found it funny due to name confusion with BIP9's versionbits
< bitcoin-git> bitcoin/master dab6583 Sebastian Falbesoner: doc: release note for new getpeerinfo fields "bip152_hb_{from,to}"

2020-12-08

< vasild> jnewbery: I am ok with you doing the announcement wrt bip155 change

2020-12-07

< bitcoin-git> [bitcoin] jonatack opened pull request #20592: p2p: update wtxidrelay documentation per BIP339 (master...update-wtxid-documentation-per-BIP339) https://github.com/bitcoin/bitcoin/pull/20592
< vasild> updated https://github.com/bitcoin/bips/pull/1043 - "send sendaddrv2 berfore sending verack"
< vasild> sipa: wumpus: wrt sending sendaddrv2 and the difference between the code and the BIP, I opened https://github.com/bitcoin/bips/pull/1043 to change the BIP.

2020-12-05

< pinheadmz> re: coordination though - BIPs are good places to pick service bits, etc at the community level - thats not really "bitcoin core deciding:
< pinheadmz> i see yeah reading up the chatter on bip155 PR as well...

2020-12-04

< wumpus> e.g. https://github.com/bitcoin/bips/pull/766 had some of the most fruitful discussion
< wumpus> ... even less interest and we might as well puglish BIPs directly into the arctic code vault
< jonasschnelli> It might lead to more reluctant testing and lesser interest to read BIPs more carefully
< jonasschnelli> <wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). [...]
< wumpus> but it's too frustrating for me personally and I don't think I'll be working on BIPs again
< wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). It was discussed in

2020-12-03

< luke-jr> until we switch to BIP324
< luke-jr> (we can just add new features only within the context of BIP324)
< luke-jr> as long as we ensure they can't continue their silliness into BIP324, at least it has an end date?
< jonasschnelli> BIP324 is probably different since we want to get disconnected when the handshake is not supported
< jonasschnelli> Its not even messages in BIP324,.. its the handshake that is headerless
< * sipa> points at BIP324
< luke-jr> IANA and BIPs aren't that different
< luke-jr> sdaftuar: we also have no authority to impose BIP155 on them anyway
< sdaftuar> i am not sure an updated version of bip155 was ever sent to the mailing list describing that the version bump was being dropped. so it's hard to blame them, imo, other than for a long-running misunderstanding of how we think unknown messaegs should be treated
< sdaftuar> what's the status of sendaddrv2/bip155, there was a report that it caused other peers to disconnect us i think?

2020-12-01

< jnewbery> vasild: your suggested change to BIP155 isn't what Bitcoin Core is doing. It sends the message after receiving a version message
< vasild> maybe bip155 should be corrected: "sendaddrv2 SHOULD be sent after receiving the verack message" s/receiving/sending/
< sipa> i'm happy we got bip154 in 0.21, but this isn't the time to change it anymore...
< sipa> *bip155
< jnewbery> in BIP 155, it says "sendaddrv2 SHOULD be sent after receiving the verack message from the peer": https://github.com/bitcoin/bips/blob/7e3284dafda168da34888977dbf4a55519b0c54d/bip-0155.mediawiki#L137

2020-11-19

< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub

2020-11-17

< jonatack> troygiorshev: thank you, i meant BIP324 :)
< troygiorshev> I'm also paying attention to BIP324 #18242
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub

2020-11-16

< bitcoin-git> [bitcoin] mateusz-klatt closed pull request #20361: Descriptor Wallets BIP39 recovery (master...master) https://github.com/bitcoin/bitcoin/pull/20361

2020-11-12

< jonatack> michaelfolkson: when reviewing, sometimes running them for less than a minute finds things, e.g. was the case for the BIP324 implementation
< jonasschnelli> warren: BIP324
< warren> jonasschnelli: btw whatever happened to BIP150/151. Looking at BIPs now I don't see a replacement that supersedes them?

2020-11-10

< bitcoin-git> [bitcoin] mateusz-klatt opened pull request #20361: load wallets from entropy (as BIP39) (master...master) https://github.com/bitcoin/bitcoin/pull/20361

2020-11-04

< S3RK> question about fuzzing. we use regtest chain params, but in corups for src/test/fuzz/descriptor_parse.cpp I see xprv keys. As a result fuzzing don't cover code paths with valid keys for bip32 decriptors. I tried to add initial seeds with tprv, but fuzzer doesn't detect any new edges covered. What do I miss?

2020-11-03

< jonasschnelli> I haven't seen BIP324 discussion about the missing backward secrecy of the current rekeying approach.
< sipa> as long as we don't worry about secrecy in the other direction (which the current bip324 writeup doesn't, afaik), i think this is very much preferable
< jonasschnelli> I wanted to ask about BIP324's rekeying
< gribble> https://github.com/bitcoin/bitcoin/issues/20119 | BIP155 follow-ups by sipa · Pull Request #20119 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | Complete the BIP155 implementation and upgrade to TORv3 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | Complete the BIP155 implementation and upgrade to TORv3 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< S3RK> question about fuzzing. we use regtest chain params, but in corups for src/test/fuzz/descriptor_parse.cpp I see xprv keys. As a result fuzzing don't cover code paths with valid keys for bip32 decriptors. I tried to add initial seeds with tprv, but fuzzer doesn't detect any new edges covered. What do I miss?

2020-11-01

< brianddk> Why does everything in bitcoin use double hash (HASH256) except BIP141 (P2WSH): https://www.reddit.com/r/Bitcoin/comments/jm9s2z/

2020-10-27

< sipa> bip322 proves the ability to spend coins sent to a particular bitcoin address; a lightning equivalent sounds like it would need a lightning-specific solution

2020-10-19

< bitcoin-git> [bitcoin] sipa opened pull request #20189: Switch to BIP341's suggested scheme for outputs without script (master...202010_taproot_std_noscript) https://github.com/bitcoin/bitcoin/pull/20189

2020-10-16

< bitcoin-git> bitcoin/master 5669642 Pieter Wuille: docs: mention BIPs 340-342 in doc/bips.md

2020-10-15

< sipa> there is one context where we actually treat someone with a private key as an attacker in BIP340, and it's a rather unusual requirement: nobody (even those with private keys) should be able to construct a signature for which the single-sig validation and batch-validation algorithm produce a different result (with more than negligible probability)
< phantomcircuit> sipa, yeah i understand now, i was confused by the bip340 language about malleability
< sipa> phantomcircuit: to be clear, the bip340 signing algorithm is deterministic if no auxiliary randomness is used
< bitcoin-git> [bitcoin] kallewoof opened pull request #20154: BIP-322 support (master...202010-bip322) https://github.com/bitcoin/bitcoin/pull/20154

2020-10-14

< sipa> it's undergoing heavy changes right now: https://github.com/bitcoin/bips/pull/1003
< andytoshi> generic signed message format, by kalle, https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki
< andytoshi> has anyone here implemented BIP322? i am working on an implementation and have some questions about the bip

2020-10-12

< bitcoin-git> [bitcoin] fanquake merged pull request #20119: BIP155 follow-ups (master...202010_bip155_followup) https://github.com/bitcoin/bitcoin/pull/20119
< bitcoin-git> bitcoin/master af22322 fanquake: Merge #20119: BIP155 follow-ups
< bitcoin-git> bitcoin/master 79f3d9b Pieter Wuille: Mention BIP155 in doc/bips.md

2020-10-11

< ja> luke-jr: when would an ack be necessary for marking 'obsolete'? i thought it would be analogous to 'final' which you seem to wait for an explicit ack for here: https://github.com/bitcoin/bips/pull/926
< ja> wooow, i got an ack from Gavin! https://github.com/bitcoin/bips/pull/1010
< sipa> Peer services BIPs should be observed to be adopted by at least 1% of public listening nodes for one month.
< vasild> https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki "Status: Draft" -- should the status be changed?
< gribble> https://github.com/bitcoin/bitcoin/issues/19954 | Complete the BIP155 implementation and upgrade to TORv3 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #20119: BIP155 follow-ups (master...202010_bip155_followup) https://github.com/bitcoin/bitcoin/pull/20119
< bitcoin-git> [bitcoin] fanquake merged pull request #19954: Complete the BIP155 implementation and upgrade to TORv3 (master...torv3) https://github.com/bitcoin/bitcoin/pull/19954

2020-10-10

< ariard> vasild: I'm still not understanding how a BIP155 node is supposed to discover the list of network IDs supported by its BIP155-peers ?

2020-10-09

< sipa> (and the usage in bip152 is restricted to 16-bit numbers, which obviously won't have any problems)

2020-10-08

< sipa> i guess we overlooked that in bip152, where it's also not used as a size, but restricted to pretty small numbers
< sipa> it is as BIP42 predicted
< jonatack> to summarize, if I may: before feature freeze in one week, please review 19953 (BIPs 340-342), 19954 (tor v3), 19988 (tx relay logic), and 19077 (sqlite wallet)

2020-10-03

< bitcoin-git> [bitcoin] robot-dreams opened pull request #20074: test: p2p_blockfilters tests for BIP157 config args (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/20074
< wumpus> the higher level question would be 'should AddrMan be entirely disabled in some cases', we had some related discussion wrt. that for BIP155 for making it possible for nodes to signal that they don't take part in address gossip

2020-10-02

< bitcoin-git> [bitcoin] jonatack closed pull request #19720: test: bip157 p2p_blockfilters configuration options (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/19720

2020-10-01

< aj> luke-jr: ping re bips PRs 978 and 1000

2020-09-29

< bitcoin-git> [bitcoin] vasild closed pull request #19031: Implement ADDRv2 support (part of BIP155) (master...addrv2) https://github.com/bitcoin/bitcoin/pull/19031

2020-09-27

< hebasto> why bip155 appendix B does not specify that H() is actually SHA3_256 ?

2020-09-23

< vasild> luke-jr: https://github.com/bitcoin/bips/pull/907 can be merged? It has 4 ACKs, including from the BIP author (wumpus).

2020-09-22

< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< jnewbery> I don't think p2p policy belongs in BIPs. https://github.com/bitcoin-core/bitcoin-devwiki/wiki seems like a more appropriate place for it
< sdaftuar> jnewbery: thanks i was just going to say that it's not clear to me that BIPs are the right place either

2020-09-20

2020-09-17

< sipa> wumpus: also, ack bip155 changes, as those need to be stable before 0.21 if we want it :)
< vasild> I agree it is out of scope, but I also think "I participate in gossip" is out of scope for bip155, if we consider that its purpose is to support larger than 16 byte addresses
< wumpus> things like that were proposed before, though never in the for of a BIP afaik, but I think that's out of scope of BIP155

2020-09-16

< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< vasild> Wrt the next bip155/torv3 PR, assuming #19845 gets merged - #19031 has two more commits "net: CAddress & CAddrMan: (un)serialize as ADDRv2" (+193/-15) and "net: advertise support for ADDRv2 via new message" (+129/-8). Then we will have done BIP155 - will gossip torv3/i2p/cjdns addresses if we receive them (even though we may not be able to make use of them yet). After that we need one more change
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< midnight> luke-jr: After what's merged, BIP155?
< sipa> won't be useful until they can be rumoured using BIP155

2020-09-14

< bitcoin-git> bitcoin/master ba4b3fb fanquake: Merge #19944: Update secp256k1 subtree (including BIP340 support)
< bitcoin-git> [bitcoin] fanquake merged pull request #19944: Update secp256k1 subtree (including BIP340 support) (master...202009_secp256k1_schnorr) https://github.com/bitcoin/bitcoin/pull/19944

2020-09-11

< sipa> i wonder how much of a bandwidth savings BIP155 will be
< wumpus> phantomcircuit: that's not relevant here, we don't do DNS lookups for bitcoin nodes, and in any case, how a DNS returns is separate from how they're gossiped (which is all that BIP155 is about)
< sipa> (that was the motivation for BIP155 in the first place)
< bitcoin-git> [bitcoin] sipa opened pull request #19944: Update secp256k1 subtree (including BIP340 support) (master...202009_secp256k1_schnorr) https://github.com/bitcoin/bitcoin/pull/19944
< vasild> Which piece of BIP155 looks like (a)?
< sipa> BIP155 makes it sound like (a), at least for TORv2
< sipa> vasild: the way i see it, the P2P is just lagging behind a bit due to no BIP155, but we can easily circumvent that now ;)
< sipa> BIP155 supports up to 512 bytes addresses, but clients will ignore unknown networks/lengths

2020-09-09

< ariard> jonasschnelli: just replied on bip324, AFAICT real-or-random and I favor MACing the length a la noise, even if as Lloyd is pointing we don't a concrete exploitation of it

2020-09-08

< yanmaani> I know, but is there any research being done? Like on BIPs or stuff? I know about utreexo
< sipa> though they were an essential part of BIP37
< sipa> aj: i have a branch where it's half done, but i got preempted by bip340/taproot stuff
< jonatack> quick reminder to review the bip155 and bip324 implementation PRs
< jonasschnelli> sipa, elichai2, real_or_random: what are your thoughts on the BIP342 comment here: https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52#gistcomment-3345400

2020-09-03

< vasild> Maybe a) can be sneaked into BIP155 as a boolean flag to sendaddrv2 and b) done outside of BIP155 via a service bit?
< vasild> I have been wondering if those two deserve a separate BIP or should be sneaked into BIP155

2020-08-31

< gmaxwell> https://github.com/bitcoin-core/secp256k1/pull/558 looks ready-ish to merge, so if anyone wanted to review ack this updated version that reflects the latest BIP340 changes (even R), it's time!

2020-08-28

< gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub
< sipa> kallewoof: fwiw, the powLimit in the signet PR doesn't exactly match the difficulty as specified in BIP325 (the digits after 00002adc28 should be zeroes)

2020-08-27

< sipa> right, this is not about computing our onion address, but to convert between the bip155 encoding and onion addresses
< vasild> https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki#Appendix_B_Tor_v3_address_encoding -- I guess another option would be to send PUBKEY+CHECKSUM instead of just PUBKEY and never calculate the checksum, if adding sha3-256 would be undesirable

2020-08-26

2020-08-25

< vasild> sdaftuar: I like to think that BIP155 addrv2 is just an implementation at this point (no design decisions to be made). However there are two PRs that are yet to be merged into BIP155: https://github.com/bitcoin/bips/pull/907 and https://github.com/bitcoin/bips/pull/967.
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< jonatack> I think BIP155 addrv2 is a priority, according to vasild the next steps should be smaller and easier
< ariard> sipa: what was llfourn main proposal of change for bip324? He didn't propose to MAC the length field, so no BIP change
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< jonatack> BIP324 v2 p2p encrypted message transport protocol: right after the last p2p meeting, jonasschnelli rebased and updated #18242 (changes only used in tests for now) and I've begun re-reviewing it along with the BIP, which has some open questions.
< jonatack> BIP325 signet: #18267 has been through a few more rounds of review and seems to be getting close, with recent review by fjahr, pinheadz, MarcoFalke, instagibbs, and myself
< jonatack> BIP155 addrv2: #19628 has been receiving review from sipa, elichai, ryanofsky, kallewoof, sipsorceryand myself, and now has 4 ACKs; vasild is deferring further (minor) changes to the PR in order to preserve existing review, but there's no reason to not review it
< jonatack> My prios were BIP155, BIP324, and BIP325 implementation PRs, and they seem to be moving forward.

2020-08-20

< theStack> https://github.com/bitcoin/bips/blob/master/bip-0152/protocol-flow.png <- it seems like the right case (C) works without the "sendcmpct(0)" as well

2020-08-19

< jonatack> review beg also for #19628 needed for BIP155 addrv2

2020-08-14

< bitcoin-git> [bitcoin] jonatack opened pull request #19720: test: bip157 p2p_blockfilters configuration options (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/19720
< bitcoin-git> bitcoin/master dca2863 Jon Atack: test: ensure OP_1NEGATE satisfies BIP62 minimal push rule

2020-08-12

< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub

2020-08-11

< vasild> jonatack: troygiorshev: yes, the BIP155 sendaddrv2 can come any time, but we try to do it early so that when the peer is about to advertise his own address to us, he has the option to send us addrv2 - would be important if his address is torv3 because he wouldn't be able to advertise it to us with addr(v1)
< vasild> https://github.com/sdaftuar/bips/blob/2020-08-generalized-feature-negotiation/bip-p2p-feature-negotiation.mediawiki -- something like that came to my mind when doing the BIP155 sendaddrv2 message. Is every new feature going to add its own message sendfoowhatever? Not very nice.
< ariard> sdaftuar: I think that's good it was unclear between matt and I on bip339 implemn in rust-bitcoin about why 339 bumps both protocol version and wtxid-relay
< jonatack> vasild: i think it's fine to define one's own list of important PRs to review. e.g. longer term for me would be: BIP155/addrv2, BIP324, BIPs340-342, BIP325
< vasild> my priority is to get BIP155 / addrv2 https://github.com/bitcoin/bitcoin/pull/19031 merged.
< sipa> i'm also interested in helping with bip324 efforts and addrv2, though i haven't found much time for that
< gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
< dongcarl> jonatack: do you have link to bip324 discussion?
< jonatack> i was then asked by a few devs to consider picking up bip324 implementation

2020-08-06

< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub

2020-08-03

< sipa> warren: BIP324 will replace BIP151
< warren> jonasschnelli: hey. Curious whatever happened to BIP150 and 151. Did that end up getting rolled into a replacement BIP?

2020-07-31

< bitcoin-git> bitcoin/master d362f19 Pieter Wuille: doc: list support for BIP 339 in doc/bips.md

2020-07-29

< sipa> the only exceptions are (1) segwit, which introduced a p2p change along with a consensus change and (2) bip133 feefilter

2020-07-27

< vasild> but I gather "varint" in BIPs may be used to denote what the source code calls compactsize
< vasild> both varint and compactsize are mentioned in some BIPs
< vasild> jonasschnelli: luke-jr: sipa: wumpus: what do you think, (s/VARINT/CompactSize/ in BIP155)?
< vasild> Anyway, given that compact size is used in p2p and not varint, I suggest that we change the spec to say "compactsize" instead of "varint" with some clarification like "For the purposes of this section, CompactSize refers to the variable-length integer encoding used acros..." (from bip152) and also change the code to use compactsize instead of varint (the code is in
< vasild> and "compactsize" is mentioned in 6 BIPs
< vasild> s/8 occurrences/mentioned in 8 BIPs/
< sipa> for BIP152 there was initially an intention to use varint, but it was changed to compactsize to simplify specification
< vasild> Or, well, if in other specs the word "VARINT" is used to mean "compactsize", then should the BIP155 C++ source code use compactsize?
< vasild> Ok, so neither one of varint or compactsize is defined in BIPs, but compact size is already used in other places in the p2p protocol whereas varint is not.
< vasild> BIP155 says:
< sipa> vasild: not in any BIPs afaik; things that existed in the protocol before the BIPs process existed as generally just taken as gospel
< vasild> sipa: I need varint in order to be able to create and parse addrv2 messages: https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki "time" and "services" use VARINT

2020-07-23

< bitcoin-git> [bitcoin] luke-jr opened pull request #19573: [WIP] Replace unused BIP 9 logic with BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573

2020-07-17

< achow101> 2020-06-19.log:16:10 < bsm117532> #proposedwalletmeetingtopic descriptor specification for watch-only wallets, and repeated payments without address use via BIP32 paths

2020-07-12

< bitcoin-git> [bitcoin] jonatack closed pull request #19436: test: ensure `OP_1NEGATE` satisfies BIP62 (master...test-OP_1NEGATE-and-use-OP_RIGHT) https://github.com/bitcoin/bitcoin/pull/19436

2020-07-01

< bitcoin-git> [bitcoin] laanwj merged pull request #19257: build: remove BIP70 configure option (master...remove_bip70_configure) https://github.com/bitcoin/bitcoin/pull/19257
< bitcoin-git> bitcoin/master 9d92ee1 Wladimir J. van der Laan: Merge #19257: build: remove BIP70 configure option
< bitcoin-git> bitcoin/master c4ffcf0 fanquake: build: remove BIP70 configure option

2020-06-25

2020-06-24

< sipa> descriptor checksums have a range of 2^40, so somewhat better than bip32 fingerprints (which are only 2^32)
< shesek> would it make sense to invent one? this could also use a `/` separator like bip32 key origins, though a different character might be better because this doesn't have multiple levels of nesting like key origins
< sipa> (i kind of think that using fingerprints for bip32 was a bad idea too... they're too small to guarantee no collisions)
< shesek> is there a customary notation for referring to the nth script of a descriptor identified by its checksum, akin to <bip32-fingerprint>/<index>?

2020-06-19

< bsm117532> #proposedwalletmeetingtopic descriptor specification for watch-only wallets, and repeated payments without address use via BIP32 paths

2020-06-16

< wumpus> but all new repositories are created under bitcoin-core, at some point, if enough things split off from the main codebase, at some point maybe only the consensus code (and bips) will be left under bitcoin

2020-06-12

< jamesob> This issue of the message handling thread being potentially blocked by indexing (BIP157/158) that jnewbery raised is disconcerting, and separating out the indexing stuff seems more or less in line with the spirit of the process separation work.
< bitcoin-git> [bitcoin] fanquake opened pull request #19257: build: remove BIP70 configure option (master...remove_bip70_configure) https://github.com/bitcoin/bitcoin/pull/19257

2020-06-10

< shesek> is there a customary notation for referring to the nth script of a descriptor identified by its checksum? something like <checksum>/<index>, akin to <bip32-fingerprint>/<index>?

2020-06-04

< sipa> it's fixed (and referenced) in BIP341
< real_or_random> we (the BIPauthors) feel it's in a good state, I think otherwise sipa wouldn't bring this up
< elichai2> I think the big "political" question in terms of merging is if anyone believes that BIP340 doesn't have a good chance of landing in bitcoin core
< nickler> Afaik we've addressed all comments on the BIPS on the mailing list in some form of another
< elichai2> I'd like to review the new keypair direction but I do hope that BIP340 will actually end up in bitcoin in the end so I think it's ok to move toward merging schnorr to libsecp
< sipa> so with the prospect of having BIP340-342 one day merged, there will need to be a time to merge BIP340 support in libsecp256k1
< sipa> shower thought: are pcap files easy? if so, maybe it's useful post-BIP324 to permit dumping the decrypted stream in pcap format
< MarcoFalke> For logging, one could disable bip324
< jonasschnelli> would ne no longer fun for post BIP324 connections
< troygiorshev> i'm personally a huge fan of BIP324 and AltNet and related, so I'

2020-06-02

< sipa> with a million keys the bip158 filter won't help
< sipa> phantomcircuit: i think bip158 was designed for much smaller sets of keys, yes
< achow101> i'm gonna need to brush up on bip158 first
< phantomcircuit> "Empirical analysis also shows that was chosen as these parameters minimize the bandwidth utilized, considering both the expected number of blocks downloaded due to false positives and the size of the filters themselves." - BIP158
< gribble> https://github.com/bitcoin/bitcoin/issues/15845 | wallet: Fast rescan with BIP157 block filters by MarcoFalke · Pull Request #15845 · bitcoin/bitcoin · GitHub
< aj> yeah, i was thinking of making it so bip35 wouldn't let you see stuff that hadn't made it into the bloom filter, but seems too complicated, esp if we think bip35 is only for trusted-ish peers
< sipa> you have to explicitly enable bip37, or whitelist the peer
< aj> sipa: why not do bip35 via bloom as well?
< sipa> aj: so WDYT about relay pool 2 minutes, bloom filter per peer for last (whatever can be relayed in 2 minutes) transactions, things can be requested if they're in the bloom filter OR in mempool and older than 2 minutes OR older than the last BIP35 response; BIP35 responses don't go into the bloom filter

2020-05-29

< gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
< sipa> it's why we think we need an upgrade mechanism in BIP342
< jonasschnelli> sipa: do you think it could have implications for v2/BIP342?